aboutsummaryrefslogtreecommitdiff
path: root/ld
diff options
context:
space:
mode:
authorNick Clifton <nickc@redhat.com>2007-10-04 13:55:25 +0000
committerNick Clifton <nickc@redhat.com>2007-10-04 13:55:25 +0000
commit8524166df4a01d692920721b0bfbb3df8d7f6a22 (patch)
tree03f00e98402b335a1461b95dcb7740a2d5902856 /ld
parent9f39ef2bb8db3e72361e7957343c73349839f36e (diff)
downloadfsf-binutils-gdb-8524166df4a01d692920721b0bfbb3df8d7f6a22.zip
fsf-binutils-gdb-8524166df4a01d692920721b0bfbb3df8d7f6a22.tar.gz
fsf-binutils-gdb-8524166df4a01d692920721b0bfbb3df8d7f6a22.tar.bz2
PR linker/4844
* emultempl/pep.em (pep_find_data_imports): Issue a warning message if auto importing is triggered without --enable-auto-import having been specified on the command line. * emultempl/pe.em (pe_find_data_imports): Likewise.
Diffstat (limited to 'ld')
-rw-r--r--ld/ChangeLog6
-rw-r--r--ld/emultempl/pe.em16
-rw-r--r--ld/emultempl/pep.em16
3 files changed, 34 insertions, 4 deletions
diff --git a/ld/ChangeLog b/ld/ChangeLog
index dc5f02a..a611417 100644
--- a/ld/ChangeLog
+++ b/ld/ChangeLog
@@ -1,5 +1,11 @@
2007-10-04 Nick Clifton <nickc@redhat.com>
+ PR linker/4844
+ * emultempl/pep.em (pep_find_data_imports): Issue a warning
+ message if auto importing is triggered without
+ --enable-auto-import having been specified on the command line.
+ * emultempl/pe.em (pe_find_data_imports): Likewise.
+
PR linker/5097
* emultempl/armelf.em (arm_elf_finish): Fix spelling typo.
diff --git a/ld/emultempl/pe.em b/ld/emultempl/pe.em
index 43ce8e9..503f79e 100644
--- a/ld/emultempl/pe.em
+++ b/ld/emultempl/pe.em
@@ -920,8 +920,20 @@ pe_find_data_imports (void)
int nsyms, symsize, i;
if (link_info.pei386_auto_import == -1)
- info_msg (_("Info: resolving %s by linking to %s (auto-import)\n"),
- undef->root.string, buf);
+ {
+ static bfd_boolean warned = FALSE;
+
+ info_msg (_("Info: resolving %s by linking to %s (auto-import)\n"),
+ undef->root.string, buf);
+
+ /* PR linker/4844. */
+ if (! warned)
+ {
+ warned = TRUE;
+ einfo (_("%P: warning: auto-importing has been activated without --enable-auto-import specified on the command line.\n\
+This should work unless it involves constant data structures referencing symbols from auto-imported DLLs."));
+ }
+ }
symsize = bfd_get_symtab_upper_bound (b);
symbols = (asymbol **) xmalloc (symsize);
diff --git a/ld/emultempl/pep.em b/ld/emultempl/pep.em
index 9e27e15..36b4f61 100644
--- a/ld/emultempl/pep.em
+++ b/ld/emultempl/pep.em
@@ -884,8 +884,20 @@ pep_find_data_imports (void)
int nsyms, symsize, i;
if (link_info.pei386_auto_import == -1)
- info_msg (_("Info: resolving %s by linking to %s (auto-import)\n"),
- undef->root.string, buf);
+ {
+ static bfd_boolean warned = FALSE;
+
+ info_msg (_("Info: resolving %s by linking to %s (auto-import)\n"),
+ undef->root.string, buf);
+
+ /* PR linker/4844. */
+ if (! warned)
+ {
+ warned = TRUE;
+ einfo (_("%P: warning: auto-importing has been activated without --enable-auto-import specified on the command line.\n\
+This should work unless it involves constant data structures referencing symbols from auto-imported DLLs."));
+ }
+ }
symsize = bfd_get_symtab_upper_bound (b);
symbols = xmalloc (symsize);