diff options
author | Jan Beulich <jbeulich@suse.com> | 2020-07-15 08:53:55 +0200 |
---|---|---|
committer | Jan Beulich <jbeulich@suse.com> | 2020-07-15 08:53:55 +0200 |
commit | 36938cabf0efcb053d1585e8580a4b3db438ca4e (patch) | |
tree | e7193f8c5b4f0cc83b6a76a4d5a35f0b86058abd /ld/testsuite/ld-i386 | |
parent | a8a48c756c0da3a49008662e14ae582764ddd0bb (diff) | |
download | fsf-binutils-gdb-36938cabf0efcb053d1585e8580a4b3db438ca4e.zip fsf-binutils-gdb-36938cabf0efcb053d1585e8580a4b3db438ca4e.tar.gz fsf-binutils-gdb-36938cabf0efcb053d1585e8580a4b3db438ca4e.tar.bz2 |
x86: avoid attaching suffixes to unambiguous insns
"Unambiguous" is is in particular taking as reference the assembler,
which also accepts certain insns - despite them allowing for varying
operand size, and hence in principle being ambiguous - without any
suffix. For example, from the very beginning of the life of x86-64 I had
trouble understanding why a plain and simple RET had to be printed as
RETQ. In case someone really used the 16-bit form, RETW disambiguates
the two quite fine.
Diffstat (limited to 'ld/testsuite/ld-i386')
-rw-r--r-- | ld/testsuite/ld-i386/ibt-plt-1.d | 2 | ||||
-rw-r--r-- | ld/testsuite/ld-i386/ibt-plt-2a.d | 2 | ||||
-rw-r--r-- | ld/testsuite/ld-i386/ibt-plt-2c.d | 2 | ||||
-rw-r--r-- | ld/testsuite/ld-i386/ibt-plt-3a.d | 2 | ||||
-rw-r--r-- | ld/testsuite/ld-i386/ibt-plt-3c.d | 2 | ||||
-rw-r--r-- | ld/testsuite/ld-i386/plt-pic.pd | 2 | ||||
-rw-r--r-- | ld/testsuite/ld-i386/plt-pic2.dd | 2 | ||||
-rw-r--r-- | ld/testsuite/ld-i386/plt.pd | 2 | ||||
-rw-r--r-- | ld/testsuite/ld-i386/plt2.dd | 2 | ||||
-rw-r--r-- | ld/testsuite/ld-i386/pr19636-1d.d | 2 | ||||
-rw-r--r-- | ld/testsuite/ld-i386/pr19636-1l.d | 2 | ||||
-rw-r--r-- | ld/testsuite/ld-i386/pr19636-2c.d | 2 | ||||
-rw-r--r-- | ld/testsuite/ld-i386/pr20830.d | 2 | ||||
-rw-r--r-- | ld/testsuite/ld-i386/vxworks1-lib.dd | 2 | ||||
-rw-r--r-- | ld/testsuite/ld-i386/vxworks1.dd | 2 |
15 files changed, 15 insertions, 15 deletions
diff --git a/ld/testsuite/ld-i386/ibt-plt-1.d b/ld/testsuite/ld-i386/ibt-plt-1.d index beccbf7..a7eaa1f 100644 --- a/ld/testsuite/ld-i386/ibt-plt-1.d +++ b/ld/testsuite/ld-i386/ibt-plt-1.d @@ -8,7 +8,7 @@ Disassembly of section .plt: [a-f0-9]+ <.plt>: - +[a-f0-9]+: ff b3 04 00 00 00 pushl 0x4\(%ebx\) + +[a-f0-9]+: ff b3 04 00 00 00 push 0x4\(%ebx\) +[a-f0-9]+: ff a3 08 00 00 00 jmp \*0x8\(%ebx\) +[a-f0-9]+: 0f 1f 40 00 nopl 0x0\(%eax\) +[a-f0-9]+: f3 0f 1e fb endbr32 diff --git a/ld/testsuite/ld-i386/ibt-plt-2a.d b/ld/testsuite/ld-i386/ibt-plt-2a.d index 5825be4..9c8f599 100644 --- a/ld/testsuite/ld-i386/ibt-plt-2a.d +++ b/ld/testsuite/ld-i386/ibt-plt-2a.d @@ -9,7 +9,7 @@ Disassembly of section .plt: 0+140 <.plt>: - +[a-f0-9]+: ff b3 04 00 00 00 pushl 0x4\(%ebx\) + +[a-f0-9]+: ff b3 04 00 00 00 push 0x4\(%ebx\) +[a-f0-9]+: ff a3 08 00 00 00 jmp \*0x8\(%ebx\) +[a-f0-9]+: 0f 1f 40 00 nopl 0x0\(%eax\) +[a-f0-9]+: f3 0f 1e fb endbr32 diff --git a/ld/testsuite/ld-i386/ibt-plt-2c.d b/ld/testsuite/ld-i386/ibt-plt-2c.d index 7193034..a9c8642 100644 --- a/ld/testsuite/ld-i386/ibt-plt-2c.d +++ b/ld/testsuite/ld-i386/ibt-plt-2c.d @@ -9,7 +9,7 @@ Disassembly of section .plt: [a-f0-9]+ <.plt>: - +[a-f0-9]+: ff b3 04 00 00 00 pushl 0x4\(%ebx\) + +[a-f0-9]+: ff b3 04 00 00 00 push 0x4\(%ebx\) +[a-f0-9]+: ff a3 08 00 00 00 jmp \*0x8\(%ebx\) +[a-f0-9]+: 0f 1f 40 00 nopl 0x0\(%eax\) +[a-f0-9]+: f3 0f 1e fb endbr32 diff --git a/ld/testsuite/ld-i386/ibt-plt-3a.d b/ld/testsuite/ld-i386/ibt-plt-3a.d index 4bbf1a3..b4366c9 100644 --- a/ld/testsuite/ld-i386/ibt-plt-3a.d +++ b/ld/testsuite/ld-i386/ibt-plt-3a.d @@ -9,7 +9,7 @@ Disassembly of section .plt: 0+140 <.plt>: - +[a-f0-9]+: ff b3 04 00 00 00 pushl 0x4\(%ebx\) + +[a-f0-9]+: ff b3 04 00 00 00 push 0x4\(%ebx\) +[a-f0-9]+: ff a3 08 00 00 00 jmp \*0x8\(%ebx\) +[a-f0-9]+: 0f 1f 40 00 nopl 0x0\(%eax\) +[a-f0-9]+: f3 0f 1e fb endbr32 diff --git a/ld/testsuite/ld-i386/ibt-plt-3c.d b/ld/testsuite/ld-i386/ibt-plt-3c.d index 4bbf1a3..b4366c9 100644 --- a/ld/testsuite/ld-i386/ibt-plt-3c.d +++ b/ld/testsuite/ld-i386/ibt-plt-3c.d @@ -9,7 +9,7 @@ Disassembly of section .plt: 0+140 <.plt>: - +[a-f0-9]+: ff b3 04 00 00 00 pushl 0x4\(%ebx\) + +[a-f0-9]+: ff b3 04 00 00 00 push 0x4\(%ebx\) +[a-f0-9]+: ff a3 08 00 00 00 jmp \*0x8\(%ebx\) +[a-f0-9]+: 0f 1f 40 00 nopl 0x0\(%eax\) +[a-f0-9]+: f3 0f 1e fb endbr32 diff --git a/ld/testsuite/ld-i386/plt-pic.pd b/ld/testsuite/ld-i386/plt-pic.pd index 4122c46..5c047d4 100644 --- a/ld/testsuite/ld-i386/plt-pic.pd +++ b/ld/testsuite/ld-i386/plt-pic.pd @@ -9,7 +9,7 @@ Disassembly of section .plt: [0-9a-f]+ <.plt>: - +[0-9a-f]+: ff b3 04 00 00 00 pushl 0x4\(%ebx\) + +[0-9a-f]+: ff b3 04 00 00 00 push 0x4\(%ebx\) +[0-9a-f]+: ff a3 08 00 00 00 jmp \*0x8\(%ebx\) #... diff --git a/ld/testsuite/ld-i386/plt-pic2.dd b/ld/testsuite/ld-i386/plt-pic2.dd index 1d81c76..8162234 100644 --- a/ld/testsuite/ld-i386/plt-pic2.dd +++ b/ld/testsuite/ld-i386/plt-pic2.dd @@ -10,7 +10,7 @@ Disassembly of section .plt: .* <.plt>: - +[a-f0-9]+: ff b3 04 00 00 00 pushl 0x4\(%ebx\) + +[a-f0-9]+: ff b3 04 00 00 00 push 0x4\(%ebx\) +[a-f0-9]+: ff a3 08 00 00 00 jmp \*0x8\(%ebx\) +[a-f0-9]+: 00 00 add %al,\(%eax\) ... diff --git a/ld/testsuite/ld-i386/plt.pd b/ld/testsuite/ld-i386/plt.pd index a6e6d35..efcd8a1 100644 --- a/ld/testsuite/ld-i386/plt.pd +++ b/ld/testsuite/ld-i386/plt.pd @@ -9,7 +9,7 @@ Disassembly of section .plt: [0-9a-f]+ <.plt>: - +[0-9a-f]+: ff 35 ([0-9a-f]{2} ){4} * pushl 0x[0-9a-f]+ + +[0-9a-f]+: ff 35 ([0-9a-f]{2} ){4} * push 0x[0-9a-f]+ +[0-9a-f]+: ff 25 ([0-9a-f]{2} ){4} * jmp \*0x[0-9a-f]+ #... diff --git a/ld/testsuite/ld-i386/plt2.dd b/ld/testsuite/ld-i386/plt2.dd index f1a49e5..c9d673f 100644 --- a/ld/testsuite/ld-i386/plt2.dd +++ b/ld/testsuite/ld-i386/plt2.dd @@ -10,7 +10,7 @@ Disassembly of section .plt: 0+8048160 <.plt>: - +[a-f0-9]+: ff 35 40 92 04 08 pushl 0x8049240 + +[a-f0-9]+: ff 35 40 92 04 08 push 0x8049240 +[a-f0-9]+: ff 25 44 92 04 08 jmp \*0x8049244 +[a-f0-9]+: 00 00 add %al,\(%eax\) ... diff --git a/ld/testsuite/ld-i386/pr19636-1d.d b/ld/testsuite/ld-i386/pr19636-1d.d index b034e30..b7e6aba 100644 --- a/ld/testsuite/ld-i386/pr19636-1d.d +++ b/ld/testsuite/ld-i386/pr19636-1d.d @@ -9,7 +9,7 @@ Disassembly of section .plt: .* <.plt>: -[ ]*[a-f0-9]+: ff b3 04 00 00 00 pushl 0x4\(%ebx\) +[ ]*[a-f0-9]+: ff b3 04 00 00 00 push 0x4\(%ebx\) [ ]*[a-f0-9]+: ff a3 08 00 00 00 jmp \*0x8\(%ebx\) [ ]*[a-f0-9]+: 00 00 add %al,\(%eax\) [ ]*[a-f0-9]+: 00 00 add %al,\(%eax\) diff --git a/ld/testsuite/ld-i386/pr19636-1l.d b/ld/testsuite/ld-i386/pr19636-1l.d index 4567c53..8f2a8e5 100644 --- a/ld/testsuite/ld-i386/pr19636-1l.d +++ b/ld/testsuite/ld-i386/pr19636-1l.d @@ -10,7 +10,7 @@ Disassembly of section .plt: .* <.plt>: -[ ]*[a-f0-9]+: ff b3 04 00 00 00 pushl 0x4\(%ebx\) +[ ]*[a-f0-9]+: ff b3 04 00 00 00 push 0x4\(%ebx\) [ ]*[a-f0-9]+: ff a3 08 00 00 00 jmp \*0x8\(%ebx\) [ ]*[a-f0-9]+: 00 00 add %al,\(%eax\) [ ]*[a-f0-9]+: 00 00 add %al,\(%eax\) diff --git a/ld/testsuite/ld-i386/pr19636-2c.d b/ld/testsuite/ld-i386/pr19636-2c.d index e3b737b..4b49c81 100644 --- a/ld/testsuite/ld-i386/pr19636-2c.d +++ b/ld/testsuite/ld-i386/pr19636-2c.d @@ -9,7 +9,7 @@ Disassembly of section .plt: .* <.plt>: -[ ]*[a-f0-9]+: ff b3 04 00 00 00 pushl 0x4\(%ebx\) +[ ]*[a-f0-9]+: ff b3 04 00 00 00 push 0x4\(%ebx\) [ ]*[a-f0-9]+: ff a3 08 00 00 00 jmp \*0x8\(%ebx\) [ ]*[a-f0-9]+: 00 00 add %al,\(%eax\) [ ]*[a-f0-9]+: 00 00 add %al,\(%eax\) diff --git a/ld/testsuite/ld-i386/pr20830.d b/ld/testsuite/ld-i386/pr20830.d index 5532207..8a14a60 100644 --- a/ld/testsuite/ld-i386/pr20830.d +++ b/ld/testsuite/ld-i386/pr20830.d @@ -41,7 +41,7 @@ Contents of the .eh_frame section: Disassembly of section .plt: 0+110 <.plt>: - +[a-f0-9]+: ff b3 04 00 00 00 pushl 0x4\(%ebx\) + +[a-f0-9]+: ff b3 04 00 00 00 push 0x4\(%ebx\) +[a-f0-9]+: ff a3 08 00 00 00 jmp \*0x8\(%ebx\) +[a-f0-9]+: 00 00 add %al,\(%eax\) ... diff --git a/ld/testsuite/ld-i386/vxworks1-lib.dd b/ld/testsuite/ld-i386/vxworks1-lib.dd index 6d56eb2..c9fc054 100644 --- a/ld/testsuite/ld-i386/vxworks1-lib.dd +++ b/ld/testsuite/ld-i386/vxworks1-lib.dd @@ -4,7 +4,7 @@ Disassembly of section \.plt: 00080800 <_PROCEDURE_LINKAGE_TABLE_>: - 80800: ff b3 04 00 00 00 pushl 0x4\(%ebx\) + 80800: ff b3 04 00 00 00 push 0x4\(%ebx\) 80806: ff a3 08 00 00 00 jmp \*0x8\(%ebx\) 8080c: 90 nop 8080d: 90 nop diff --git a/ld/testsuite/ld-i386/vxworks1.dd b/ld/testsuite/ld-i386/vxworks1.dd index 02b8bc0..80f93c9 100644 --- a/ld/testsuite/ld-i386/vxworks1.dd +++ b/ld/testsuite/ld-i386/vxworks1.dd @@ -4,7 +4,7 @@ Disassembly of section \.plt: 00080800 <_PROCEDURE_LINKAGE_TABLE_>: - 80800: ff 35 04 14 08 00 pushl 0x81404 + 80800: ff 35 04 14 08 00 push 0x81404 80802: R_386_32 _GLOBAL_OFFSET_TABLE_ 80806: ff 25 08 14 08 00 jmp \*0x81408 80808: R_386_32 _GLOBAL_OFFSET_TABLE_ |