diff options
author | H.J. Lu <hjl.tools@gmail.com> | 2018-02-05 08:38:16 -0800 |
---|---|---|
committer | H.J. Lu <hjl.tools@gmail.com> | 2018-02-05 08:38:16 -0800 |
commit | cd04836359da82ae1dc67e5a05565536f4427b51 (patch) | |
tree | fc72f6593a58e26174caadbfe9515204901fb318 /ld/testsuite/ld-i386/load1.d | |
parent | b8df6ca79e69678a07d3216b9b2b552fce27cda8 (diff) | |
download | fsf-binutils-gdb-cd04836359da82ae1dc67e5a05565536f4427b51.zip fsf-binutils-gdb-cd04836359da82ae1dc67e5a05565536f4427b51.tar.gz fsf-binutils-gdb-cd04836359da82ae1dc67e5a05565536f4427b51.tar.bz2 |
x86: Remove the unused _GLOBAL_OFFSET_TABLE_
Since _GLOBAL_OFFSET_TABLE_ may be referenced implicitly on x86,
checking ref_regular_nonweak leaves the unused _GLOBAL_OFFSET_TABLE_
in output. This patch checks explicit GOT references instead.
ld-i386/discarded1.s and ld-x86-64/discarded1.s are updated to avoid
linker optimization which removes GOT references.
bfd/
PR ld/22782
* elf32-i386.c (elf_i386_check_relocs): Set got_referenced if
_GLOBAL_OFFSET_TABLE_ is referenced or GOT is needed to resolve
undefined weak symbol to 0.
* elf64-x86-64.c (elf_x86_64_check_relocs): Set got_referenced
if _GLOBAL_OFFSET_TABLE_ is referenced.
* elfxx-x86.c (_bfd_x86_elf_size_dynamic_sections): Check
got_referenced instead of ref_regular_nonweak. Remove the
unused _GLOBAL_OFFSET_TABLE_ from symbol table.
* elfxx-x86.h (elf_x86_link_hash_table): Add got_referenced.
ld/
PR ld/22782
* testsuite/ld-i386/discarded1.s: Replace mov with div.
* testsuite/ld-x86-64/discarded1.s: Likewise.
* testsuite/ld-i386/i386.exp: Run pr22782.
* testsuite/ld-i386/load1-nacl.d: Updated for removing
_GLOBAL_OFFSET_TABLE_ from output.
* testsuite/ld-i386/load1.d: Likewise.
* testsuite/ld-x86-64/load1a-nacl.d: Likewise.
* testsuite/ld-x86-64/load1a.d: Likewise.
* testsuite/ld-x86-64/load1b-nacl.d: Likewise.
* testsuite/ld-x86-64/load1b.d: Likewise.
* testsuite/ld-i386/pr22782.d: New file.
* testsuite/ld-i386/pr22782.s: Likewise.
* testsuite/ld-x86-64/pr22782.s: Likewise.
* testsuite/ld-x86-64/pr22782a.d: Likewise.
* testsuite/ld-x86-64/pr22782b.d: Likewise.
* testsuite/ld-x86-64/x86-64.exp: Run pr22782a and pr22782b.
Diffstat (limited to 'ld/testsuite/ld-i386/load1.d')
-rw-r--r-- | ld/testsuite/ld-i386/load1.d | 84 |
1 files changed, 42 insertions, 42 deletions
diff --git a/ld/testsuite/ld-i386/load1.d b/ld/testsuite/ld-i386/load1.d index 9c4aa8e..2e4957b 100644 --- a/ld/testsuite/ld-i386/load1.d +++ b/ld/testsuite/ld-i386/load1.d @@ -7,52 +7,52 @@ SYMBOL TABLE: #... -0+8049170 l O .data 0+1 bar +0+8049164 l O .data 0+1 bar #... -0+8049171 g O .data 0+1 foo +0+8049165 g O .data 0+1 foo #... Disassembly of section .text: 0+8048074 <_start>: -[ ]*[a-f0-9]+: c7 c0 70 91 04 08 mov \$0x8049170,%eax -[ ]*[a-f0-9]+: 81 d0 70 91 04 08 adc \$0x8049170,%eax -[ ]*[a-f0-9]+: 81 c3 70 91 04 08 add \$0x8049170,%ebx -[ ]*[a-f0-9]+: 81 e1 70 91 04 08 and \$0x8049170,%ecx -[ ]*[a-f0-9]+: 81 fa 70 91 04 08 cmp \$0x8049170,%edx -[ ]*[a-f0-9]+: 81 cf 70 91 04 08 or \$0x8049170,%edi -[ ]*[a-f0-9]+: 81 de 70 91 04 08 sbb \$0x8049170,%esi -[ ]*[a-f0-9]+: 81 ed 70 91 04 08 sub \$0x8049170,%ebp -[ ]*[a-f0-9]+: 81 f4 70 91 04 08 xor \$0x8049170,%esp -[ ]*[a-f0-9]+: f7 c1 70 91 04 08 test \$0x8049170,%ecx -[ ]*[a-f0-9]+: c7 c0 70 91 04 08 mov \$0x8049170,%eax -[ ]*[a-f0-9]+: 81 d0 70 91 04 08 adc \$0x8049170,%eax -[ ]*[a-f0-9]+: 81 c3 70 91 04 08 add \$0x8049170,%ebx -[ ]*[a-f0-9]+: 81 e1 70 91 04 08 and \$0x8049170,%ecx -[ ]*[a-f0-9]+: 81 fa 70 91 04 08 cmp \$0x8049170,%edx -[ ]*[a-f0-9]+: 81 cf 70 91 04 08 or \$0x8049170,%edi -[ ]*[a-f0-9]+: 81 de 70 91 04 08 sbb \$0x8049170,%esi -[ ]*[a-f0-9]+: 81 ed 70 91 04 08 sub \$0x8049170,%ebp -[ ]*[a-f0-9]+: 81 f4 70 91 04 08 xor \$0x8049170,%esp -[ ]*[a-f0-9]+: f7 c1 70 91 04 08 test \$0x8049170,%ecx -[ ]*[a-f0-9]+: c7 c0 71 91 04 08 mov \$0x8049171,%eax -[ ]*[a-f0-9]+: 81 d0 71 91 04 08 adc \$0x8049171,%eax -[ ]*[a-f0-9]+: 81 c3 71 91 04 08 add \$0x8049171,%ebx -[ ]*[a-f0-9]+: 81 e1 71 91 04 08 and \$0x8049171,%ecx -[ ]*[a-f0-9]+: 81 fa 71 91 04 08 cmp \$0x8049171,%edx -[ ]*[a-f0-9]+: 81 cf 71 91 04 08 or \$0x8049171,%edi -[ ]*[a-f0-9]+: 81 de 71 91 04 08 sbb \$0x8049171,%esi -[ ]*[a-f0-9]+: 81 ed 71 91 04 08 sub \$0x8049171,%ebp -[ ]*[a-f0-9]+: 81 f4 71 91 04 08 xor \$0x8049171,%esp -[ ]*[a-f0-9]+: f7 c1 71 91 04 08 test \$0x8049171,%ecx -[ ]*[a-f0-9]+: c7 c0 71 91 04 08 mov \$0x8049171,%eax -[ ]*[a-f0-9]+: 81 d0 71 91 04 08 adc \$0x8049171,%eax -[ ]*[a-f0-9]+: 81 c3 71 91 04 08 add \$0x8049171,%ebx -[ ]*[a-f0-9]+: 81 e1 71 91 04 08 and \$0x8049171,%ecx -[ ]*[a-f0-9]+: 81 fa 71 91 04 08 cmp \$0x8049171,%edx -[ ]*[a-f0-9]+: 81 cf 71 91 04 08 or \$0x8049171,%edi -[ ]*[a-f0-9]+: 81 de 71 91 04 08 sbb \$0x8049171,%esi -[ ]*[a-f0-9]+: 81 ed 71 91 04 08 sub \$0x8049171,%ebp -[ ]*[a-f0-9]+: 81 f4 71 91 04 08 xor \$0x8049171,%esp -[ ]*[a-f0-9]+: f7 c1 71 91 04 08 test \$0x8049171,%ecx +[ ]*[a-f0-9]+: c7 c0 64 91 04 08 mov \$0x8049164,%eax +[ ]*[a-f0-9]+: 81 d0 64 91 04 08 adc \$0x8049164,%eax +[ ]*[a-f0-9]+: 81 c3 64 91 04 08 add \$0x8049164,%ebx +[ ]*[a-f0-9]+: 81 e1 64 91 04 08 and \$0x8049164,%ecx +[ ]*[a-f0-9]+: 81 fa 64 91 04 08 cmp \$0x8049164,%edx +[ ]*[a-f0-9]+: 81 cf 64 91 04 08 or \$0x8049164,%edi +[ ]*[a-f0-9]+: 81 de 64 91 04 08 sbb \$0x8049164,%esi +[ ]*[a-f0-9]+: 81 ed 64 91 04 08 sub \$0x8049164,%ebp +[ ]*[a-f0-9]+: 81 f4 64 91 04 08 xor \$0x8049164,%esp +[ ]*[a-f0-9]+: f7 c1 64 91 04 08 test \$0x8049164,%ecx +[ ]*[a-f0-9]+: c7 c0 64 91 04 08 mov \$0x8049164,%eax +[ ]*[a-f0-9]+: 81 d0 64 91 04 08 adc \$0x8049164,%eax +[ ]*[a-f0-9]+: 81 c3 64 91 04 08 add \$0x8049164,%ebx +[ ]*[a-f0-9]+: 81 e1 64 91 04 08 and \$0x8049164,%ecx +[ ]*[a-f0-9]+: 81 fa 64 91 04 08 cmp \$0x8049164,%edx +[ ]*[a-f0-9]+: 81 cf 64 91 04 08 or \$0x8049164,%edi +[ ]*[a-f0-9]+: 81 de 64 91 04 08 sbb \$0x8049164,%esi +[ ]*[a-f0-9]+: 81 ed 64 91 04 08 sub \$0x8049164,%ebp +[ ]*[a-f0-9]+: 81 f4 64 91 04 08 xor \$0x8049164,%esp +[ ]*[a-f0-9]+: f7 c1 64 91 04 08 test \$0x8049164,%ecx +[ ]*[a-f0-9]+: c7 c0 65 91 04 08 mov \$0x8049165,%eax +[ ]*[a-f0-9]+: 81 d0 65 91 04 08 adc \$0x8049165,%eax +[ ]*[a-f0-9]+: 81 c3 65 91 04 08 add \$0x8049165,%ebx +[ ]*[a-f0-9]+: 81 e1 65 91 04 08 and \$0x8049165,%ecx +[ ]*[a-f0-9]+: 81 fa 65 91 04 08 cmp \$0x8049165,%edx +[ ]*[a-f0-9]+: 81 cf 65 91 04 08 or \$0x8049165,%edi +[ ]*[a-f0-9]+: 81 de 65 91 04 08 sbb \$0x8049165,%esi +[ ]*[a-f0-9]+: 81 ed 65 91 04 08 sub \$0x8049165,%ebp +[ ]*[a-f0-9]+: 81 f4 65 91 04 08 xor \$0x8049165,%esp +[ ]*[a-f0-9]+: f7 c1 65 91 04 08 test \$0x8049165,%ecx +[ ]*[a-f0-9]+: c7 c0 65 91 04 08 mov \$0x8049165,%eax +[ ]*[a-f0-9]+: 81 d0 65 91 04 08 adc \$0x8049165,%eax +[ ]*[a-f0-9]+: 81 c3 65 91 04 08 add \$0x8049165,%ebx +[ ]*[a-f0-9]+: 81 e1 65 91 04 08 and \$0x8049165,%ecx +[ ]*[a-f0-9]+: 81 fa 65 91 04 08 cmp \$0x8049165,%edx +[ ]*[a-f0-9]+: 81 cf 65 91 04 08 or \$0x8049165,%edi +[ ]*[a-f0-9]+: 81 de 65 91 04 08 sbb \$0x8049165,%esi +[ ]*[a-f0-9]+: 81 ed 65 91 04 08 sub \$0x8049165,%ebp +[ ]*[a-f0-9]+: 81 f4 65 91 04 08 xor \$0x8049165,%esp +[ ]*[a-f0-9]+: f7 c1 65 91 04 08 test \$0x8049165,%ecx #pass |