diff options
| author | Jiong Wang <jiong.wang@arm.com> | 2014-07-08 09:29:06 +0100 |
|---|---|---|
| committer | Jiong Wang <jiong.wang@arm.com> | 2014-07-08 09:29:06 +0100 |
| commit | 2e0488d33f8abbbc5bec214e1723d07048d7afcc (patch) | |
| tree | a08805baf393f3a45f3b5d4f6afd6ce6774a1b4c /ld/testsuite/ld-aarch64/local-addend-r.d | |
| parent | 1f267ae3d18c165f8b4327aa423b909eae92f4d6 (diff) | |
| download | fsf-binutils-gdb-2e0488d33f8abbbc5bec214e1723d07048d7afcc.zip fsf-binutils-gdb-2e0488d33f8abbbc5bec214e1723d07048d7afcc.tar.gz fsf-binutils-gdb-2e0488d33f8abbbc5bec214e1723d07048d7afcc.tar.bz2 | |
Enable elf_backend_rela_normal for AArch64
If we are generating non-relocatable object and --emit-relocs specified,
aarch64 ld is actually generating wrong addend for rela entry when
relocate against local symbol.
for example, for simple testcase
foo.c
===
const char * const a = "foo";
const char *
foo ()
{
return a;
}
bar.c
===
const char * const b = "bar";
const char * bar ()
{
return b;
}
aarch64-none-linux-gnu-ld --emit-relocs -o x.o foo.o bar.o
aarch64-none-linux-gnu-readelf -r x.o
... R_AARCH64_ADR_PRE 0000000000400018 .rodata + 0
... R_AARCH64_ADD_ABS 0000000000400018 .rodata + 0
... R_AARCH64_ADR_PRE 0000000000400018 .rodata + 0
... R_AARCH64_ADD_ABS 0000000000400018 .rodata + 0
while it should be:
... R_AARCH64_ADR_PRE 0000000000400018 .rodata + 0
... R_AARCH64_ADD_ABS 0000000000400018 .rodata + 0
... R_AARCH64_ADR_PRE 0000000000400018 .rodata + 10
... R_AARCH64_ADD_ABS 0000000000400018 .rodata + 10
bfd generic code could actually handle this properly, but only when
elf_backend_rela_normal set to '1'.
this patch enable this and remove those target specific hack.
bfd/
* elfnn-aarch64.c (elf_backend_rela_normal): Set to 1.
(elfNN_aarch64_relocate_section): Remove duplicated addend adjustment
when info->relocatable be true.
ld/testsuite/
* ld-aarch64/emit-relocs-local-addend-bar.s: * New source file.
* ld-aarch64/emit-relocs-local-addend-foo.s: * Likewise.
* ld-aarch64/emit-relocs-local-addend.d: * New testcase.
* ld-aarch64/local-addend-r.d: Likewise.
Diffstat (limited to 'ld/testsuite/ld-aarch64/local-addend-r.d')
| -rw-r--r-- | ld/testsuite/ld-aarch64/local-addend-r.d | 16 |
1 files changed, 16 insertions, 0 deletions
diff --git a/ld/testsuite/ld-aarch64/local-addend-r.d b/ld/testsuite/ld-aarch64/local-addend-r.d new file mode 100644 index 0000000..c8c2777 --- /dev/null +++ b/ld/testsuite/ld-aarch64/local-addend-r.d @@ -0,0 +1,16 @@ +#source: emit-relocs-local-addend-foo.s +#source: emit-relocs-local-addend-bar.s +#ld: -e0 -r +#readelf: -r + +Relocation section '\.rela\.text' at offset 0x338 contains 4 entries: + Offset Info Type Sym\. Value Sym\. Name \+ Addend +000000000000 000200000113 R_AARCH64_ADR_PRE 0000000000000000 \.rodata \+ 0 +000000000004 000200000115 R_AARCH64_ADD_ABS 0000000000000000 \.rodata \+ 0 +00000000000c 000200000113 R_AARCH64_ADR_PRE 0000000000000000 \.rodata \+ 10 +000000000010 000200000115 R_AARCH64_ADD_ABS 0000000000000000 \.rodata \+ 10 + +Relocation section '\.rela\.rodata' at offset 0x398 contains 2 entries: + Offset Info Type Sym\. Value Sym. Name \+ Addend +000000000008 000200000101 R_AARCH64_ABS64 0000000000000000 \.rodata \+ 0 +000000000018 000200000101 R_AARCH64_ABS64 0000000000000000 \.rodata \+ 10 |