diff options
| author | Tom Tromey <tom@tromey.com> | 2019-07-11 18:19:28 -0600 |
|---|---|---|
| committer | Tom Tromey <tom@tromey.com> | 2019-08-16 11:28:34 -0600 |
| commit | 20149b6b207ac8c2bcde6f272607109f566168a9 (patch) | |
| tree | 75c6bfb31f83b0837102ca8613e9559d4e3cdae1 /gdb/tui/tui-source.c | |
| parent | 2d83e710a14c62cb6a9501c84fc46062f817428d (diff) | |
| download | fsf-binutils-gdb-20149b6b207ac8c2bcde6f272607109f566168a9.zip fsf-binutils-gdb-20149b6b207ac8c2bcde6f272607109f566168a9.tar.gz fsf-binutils-gdb-20149b6b207ac8c2bcde6f272607109f566168a9.tar.bz2 | |
Remove "noerror" parameter from some TUI functions
A few TUI functions take a "noerror" parameter. This is only checked
in one spot: in tui_set_source_content, if noerror is false, and if an
error occurs, then the function will call print_sys_errmsg.
This seems misguided to me, so this patch removes that code and this
parameter.
gdb/ChangeLog
2019-08-16 Tom Tromey <tom@tromey.com>
* tui/tui-winsource.h (tui_update_source_window)
(tui_update_source_window_as_is): Remove "noerror" parameter.
* tui/tui-winsource.c (tui_update_source_window)
(tui_update_source_window_as_is): Remove "noerror" parameter.
(tui_update_source_windows_with_addr)
(tui_update_source_windows_with_line)
(tui_source_window_base::rerender)
(tui_source_window_base::refill): Update.
* tui/tui-source.h (tui_set_source_content)
(tui_show_symtab_source): Remove "noerror" parameter.
* tui/tui-source.c (tui_set_source_content): Remove "noerror"
parameter.
(tui_show_symtab_source): Likewise.
(tui_source_window::maybe_update): Update.
* tui/tui-disasm.c (tui_show_disassem)
(tui_show_disassem_and_update_source)
(tui_disasm_window::do_scroll_vertical)
(tui_disasm_window::maybe_update): Update.
Diffstat (limited to 'gdb/tui/tui-source.c')
| -rw-r--r-- | gdb/tui/tui-source.c | 22 |
1 files changed, 5 insertions, 17 deletions
diff --git a/gdb/tui/tui-source.c b/gdb/tui/tui-source.c index c86af84..db83fb0 100644 --- a/gdb/tui/tui-source.c +++ b/gdb/tui/tui-source.c @@ -125,8 +125,7 @@ copy_source_line (const char **ptr, int line_no, int first_col, enum tui_status tui_set_source_content (tui_source_window_base *win_info, struct symtab *s, - int line_no, - int noerror) + int line_no) { enum tui_status ret = TUI_FAILURE; @@ -143,17 +142,7 @@ tui_set_source_content (tui_source_window_base *win_info, std::string srclines; if (!g_source_cache.get_source_lines (s, line_no, line_no + nlines, &srclines)) - { - if (!noerror) - { - const char *filename = symtab_to_filename_for_display (s); - char *name = (char *) alloca (strlen (filename) + 100); - - sprintf (name, "%s:%d", filename, line_no); - print_sys_errmsg (name, errno); - } - ret = TUI_FAILURE; - } + ret = TUI_FAILURE; else { int cur_line_no, cur_line; @@ -213,11 +202,10 @@ tui_set_source_content (tui_source_window_base *win_info, void tui_show_symtab_source (tui_source_window_base *win_info, struct gdbarch *gdbarch, struct symtab *s, - struct tui_line_or_address line, - int noerror) + struct tui_line_or_address line) { win_info->horizontal_offset = 0; - tui_update_source_window_as_is (win_info, gdbarch, s, line, noerror); + tui_update_source_window_as_is (win_info, gdbarch, s, line); } @@ -330,7 +318,7 @@ tui_source_window::maybe_update (struct frame_info *fi, symtab_and_line sal, if (!(source_already_displayed && line_is_displayed (line_no))) tui_update_source_window (this, get_frame_arch (fi), - sal.symtab, l, TRUE); + sal.symtab, l); else { l.u.line_no = line_no; |