aboutsummaryrefslogtreecommitdiff
path: root/gdb/testsuite/gdb.base/fileio.exp
diff options
context:
space:
mode:
authorYao Qi <yao@codesourcery.com>2014-10-29 21:43:05 +0800
committerYao Qi <yao@codesourcery.com>2014-10-29 21:43:05 +0800
commit563e8d85161198df8a13de4bc660a047305458c9 (patch)
tree44d49bac575370a3b9c2247447a0b3ba94517aaf /gdb/testsuite/gdb.base/fileio.exp
parent0ea4d52e4396f6fdf44e6b0d5a21db17cad41ec7 (diff)
downloadfsf-binutils-gdb-563e8d85161198df8a13de4bc660a047305458c9.zip
fsf-binutils-gdb-563e8d85161198df8a13de4bc660a047305458c9.tar.gz
fsf-binutils-gdb-563e8d85161198df8a13de4bc660a047305458c9.tar.bz2
Prepare directory in case test_system fails
In gdb.base/fileio.c, some functions may depend on others. For example, test_rename renames a file to one directory which is created in test_system. That is means, if test_system fails, test_rename fails too, which is not a good practise, IMO. In test_system, system ("mkdir -p XX") is used to create directories needed for test_rename. In this patch, we use dejagnu remote_exec proc to create these directories on host. In my gdb testing, mingw32 host and arm-none-eabi target, system ("mkdir -p XX") doesn't work properly (this issue can be addressed separately), and this patch fixes the following fails. FAIL: gdb.base/fileio.exp: Renaming a directory to a non-empty directory returns ENOTEMPTY or EEXIST FAIL: gdb.base/fileio.exp: Unlink a file FAIL: gdb.base/fileio.exp: Unlinking a file in a directory w/o write access returns EACCES gdb/testsuite: 2014-10-29 Yao Qi <yao@codesourcery.com> * gdb.base/fileio.exp: Make directories on host.
Diffstat (limited to 'gdb/testsuite/gdb.base/fileio.exp')
-rw-r--r--gdb/testsuite/gdb.base/fileio.exp7
1 files changed, 7 insertions, 0 deletions
diff --git a/gdb/testsuite/gdb.base/fileio.exp b/gdb/testsuite/gdb.base/fileio.exp
index 89f0997..00c2b16 100644
--- a/gdb/testsuite/gdb.base/fileio.exp
+++ b/gdb/testsuite/gdb.base/fileio.exp
@@ -210,6 +210,13 @@ gdb_test continue \
"Continuing\\..*system 4:.*OK$stop_msg" \
"System with invalid command returns 127"
+# Prepare the directory for rename tests in case that test_system
+# failed to create.
+set dir1 [file join $outdir "dir1.fileio.test" "subdir.fileio.test"]
+remote_exec host "mkdir -p $dir1"
+set dir1 [file join $outdir "dir2.fileio.test"]
+remote_exec host "mkdir $dir1"
+
gdb_test continue \
"Continuing\\..*rename 1:.*OK$stop_msg" \
"Rename a file"