diff options
| author | Tom Tromey <tom@tromey.com> | 2022-08-02 09:55:32 -0600 |
|---|---|---|
| committer | Tom Tromey <tom@tromey.com> | 2022-08-03 13:26:58 -0600 |
| commit | 98badbfdc222d1d7f346046f23a64522b88d22a0 (patch) | |
| tree | a57a95b75f64a0e318e0b1bd31dd6b246e4797d8 /gdb/solib.c | |
| parent | 4d44946794e68cf79cfba467fa414a958dba2185 (diff) | |
| download | fsf-binutils-gdb-98badbfdc222d1d7f346046f23a64522b88d22a0.zip fsf-binutils-gdb-98badbfdc222d1d7f346046f23a64522b88d22a0.tar.gz fsf-binutils-gdb-98badbfdc222d1d7f346046f23a64522b88d22a0.tar.bz2 | |
Use gdb_bfd_ref_ptr in objfile
This changes struct objfile to use a gdb_bfd_ref_ptr. In addition to
removing some manual memory management, this fixes a use-after-free
that was introduced by the registry rewrite series. The issue there
was that, in some cases, registry shutdown could refer to memory that
had already been freed. This help fix the bug by delaying the
destruction of the BFD reference (and thus the per-bfd object) until
after the registry has been shut down.
Diffstat (limited to 'gdb/solib.c')
| -rw-r--r-- | gdb/solib.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/gdb/solib.c b/gdb/solib.c index b9ddd04..fc07f60 100644 --- a/gdb/solib.c +++ b/gdb/solib.c @@ -764,7 +764,9 @@ solib_read_symbols (struct so_list *so, symfile_add_flags flags) { section_addr_info sap = build_section_addr_info_from_section_table (*so->sections); - so->objfile = symbol_file_add_from_bfd (so->abfd, so->so_name, + gdb_bfd_ref_ptr tmp_bfd + (gdb_bfd_ref_ptr::new_reference (so->abfd)); + so->objfile = symbol_file_add_from_bfd (tmp_bfd, so->so_name, flags, &sap, OBJF_SHARED, NULL); so->objfile->addr_low = so->addr_low; |