diff options
| author | Tom Tromey <tom@tromey.com> | 2022-08-02 09:55:32 -0600 |
|---|---|---|
| committer | Tom Tromey <tom@tromey.com> | 2022-08-03 13:26:58 -0600 |
| commit | 98badbfdc222d1d7f346046f23a64522b88d22a0 (patch) | |
| tree | a57a95b75f64a0e318e0b1bd31dd6b246e4797d8 /gdb/remote.c | |
| parent | 4d44946794e68cf79cfba467fa414a958dba2185 (diff) | |
| download | fsf-binutils-gdb-98badbfdc222d1d7f346046f23a64522b88d22a0.zip fsf-binutils-gdb-98badbfdc222d1d7f346046f23a64522b88d22a0.tar.gz fsf-binutils-gdb-98badbfdc222d1d7f346046f23a64522b88d22a0.tar.bz2 | |
Use gdb_bfd_ref_ptr in objfile
This changes struct objfile to use a gdb_bfd_ref_ptr. In addition to
removing some manual memory management, this fixes a use-after-free
that was introduced by the registry rewrite series. The issue there
was that, in some cases, registry shutdown could refer to memory that
had already been freed. This help fix the bug by delaying the
destruction of the BFD reference (and thus the per-bfd object) until
after the registry has been shut down.
Diffstat (limited to 'gdb/remote.c')
| -rw-r--r-- | gdb/remote.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/gdb/remote.c b/gdb/remote.c index 49d26c2..04b283f 100644 --- a/gdb/remote.c +++ b/gdb/remote.c @@ -4321,7 +4321,7 @@ remote_target::get_offsets () objfile *objf = current_program_space->symfile_object_file; section_offsets offs = objf->section_offsets; - symfile_segment_data_up data = get_symfile_segment_data (objf->obfd); + symfile_segment_data_up data = get_symfile_segment_data (objf->obfd.get ()); do_segments = (data != NULL); do_sections = num_segments == 0; @@ -4356,7 +4356,7 @@ remote_target::get_offsets () if (do_segments) { - int ret = symfile_map_offsets_to_segments (objf->obfd, + int ret = symfile_map_offsets_to_segments (objf->obfd.get (), data.get (), offs, num_segments, segments); |