diff options
| author | Andrew Burgess <aburgess@redhat.com> | 2023-08-11 11:53:27 +0100 |
|---|---|---|
| committer | Andrew Burgess <aburgess@redhat.com> | 2023-08-23 09:50:32 +0100 |
| commit | 951dbdfeec44d8d2971b155f17edff09d6f1a67a (patch) | |
| tree | c6c22adb73132ffc36e6ea112c6848b7fc17a5d5 /gdb/python | |
| parent | e200b179ce7d2b03e903a2da1e8d1a6739cdca1c (diff) | |
| download | fsf-binutils-gdb-951dbdfeec44d8d2971b155f17edff09d6f1a67a.zip fsf-binutils-gdb-951dbdfeec44d8d2971b155f17edff09d6f1a67a.tar.gz fsf-binutils-gdb-951dbdfeec44d8d2971b155f17edff09d6f1a67a.tar.bz2 | |
gdb: remove mi_parse::make functions
Remove the static mi_parse::make functions, and instead use the
mi_parse constructor.
This is a partial revert of the commit:
commit fde3f93adb50c9937cd2e1c93561aea2fd167156
Date: Mon Mar 20 10:56:55 2023 -0600
Introduce "static constructor" for mi_parse
which introduced the mi_parse::make functions, though after discussion
on the list the reasons for seem to have been lost[1]. Given there
are no test regressions when moving back to using the constructors, I
propose we should do that for now.
There should be no user visible changes after this commit.
[1] https://inbox.sourceware.org/gdb-patches/20230404-dap-loaded-sources-v2-5-93f229095e03@adacore.com/
Approved-By: Tom Tromey <tom@tromey.com>
Diffstat (limited to 'gdb/python')
| -rw-r--r-- | gdb/python/py-mi.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/gdb/python/py-mi.c b/gdb/python/py-mi.c index 0fcd578..66dc6fb 100644 --- a/gdb/python/py-mi.c +++ b/gdb/python/py-mi.c @@ -284,8 +284,8 @@ gdbpy_execute_mi_command (PyObject *self, PyObject *args, PyObject *kw) try { scoped_restore save_uiout = make_scoped_restore (¤t_uiout, &uiout); - std::unique_ptr<struct mi_parse> parser - = mi_parse::make (std::move (mi_command), std::move (arg_strings)); + auto parser = gdb::make_unique<mi_parse> (std::move (mi_command), + std::move (arg_strings)); mi_execute_command (parser.get ()); } catch (const gdb_exception &except) |