diff options
| author | Tom Tromey <tom@tromey.com> | 2017-01-11 16:28:43 -0700 |
|---|---|---|
| committer | Tom Tromey <tom@tromey.com> | 2017-02-10 12:24:32 -0700 |
| commit | 88b6faea9953505e9e8a7a77995c7db5dfb6ac19 (patch) | |
| tree | 8c37cbea07dded189647be98286894aa9e172579 /gdb/python/py-breakpoint.c | |
| parent | 7780f18678aeb553778633aeb50f41694f55bf27 (diff) | |
| download | fsf-binutils-gdb-88b6faea9953505e9e8a7a77995c7db5dfb6ac19.zip fsf-binutils-gdb-88b6faea9953505e9e8a7a77995c7db5dfb6ac19.tar.gz fsf-binutils-gdb-88b6faea9953505e9e8a7a77995c7db5dfb6ac19.tar.bz2 | |
Use gdbpy_ref to simplify some logic
This uses the new gdbpy_ref template to simplify logic in various
parts of the Python layer; for example removing repeated error code or
removing gotos.
gdb/ChangeLog
2017-02-10 Tom Tromey <tom@tromey.com>
* python/py-cmd.c (cmdpy_destroyer): Use gdbpy_ref.
* python/py-breakpoint.c (gdbpy_breakpoint_deleted): Use
gdbpy_ref.
* python/py-type.c (field_new): Use gdbpy_ref.
* python/py-symtab.c (symtab_and_line_to_sal_object): Use
gdbpy_ref.
* python/py-progspace.c (pspy_new): Use gdbpy_ref.
(py_free_pspace): Likewise.
(pspace_to_pspace_object): Likewise.
* python/py-objfile.c (objfpy_new): Use gdbpy_ref.
(py_free_objfile): Likewise.
(objfile_to_objfile_object): Likewise.
* python/py-inferior.c (delete_thread_object): Use
gdbpy_ref.
(infpy_read_memory): Likewise.
(py_free_inferior): Likewise.
* python/py-evtregistry.c (create_eventregistry_object): Use
gdbpy_ref.
* python/py-event.c (create_event_object): Use gdbpy_ref.
Diffstat (limited to 'gdb/python/py-breakpoint.c')
| -rw-r--r-- | gdb/python/py-breakpoint.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/gdb/python/py-breakpoint.c b/gdb/python/py-breakpoint.c index 507b866..724a7ed 100644 --- a/gdb/python/py-breakpoint.c +++ b/gdb/python/py-breakpoint.c @@ -911,25 +911,23 @@ gdbpy_breakpoint_deleted (struct breakpoint *b) int num = b->number; PyGILState_STATE state; struct breakpoint *bp = NULL; - gdbpy_breakpoint_object *bp_obj; state = PyGILState_Ensure (); bp = get_breakpoint (num); if (bp) { - bp_obj = bp->py_bp_object; - if (bp_obj) + gdbpy_ref<gdbpy_breakpoint_object> bp_obj (bp->py_bp_object); + if (bp_obj != NULL) { if (!evregpy_no_listeners_p (gdb_py_events.breakpoint_deleted)) { - if (evpy_emit_event ((PyObject *) bp_obj, + if (evpy_emit_event ((PyObject *) bp_obj.get (), gdb_py_events.breakpoint_deleted) < 0) gdbpy_print_stack (); } bp_obj->bp = NULL; --bppy_live; - Py_DECREF (bp_obj); } } PyGILState_Release (state); |