diff options
author | Tom Tromey <tom@tromey.com> | 2018-06-05 10:22:01 -0600 |
---|---|---|
committer | Tom Tromey <tom@tromey.com> | 2018-07-03 23:00:49 -0600 |
commit | f51e0e20bd303a9b366084ac719db10978402713 (patch) | |
tree | 021c92b289956ebdb0ed96266e5bddb6bf86e3a0 /gdb/breakpoint.c | |
parent | 9b960ba18c83e3f9aad16fe8bf845f5c469712bd (diff) | |
download | fsf-binutils-gdb-f51e0e20bd303a9b366084ac719db10978402713.zip fsf-binutils-gdb-f51e0e20bd303a9b366084ac719db10978402713.tar.gz fsf-binutils-gdb-f51e0e20bd303a9b366084ac719db10978402713.tar.bz2 |
Remove VEC from breakpoint
This removes a use of VEC from breakpoint.h, also removing the
now-unnecessary breakpoint_p typedef.
This patch fixes a latent memory leak in
find_matching_tracepoint_location, which neglected to free the vector
returned by all_tracepoints.
Tested by the buildbot.
gdb/ChangeLog
2018-07-03 Tom Tromey <tom@tromey.com>
* tracepoint.c (process_tracepoint_on_disconnect, start_tracing)
(stop_tracing, tstatus_command)
(find_matching_tracepoint_location, merge_uploaded_tracepoints)
(print_one_static_tracepoint_marker): Update.
* breakpoint.c (static_tracepoints_here, all_tracepoints): Return
std::vector.
* breakpoint.h (breakpoint_p): Remove typedef. Don't declare
VEC.
(all_tracepoints, static_tracepoints_here): Return std::vector.
Diffstat (limited to 'gdb/breakpoint.c')
-rw-r--r-- | gdb/breakpoint.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c index df1afac..77c4638 100644 --- a/gdb/breakpoint.c +++ b/gdb/breakpoint.c @@ -1145,11 +1145,11 @@ validate_commands_for_breakpoint (struct breakpoint *b, /* Return a vector of all the static tracepoints set at ADDR. The caller is responsible for releasing the vector. */ -VEC(breakpoint_p) * +std::vector<breakpoint *> static_tracepoints_here (CORE_ADDR addr) { struct breakpoint *b; - VEC(breakpoint_p) *found = 0; + std::vector<breakpoint *> found; struct bp_location *loc; ALL_BREAKPOINTS (b) @@ -1157,7 +1157,7 @@ static_tracepoints_here (CORE_ADDR addr) { for (loc = b->loc; loc; loc = loc->next) if (loc->address == addr) - VEC_safe_push(breakpoint_p, found, b); + found.push_back (b); } return found; @@ -15166,15 +15166,15 @@ save_tracepoints_command (const char *args, int from_tty) /* Create a vector of all tracepoints. */ -VEC(breakpoint_p) * +std::vector<breakpoint *> all_tracepoints (void) { - VEC(breakpoint_p) *tp_vec = 0; + std::vector<breakpoint *> tp_vec; struct breakpoint *tp; ALL_TRACEPOINTS (tp) { - VEC_safe_push (breakpoint_p, tp_vec, tp); + tp_vec.push_back (tp); } return tp_vec; |