diff options
| author | Tom Tromey <tromey@adacore.com> | 2024-03-21 11:15:56 -0600 |
|---|---|---|
| committer | Tom Tromey <tromey@adacore.com> | 2024-03-22 13:17:43 -0600 |
| commit | c05dd51122c2d654031b04e02ad0ea5b53ffe5e2 (patch) | |
| tree | df883998b862b998f58d2b1edefa8bc96a84c725 /gdb/arc-tdep.c | |
| parent | af25053d5f9e1867bd0df1d5f168c803e1d7d015 (diff) | |
| download | fsf-binutils-gdb-c05dd51122c2d654031b04e02ad0ea5b53ffe5e2.zip fsf-binutils-gdb-c05dd51122c2d654031b04e02ad0ea5b53ffe5e2.tar.gz fsf-binutils-gdb-c05dd51122c2d654031b04e02ad0ea5b53ffe5e2.tar.bz2 | |
Use std::string for disassembler options
I noticed that the disassembler_options code uses manual memory
management. It seemed simpler to replace this with std::string.
Approved-By: John Baldwin <jhb@FreeBSD.org>
Diffstat (limited to 'gdb/arc-tdep.c')
| -rw-r--r-- | gdb/arc-tdep.c | 15 |
1 files changed, 7 insertions, 8 deletions
diff --git a/gdb/arc-tdep.c b/gdb/arc-tdep.c index 7dd43cc..63a1fd9 100644 --- a/gdb/arc-tdep.c +++ b/gdb/arc-tdep.c @@ -299,7 +299,7 @@ static const struct arc_register_feature arc_common_aux_reg_feature = } }; -static char *arc_disassembler_options = NULL; +static std::string arc_disassembler_options; /* Functions are sorted in the order as they are used in the _initialize_arc_tdep (), which uses the same order as gdbarch.h. Static @@ -2365,7 +2365,6 @@ arc_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches) = tdesc_architecture (info.target_desc); if (tdesc_arch != NULL) { - xfree (arc_disassembler_options); /* FIXME: It is not really good to change disassembler options behind the scene, because that might override options specified by the user. However as of now ARC doesn't support @@ -2386,24 +2385,24 @@ arc_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches) switch (tdesc_arch->mach) { case bfd_mach_arc_arc601: - arc_disassembler_options = xstrdup ("cpu=arc601"); + arc_disassembler_options = "cpu=arc601"; break; case bfd_mach_arc_arc600: - arc_disassembler_options = xstrdup ("cpu=arc600"); + arc_disassembler_options = "cpu=arc600"; break; case bfd_mach_arc_arc700: - arc_disassembler_options = xstrdup ("cpu=arc700"); + arc_disassembler_options = "cpu=arc700"; break; case bfd_mach_arc_arcv2: /* Machine arcv2 has three arches: ARCv2, EM and HS; where ARCv2 is treated as EM. */ if (arc_arch_is_hs (tdesc_arch)) - arc_disassembler_options = xstrdup ("cpu=hs38_linux"); + arc_disassembler_options = "cpu=hs38_linux"; else - arc_disassembler_options = xstrdup ("cpu=em4_fpuda"); + arc_disassembler_options = "cpu=em4_fpuda"; break; default: - arc_disassembler_options = NULL; + arc_disassembler_options = ""; break; } } |