diff options
| author | Simon Marchi <simon.marchi@ericsson.com> | 2017-12-05 16:39:35 -0500 |
|---|---|---|
| committer | Simon Marchi <simon.marchi@ericsson.com> | 2017-12-05 16:39:41 -0500 |
| commit | 858c9d13240e695bc3b750368f5d4e524b12112e (patch) | |
| tree | de0ffc82a4e71df3ec2f15b5818c71dec6cffcb7 | |
| parent | d4a0e8b57d6f85e4ee4a31e0e6929ff5b4fd9823 (diff) | |
| download | fsf-binutils-gdb-858c9d13240e695bc3b750368f5d4e524b12112e.zip fsf-binutils-gdb-858c9d13240e695bc3b750368f5d4e524b12112e.tar.gz fsf-binutils-gdb-858c9d13240e695bc3b750368f5d4e524b12112e.tar.bz2 | |
Address review comments for the previous series
I failed at git and missed adding/lost changes on the wrong branch, the
result being that I didn't incorporate fixes resulting from Yao's review
comments. This patch fixes that.
There are two places where we should use the unique pointer typedef, and
ChangeLog entries missing.
gdb/ChangeLog:
* target-descriptions.c (struct tdesc_feature) <registers>: Use
tdesc_reg_up typedef.
(struct target_desc) <features>: Use tdesc_feature_up typedef.
| -rw-r--r-- | gdb/ChangeLog | 8 | ||||
| -rw-r--r-- | gdb/target-descriptions.c | 4 |
2 files changed, 10 insertions, 2 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 1d3a3e8..657f87b 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,9 @@ +2017-12-05 Simon Marchi <simon.marchi@ericsson.com> + + * target-descriptions.c (struct tdesc_feature) <registers>: Use + tdesc_reg_up typedef. + (struct target_desc) <features>: Use tdesc_feature_up typedef. + 2017-12-05 Simon Marchi <simon.marchi@polymtl.ca> * target-descriptions.c (struct tdesc_type): Use default @@ -118,6 +124,8 @@ (tdesc_register_in_reggroup_p): Adjust. (class print_c_tdesc) <visit>: Adjust. (class print_c_feature) <visit>: Adjust. + * features/arc-arcompact.c: Re-generate. + * features/arc-v2.c: Re-generate. 2017-12-05 Simon Marchi <simon.marchi@ericsson.com> diff --git a/gdb/target-descriptions.c b/gdb/target-descriptions.c index 12d72fa..5a6f619 100644 --- a/gdb/target-descriptions.c +++ b/gdb/target-descriptions.c @@ -529,7 +529,7 @@ struct tdesc_feature : tdesc_element std::string name; /* The registers associated with this feature. */ - std::vector<std::unique_ptr<tdesc_reg>> registers; + std::vector<tdesc_reg_up> registers; /* The types associated with this feature. */ std::vector<tdesc_type_up> types; @@ -613,7 +613,7 @@ struct target_desc : tdesc_element std::vector<property> properties; /* The features associated with this target. */ - std::vector<std::unique_ptr<tdesc_feature>> features; + std::vector<tdesc_feature_up> features; void accept (tdesc_element_visitor &v) const override { |