aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPedro Alves <palves@redhat.com>2017-10-04 13:00:13 +0100
committerPedro Alves <palves@redhat.com>2017-10-04 13:00:13 +0100
commit44704526e482d24baa104764495ca376561a85bf (patch)
treecbd503a5fdc1634ae9d6097a7a91fe16c2c1a29b
parenta87c142792e4dcbec2bb3825e71f3ace044c2096 (diff)
downloadfsf-binutils-gdb-44704526e482d24baa104764495ca376561a85bf.zip
fsf-binutils-gdb-44704526e482d24baa104764495ca376561a85bf.tar.gz
fsf-binutils-gdb-44704526e482d24baa104764495ca376561a85bf.tar.bz2
Add missing-END_CATCH detection/protection (to gdb's TRY/CATCH/END_CATCH)
(Adding missing ChangeLog entry) While we still have cleanups (i.e., make_cleanup & co), we must be sure to add END_CATCH at the end of a TRY/CATCH/END_CATCH construct. However, it's currently too easy to miss adding the END_CATCH, because the code compiles anyway without it. I realized this when I noticed that another patch I was working on missed several adding END_CATCH in several new TRY/CATCH uses. This commit fixes that by making TRY open a new scope that is only closed by END_CATCH. This way, if you forget to add the END_CATCH, then compilation fails due to the unbalanced curly braces. This caught a couple places where we were missing END_CATCH in current master, also fixed by the patch. gdb/ChangeLog: 2017-10-04 Pedro Alves <palves@redhat.com> * cli/cli-cmds.c (complete_command): Add missing END_CATCH. * common/common-exceptions.h (TRY): Open an outermost scope. Expand intro comment. (CATCH): Reindent. (END_CATCH): Close the outermost scope. * completer.c (complete_line_internal): Add missing END_CATCH.
-rw-r--r--gdb/ChangeLog9
1 files changed, 9 insertions, 0 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index e113e2f..bc58f51 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,12 @@
+2017-10-04 Pedro Alves <palves@redhat.com>
+
+ * cli/cli-cmds.c (complete_command): Add missing END_CATCH.
+ * common/common-exceptions.h (TRY): Open an outermost scope.
+ Expand intro comment.
+ (CATCH): Reindent.
+ (END_CATCH): Close the outermost scope.
+ * completer.c (complete_line_internal): Add missing END_CATCH.
+
2017-10-04 Sergio Durigan Junior <sergiodj@redhat.com>
* NEWS (Changes since GDB 8.0): Add entry about new