- Mar 08, 2018
-
-
Myles Borins authored
PR-URL: https://github.com/nodejs/node/pull/19181
-
Myles Borins authored
Notable Changes: * crypto: - add cert.fingerprint256 as SHA256 fingerprint (Hannes Magnusson) https://github.com/nodejs/node/pull/17690 * http2: - Fixed issues with aborted connections in the HTTP/2 implementation (Anna Henningsen) https://github.com/nodejs/node/pull/18987 https://github.com/nodejs/node/pull/19002 * loader: - --inspect-brk now works properly for esmodules (Gus Caplan) https://github.com/nodejs/node/pull/18949 * src: - make process.dlopen() load well-known symbol (Ben Noordhuis) https://github.com/nodejs/node/pull/18934 * trace_events: - add file pattern cli option (Andreas Madsen) https://github.com/nodejs/node/pull/18480 * Added new collaborators: - Chen Gang (MoonBall) https://github.com/MoonBall PR-URL: https://github.com/nodejs/node/pull/19181 -
Anna Henningsen authored
Backport-PR-URL: https://github.com/nodejs/node/pull/19194 PR-URL: https://github.com/nodejs/node/pull/18607 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Vse Mozhet Byt authored
We have two notes in API docs about Android support: the first has no links, the second links to the table of supported OSs where Android is not mentioned which may be confusing. This PR makes both notes link to dedicated Android part of BUILDING.md. Backport-PR-URL: https://github.com/nodejs/node/pull/19183 PR-URL: https://github.com/nodejs/node/pull/19004 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Yuta Hiroto <hello@about-hiroppy.com>
-
Gus Caplan authored
Backport-PR-URL: https://github.com/nodejs/node/pull/19180 PR-URL: https://github.com/nodejs/node/pull/18925 Reviewed-By:
-
Guy Bedford authored
Backport-PR-URL: https://github.com/nodejs/node/pull/18923 PR-URL: https://github.com/nodejs/node/pull/18788 Refs: https://github.com/nodejs/node/pull/18728 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
-
Guy Bedford authored
This adds support for ensuring that the top-level main into Node is supported loading when it has no extension for backwards-compat with NodeJS bin workflows. In addition package.json caching is implemented in the module lookup process. Backport-PR-URL: https://github.com/nodejs/node/pull/18923 PR-URL: https://github.com/nodejs/node/pull/18728 Reviewed-By:
-
Anna Henningsen authored
This fixes a crash that occurred when a `Http2Stream` write is completed after it is already destroyed. Instead, don’t destroy the stream in that case and wait for GC to take over. Backport-PR-URL: https://github.com/nodejs/node/pull/19185 PR-URL: https://github.com/nodejs/node/pull/19002 Fixes: https://github.com/nodejs/node/issues/18973 Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com>
-
Ben Noordhuis authored
Don't try to update the internal field pointer of the JS object in the destructor. The garbage collector invokes the destructor when the object is collected and is not necessarily in a valid state anymore. Backport-PR-URL: https://github.com/nodejs/node/pull/19185 PR-URL: https://github.com/nodejs/node/pull/18656 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com>
-
Ben Noordhuis authored
The previous commit made persistent handles auto-reset on destruction. This commit removes the Reset() calls that are now no longer necessary. Backport-PR-URL: https://github.com/nodejs/node/pull/19185 PR-URL: https://github.com/nodejs/node/pull/18656 Reviewed-By:
-
Ben Noordhuis authored
Replace v8::Persistent with node::Persistent, a specialization that resets the persistent handle on destruction. Prevents accidental resource leaks when forgetting to call .Reset() manually. I'm fairly confident this commit fixes a number of resource leaks that have gone undiagnosed so far. Backport-PR-URL: https://github.com/nodejs/node/pull/19185 PR-URL: https://github.com/nodejs/node/pull/18656 Reviewed-By:
-
James M Snell authored
Backport-PR-URL: https://github.com/nodejs/node/pull/19185 PR-URL: https://github.com/nodejs/node/pull/18297 Reviewed-By:
-
Ujjwal Sharma authored
PR-URL: https://github.com/nodejs/node/pull/19162 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
-
Timothy Gu authored
Fixes: https://github.com/nodejs/node/issues/17892 Fixes: https://github.com/nodejs/node/issues/17893 Fixes: https://github.com/nodejs/node/issues/18992 PR-URL: https://github.com/nodejs/node/pull/18993 Reviewed-By:
-
Steven R. Loomis authored
iculslocs uses stdio, but didn't include the header. PR-URL: https://github.com/nodejs/node/pull/19150 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
-
Daniel Bevenius authored
Currently test-http2-client-write-empty-string.js will throw "Error [ERR_NO_CRYPTO]: Node.js is not compiled with OpenSSL crypto support" when configured --without-ssl. This commit moves the require of http2 to after the crypto check to avoid this error. PR-URL: https://github.com/nodejs/node/pull/19111 Reviewed-By:
Jon Moss <me@jonathanmoss.me>
-
Ben Noordhuis authored
Convert manual memory management of STACK_OF(X509) instances to std::unique_ptr with a custom deleter. Note the tasteful application of std::move() to indicate a function that consumes its argument. PR-URL: https://github.com/nodejs/node/pull/19087 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com>
-
Daniel Bevenius authored
PR-URL: https://github.com/nodejs/node/pull/19087 Reviewed-By:
-
Rich Trott authored
Remove request that user provide a list of subsystems in the pull request template. * We already ask them to put the subsystems in the first line of the commit message. * The subsystem is usually easy to determine. * We have a bot that applies subsystem labels on new PRs and it seems to do a rather good job. Tools over rules. Let the bot do it. * The fewer unnecessary things we ask for in the template, the lower the barrier to entry. * Anecdotal, but I have never found it useful to have the person submitting the PR list out subsystems in the pull request post. PR-URL: https://github.com/nodejs/node/pull/19125 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
Matheus Marchini <matheus@sthima.com> Reviewed-By:
Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By:
Kyle Farnung <kfarnung@microsoft.com>
-
Rich Trott authored
There are some uses of "in general" that are unnecessary. (We don't need to be tentative about the fact that tests should pass, for example.) PR-URL: https://github.com/nodejs/node/pull/19123 Reviewed-By:
-
Ruben Bridgewater authored
PR-URL: https://github.com/nodejs/node/pull/19099 Reviewed-By:
Shingo Inoue <leko.noor@gmail.com> Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
Rich Trott authored
Allow users to switch to the table of contents for older versions of Node.js. This gets rid of the "Failed to add alternative version link" warnings when building docs. PR-URL: https://github.com/nodejs/node/pull/19113 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Jakob Kummerow authored
Original commit message: Introduce --disallow-code-generation-from-strings Exposing the existing Context::AllowCodeGenerationFromStrings(false) API to the command line. Bug: v8:7134 Change-Id: I062ccff0b03c5bcf6878c41c455c0ded37a1d743 Reviewed-on: https://chromium-review.googlesource.com/809631 Reviewed-by:Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#49911} PR-URL: https://github.com/nodejs/node/pull/18212 Refs: https://github.com/v8/v8/commit/0bcb1d6f2de9b278b1de7de1b5333e7f47fdce8e Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
-
Michael Dawson authored
Add team that we can use to cc organizations or people who do one of the following: * bundle node into their product * bundle node into their distributions * provide an installer * provide a version manager PR-URL: https://github.com/nodejs/node/pull/19098 Reviewed-By:
-
punteek authored
Added a simple example showing how to rename a file. Refs: https://github.com/nodejs/node/issues11135 PR-URL: https://github.com/nodejs/node/pull/18812 Reviewed-By:
-
Bradley Farias authored
ensures that instantiation result is only used during initial loading PR-URL: https://github.com/nodejs/node/pull/18965 Reviewed-By:
Guy Bedford <guybedford@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Jan Krems <jan.krems@gmail.com> Reviewed-By:
-
Michael Dawson authored
Fix the gcovr version to a fixed version and uses patches specific to that version. This avoids us being broken by changes in the gcovr repo. Using file name for patches specific to the version level will allow us to move up when necessary without breaking coverage for earlier versions of Node.js PR-URL: https://github.com/nodejs/node/pull/19094 Reviewed-By:
-
Ben Noordhuis authored
Look for symbol `node_register_module_v${NODE_MODULE_VERSION}` if the add-on didn't self-register. This can be used to create add-ons that support multiple Node.js versions from a single shared object. PR-URL: https://github.com/nodejs/node/pull/18934 Reviewed-By:Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By:
-
Ben Noordhuis authored
Move some code around and clean up the DLib helper class as prep work for a follow-up commit. PR-URL: https://github.com/nodejs/node/pull/18934 Reviewed-By:
-
- Mar 07, 2018
-
-
Yihong Wang authored
When building the node with `--shared` option, we need to verify the symbols in shared lib instead of executable. Refs: https://github.com/nodejs/node/issues/18535 Signed-off-by:
Yihong Wang <yh.wang@ibm.com> PR-URL: https://github.com/nodejs/node/pull/18806 Refs: https://github.com/nodejs/node/issues/18535 Reviewed-By:
-
Ruben Bridgewater authored
The offset was formerly coerced to a integer and this reimplements that. PR-URL: https://github.com/nodejs/node/pull/18215 Fixes: https://github.com/nodejs/node/issues/18208 Reviewed-By:
-
Andreas Madsen authored
Allow the user to specify the filepath for the trace_events log file using a template string. Backport-PR-URL: https://github.com/nodejs/node/pull/19144 PR-URL: https://github.com/nodejs/node/pull/18480 Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By:
-
Sho Miyamoto authored
Backport-PR-URL: https://github.com/nodejs/node/pull/19127 PR-URL: https://github.com/nodejs/node/pull/18775 Reviewed-By:
Weijia Wang <starkwang@126.com> Reviewed-By:
Roman Reiss <me@silverwind.io>
-
Sho Miyamoto authored
Backport-PR-URL: https://github.com/nodejs/node/pull/19127 PR-URL: https://github.com/nodejs/node/pull/18775 Reviewed-By:
-
- Mar 05, 2018
-
-
Anna Henningsen authored
This might otherwise result in a hard crash when trying to write to a socket after a sudden disconnect. Note that the test here uses an aborted `h2load` run to create the failing requests; That’s far from ideal, but it provides a reasonably reliably reproduction at this point. PR-URL: https://github.com/nodejs/node/pull/18987 Fixes: https://github.com/nodejs/node/issues/18973 Reviewed-By:
-
Anna Henningsen authored
Make the script not error out immediately because of a missing pseudo-global. (Note that it seems like tests are still broken on `master`.) PR-URL: https://github.com/nodejs/node/pull/19059 Fixes: https://github.com/nodejs/node/issues/19044 Refs: https://github.com/nodejs/node/pull/18623 Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Minwoo Jung <minwoo@nodesource.com> Reviewed-By:
-
Anna Henningsen authored
This is pretty useful when trying to inspect the last error caught by a REPL, and is made to be analogous to `_`, which contains the last successful completion value. PR-URL: https://github.com/nodejs/node/pull/18919 Reviewed-By:
Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By:
Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By:
-
Gabriel Schulhof authored
Remove the necessity for allocating on the heap, and assert that the correct pointer gets passed to the finalizer. PR-URL: https://github.com/nodejs/node/pull/19086 Reviewed-By:
-
Anna Henningsen authored
Show the stack trace for the `eventemitter.emit('error')` call in the case of an uncaught exception. Previously, there would be no clue in Node’s output about where the actual `throw` comes from. PR-URL: https://github.com/nodejs/node/pull/19003 Reviewed-By: -
Ruben Bridgewater authored
PR-URL: https://github.com/nodejs/node/pull/18746 Reviewed-By:
-
