- Dec 24, 2014
-
-
Timothy J Fontaine authored
-
Timothy J Fontaine authored
-
- Dec 23, 2014
-
-
Timothy J Fontaine authored
* tls: re-add 1024-bit SSL certs removed by f9456a2d (Chris Dickinson) * timers: don't close interval timers when unrefd (Julien Gilli) * timers: don't mutate unref list while iterating it (Julien Gilli)
-
James M Snell authored
Better wording for start and end parameters, also document .length should be considered readonly. RE: #8857, #8859, #8913 PR: #8910 PR-URL: https://github.com/joyent/node/pull/8910 Signed-off-by:
Timothy J Fontaine <tjfontaine@gmail.com>
-
James M Snell authored
Clarify that adding or removing a listener is not idempotent. RE: #8853 PR: #8911 PR-URL: https://github.com/joyent/node/pull/8911 Signed-off-by:
Timothy J Fontaine <tjfontaine@gmail.com>
-
Julien Gilli authored
Commit 934bfe23 had introduced a regression where node would crash trying to access a null unref timer if a given unref timer's callback would remove other unref timers set to fire in the future. More generally, it makes the unrefTimeout function more solid by not mutating the unrefList while traversing it. Fixes #8897. Reviewed-By:
Timothy J Fontaine <tjfontaine@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
- Dec 20, 2014
-
-
Chris Dickinson authored
this fixes a problem where connecting to AWS services would report an untrusted cert error. Fixes: https://github.com/joyent/node/issues/8894 PR-URL: https://github.com/joyent/node/pull/8904 Reviewed-By:
Timothy J Fontaine <tjfontaine@gmail.com> Reviewed-By:
Julien Gilli <julien.gilli@joyent.com>
-
Julien Gilli authored
This change fixes a regression introduced by commit 0d051238 , which contained a typo that would cause every unrefd interval to fire only once. Fixes #8900. Reviewed-By:
Timothy J Fontaine <tjfontaine@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-by:
Trevor Norris <trev.norris@gmail.com>
-
- Dec 18, 2014
-
-
Timothy J Fontaine authored
-
Timothy J Fontaine authored
-
Timothy J Fontaine authored
* uv: update to v0.10.30 * zlib: upgrade to v1.2.8 * child_process: check execFile args is an array (Sam Roberts) * child_process: check fork args is an array (Sam Roberts) * crypto: update root certificates (Ben Noordhuis) * domains: fix issues with abort on uncaught (Julien Gilli) * timers: Avoid linear scan in _unrefActive. (Julien Gilli) * timers: fix unref() memory leak (Trevor Norris) * v8: add api for aborting on uncaught exception (Julien Gilli) * debugger: fix when using "use strict" (Julien Gilli)
-
Trevor Norris authored
This reverts commit 1eb1e0a9.
-
Ben Noordhuis authored
Reduce the overhead of the CPU profiler by suppressing SIGPROF signals when sleeping / polling for events. Avoids unnecessary wakeups when the CPU profiler is active. Depends on https://github.com/libuv/libuv#15. Ref: https://github.com/strongloop/strong-agent/issues/3 PR-URL: https://github.com/joyent/node/pull/8791 Reviewed-by:
Trevor Norris <trev.norris@gmail.com>
-
cjihrig authored
A block of asserts were duplicated in test/simple/test-child-process-spawn-typeerror.js. This commit removes the duplicated asserts. Fixes: https://github.com/joyent/node/pull/8454 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Julien Gilli authored
Make the difference between dns.lookup and other functions even clearer. PR: #8747 Signed-off-by:Timothy J Fontaine <tjfontaine@gmail.com>
-
Julien Gilli authored
Original commit message: Enable "strict mode"; for debugger scripts BUG=v8:3708 Review URL: https://codereview.chromium.org/736583007 Cr-Commit-Position: refs/heads/master@{#25420}
-
Julien Gilli authored
Original commit message: Fix Unhandled ReferenceError in debug-debugger.js This fixes following exception in Sky on attempt to set a breakpoint "Unhandled: Uncaught ReferenceError: break_point is not defined" I think this happens in Sky but not in Chrome because Sky scripts are executed in strict mode. BUG=None LOG=N R=yangguo@chromium.org Review URL: https://codereview.chromium.org/741683002 Cr-Commit-Position: refs/heads/master@{#25415}
-
- Dec 17, 2014
-
-
Shigeki Ohtsu authored
-
Shigeki Ohtsu authored
This adds new sources for gzip files and defines a new flag for mac and freebsd. They are taken from third_party/zlib/zlib.gyp in Chromium repository.
-
Shigeki Ohtsu authored
-
Julien Gilli authored
Before this change, _unrefActive would keep the unrefList sorted when adding a new timer. Because _unrefActive is called extremely frequently, this linear scan (O(n) at worse) would make _unrefActive show high in the list of contributors when profiling CPU usage. This commit changes _unrefActive so that it doesn't try to keep the unrefList sorted. The insertion thus happens in constant time. However, when a timer expires, unrefTimeout has to go through the whole unrefList because it's not ordered anymore. It is usually not large enough to have a significant impact on performance because: - Most of the time, the timers will be removed before unrefTimeout is called because their users (sockets mainly) cancel them when an I/O operation takes place. - If they're not, it means that some I/O took a long time to happen, and the initiator of subsequents I/O operations that would add more timers has to wait for them to complete. With this change, _unrefActive does not show as a significant contributor in CPU profiling reports anymore. Fixes #8160. PR-URL: #8751 Signed-off-by:Timothy J Fontaine <tjfontaine@gmail.com>
-
- Dec 16, 2014
-
-
Trevor Norris authored
ICU support in v0.12 generates a new icu_config.gypi. This was accidentally committed after switching branches. The file has been removed and added to .gitignore. Fixes: 0d051238 "timers: fix unref() memory leak"
-
Steven R. Loomis authored
Previously, 'configure' would not return an exit status if gyp blows up. This can be tested via: date >> node.gyp ; ./configure && echo A-OK You will get "A-OK" even though gyp had failed. Signed-off-by:Julien Gilli <julien.gilli@joyent.com>
-
Julien Gilli authored
The original documentation was slightly confusing. It seemed that the list of items described the properties of the urlObj object, while it was actually describing the formatting process. This change makes this clearer. Fixes #8796. Reviewed-by:Chris Dickinson <christopher.s.dickinson@gmail.com>
-
- Dec 12, 2014
-
-
silverwind authored
Documentation mentioned 'securityOptions', where it should have read 'secureOptions'. Fixes #8608. Signed-off-by:Julien Gilli <julien.gilli@joyent.com>
-
- Dec 10, 2014
-
-
Saúl Ibarra Corretgé authored
PR-URL: https://github.com/joyent/node/pull/8849 Reviewed-by:
Trevor Norris <trev.norris@gmail.com>
-
- Dec 09, 2014
-
-
pkcs authored
Code examples in documentation for net.createServer and net.createConnection contained confusing log messages. This change makes them clearer. Signed-off-by:Julien Gilli <julien.gilli@joyent.com>
-
- Dec 07, 2014
-
-
Alejandro Oviedo authored
Currently there's an example using http.ServerResponse stream, which has a known bug and will not throw an error while writing after end(). Changed to a writable stream from fs which behaves as expected. fix #8814 Signed-off-by:Julien Gilli <julien.gilli@joyent.com>
-
- Dec 06, 2014
-
-
Brendan Ashworth authored
Replace 'a' with 'an' where appropriate.
-
- Dec 04, 2014
-
-
Fedor Indutny authored
In very unlikely case, where `deflateInit2()` may return error (right now happening only on exhausting all memory), the `ZCtx::Error()` will be called and will try to `Unref()` the handle. But the problem is that this handle was never `Ref()`ed, so it will trigger an assertion error and crash the program. Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> PR-URL: https://github.com/joyent/node/pull/8687
-
Ben Noordhuis authored
Update tools/certdata.txt to [0] (last updated on 2014-11-14) and rebuild src/node_root_certs.h. Refs joyent/node#8679 and joyent/node#8709. [0] https://hg.mozilla.org/mozilla-central/raw-file/64206634959a/security/nss/lib/ckfw/builtins/certdata.txt
-
Ben Noordhuis authored
Remove unneeded functionality and tweak the generated output so we can #include it in C++ source code. This is a back-port of commit e159073d from the master branch.
-
Ben Noordhuis authored
This is a back-port of commit 5ab863de from the master branch.
-
- Nov 27, 2014
-
-
Trevor Norris authored
The destructor isn't being called for timers that have been unref'd. Fixes: https://github.com/joyent/node/issues/8364 Signed-off-by:
Trevor Norris <trev.norris@gmail.com>
-
- Nov 19, 2014
-
-
Sam Roberts authored
- Add hyperlinks from spawn options to subsections detailing what those options do. - Clarify some verbiage around ChildProcess.prototype.std{in,out,err}. - Remove second-person pronoun. PR-URL: https://github.com/joyent/node/pull/8639 Reviewed-by:Chris Dickinson <christopher.s.dickinson@gmail.com>
-
Trevor Norris authored
Forgot to fix these before landing the patch. Fixes: e17c5a72
-
Julien Gilli authored
Do not abort the process if an error is thrown from within a domain, an error handler is setup for the domain and --abort-on-uncaught-exception was passed on the command line. However, if an error is thrown from within the top-level domain's error handler and --abort-on-uncaught-exception was passed on the command line, make the process abort. Fixes: https://github.com/joyent/node/issues/8631 Fixes: https://github.com/joyent/node/issues/8630 PR-URL: https://github.com/joyent/node/pull/8666 Reviewed-by:
Trevor Norris <trev.norris@gmail.com>
-
Trevor Norris authored
Add v8::Isolate::SetAbortOnUncaughtException() so the user can be notified when an uncaught exception has bubbled. PR-URL: https://github.com/joyent/node/pull/8666 Reviewed-by:
Trevor Norris <trev.norris@gmail.com>
-
Sam Roberts authored
PR-URL: https://github.com/joyent/node/pull/8454 Reviewed-by:
Trevor Norris <trev.norris@gmail.com>
-
Sam Roberts authored
Optional fork args should be type-checked with same behaviour as the equivalent argument to spawn. PR-URL: https://github.com/joyent/node/pull/8454 Reviewed-by:
Trevor Norris <trev.norris@gmail.com>
-