- Jun 06, 2017
-
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/13384 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Refael Ackermann <refack@gmail.com>
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/13384 Reviewed-By:
-
Brian White authored
This fixes a regression from 53c88fa4 so that special arguments can once again be passed to the node executable when running tests. PR-URL: https://github.com/nodejs/node/pull/13384 Reviewed-By:
-
Sam Roberts authored
Test guide describes a conventional layout for test headers, review inspector tests and reorganize to follow the convention. PR-URL: https://github.com/nodejs/node/pull/13428 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
sreepurnajasti authored
PR-URL: https://github.com/nodejs/node/pull/13285 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
James M Snell authored
Using ES6 Classes broke userland code. Revert back to functions. PR-URL: https://github.com/nodejs/node/pull/13374 Fixes: https://github.com/nodejs/node/issues/13358 Ref: https://github.com/nodejs/node/pull/13370 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com>
-
- Jun 05, 2017
-
-
Eugene Ostroukhov authored
This change allows reentering the message dispatch loop when the Node is paused. This is necessary when the pause happened as a result of the message sent by a debug frontend, such as evaluating a function with a breakpoint inside. Fixes: https://github.com/nodejs/node/issues/13320 PR-URL: https://github.com/nodejs/node/pull/13350 Reviewed-By:
-
Vse Mozhet Byt authored
* Make `require()` consistent. * Add missing argument. * Add missing `\n` in outputs. * Reduce string concatenations. * Update outputs. * Reword and fix a typo. PR-URL: https://github.com/nodejs/node/pull/13400 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Andreas Madsen <amwebdk@gmail.com> Reviewed-By:
-
Vse Mozhet Byt authored
Do not promote using of `arguments`. One fragment is left as is because of history nature: it uses a real deprecated code from libs. Refs: http://eslint.org/docs/rules/prefer-rest-params Refs: https://github.com/nodejs/node/blob/99da8e8e02a874a0a044889f863c45700509d02c/lib/util.js#L1002-L1006 PR-URL: https://github.com/nodejs/node/pull/13389 Reviewed-By:
-
Nikolai Vavilov authored
PR-URL: https://github.com/nodejs/node/pull/13434 Reviewed-By:
Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
-
Matteo Collina authored
We stated that 'data' and pipe() are preferred over 'readable'. This commit clarifies that 'data' and pipe() are easier to understand, but 'readable' might result in increased throughput. Fixes: https://github.com/nodejs/node/issues/11587 PR-URL: https://github.com/nodejs/node/pull/13432 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
Matteo Collina authored
Clarifies the behavior of streams when _readableState.flowing is false. resume() must be called explicitly for the 'data' event to be emitted again. Fixes: https://github.com/nodejs/node/issues/1041 PR-URL: https://github.com/nodejs/node/pull/13329 Reviewed-By:
-
Paul Bininda authored
PR-URL: https://github.com/nodejs/node/pull/13394 Fixes: https://github.com/nodejs/node/issues/13382 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/13409 Refs: https://github.com/nodejs/node/pull/10638 Reviewed-By:
-
- Jun 04, 2017
-
-
Anna Henningsen authored
Improve error messages in the async hooks tests, mostly by removing unhelpful `message` parameters for assertions. PR-URL: https://github.com/nodejs/node/pull/13243 Reviewed-By:
Kunal Pathak <kunal.pathak@microsoft.com> Reviewed-By:
Trevor Norris <trev.norris@gmail.com>
-
JiaLi.Passion authored
async_hooks init callback will be triggered when promise newly created, in previous version, the parent promise which pass from chrome V8 PromiseHook is ignored, so we can't tell the promise is a pure new promise or a chained promise. In this commit, we use the parent promise's id as triggerId to trigger the init callback. Fixes: https://github.com/nodejs/node/issues/13302 PR-URL: https://github.com/nodejs/node/pull/13367 Reviewed-By:
-
Anna Henningsen authored
Under very specific circumstances the `http` implementation could be brought to crash, because the Agent did not re-assign the async id field properly after setting up a socket for reuse. Fixes: https://github.com/nodejs/node/issues/13325 PR-URL: https://github.com/nodejs/node/pull/13348 Reviewed-By:
-
Anna Henningsen authored
Now that `async_hooks` is released, it makes sense to me to have a team for addressing issues with it. nodejs/diagnostics can still be @mentioned if there are questions about the API rather than its implementation. PR-URL: https://github.com/nodejs/node/pull/13332 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
-
Dávid Szakállas authored
Add tests for checking the behavior of async_hooks.triggerId. It should return different ids when called in callbacks having different ancestry paths. It should return the same id when called in callbacks having the same ancestry path. PR-URL: https://github.com/nodejs/node/pull/13328 Reviewed-By:
-
Gibson Fahnestock authored
If you don't have the full Xcode installed, the command-line tools are all you need. PR-URL: https://github.com/nodejs/node/pull/13264 Fixes: https://github.com/nodejs/node/issues/6449 Refs: https://github.com/nodejs/node/pull/9215 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/13359 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
David Cai <davidcai1993@yahoo.com>
-
- Jun 03, 2017
-
-
Daijiro Wachi authored
To make the example codes in URL doc work without additional codes, it should have more lines to require modules. PR-URL: https://github.com/nodejs/node/pull/13365 Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/13354 Refs: http://eslint.org/docs/rules/object-curly-spacing Reviewed-By:
Timothy Gu <timothygu99@gmail.com> Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/13354 Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/13349 Reviewed-By:
Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By:
-
Anna Henningsen authored
Verify that the destroy callback for a TCP server is called before exit if it is closed in another destroy callback. Fixes: https://github.com/nodejs/node/issues/13262 PR-URL: https://github.com/nodejs/node/pull/13369 Reviewed-By:
-
Trevor Norris authored
Calling the destroy callbacks in a uv_idle_t causes a timing issue where if a handle or request is closed then the class isn't deleted until uv_close() callbacks are called (which happens after the poll phase). This results in some destroy callbacks not being called just before the application exits. So instead switch the destroy callbacks to be called in a uv_timer_t with the timeout set to zero. When uv_run() is called with UV_RUN_ONCE the final operation of the event loop is to process all remaining timers. By setting the timeout to zero it results in the destroy callbacks being processed after uv_close() but before uv_run() returned. Processing the destroyed ids that were previously missed. Also, process the destroy_ids_list() in a do {} while() loop that makes sure the vector is empty before returning. Which also makes running clear() unnecessary. Fixes: https://github.com/nodejs/node/issues/13262 PR-URL: https://github.com/nodejs/node/pull/13369 Reviewed-By: -
Rich Trott authored
Omitting AIX from `fs.watch()` portion of this test. It works on AIX, but not reliably. PR-URL: https://github.com/nodejs/node/pull/13385 Fixes: https://github.com/nodejs/node/issues/13377 Reviewed-By:
-
Vse Mozhet Byt authored
* Use test() instead of match() in boolean context. * Add spaces in code example. * Fix typo. PR-URL: https://github.com/nodejs/node/pull/13342 Reviewed-By:
Brian White <mscdex@mscdex.net>
-
Rich Trott authored
* alphabetize the JS test suites * Use CI_JS_SUITES variable instead of listing all tests PR-URL: https://github.com/nodejs/node/pull/13340 Reviewed-By:
-
Bidisha Pyne authored
PR-URL: https://github.com/nodejs/node/pull/13293 Reviewed-By:
-
Michael Dawson authored
Add info about who to @cc for issues with n-api PR-URL: https://github.com/nodejs/node/pull/13335 Reviewed-By:
Jason Ginchereau <jasongin@microsoft.com> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Hitesh Kanwathirtha <digitalinfinity@gmail.com>
-
- Jun 02, 2017
-
-
Daniel Bevenius authored
Added the missing make command in steps 6.3 when building asm_obsolete. Also updated the commit message to include the version nasm in addition to the gcc version. Fixes: https://github.com/nodejs/node/issues/13161 PR-URL: https://github.com/nodejs/node/pull/13233 Reviewed-By:
Shigeki Ohtsu <ohtsu@ohtsu.org> Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
-
Daniel Bevenius authored
Regenerate asm files with Makefile and CC=gcc and ASM=nasm where gcc version was 5.4.0 and nasm version was 2.11.08. Also asm files in asm_obsolete dir to support old compiler and assembler are regenerated without CC and ASM envs. Fixes: https://github.com/nodejs/node/issues/13161 PR-URL: https://github.com/nodejs/node/pull/13233 Reviewed-By:
-
Daniel Bevenius authored
Regenerate config files for supported platforms with Makefile. Fixes: https://github.com/nodejs/node/issues/13161 PR-URL: https://github.com/nodejs/node/pull/13233 Reviewed-By:
-
Shigeki Ohtsu authored
In openssl s_client on Windows, RAND_screen() is invoked to initialize random state but it takes several seconds in each connection. This added -no_rand_screen to openssl s_client on Windows to skip RAND_screen() and gets a better performance in the unit test of test-tls-server-verify. Do not enable this except to use in the unit test. Fixes: https://github.com/nodejs/io.js/issues/1461 PR-URL: https://github.com/nodejs/io.js/pull/1836 Reviewed-By:
-
Shigeki Ohtsu authored
Reapply b9106137 . Fixes: https://github.com/iojs/io.js/issues/589 PR-URL: https://github.com/iojs/io.js/pull/1389 Reviewed-By:
Fedor Indutny <fedor@indutny.com> Reviewed-By:
-
Shigeki Ohtsu authored
See https://mta.openssl.org/pipermail/openssl-dev/2015-February/000651.html iojs needs to stop using masm and move to nasm or yasm on Win32. Fixes: https://github.com/iojs/io.js/issues/589 PR-URL: https://github.com/iojs/io.js/pull/1389 Reviewed-By:
-
Fedor Indutny authored
`x86masm.pl` was mistakenly using .486 instruction set, why `cpuid` (and perhaps others) are requiring .686 . Fixes: https://github.com/iojs/io.js/issues/589 PR-URL: https://github.com/iojs/io.js/pull/1389 Reviewed-By:
Shigeki Ohtsu <ohtsu@iij.ad.jp>
-
Daniel Bevenius authored
All symlink files in deps/openssl/openssl/include/openssl/ are removed and replaced with real header files to avoid issues on Windows. Two files of opensslconf.h in crypto and include dir are replaced to refer config/opensslconf.h. Fixes: https://github.com/nodejs/node/issues/13161 PR-URL: https://github.com/nodejs/node/pull/13233 Reviewed-By:
-
