- Mar 09, 2016
-
-
Jeremiah Senkpiel authored
Notable changes: * child_process: “send()” now accepts an options parameter (cjihrig) https://github.com/nodejs/node/pull/5283 - Currently the only option is “keepOpen”, which keeps the underlying socket open after the message is sent. * constants: “ENGINE_METHOD_RSA” is now correctly exposed (Sam Roberts) https://github.com/nodejs/node/pull/5463 * Fixed two regressions which originated in v5.7.0: - http: Errors inside of http client callbacks now propagate correctly (Trevor Norris) https://github.com/nodejs/node/pull/5591 - path: Fixed normalization of absolute paths (Evan Lucas) https://github.com/nodejs/node/pull/5589 * repl: “start()” no longer requires an options parameter (cjihrig) https://github.com/nodejs/node/pull/5388 * util: Improved “format()” performance 50-300% (Evan Lucas) https://github.com/nodejs/node/pull/5360 PR-URL: https://github.com/nodejs/node/pull/5559
-
Trevor Norris authored
In AsyncWrap::MakeCallback always return empty handle if there is an error. In the future this should change to return a v8::MaybeLocal, but that major change will have to wait for v6.x, and these changes are meant to be backported to v4.x. The HTTParser call to AsyncWrap::MakeCallback failed because it expected a thrown call to return an empty handle. In node::MakeCallback return an empty handle if the call is in_makecallback(), otherwise return v8::Undefined() as usual to preserve backwards compatibility. Fixes: https://github.com/nodejs/node/issues/5555 PR-URL: https://github.com/nodejs/node/pull/5591 Reviewed-By:
Julien Gilli <jgilli@nodejs.org>
-
Kat Marchán authored
PR-URL: https://github.com/nodejs/node/pull/5369 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com> Conflicts: deps/npm/node_modules/request/node_modules/aws4/LICENSE
-
Myles Borins authored
Currently we are not testing that `npm install` works. This is a very naive / basic test that shells out to `npm install` in an empty `tempDir`. While this test will not be able to check that `npm install` is 100% working, it should catch certain edge cases that break it. PR-URL: https://github.com/nodejs/node/pull/5166 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Alexis Campailla <orangemocha@nodejs.org>
-
Michael Barrett authored
PR-URL: https://github.com/nodejs/node/pull/5557 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Evan Lucas authored
Fixes a regression introduced by b212be08. path.normalize(''/a/b/c/../../../x/y/z'') should return '/x/y/z'. Fixes: https://github.com/nodejs/node/issues/5585 PR-URL: https://github.com/nodejs/node/pull/5589 Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Brian White <mscdex@mscdex.net>
-
Sequoia McDowell authored
The docs mentioned that the docs source live in the node source, but did not link to same. PR-URL: https://github.com/nodejs/node/pull/4591 Reviewed-By:
Roman Reiss <me@silverwind.io> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Rich Trott authored
`test-debug-break-on-uncaught` was hanging on the domain and parse error scenarios. These tests are not run in CI and may have been broken for a very long time. Refs: https://github.com/nodejs/node/issues/3156 Refs: https://github.com/nodejs/node/commit/c16963b9 PR-URL: https://github.com/nodejs/node/pull/5532 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Rod Vagg <r@va.gg>
-
Sakthipriyan Vairamani authored
Every time `make test` is run, the cpplint prints the file it successfully linted. None of the other linters in the project does that. This patch simply removes the "Done processing" message from the cpplint. PR-URL: https://github.com/nodejs/node/pull/5578 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Roman Reiss <me@silverwind.io> Reviewed-By:
Michaël Zasso <mic.besace@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Rich Trott authored
Enabled no-self-assign rule in ESLint. This required one change in a benchmark file. Changed a loop (that is outside of the benchmark itself, so performance is not critical) from a for loop that repeats a string to use String.prototype.repeat() instead. While at it, took the opportunity to const-ify the benchmark file. Also moved the "Strict" section in the .eslintrc to match where it is in the ESLint documentation. Updated the link for Strict rules to point to the ESLint website rather than the GitHub-hosted code. PR-URL: https://github.com/nodejs/node/pull/5552 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Johan Bergström <bugs@bergstroem.nu> Reviewed-By:
targos - Michaël Zasso <mic.besace@gmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io>
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/5560 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Robert Jefe Lindstaedt authored
also change stripe color to RGB 68 136 62 PR-URL: https://github.com/nodejs/node/pull/5531 Reviewed-By:
Roman Reiss <me@silverwind.io> Reviewed-By:
Rod Vagg <rod@vagg.org>
-
Matteo Collina authored
In net we default to 'localhost' as the default address for connect. Not doing the same on dgram is confusing, because sending to 0.0.0.0 works on Linux/OS X but not on Windows. Defaulting that to 127.0.0.1 / ::1 addresses that. Related: https://github.com/nodejs/node/pull/5407 Related: https://github.com/nodejs/node/issues/5398 Fixes: https://github.com/nodejs/node/issues/5487 PR-URL: https://github.com/nodejs/node/pull/5493 Reviewed-By:
Saúl Ibarra Corretgé <saghul@gmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io>
-
Brian White authored
Replacing the regexp and replace function with a loop improves performance by ~60-200%. PR-URL: https://github.com/nodejs/node/pull/5360 Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Evan Lucas authored
By manually copying arguments and breaking the try/catch out, we are able to improve the performance of util.format by 20-100% (depending on the types). PR-URL: https://github.com/nodejs/node/pull/5360 Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Evan Lucas authored
PR-URL: https://github.com/nodejs/node/pull/5360 Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Stefan Budeanu authored
Use the "Apple LLVM" version number since the banner has changed in newer versions of Mac OS X, resulting in the obsolete assembler path being used to compile OpenSSL. PR-URL: https://github.com/nodejs/node/pull/5553 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
cjihrig authored
This commit adds a failing test case for the vm module. Currently, if runInContext() defines a function, and a later call to runInContext() redefines the same function, the original function is not overwritten. Refs: https://github.com/nodejs/node/issues/548 PR-URL: https://github.com/nodejs/node/pull/5528 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Wyatt Preul <wpreul@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
cjihrig authored
This commit adds a known_issues directory to the test directory for scripts that reproduce known bugs. Since these scripts are expected to fail, it also adds a --expect-fail flag to test.py which reports tests as successful when they fail. Refs: https://github.com/nodejs/testing/issues/18 PR-URL: https://github.com/nodejs/node/pull/5528 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Wyatt Preul <wpreul@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
James M Snell authored
Rework the doc a bit to tighten it up, including removing the use of `you` Fix some line wrapping issues. PR-URL: https://github.com/nodejs/node/pull/5287 Reviewed-By:
Roman Klauke <romaaan.git@gmail.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> ...
-
Trevor Norris authored
Looping rapidly and making new connections causes problems on pi2. Instead create a new connection when an old connection has already been made. Running a stress test of 600 times and they all passed. Fixes: https://github.com/nodejs/node/issues/5302 PR-URL: https://github.com/nodejs/node/pull/5537 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Alexis Campailla <orangemocha@nodejs.org>
-
Wyatt Preul authored
The properties on memoryUsage were not checked before, this commit checks them. PR-URL: #5546 Reviewed-By:Colin Ihrig <cjihrig@gmail.com>
-
silverwind authored
Also fixed a minor color issue with :focus on the title. PR-URL: https://github.com/nodejs/node/pull/5548 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/5517 Reviewed-By:
Brian White <mscdex@mscdex.net> Reviewed-By:
Michaël Zasso <mic.besace@gmail.com> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/5517 Reviewed-By:
Brian White <mscdex@mscdex.net> Reviewed-By:
Michaël Zasso <mic.besace@gmail.com> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Rich Trott authored
Enable `no-extra-parens`. This rule restricts the use of parentheses to only where they are necessary. It is set to be restricted to report only function expressions. PR-URL: https://github.com/nodejs/node/pull/5512 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Craig Akimoto authored
https://code.google.com/p/v8/ redirects to the V8 issue tracker PR-URL: https://github.com/nodejs/node/pull/5530 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Sam Roberts authored
ENGINE_METHOD_PKEY_METH and ENGINE_METHOD_PKEY_ASN1_METH are misspelled in the documentation, both should be ..._METHS. PR-URL: https://github.com/nodejs/node/pull/5463 Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
Sam Roberts authored
constants.ENGINE_METHOD_RSA was documented, but not implemented. PR-URL: https://github.com/nodejs/node/pull/5463 Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
cjihrig authored
Currently, there is a check to ensure that the user either provides an object or a string to repl.start(). The string case is used to set a REPL prompt. However, a default of '> ' already exists, so forcing the user to specify a prompt is a bit redundant. This commit removes this restriction. Fixes: https://github.com/nodejs/node/issues/5385 PR-URL: https://github.com/nodejs/node/pull/5388 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Julian Duque <julianduquej@gmail.com>
-
cjihrig authored
This option allows an instance of net.Socket to be kept open in the sending process. Fixes: https://github.com/nodejs/node/issues/4271 PR-URL: https://github.com/nodejs/node/pull/5283 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
cjihrig authored
This commit adds an options object to process.send(). The same object is propagated to process._send(), the _handleQueue, and the send() and postSend() functions of the handle converter. Fixes: https://github.com/nodejs/node/issues/4271 PR-URL: https://github.com/nodejs/node/pull/5283 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
- Mar 03, 2016
-
-
Jeremiah Senkpiel authored
PR-URL: https://github.com/nodejs/node/pull/5464
-
Jeremiah Senkpiel authored
Notable changes: * governance: The Core Technical Committee (CTC) added four new members to help guide Node.js core development: Evan Lucas, Rich Trott, Ali Ijaz Sheikh and Сковорода Никита Андреевич (Nikita Skovoroda). * openssl: Upgrade from 1.0.2f to 1.0.2g (Ben Noordhuis) https://github.com/nodejs/node/pull/5507 - Fix a double-free defect in parsing malformed DSA keys that may potentially be used for DoS or memory corruption attacks. It is likely to be very difficult to use this defect for a practical attack and is therefore considered low severity for Node.js users. More info is available at https://www.openssl.org/news/vulnerabilities.html#2016-0705 - Fix a defect that can cause memory corruption in certain very rare cases relating to the internal `BN_hex2bn()` and `BN_dec2bn()` functions. It is believed that Node.js is not invoking the code paths that use these functions so practical attacks via Node.js using this defect are _unlikely_ to be possible. More info is available at https://www.openssl.org/news/vulnerabilities.html#2016-0797 - Fix a defect that makes the CacheBleed Attack (https://ssrg.nicta.com.au/projects/TS/cachebleed/) possible. This defect enables attackers to execute side-channel attacks leading to the potential recovery of entire RSA private keys. It only affects the Intel Sandy Bridge (and possibly older) microarchitecture when using hyper-threading. Newer microarchitectures, including Haswell, are unaffected. More info is available at https://www.openssl.org/news/vulnerabilities.html#2016-0702 * Fixed several regressions that appeared in v5.7.0: - path.relative(): - Output is no longer unnecessarily verbose (Brian White) https://github.com/nodejs/node/pull/5389 - Resolving UNC paths on Windows now works correctly (Owen Smith) https://github.com/nodejs/node/pull/5456 - Resolving paths with prefixes now works correctly from the root directory (Owen Smith) https://github.com/nodejs/node/pull/5490 - url: Fixed an off-by-one error with `parse()` (Brian White) https://github.com/nodejs/node/pull/5394 - dgram: Now correctly handles a default address case when offset and length are specified (Matteo Collina) https://github.com/nodejs/node/pull/5407 PR-URL: https://github.com/nodejs/node/pull/5464
-
ronkorving authored
PR-URL: https://github.com/nodejs/node/pull/5472 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io> Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
firedfox authored
All eslint rules are configured to report as errors. Remove useless --quiet flag from eslint invocation in Makefile and vcbuild.bat. PR-URL: https://github.com/nodejs/node/pull/5519 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Michaël Zasso <mic.besace@gmail.com> Reviewed-By:
Johan Bergström <bugs@bergstroem.nu> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io>
-
Anton Khlynovskiy authored
Array#pop() is known to be faster than Array#shift(). To be exact, it's O(1) vs. O(n). In this case there's no difference from which side of the "pool" array the object is retrieved, so .pop() should be preferred. PR-URL: https://github.com/nodejs/node/pull/2174 Reviewed-By:
mscdex - Brian White <mscdex@mscdex.net> Reviewed-By:
jasnell - James M Snell <jasnell@gmail.com> Reviewed-By:
ofrobots - Ali Ijaz Sheikh <ofrobots@google.com>
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/5410 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Ben Noordhuis authored
* Restrict the receiver to instances of the FunctionTemplate. * Use `args.This()` instead of `args.Holder()`. Fixes: https://github.com/nodejs/node/issues/3682 PR-URL: https://github.com/nodejs/node/pull/5521 Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
Rich Trott authored
Increase timeout for test from 500ms to 1000ms so busy slow machines don't produce false positives. Fixes: https://github.com/nodejs/node/issues/4964 PR-URL: https://github.com/nodejs/node/pull/5466 Reviewed-By:
Alexis Campailla <orangemocha@nodejs.org>
-