- Jun 04, 2015
-
-
Shigeki Ohtsu authored
In openssl s_client on Windows, RAND_screen() is invoked to initialize random state but it takes several seconds in each connection. This added -no_rand_screen to openssl s_client on Windows to skip RAND_screen() and gets a better performance in the unit test of test-tls-server-verify. Do not enable this except to use in the unit test. (cherry picked from commit 9f0f7c38e6df975dd39735d0e9ef968076369c74) Reviewed-By:
James M Snell <jasnell@gmail.com> PR-URL: https://github.com/joyent/node/pull/25368
-
Shigeki Ohtsu authored
For better performance of the test, the parent kills child processes so as not to wait them to be ended. (cherry picked from commit 833b23636045f7afc929196139021630a390391a) Reviewed-By:
James M Snell <jasnell@gmail.com> PR-URL: https://github.com/joyent/node/pull/25368
-
Alexis Campailla authored
Now that the test is fixed, node-accept-pull-request should fail when the test fails. Reviewed-By:
James M Snell <jasnell@gmail.com> PR-URL: https://github.com/joyent/node/pull/25368
-
João Reis authored
When running in parallel, it is not easy to identify what server and client failed when the test fails. This adds identifiers to all lines of console output. Reviewed-By:
James M Snell <jasnell@gmail.com> PR-URL: https://github.com/joyent/node/pull/25368
-
João Reis authored
Different servers must use different ports. Since we can count only on common.PORT and common.PORT+1, run only 2 servers in parallel. Reviewed-By:
James M Snell <jasnell@gmail.com> PR-URL: https://github.com/joyent/node/pull/25368
-
João Reis authored
OpenSSL s_client introduces some delay on Windows. With all clients running sequentially, this delay is big enough to break CI. This fix runs the clients in parallel (unless the test includes renegotiation), reducing the total run time. Reviewed-By:
James M Snell <jasnell@gmail.com> PR-URL: https://github.com/joyent/node/pull/25368
-
- May 23, 2015
-
-
Julien Gilli authored
-
Julien Gilli authored
-
Julien Gilli authored
* npm: upgrade to 2.10.1 * V8: revert v8 Array.prototype.values() removal (cjihrig) * win: bring back xp/2k3 support (Bert Belder)
-
Rebecca Turner authored
Reviewed-By:
Julien Gilli <julien.gilli@joyent.com> PR-URL: https://github.com/joyent/node/pull/25364
-
Bert Belder authored
Issue: https://github.com/joyent/node/issues/25348 The gyp/project files don't explicitly specify a subsystem version, which results in the default being used. The default changed from VS 2010 to VS 2012 and later. Backport e8d08503 from io.js. Original commit message follows: Chrome still runs on Windows XP, so there is no reason that iojs couldn't. PR: https://github.com/iojs/io.js/pull/512 (cherry picked from commit e8d08503 ) Reviewed-By:
Julien Gilli <julien.gilli@joyent.com> PR-URL: https://github.com/joyent/node/pull/25367
-
cjihrig authored
This commit adds a regression test for https://github.com/joyent/node/issues/25324 Reviewed-By:
Julien Gilli <julien.gilli@joyent.com> PR-URL: https://github.com/joyent/node/pull/25328
-
cjihrig authored
The Node 0.12 line was initially released with a version of v8 that included Array.prototype.values(). In https://github.com/joyent/node/pull/18206, v8 was updated to a version that dropped support for values(). https://codereview.chromium.org/647703003 removed this method because it causes problems with some versions of Outlook Web Access. This commit reverts the removal of Array.prototype.values(). Original commit message: Revert "Version 3.28.71.17 (merged r24706, r24708)" This reverts commit 529541ecb58fd0d6df4dfbe41d01bff9ae21ff06. Conflicts: src/version.cc Reviewed-By:
Julien Gilli <julien.gilli@joyent.com> PR-URL: https://github.com/joyent/node/pull/25328
-
- May 21, 2015
-
-
Chad Johnston authored
Refs #25270,#25271 Reviewed-By:
Michael Dawson <mhdawsonibm@gmail.com> PR-URL: https://github.com/joyent/node/pull/25325
-
- May 15, 2015
-
-
Gireesh Punathil authored
With additional load in the system, the child process which runs sleep command takes more time to run - typically slightly above 1 second, but above 2 seconds under stress. While the intent of the test is to test the functionality of spawnSync and the child process in general, in effect it is testing the system command sleep, and further, it's responsiveness. Since from the name the purpose of the test seems to be unrelated to the sleep behaviour, I believe a more meaningful assertion would be to see the time taken is more than 1 second. Reviewed-By:
Michael Dawson <mhdawsonibm@gmail.com> PR-URL: https://github.com/joyent/node/pull/25291
-
Michael Dawson authored
This test currently fails when run on machines without IPv6 enabled. Futher it was delete in io.js under 3143d732 as the test was known to have problems across platforms and releases. The existing test was hard to understand so I wrote a new version but then found exactly what was reported in the io.js pull request. Behaviour varies across platforms such that writing a solid test would either be infeasible or test so little that it does not seem to make sense to keep it. Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> PR-URL: https://github.com/joyent/node/pull/25326
-
- May 14, 2015
-
-
Julien Gilli authored
-
Julien Gilli authored
-
Julien Gilli authored
* V8: update to 3.28.71.19 * uv: upgrade to 1.5.0 * npm: upgrade to 2.9.1 * V8: don't busy loop in v8 cpu profiler thread (Mike Tunnicliffe) * V8: fix issue with let bindings in for loops (adamk) * debugger: don't spawn child process in remote mode (Jackson Tian) * net: do not set V4MAPPED on FreeBSD (Julien Gilli) * repl: make 'Unexpected token' errors recoverable (Julien Gilli) * src: backport ignore ENOTCONN on shutdown race (Ben Noordhuis) * src: fix backport of SIGINT crash fix on FreeBSD (Julien Gilli)
-
Julien Gilli authored
Revert "disable RC4, add --cipher-list command line switch" and "tls: make --enable-legacy-cipher-list=val less verbose" This reverts commit f9291a94 and b5737bb9 . There is still some work to be done to guarantee secure defaults and a smooth upgrade path for v0.12.x users. Before this work is finished, we want to be able to release new versions of v0.12.x. So instead of waiting for these changes to be ready to ship, revert them and integrate them when they're ready to be shipped. Conflicts: src/node.cc Reviewed-By:
James M Snell <jasnell@gmail.com> PR-URL: https://github.com/joyent/node/pull/25296
-
- May 13, 2015
-
-
Forrest L Norvell authored
Reviewed-By:
Julien Gilli <julien.gilli@joyent.com> PR-URL: https://github.com/joyent/node/pull/25289
-
Julien Gilli authored
Fix the regexp used to detect 'Unexpected token' errors so that they can be considered as recoverable. This fixes the following use case: > var foo = 'bar \ ... baz'; undefined > foo 'bar baz' > Fixes #8874 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> PR-URL: https://github.com/joyent/node/pull/8875
-
Alexis Campailla authored
test-tls-server-verify takes a lont time to execute and times out on the Jenkins machines. Reviewed-By:
James M Snell <jasnell@gmail.com> PR-URL: https://github.com/joyent/node/pull/25284
-
- May 12, 2015
-
-
Mike Tunnicliffe authored
Backport 6964a9e0685fa186d9d9b7907be17505e839db1a from upstream v8. Original commit message: Make CPU profiler do not hog 100% of CPU. Tick event processor should not stay in a tight loop when there's nothing to do. It can go sleep until next sample event. LOG=N BUG=v8:3967 Committed: https://crrev.com/6964a9e0685fa186d9d9b7907be17505e839db1a Cr-Commit-Position: refs/heads/master@{#28211} Fixes #25137 Related: #9439, #8789 PR: #25268 PR-URL: https://github.com/joyent/node/pull/25268 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Julien Gilli <jgilli@fastmail.fm>
-
Trevor Norris authored
The -fno-strict-aliasing flag was added to fix compilation warnings when building Node.js with GCC <= 4.4 Reviewed-By:
Julien Gilli <julien.gilli@joyent.com> PR-URL: https://github.com/joyent/node/pull/9179 PR: #25141 PR-URL: https://github.com/joyent/node/pull/25141 Reviewed-By:
Trevor Norris <trev.norris@gmail.com> Reviewed-By:
Julien Gilli <jgilli@fastmail.fm>
-
Saúl Ibarra Corretgé authored
PR: #25141 PR-URL: https://github.com/joyent/node/pull/25141 Reviewed-By:
Trevor Norris <trev.norris@gmail.com> Reviewed-By:
Julien Gilli <jgilli@fastmail.fm>
-
- May 07, 2015
-
-
Michael Dawson authored
The loopback on AIX is slower by default than on other platforms and we've seen a number of tests fail on AIX for this reason. This looks to be another instance. Changing the test to bind to the host ip instead of the loopback makes it pass reliably. This change extends the timeout so that it passes reliably on AIX even with the slower loopback behaviour modified: test/simple/test-tls-wrap-timeout.js Reviewed-By:
coln Ihrig <cjihrig@gmail.com> PR-URL: https://github.com/joyent/node/pull/25138
-
- May 01, 2015
-
-
Forrest L Norvell authored
Reviewed-By:
Julien Gilli <julien.gilli@joyent.com> PR-URL: https://github.com/joyent/node/pull/20311
-
Julien Gilli authored
When running make test-npm, make would use the node binary available in the PATH, which would most of the time not be the same binary as the one built from the source tree from where the make test-npm command in run. This can be confusing, as it can lead users to think that they tested npm with the version of node that was built from the current checkout of the source tree when it would actually run the tests with a completely different version. This change modifies the PATH environment variable for all commands that need to run the node binary to run npm's tests by adding the root of the local checkout as the first entry, so that the custom built node is always used. Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> PR-URL: https://github.com/joyent/node/pull/9107
-
- Apr 30, 2015
-
-
Julien Gilli authored
072460265226c047369558b23e9ff2748965bf6c floats a patch on V8 that fixes issue #9113 that would cause let bindings and continue statements in for loops to not work properly. This change adds a regression test that fails if that patch is not properly floated, thus preventing us from not floating that patch after future V8 upgrades. Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> PR-URL: https://github.com/joyent/node/pull/23948
-
adamk authored
Backport b17eaaa5755e625493c5fe537f42b58838923c52 from upstream v8. Original commit message: Fix desugaring of let bindings in for loops to handle continue properly This requires putting the original loop's body inside an inner for loop (with the same labels as the original loop) and re-binding the temp variables in its "next" expression. A second flag is added to the desugared code to ensure the loop body executes at most once per loop. BUG=v8:3683 LOG=y Review URL: https://codereview.chromium.org/720863002 Cr-Commit-Position: refs/heads/master@{#25363} Fixes #9113 and #14411. Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> PR-URL: https://github.com/joyent/node/pull/23948
-
Julien Gilli authored
This change in V8: https://code.google.com/p/v8/source/detail?r=22210 has introduced a method named OS::GetCurrentThreadId which fails to compile on OSes where a "gettid" syscall does not exist. This build issue has been fixed upstream by several changes: - https://code.google.com/p/v8/source/detail?r=23459. - https://codereview.chromium.org/649553002 - https://codereview.chromium.org/642223003 Another minor fix to the upstream changes was also necessary. See https://code.google.com/p/v8/issues/detail?id=3620 for more information. The other build issue was due to the fact that alloca.h is not included by other system includes on SmartOS, which is assumed by V8. Built and tested on Linux, MacOS X, Windows and SmartOS. Reviewed-By:
Trevor Norris <trev.norris@gmail.com> PR-URL: https://github.com/joyent/node/pull/18206
-
Yury Semikhatsky authored
Backport 2ad2237507c5b5f9047b8d94d2f4997327eae852 from V8. Original commit message: Fix Unhandled ReferenceError in debug-debugger.js This fixes following exception in Sky on attempt to set a breakpoint "Unhandled: Uncaught ReferenceError: break_point is not defined" I think this happens in Sky but not in Chrome because Sky scripts are executed in strict mode. BUG=None LOG=N R=yangguo@chromium.org Review URL: https://codereview.chromium.org/741683002 Cr-Commit-Position: refs/heads/master@{#25415} Reviewed-By:
Trevor Norris <trev.norris@gmail.com> PR-URL: https://github.com/joyent/node/pull/18206
-
Dave Pacheco authored
Reviewed-By:
Trevor Norris <trev.norris@gmail.com> PR-URL: https://github.com/joyent/node/pull/18206
-
Refael Ackermann authored
Reviewed-By:
Trevor Norris <trev.norris@gmail.com> PR-URL: https://github.com/joyent/node/pull/18206
-
Trevor Norris authored
Reviewed-By:
Trevor Norris <trev.norris@gmail.com> PR-URL: https://github.com/joyent/node/pull/18206
-
Trevor Norris authored
The 3.28.73 update was technically unstable code. This reverts the code to the latest 3.28 stable release. Reviewed-By:
Trevor Norris <trev.norris@gmail.com> PR-URL: https://github.com/joyent/node/pull/18206
-
- Apr 29, 2015
-
-
Julien Gilli authored
V4MAPPED is not supported on recent FreeBSD versions, at least on 10.1. Thus, do not set this flag in net.connect on FreeBSD. Fixes #8540 and #9204. Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> PR-URL: https://github.com/joyent/node/pull/18204
-
- Apr 24, 2015
-
-
Alexis Campailla authored
vcbuild.bat calls python configure before setting GYP_MSVS_VERSION, so SelectVisualStudioVersion (tools\gyp\pylib\gyp\MSVSVersion.py) defaults to 'auto' and selects VS 2005. vcbuild sets the environment in the current shell, so this issue would manifest itself only on the first invocation of the script in any given shell windows. Reviewed-By:
Julien Gilli <jgilli@fastmail.fm> PR-URL: https://github.com/joyent/node/pull/20109
-
- Apr 15, 2015
-
-
Julien Gilli authored
61fe1fe2 backported b64983d7 from io.js, but failed to change nullptr to NULL, which lead to a build break on FreeBSD since the current build system doesn't enable support for C++11. This change replaces nullptr by NULL, and has been tested on FreeBSD 10.1-RELEASE-p8. Fixes #9326. Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> PR-URL: https://github.com/joyent/node/pull/14819
-