- Nov 15, 2020
-
-
Michaël Zasso authored
Original commit message: [wasm-simd][arm64] fix cross compile arm64 on windows See: https://github.com/nodejs/node/pull/35415 Change-Id: I5d77ae202d4bbfb0971246fe5de9c0ad17c485ff Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2459491 Reviewed-by:Tobias Tebbi <tebbi@chromium.org> Auto-Submit: Jiawen Geng <technicalcute@gmail.com> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#70444} Refs: https://github.com/v8/v8/commit/d76abfed3512ceabf91ee1a148845c7592030f76 PR-URL: https://github.com/nodejs/node/pull/35415 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
Jiawen Geng authored
PR-URL: https://github.com/nodejs/node/pull/35415 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
cjihrig authored
This commit updates V8's gen-postmortem-metadata.py script to fix SmartOS compilation with V8 8.5. PR-URL: https://github.com/nodejs/node/pull/35415 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
cjihrig authored
This commit updates V8's gen-postmortem-metadata.py script to fix SmartOS compilation for V8 8.4. PR-URL: https://github.com/nodejs/node/pull/33579 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Shelley Vohr <codebytere@gmail.com>
-
Matheus Marchini authored
Patch V8 (wasm/wasm-module.cc) to remove const qualifier from type passed to template call of `OwnedVector::Of`. Xcode 8 can't convert 'OwnedVector<unsigned char>' to 'OwnedVector<const unsigned char>' when returning from a function (which is likely a bug on Xcode, considering this worked on the prior version of Xcode as well as newer versions). This workaround shouldn't affect the application, since the const qualifier is preserved in the AsmJsOffsetInformation::encoded_offset_. There's also a V8 test passing a const-qualified type to ::Of, but since we don't test V8 on Xcode 8, it should be fine to leave it as is. Signed-off-by:
Matheus Marchini <mmarchini@netflix.com> PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/26685 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Refael Ackermann <refack@gmail.com> PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
Joao Reis authored
There is a bug in the most recent version of VS2015 that affects v8.h and therefore prevents compilation of addons. Refs: https://stackoverflow.com/q/38378693 PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
Refael Ackermann authored
This should be semver-patch since actual invocation is version conditional. PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
Refael Ackermann authored
Fixes a compilation issue on some platforms PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
Ujjwal Sharma authored
Patch V8 (compiler/js-heap-broker.cc) to remove the use of an optional property, which is a fairly new C++ feature, since that requires a newer XCode version than the minimum requirement in BUILDING.md and thus breaks CI. PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
Refael Ackermann authored
Original commit message: [testrunner] delete ancient junit compatible format support Testrunner has ancient support for JUnit compatible XML output. This CL removes this old feature. R=mstarzinger@chromium.org,jgruber@chromium.org,jkummerow@chromium.org CC=machenbach@chromium.org Bug: v8:8728 Change-Id: I7e1beb011dbaec3aa1a27398a5c52abdd778eaf0 Reviewed-on: https://chromium-review.googlesource.com/c/1430065 Reviewed-by:Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#59045} Refs: https://github.com/v8/v8/commit/bd019bdb725cebaa34327634d73936cd7003d17c PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
Michaël Zasso authored
Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 8.7. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md PR-URL: https://github.com/nodejs/node/pull/35700 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Shelley Vohr <codebytere@gmail.com>
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/35700 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Shelley Vohr <codebytere@gmail.com>
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/35700 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Shelley Vohr <codebytere@gmail.com>
-
Shelley Vohr authored
PR-URL: https://github.com/nodejs/node/pull/36101 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com>
-
Rich Trott authored
Inadvertent double hash in link makes it invalid and no longer pointing to the documentation section it intends to point to. PR-URL: https://github.com/nodejs/node/pull/36109 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com>
-
Rich Trott authored
In email, Shigeki Ohtsu indicated that a move to emeritus would be appropriate at this time. I'm especially grateful for the crypto and security work over the years, and I'm sure I'm not the only one. PR-URL: https://github.com/nodejs/node/pull/36093 Reviewed-By:
Shigeki Ohtsu <ohtsu@ohtsu.org> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Momtchil Momtchev authored
Render all properties of nodeTiming enumerable so JSON.stringify and Object.keys can access them Fixes: https://github.com/nodejs/node/issues/35936 PR-URL: https://github.com/nodejs/node/pull/35977 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
FeelyChau authored
If the option cwd does not exist, the error ENOENT is the same as the error emitted when the command does not exist, it's confusing. PR-URL: https://github.com/nodejs/node/pull/34505 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
Szymon Marczak authored
PR-URL: https://github.com/nodejs/node/pull/33099 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com>
-
Luigi Pinca authored
- Remove unneeded listener for the `'error'` event. - Use `common.mustCall()`. - Verify that the `src` stream gets paused. PR-URL: https://github.com/nodejs/node/pull/36056 Refs: https://github.com/nodejs/node/pull/35941 Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Ricky Zhou <0x19951125@gmail.com>
-
- Nov 14, 2020
-
-
raisinten authored
Fixes: https://github.com/nodejs/node/issues/36064 PR-URL: https://github.com/nodejs/node/pull/36094 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Zeyu Yang <himself65@outlook.com> Reviewed-By:
Andrey Pechkurov <apechkurov@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/36023 Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/36019 Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/36025 Reviewed-By:
Shingo Inoue <leko.noor@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Rich Trott authored
Add test case to cover currently-uncovered code. Refs: https://coverage.nodejs.org/coverage-39a7f7663e8f70fc/lib/internal/util/inspect.js.html#L333 PR-URL: https://github.com/nodejs/node/pull/36086 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com>
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/36011 Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Antoine du Hamel authored
Refs: https://www.w3.org/TR/WebCryptoAPI/#subtlecrypto-interface Fixes: https://github.com/nodejs/node/issues/36083 PR-URL: https://github.com/nodejs/node/pull/36087 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/36003 Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/35998 Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Yash Ladha authored
We were fetching the buffer from the float array to send out the response in js land, however that logic is being duplicated in node_process.h. Now they will be using an inline to fetch the array buffers and making it more generic. PR-URL: https://github.com/nodejs/node/pull/34553 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com>
-
Brian Ingenito authored
For scenario where target env is explicitly specified as vs2019, do not clear VCINSTALLDIR which was being cleared to handle fallback to vs2017 block when attempting to find a matching available VS. Fixes: https://github.com/nodejs/node/issues/35856 PR-URL: https://github.com/nodejs/node/pull/36009 Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
- Nov 13, 2020
-
-
Aleksandr Krutko authored
Replace `var` with `const` in vm context for test-util-inspect.js. PR-URL: https://github.com/nodejs/node/pull/36069 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
Rich Trott authored
Use apostrophe for possessive. PR-URL: https://github.com/nodejs/node/pull/36066 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com>
-
Gireesh Punathil authored
Add libuv's cumulative idle time in the diagnostic report. Add the data under the libuv's loop section Refs: https://github.com/nodejs/node/pull/34938 PR-URL: https://github.com/nodejs/node/pull/35940 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Richard Lau <rlau@redhat.com>
-
Rich Trott authored
The test uses a file name twice, causing unreliability in CI. In particular, it's failing a lot on the Raspberry Pi devices. Fixes: https://github.com/nodejs/node/issues/36090 PR-URL: https://github.com/nodejs/node/pull/36102 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Richard Lau <rlau@redhat.com>
-
Rich Trott authored
The test is not nearly as unreliable as it used to be but we're still seeing failures around the timing checks that will definitely be affected by other tests running in other processes. So move it to sequential. Refs: https://github.com/nodejs/node/pull/35961#issuecomment-722222696 PR-URL: https://github.com/nodejs/node/pull/35996 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com>
-
raisinten authored
Refs: https://github.com/nodejs/node/pull/26725 Fixes: https://github.com/nodejs/node/issues/29813 Refs: https://github.com/nodejs/node/pull/29814 PR-URL: https://github.com/nodejs/node/pull/35755 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Christian Clauss <cclauss@me.com>
-
rickyes authored
PR-URL: https://github.com/nodejs/node/pull/35845 Fixes: https://github.com/nodejs/node/issues/35833 Reviewed-By:
Robert Nagy <ronagy@icloud.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
- Nov 12, 2020
-
-
Ole André Vadla Ravnås authored
Original commit message: [mac-arm64] Fix missing #include For an "#if defined(MAP_JIT)" test to work as expected, <sys/mman.h> must be included in the compilation unit. Bug: chromium:1144200 Change-Id: Ia0bf35ec1872c02457f1fbc0ee6689c7f7d27d4a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2517689 Reviewed-by:Clemens Backes <clemensb@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#70986} PR-URL: https://github.com/nodejs/node/pull/35986 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Michael Dawson <midawson@redhat.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Beth Griggs <bgriggs@redhat.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com>
-