- Jun 24, 2020
-
-
Benjamin Gruenbaum authored
Event#cancelBubble is property (and not a function). Change Event#cancelBubble to a property and add a test. PR-URL: https://github.com/nodejs/node/pull/33613 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com> PR-URL: https://github.com/nodejs/node/pull/34015 Reviewed-By:
Denys Otrishko <shishugi@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
Benjamin Gruenbaum authored
PR-URL: https://github.com/nodejs/node/pull/34015 Reviewed-By:
-
Benjamin Gruenbaum authored
PR-URL: https://github.com/nodejs/node/pull/34015 Reviewed-By:
-
Zirak authored
On the web, dispatchEvent is finicky about its `this` value. An exception is thrown for `this` values which are not an EventTarget. PR-URL: https://github.com/nodejs/node/pull/34015 Reviewed-By:
-
Benjamin Gruenbaum authored
Remove support for multiple arguments (which don't actually work for EventTarget). Use our EventTarget implementation rather than a mock. Refactor `once` code in preparation of `on` using shared code for supporting `on` with `EventTarget`s. Support EventTarget in the `events.on` static method PR-URL: https://github.com/nodejs/node/pull/34015 Reviewed-By:
-
Denys Otrishko authored
PR-URL: https://github.com/nodejs/node/pull/34015 Reviewed-By:
-
Denys Otrishko authored
PR-URL: https://github.com/nodejs/node/pull/34015 Reviewed-By:
-
Mateusz Krawczuk authored
PR-URL: https://github.com/nodejs/node/pull/33983 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
-
Gabriel Schulhof authored
Document that it is not necessary to open handle and/or callback scopes inside finalizer, async work, thread-safe function etc. callbacks unless for reasons documented in the section about object lifetime management. Link usage of callback signatures to their definition. Fixes: https://github.com/nodejs/node/issues/33893 PR-URL: https://github.com/nodejs/node/pull/33915 Reviewed-By:
Chengzhong Wu <legendecas@gmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
Rich Trott authored
Remove noCallOrProp from tools/doc/json.js. It is a negative lookahead that is only used in one regex where it is placed immediately before a terminating $, thus rendering it meaningless. PR-URL: https://github.com/nodejs/node/pull/33998 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Jamie Davis <davisjam@vt.edu>
-
legendecas authored
PR-URL: https://github.com/nodejs/node/pull/33871 Reviewed-By:
Gabriel Schulhof <gabriel.schulhof@intel.com>
-
Evan Lucas authored
All other JavaScript files in lib use snake case, so make this one consistent. PR-URL: https://github.com/nodejs/node/pull/33793 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
-
- Jun 23, 2020
-
-
Rich Trott authored
The collaborator guide suggests pinging individuals about npm upgrades. Change to pinging the npm team instead. PR-URL: https://github.com/nodejs/node/pull/33999 Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By:
Andrey Pechkurov <apechkurov@gmail.com>
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/34000 Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/34000 Reviewed-By:
-
Robert Nagy authored
The performance benefit of using a custom pool are negligable. Furthermore, it causes problems with Workers and transferrable. Rather than further adding complexity for compat with Workers, just remove the pooling logic. Refs: https://github.com/nodejs/node/issues/33880#issuecomment-644430693 Fixes: https://github.com/nodejs/node/issues/31733 PR-URL: https://github.com/nodejs/node/pull/33981 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Maël Nison authored
PR-URL: https://github.com/nodejs/node/pull/33399 Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
-
Rich Trott authored
The http2 docs include invalid JavaScript values as defaults for three options. The intention was increased clarity, but we specify valid values everywhere else in our docs, so let's do that for consistency. PR-URL: https://github.com/nodejs/node/pull/33997 Reviewed-By:
-
Rich Trott authored
We mostly have a single space between the punctuation that ends a sentence and the start of the next sentence. Change instances with two spaces to one. PR-URL: https://github.com/nodejs/node/pull/33995 Reviewed-By:
Matheus Marchini <mat@mmarchini.me> Reviewed-By:
-
James M Snell authored
Move the promisified timers implementations into a new sub-module to avoid the need to promisify. The promisified versions now return the timers/promises versions. Also adds `ref` option to the promisified versions ```js const { setTimeout, setImmediate } = require('timers/promises'); setTimeout(10, null, { ref: false }) .then(console.log); setImmediate(null, { ref: false }) .then(console.log); ``` Signed-off-by: -
WilliamConnatser authored
PR-URL: https://github.com/nodejs/node/pull/33992 Reviewed-By:
Robert Nagy <ronagy@icloud.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
Tobias Nießen authored
This change allows sharing KeyObjects between threads via postMessage. The receiver acquires a new KeyObject and a new KeyObjectHandle, but refers to the same KeyObjectData: +-------------------+ | NativeKeyObject 1 | ------------------------------------------+ +-------------------+ | ^ | extends | | | +-------------------+ +-------------------+ | | KeyObject 1 (JS) | -> | KeyObjectHandle 1 | --------------+ | +-------------------+ +-------------------+ | | | | | | | | | | | | +-------------------+ | | | NativeKeyObject 2 | ------------------------------------+ | | +-------------------+ | | | ^ | | | extends | | | | | | | +-------------------+ +-------------------+ | | | | KeyObject 2 (JS) | -> | KeyObjectHandle 2 | --------+ | | | +-------------------+ +-------------------+ | | | | | | | | | | | | | | | | | | | | | | | | +-------------------+ | | | | | NativeKeyObject 3 | ------------------------------+ | | | | +-------------------+ | | | | | ^ | | | | | extends | | | | | | v v v v v +-------------------+ +-------------------+ +---------------+ | KeyObject 3 (JS) | -> | KeyObjectHandle 3 | -> | KeyObjectData | +-------------------+ +-------------------+ +---------------+ Co-authored-by: -
Tobias Nießen authored
This separates key handles from the actual key data: +-----------------+ | NativeKeyObject | +-----------------+ ^ extends | +-----------------+ +-----------------+ +---------------+ | KeyObject (JS) | -> | KeyObjectHandle | -> | KeyObjectData | +-----------------+ +-----------------+ +---------------+ PR-URL: https://github.com/nodejs/node/pull/33360 Reviewed-By: -
Tobias Nießen authored
+---------------------+ | BaseObject | +---------------------+ | | | +---------------------+ | NativeKeyObject | +---------------------+ | | | +---------------------+ | KeyObject | +---------------------+ / \ / \ / \ / \ +---------------------+ +---------------------+ | SecretKeyObject | | AsymmetricKeyObject | +---------------------+ +---------------------+ / \ / \ / \ / \ +---------------------+ +---------------------+ | PublicKeyObject | | PrivateKeyObject | +---------------------+ +---------------------+ PR-URL: https://github.com/nodejs/node/pull/33360 Reviewed-By: -
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/33360 Reviewed-By:
-
Daniel Bevenius authored
Currently, the following lint error is generated: Running C++ linter... File "src/quic/node_quic_crypto.cc" does not use "String" make[1]: *** [Makefile:1336: tools/.cpplintstamp] Error 1 This commit removes the unused using declaration. PR-URL: https://github.com/nodejs/node/pull/34019 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
-
James M Snell authored
The way the preferred address mechanism is supposed to work is this: A server might be exposed via multiple network interfaces / addresses. The preferred address is the one that clients should use. If a client uses one of the non-preferred addresses to initially connect to the server, the server will include the preferred address in it's initial transport params back to the client over the original connection. The client then can make a choice: it can either choose to ignore the advertised preferred address and continue using the original, or it can transition the in-flight connection to the preferred address without having to restart the connection. In the latter case, the connection will start making use of the preferred address but it might not do so immediately. To test this mechanism properly, we should have our server configured on multiple endpoints with one of those marked as the preferred. The connection should start on one and preceed uninterrupted to completion. If the preferred address policy is "accept", the client will accept and transition to the servers preferred address transparently, without interupting the flow. The current test is deficient because the server is only listening on a single address which is also advertised as the preferred. While the client should get the advertisement, we're not actually making use of the preferred address advertisement and nothing on the connection changes The ipv6 version of the test is also hanging on some platforms and it's not entirely clear why yet. PR-URL: https://github.com/nodejs/node/pull/33934 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
-
Shelley Vohr authored
PR-URL: https://github.com/nodejs/node/pull/33952 Reviewed-By:
-
Anna Henningsen authored
The callback passed to `SSL_CTX_sess_set_new_cb()` should return 1 if it takes ownership (i.e. holds a reference that is later freed through `SSL_SESSION_free()`) of the passed session, and 0 otherwise. Since we don’t take ownership of the session and instead only save a serialized version of it, return 0 instead of 1. This closes a memory leak reported when running `sequential/test-quic-preferred-address-ipv6`. PR-URL: https://github.com/nodejs/node/pull/33931 Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
Daniel Bevenius authored
PR-URL: https://github.com/nodejs/node/pull/33942 Reviewed-By:
-
Daniel Bevenius authored
This commit adds two defines to ngtcp2, 'HAVE_ARPA_INET_H' and 'HAVE_NETINET_IN_H', and one define to nghttp3, 'HAVE_ARPA_INET_H' when the operating system in use is linux. The motivation for this is that currently, there are compiler warnings generated for these libraries similar to the following: ../deps/ngtcp2/lib/ngtcp2_conv.c: In function ‘ngtcp2_put_uint16be’: ../deps/ngtcp2/lib/ngtcp2_conv.c:129:7: warning: implicit declaration of function ‘htons’ [-Wimplicit-function-declaration] 129 | n = htons(n); | ^~~~~ The inclusion of 'arpa/inet.h' is guarded by the 'HAVE_ARPA_INET_H' macro (see deps/ngtcp2/lib/ngtcp2_conv.h). These headers are checked by the ngtcp2 and nghttp3 builds using CMake's CheckIncludeFile, and if they are available the above macros are defined. I'm not sure if we need to have something similar to those checks or ifit is alright to add these defines for certain operating systems. Hopefully others will chime in and advice on how to handle this in the best way. PR-URL: https://github.com/nodejs/node/pull/33942 Reviewed-By: -
James M Snell authored
Ignore `ipv6Only: true` when binding to `'udp4'` (this differs from dgram which will still attempt to apply the flag and will fail during bind). Improve the test so that it should work consistently. Signed-off-by:
-
Anna Henningsen authored
- Use `kInternalFieldCount`, similar to 0fac393d. - Always inherit from the correct parent template, similar to 8a7201b2. - Always provide a template class name. PR-URL: https://github.com/nodejs/node/pull/33968 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/33986 Reviewed-By:
-
- Jun 22, 2020
-
-
gengjiawen authored
PR-URL: https://github.com/nodejs/node/pull/33963 Reviewed-By:
David Carlier <devnexen@gmail.com> Reviewed-By:
-
wenningplus authored
Allow host and protocol to be inspected. PR-URL: https://github.com/nodejs/node/pull/33803 Fixes: https://github.com/nodejs/node/issues/2461 Reviewed-By:
-
Shakil-Shahadat authored
First class heading is made to look like other headings. PR-URL: https://github.com/nodejs/node/pull/33820 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
Daniel Bevenius authored
PR-URL: https://github.com/nodejs/node/pull/33937 Reviewed-By:
-
gengjiawen authored
PR-URL: https://github.com/nodejs/node/pull/33976 Reviewed-By:
-
gengjiawen authored
PR-URL: https://github.com/nodejs/node/pull/33976 Reviewed-By:
-
