1. Jun 11, 2011
  2. Jun 08, 2011
  3. Jun 05, 2011
    • isaacs's avatar
      typo · 794cb60f
      isaacs authored
      794cb60f
    • isaacs's avatar
      Avoid instanceof for native object types · 580ab7ba
      isaacs authored
      For classes defined in the module, this is fine.  For 'Error'
      it's probably not very hazardous.  However, testing 'Object'
      and 'String' is much more reliable using typeof, to work with
      the repl and NODE_MODULE_CONTEXT modes.
      580ab7ba
  4. Jun 04, 2011
  5. Jun 03, 2011
  6. Jun 01, 2011
  7. May 29, 2011
  8. May 28, 2011
    • Ryan Petrello's avatar
      Close #562 Close #1078 Parse file:// urls properly · 58a1d7ec
      Ryan Petrello authored
      The file:// protocol *always* has a hostname; it's frequently
      abbreviated as an empty string, which represents 'localhost'
      implicitly.
      
      According to RFC 1738 (http://tools.ietf.org/html/rfc1738):
      
      A file URL takes the form:
      
         file://<host>/<path>
      
      where <host> is the fully qualified domain name of the system on
      which the <path> is accessible...
      
      As a special case, <host> can be the string "localhost" or the empty
      string; this is interpreted as 'the machine from which the URL is
      being interpreted'.
      58a1d7ec
  9. May 26, 2011
  10. May 25, 2011
    • Ben Noordhuis's avatar
      Fix resource leaks in node_crypto.cc · eb4c9ed8
      Ben Noordhuis authored
      Fixes #1097.
      eb4c9ed8
    • Brian White's avatar
      Crypto documentation fixes · 9b347263
      Brian White authored
      Fixes #1104.
      9b347263
    • Ryan Dahl's avatar
      8f065475
    • Felix Geisendörfer's avatar
      Remove 'connect' event from server side sockets · f0a440d8
      Felix Geisendörfer authored
      Sockets emitted by the 'connection' event are always connected, having
      them emit the 'connect' event makes no sense. It only confused people,
      as it's not clear if you have to listen to 'connect' or not.
      
      That try..catch block was also very scary. It would silently swallow
      exceptions in 'connect' listeners and destroy the socket. Makes no
      sense.
      
      Fixes #1047.
      f0a440d8
    • Felix Geisendörfer's avatar
      Fix error handling bug in stream.pipe() · 2b91256c
      Felix Geisendörfer authored
      Problem: Since stream.pipe() is registering it's own error handlers on
      the source and destination stream, it needs to replicate the
      EventEmitter 'error' emitting semantics of throwing an error if there
      are no other listeners. However, there was a off-by-one error because
      the check for remaining listeners was done after cleanup() which means
      the pipe's own listener was no longer included.
      
      This would cause 'error' events on either the dest or the source to
      throw if there was one other error listener, and while swallowing
      the 'error' event if there was no other listener.
      
      Solution: I added a test demonstrating the two issues and fixed the
      problem by correcting the off-by-one error.
      
      Fixes #1095.
      2b91256c
    • Brian White's avatar
      Fix incorrect documentation for assert.fail() · d2225942
      Brian White authored
      Fixes #1100.
      d2225942
  11. May 24, 2011
  12. May 23, 2011
  13. May 21, 2011