- Jul 27, 2010
-
-
Benjamin Kramer authored
Also silences a compiler warning about deprecated conversion from const char* to char*.
-
Benjamin Kramer authored
& has higher precedence than ==, making this a noop. Use the less error-prone S_IS* macros instead. Found by clang.
-
Benjamin Kramer authored
The old definition was off by one byte on BSD. Also simplify ADDRESS_TO_JS because sun_path is always zero-terminated now.
-
Ryan Dahl authored
-
Chandra Sekar S authored
-
Ryan Dahl authored
-
- Jul 26, 2010
-
-
Ryan Dahl authored
-
Ryan Dahl authored
-
Dmitry Baranovskiy authored
Added ability to pass offset to buffer write and toString methods as a string, i.e. '2' and encoding as anything
-
Dmitry Baranovskiy authored
Fixed format, so it wouldn’t blow up if %d argument is null or undefined + ensure that numbers will be numbers
-
- Jul 24, 2010
-
-
Ryan Dahl authored
There might be an off-by-one on the returned value.
-
Ryan Dahl authored
-
Ryan Dahl authored
-
isaacs authored
Before there was this comment: Can't strip trailing slashes since module.js incorrectly thinks dirname('/a/b/') should yield '/a/b' instead of '/a'. But now, such thinking is corrected. -
Andrew Naylor authored
-
- Jul 22, 2010
-
-
Ryan Dahl authored
-
Ryan Dahl authored
-
Ryan Dahl authored
-
Chandra Sekar S authored
-
- Jul 21, 2010
-
-
Peter Griess authored
- Buffer.toString('ascii', 0, 0) incorrectly returns the entire contents of the buffer. Fix this. - Provide similar behavior to Buffer.write() and Buffer.copy() when dealing with 0-length in valid and invalid byte ranges. -
Sam Shull authored
-
Robert Keizer authored
-
isaacs authored
This way, require("/foo") will work if there is a "foo.js", or a file named simply "foo" with no extension.
-
- Jul 20, 2010
-
-
Ryan Dahl authored
Callbacks should always be the last argument.
-
Brian authored
-
isaacs authored
This is ever so slightly less efficient than caching based on ID, since the filename has to be looked up before we can check the cache. However, it's the most minimal approach possible to get this change in place. Since require() is a blocking startup-time operation anyway, a bit of slowness is not a huge problem. A test involving require.paths modification and absolute loading. Here's the gist of it. Files: /p1/foo.js /p2/foo.js 1. Add "/p1" to require.paths. 2. foo1 = require("foo") 3. assert foo1 === require("/p1/foo") (fail) 4. Remove /p1 from require.paths. 5. Add /p2 to require.paths. 6. foo2 = require("foo") 7. assert foo1 !== foo2 (fail) 8. assert foo2 === require("/p2/foo") (fail) It's an edge case, but it affects how dependencies are mapped by npm. If your module requires foo-1.2.3, and my module requires foo-2.3.4, then you should expect to have require("foo") give you foo-1.2.3, and I should expect require("foo") to give me foo-2.3.4. However, with module ID based caching, if your code loads *first*, then your "foo" is THE "foo", so I'll get your version instead of mine. It hasn't yet been a problem, but only because there are so few modules, and everyone pretty much uses the latest version all the time. But as things start to get to the 1.x and 2.x versions, it'll be an issue, I'm sure. Dependency hell isn't fun, so this is a way to avoid it before it strikes. -
Peter Griess authored
-
Micheil Smith authored
The tests did not accurately test for a strict equality, meaning that the number == to the string.
-
Jan Kassens authored
-
Jan Kassens authored
-
Jan Kassens authored
* handles NaN and Infinity * works with arrays from other contexts
-
Ryan Dahl authored
-
Ryan Dahl authored
-
Benjamin Fritsch authored
-
Ryan Dahl authored
-
- Jul 19, 2010
-
-
Jérémy Lal authored
-
- Jul 18, 2010
- Jul 17, 2010