- Apr 28, 2020
-
-
Sam Roberts authored
Refs: https://github.com/nodejs/node/issues/26401#issuecomment-613095719 PR-URL: https://github.com/nodejs/node/pull/32826 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
Sam Roberts authored
Refs: https://github.com/nodejs/node/issues/29802 Refs: https://github.com/nodejs/node/pull/32595 PR-URL: https://github.com/nodejs/node/pull/32825 Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By:
-
Reşat SABIQ authored
PR-URL: https://github.com/nodejs/node/pull/32591 Fixes: https://github.com/nodejs/node/issues/32559 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
-
Julian Duque authored
PR-URL: https://github.com/nodejs/node/pull/32751 Reviewed-By:
Adrian Estrada <edsadr@gmail.com> Reviewed-By:
Zeyu Yang <himself65@outlook.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Daniel Bevenius authored
Currently, the following warnings are emitted during compilation: In file included from ../src/string_bytes.h:29, from ../src/string_bytes.cc:22: ../deps/v8/include/v8.h: In instantiation of ‘void v8::PersistentBase<T>::SetWeak( P*,typename v8::WeakCallbackInfo<P>::Callback, v8::WeakCallbackType) [with P = node::BaseObject; T = v8::Object; typename v8::WeakCallbackInfo<P>::Callback = void (*)(const v8::WeakCallbackInfo<node::BaseObject>&)]’: ../src/base_object-inl.h:135:42: required from here ../deps/v8/include/v8.h:10732:16: warning: cast between incompatible function types from ‘v8::WeakCallbackInfo<node::BaseObject>::Callback’ {aka ‘void (*)(const v8::WeakCallbackInfo<node::BaseObject>&)’} to ‘Callback’ {aka ‘void (*)(const v8::WeakCallbackInfo<void>&)’} [-Wcast-function-type] 10732 | reinterpret_cast<Callback>(callback), type); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ And the... -
Yash Ladha authored
check for callback function is moved to a separate function. This piece of code is being shared by other entities as well. PR-URL: https://github.com/nodejs/node/pull/32665 Reviewed-By:
-
Anna Henningsen authored
Add a configure flag that enables building V8 with `-DDEBUG`, in particular with debug checks enabled and with runtime debugging features, e.g. inspecting JS objects from debuggers, enabled. PR-URL: https://github.com/nodejs/node/pull/32787 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Matheus Marchini <mat@mmarchini.me> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com>
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/32788 Reviewed-By:
Robert Nagy <ronagy@icloud.com> Reviewed-By:
-
cjihrig authored
This commit moves the last experimental feature of diagnostic reports to stable status. PR-URL: https://github.com/nodejs/node/pull/32496 Reviewed-By:
-
Michael Dawson authored
Add js_native_api.h and js_native_api_types.h to the list of files covered by the N-API guidance as these were broken out of the files referenced. Signed-off-by:
Michael Dawson <michael_dawson@ca.ibm.com> PR-URL: https://github.com/nodejs/node/pull/32721 Reviewed-By:
Chengzhong Wu <legendecas@gmail.com>
-
Matheus Marchini authored
clang's linker seems to use considerably less memory than gcc, allowing us to run on Actions without running out of memory. Signed-off-by:
Matheus Marchini <mmarchini@netflix.com> PR-URL: https://github.com/nodejs/node/pull/32776 Reviewed-By:
-
Matheus Marchini authored
Signed-off-by:
-
Cecchi MacNaughton authored
The example referenced as being potentially unsafe specifies Content-Length correctly. PR-URL: https://github.com/nodejs/node/pull/32700 Reviewed-By:
-
Gerhard Stoebich authored
Add a type check in bidirectionalIndexOf to avoid using something else as Buffer. This may happen if e.g. lastIndexOf is called with invalid this. PR-URL: https://github.com/nodejs/node/pull/32770 Fixes: https://github.com/nodejs/node/issues/32753 Fixes: https://github.com/nodejs/node/issues/32747 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com>
-
Anna Henningsen authored
Avoid storing data that depends on command line options on internal bindings. This is generally a cleaner way of accessing CLI options. PR-URL: https://github.com/nodejs/node/pull/32760 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
David Carlier <devnexen@gmail.com>
-
Anna Henningsen authored
This removes a footgun in which users could attempt to transfer the pooled ArrayBuffer underlying a regular `Buffer`, which would lead to all `Buffer`s that share the same pool being rendered unusable as well, and potentially break creation of new pooled `Buffer`s. This disables this kind of transfer. Refs: https://github.com/nodejs/node/issues/32752 PR-URL: https://github.com/nodejs/node/pull/32759 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
-
Andrey Pechkurov authored
PR-URL: https://github.com/nodejs/node/pull/32757 Reviewed-By:
-
Juan José Arboleda authored
PR-URL: https://github.com/nodejs/node/pull/32749 Reviewed-By:
-
Harshitha KP authored
Fixes: https://github.com/nodejs/node/issues/22139 Co-authored-by:
Mritunjay Goutam <mritunjaygoutam2204@gmail.com> PR-URL: https://github.com/nodejs/node/pull/32703 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
Andrey Pechkurov authored
PR-URL: https://github.com/nodejs/node/pull/31950 Reviewed-By:
Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By:
-
Stephen Belanger authored
PR-URL: https://github.com/nodejs/node/pull/31950 Reviewed-By:
-
John Kleinschmidt authored
Fixes: https://github.com/nodejs/build/issues/1931 PR-URL: https://github.com/nodejs/node/pull/32129 Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
-
John Kleinschmidt authored
Git for Windows includes `C:\Program Files\Git\bin\bash.exe`, which spawns ..\usr\bin\bash.exe, so copying that executable won't work. However, if a symlink is used to test paths with spaces, this executable will still work. PR-URL: https://github.com/nodejs/node/pull/32129 Reviewed-By:
-
Andrey Pechkurov authored
PR-URL: https://github.com/nodejs/node/pull/32817 Reviewed-By:
-
Anna Henningsen authored
Use the same type check we use in `MoveToContext()` in `ReceiveMessage()`. Fixes: https://github.com/nodejs/node/issues/32742 PR-URL: https://github.com/nodejs/node/pull/32745 Reviewed-By:
-
Gabriel Schulhof authored
We introduce status `napi_would_deadlock` to be used as a return status by `napi_call_threadsafe_function` if the call is made with `napi_tsfn_blocking` on the main thread and the queue is full. Fixes: https://github.com/nodejs/node/issues/32615 Signed-off-by:
Gabriel Schulhof <gabriel.schulhof@intel.com> PR-URL: https://github.com/nodejs/node/pull/32860 Backport-PR-URL: https://github.com/nodejs/node/pull/32948 Reviewed-By:
-
Gabriel Schulhof authored
This reverts commit aeb7084f. The solution creates incorrect behaviour on Windows. Re: https://github.com/nodejs/node-addon-api/pull/697#issuecomment-612993476 Signed-off-by:
-
Michaël Zasso authored
Original commit message: [debug] Revert to old line number behavior for new Function() Reverting https://chromium-review.googlesource.com/c/v8/v8/+/1741660 This fixed one bug but caused a lot of others and on balance I think reverting it is the lesser evil. This also fixed generator-relocation.js because (function*(){}).constructor is the function constructor and we try to set a breakpoint on line 3. Bug: chromium:109362, chromium:1028689 Fixes: v8:9721 Change-Id: I1bfe6ec57ce77ea7292df91266311f5c0194947e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1940259 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#65232} Refs: https://github.com/v8/v8/commit/dc3a90be6ca7f7160e1865f289e76c7bc32f78c4 Revert "assert: fix line number calculation after V8 upgrade" This reverts commit 5981fb7f. Fixes: https://github.com/nodejs/node/issues/32688 PR-URL: https://github.com/nodejs/node/pull/32795 Reviewed-By:
-
- Apr 15, 2020
-
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/32813
-
Michaël Zasso authored
Notable changes: New file system APIs: * Added a new function, `fs.readv` (with sync and promisified versions). This function takes an array of `ArrayBufferView` elements and will write the data it reads sequentially to the buffers (Sk Sajidul Kadir). https://github.com/nodejs/node/pull/32356 * A new overload is available for `fs.readSync`, which allows to optionally pass any of the `offset`, `length` and `position` parameters. https://github.com/nodejs/node/pull/32460 Other changes: * dns: * Added the `dns.ALL` flag, that can be passed to `dns.lookup()` with `dns.V4MAPPED` to return resolved IPv6 addresses as well as IPv4 mapped IPv6 addresses (murgatroid99). https://github.com/nodejs/node/pull/32183 * http: * The default maximum HTTP header size was changed from 8KB to 16KB (rosaxny). https://github.com/nodejs/node/pull/32520 * n-api: * Calls to `napi_call_threadsafe_function` from the main thread can now return the `napi_would_deadlock` status in certain circumstances (Gabriel Schulhof). https://github.com/nodejs/node/pull/32689 * util: * Added a new `maxStrLength` option to `util.inspect`, to control the maximum length of printed strings. Its default value is `Infinity` (rosaxny). https://github.com/nodejs/node/pull/32392 * worker: * Added support for passing a `transferList` along with `workerData` to the `Worker` constructor (Juan José Arboleda). https://github.com/nodejs/node/pull/32278 New core collaborators: With this release, we welcome three new Node.js core collaborators: * himself65. https://github.com/nodejs/node/pull/32734 * flarna (Gerhard Stoebich). https://github.com/nodejs/node/pull/32620 * mildsunrise (Alba Mendez). https://github.com/nodejs/node/pull/32525 PR-URL: https://github.com/nodejs/node/pull/32813
-
- Apr 13, 2020
-
-
Robert Nagy authored
Refs: https://github.com/nodejs/node/issues/32764 PR-URL: https://github.com/nodejs/node/pull/32767 Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
Jesus Hernandez authored
PR-URL: https://github.com/nodejs/node/pull/32779 Reviewed-By:
-
Michaël Zasso authored
This makes the output much smaller and lets us focus on errors if there are any. PR-URL: https://github.com/nodejs/node/pull/32714 Reviewed-By:
-
Juan José Arboleda authored
Replace the obsolete node-test-pull-request-lite-pipeline CI task in favour of node-test-pull-request. PR-URL: https://github.com/nodejs/node/pull/32736 Reviewed-By:
-
Richard Lau authored
Move the generated previous doc versions JSON file out of `out/doc` to prevent it being included in the distributed packages. Signed-off-by:
Shelley Vohr <codebytere@gmail.com> Reviewed-By:
-
Nimit authored
This adds new section for v8 options and --max-old-space-size Fixes: https://github.com/nodejs/node/issues/32252 PR-URL: https://github.com/nodejs/node/pull/32262 Reviewed-By:
-
Juan José Arboleda authored
PR-URL: https://github.com/nodejs/node/pull/32729 Reviewed-By:
-
- Apr 12, 2020
-
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/32719 Reviewed-By:
-
龙腾道 authored
Function setTimeout in net.Socket should return this, not undefined, as doc said. PR-URL: https://github.com/nodejs/node/pull/32722 Refs: https://nodejs.org/api/net.html#net_socket_settimeout_timeout_callback Reviewed-By:
-
himself65 authored
Make `startMark` and `endMark` parameters optional. PR-URL: https://github.com/nodejs/node/pull/32651 Fixes: https://github.com/nodejs/node/issues/32647 Refs: https://www.w3.org/TR/user-timing-2/#measure-method Reviewed-By:
-
