- Apr 22, 2020
-
-
David Gilbertson authored
Tables on some pages (e.g. https://nodejs.org/api/crypto.html) are quite wide because of long content (e.g. URLs) that don't break. With this change, cell padding is smaller on small screens, and the table content is allowed to break. PR-URL: https://github.com/nodejs/node/pull/31859 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Ben Noordhuis authored
Turn the `strategy_` method pointer into an enum-based static dispatch. It's both safer and more secure (no chance of method pointer corruption) and it helps GCC see that the shift and suffix tables it's complaining about are unused in single char search mode. Fixes the following warning: ../src/string_search.h:113:30: warning: ‘search’ may be used uninitialized in this function [-Wmaybe-uninitialized] return (this->*strategy_)(subject, index); Fixes: https://github.com/nodejs/node/issues/26733 Refs: https://github.com/nodejs/node/pull/31532 Refs: https://github.com/nodejs/node/pull/31798 PR-URL: https://github.com/nodejs/node/pull/31809 Reviewed-By:Michaël Zasso <targos@protonmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Denys Otrishko <shishugi@gmail.com> Reviewed-By:
David Carlier <devnexen@gmail.com> Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Ben Noordhuis authored
PR-URL: https://github.com/nodejs/node/pull/31809 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Denys Otrishko <shishugi@gmail.com> Reviewed-By:
David Carlier <devnexen@gmail.com> Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
forfun414 authored
change scripts and sources for android build, don't need standalone toolchain after ndk 19, and use clang as default android target compiler. PR-URL: https://github.com/nodejs/node/pull/31521 Reviewed-By:
Christian Clauss <cclauss@me.com>
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/31400 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/31400 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
cjihrig authored
Update ESLint to 7.0.0-alpha.2 PR-URL: https://github.com/nodejs/node/pull/31400 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
cjihrig authored
Update ESLint to 7.0.0-alpha.1 PR-URL: https://github.com/nodejs/node/pull/31400 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
cjihrig authored
Update ESLint to 7.0.0-alpha.0 PR-URL: https://github.com/nodejs/node/pull/31400 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
RamanandPatil authored
PR-URL: https://github.com/nodejs/node/pull/32041 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
Myles Borins authored
This is only for 10.15 but this test is periodically failing across many CI runs. Would like to mark this as flaky so we can avoid lots of red CI. Refs: https://github.com/nodejs/node/issues/21781 PR-URL: https://github.com/nodejs/node/pull/32189 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Beth Griggs <Bethany.Griggs@uk.ibm.com>
-
- Apr 21, 2020
-
-
Guy Bedford authored
PR-URL: https://github.com/nodejs/node/pull/31845 Reviewed-By:
Jan Krems <jan.krems@gmail.com> Reviewed-By:
Geoffrey Booth <webmaster@geoffreybooth.com> Backport-PR-URL: https://github.com/nodejs/node/pull/32959 Reviewed-By:
Michaël Zasso <targos@protonmail.com>
-
Alba Mendez authored
Completely disables the use of positioned writes at writeFile and writeFileSync, which allows it to work with non-seekable files. Fixes: https://github.com/nodejs/node/issues/31926 Backport-PR-URL: https://github.com/nodejs/node/pull/32172 PR-URL: https://github.com/nodejs/node/pull/32006 Reviewed-By:
Anna Henningsen <anna@addaleax.net>
-
antsmartian authored
Backport-PR-URL: https://github.com/nodejs/node/pull/32164 PR-URL: https://github.com/nodejs/node/pull/31187 Refs: https://github.com/nodejs/node/pull/31144 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Denys Otrishko <shishugi@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Robert Nagy <ronagy@icloud.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net>
-
Matheus Marchini authored
If the subprocess being inspected hard crashes, there will be no information on the log, and the parent process will just wait until timeout. Logging the error signal when it happens can help developers understand failures faster. Signed-off-by:
Matheus Marchini <mmarchini@netflix.com> PR-URL: https://github.com/nodejs/node/pull/32133 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Denys Otrishko authored
PR-URL: https://github.com/nodejs/node/pull/31773 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Denys Otrishko authored
This adds `const char*` based APIs to KVStore to avoid multiple string conversions (char -> Utf8 -> Local -> char etc.) when possible. PR-URL: https://github.com/nodejs/node/pull/31773 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Robert Nagy authored
Whether and when a socket is destroyed or not after a timeout is up to the user. This leaves an edge case where a socket that has emitted 'timeout' might be re-used from the free pool. Even if destroy is called on the socket, it won't be removed from the freelist until 'close' which can happen several ticks later. Sockets are removed from the free list on the 'close' event. However, there is a delay between calling destroy() and 'close' being emitted. This means that it possible for a socket that has been destroyed to be re-used from the free list, causing unexpected failures. PR-URL: https://github.com/nodejs/node/pull/32000 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Denys Otrishko <shishugi@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
James M Snell authored
Separating this out from the QUIC PR to allow it to be separately reviewed. The QUIC implementation makes use of the hdr_histogram for dynamic performance monitoring. This introduces a BaseObject class that allows the internal histograms to be accessed on the JavaScript side and adds a generic Histogram class that will be used by both QUIC and perf_hooks (for the event loop delay monitoring). Signed-off-by:
James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/31988 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com>
-
- Apr 18, 2020
-
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/31915 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Anna Henningsen authored
Use a JS function as the single entry point for emitting `.onmessage()` calls, avoiding the overhead of manually constructing each message event object in C++. confidence improvement accuracy (*) (**) (***) worker/echo.js n=100000 sendsPerBroadcast=1 payload='object' workers=1 *** 16.34 % ±1.16% ±1.54% ±1.99% worker/echo.js n=100000 sendsPerBroadcast=1 payload='string' workers=1 *** 24.41 % ±1.50% ±1.99% ±2.58% worker/echo.js n=100000 sendsPerBroadcast=10 payload='object' workers=1 *** 26.66 % ±1.54% ±2.05% ±2.65% worker/echo.js n=100000 sendsPerBroadcast=10 payload='string' workers=1 *** 32.72 % ±1.60% ±2.11% ±2.73% worker/messageport.js n=1000000 payload='object' *** 40.28 % ±1.48% ±1.95% ±2.52% worker/messageport.js n=1000000 payload='string' *** 76.95 % ±2.19% ±2.90% ±3.75% Also fix handling exceptions returned from `MessagePort::New`. PR-URL: https://github.com/nodejs/node/pull/31605 Reviewed-By:James M Snell <jasnell@gmail.com> Reviewed-By:
Denys Otrishko <shishugi@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Daniel Bevenius authored
PR-URL: https://github.com/nodejs/node/pull/31535 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
David Carlier <devnexen@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Matteo Collina authored
A test was missing for an async iterator created after the stream had emitted 'close'. This was regressed by #31314. See: https://github.com/nodejs/node/pull/31314 PR-URL: https://github.com/nodejs/node/pull/31508 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
Guy Bedford authored
Backport-PR-URL: https://github.com/nodejs/node/pull/32883 PR-URL: https://github.com/nodejs/node/pull/32351 Reviewed-By:
Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By:
Bradley Farias <bradley.meck@gmail.com> Reviewed-By:
Jan Krems <jan.krems@gmail.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
- Apr 09, 2020
-
-
Shelley Vohr authored
PR-URL: https://github.com/nodejs/node/pull/32313
-
- Apr 08, 2020
-
-
Shelley Vohr authored
Notable changes: doc: * add ronag to collaborators (Robert Nagy) [#31498](https://github.com/nodejs/node/pull/31498) * add GeoffreyBooth to collaborators (Geoffrey Booth) [#31306](https://github.com/nodejs/node/pull/31306) deps: * upgrade npm to 6.13.6 (Ruy Adorno) [#31304](https://github.com/nodejs/node/pull/31304) * update openssl to 1.1.1e (Hassaan Pasha) [#32328](https://github.com/nodejs/node/pull/32328)
-
- Apr 04, 2020
-
-
Richard Lau authored
PR-URL: https://github.com/nodejs/node/pull/32619 Refs: https://github.com/v8/v8/commit/07ee86a5a28b7f9526748ca8f765c1b704f93c0c Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Milad Farazmand authored
Original commit message: PPC: allow for calling CFunctions without function descriptors on AIX. The calling conventions on AIX uses function descriptors, which means that pointers to functions do not point to code, but instead point to metadata about them. When calling JITed code, we must assure to use function descriptors instead of raw pointers when needed. Before this CL 213504b, all CallCFunction on AIX were guaranteed to have function descriptors. Starting form the CL mentioned above, CallCFunction can also Jump to a Trampoline which does not have a function descriptor, hence a new "CallCFunctionWithoutFunctionDescriptor" method is proposed to deal with this issue. BUG= v8:9766 Change-Id: I9343c31c812f5d4dda8503a5adf024b24dbde072 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1825961 Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Reviewed-by:Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#64357} Refs: https://github.com/v8/v8/commit/07ee86a5a28b7f9526748ca8f765c1b704f93c0c PR-URL: https://github.com/nodejs/node/pull/32619 Refs: https://github.com/v8/v8/commit/07ee86a5a28b7f9526748ca8f765c1b704f93c0c Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Myles Borins authored
PR-URL: https://github.com/nodejs/node/pull/32610 Reviewed-By:
Geoffrey Booth <webmaster@geoffreybooth.com>
-
Guy Bedford authored
Backport-PR-URL: https://github.com/nodejs/node/pull/32610 Co-Authored-By:
Geoffrey Booth <GeoffreyBooth@users.noreply.github.com> PR-URL: https://github.com/nodejs/node/pull/32098 Reviewed-By:
Geoffrey Booth <webmaster@geoffreybooth.com>
-
Nick Schonning authored
This matches what the lint-js make target passes through the CLI. Backport-PR-URL: https://github.com/nodejs/node/pull/32610 PR-URL: https://github.com/nodejs/node/pull/32145 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Denys Otrishko <shishugi@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
Rich Trott authored
Remove "obvious" and "obviously" in two places in esm.md. It may be obvious to some, but likely not everyone or else it probably wouldn't be worth mentioning/documenting. Backport-PR-URL: https://github.com/nodejs/node/pull/32610 PR-URL: https://github.com/nodejs/node/pull/32457 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
Richard Lau authored
Signed-off-by:
Richard Lau <riclau@uk.ibm.com> Backport-PR-URL: https://github.com/nodejs/node/pull/32610 PR-URL: https://github.com/nodejs/node/pull/32462 Refs: https://github.com/nodejs/node/pull/31479 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
Rich Trott authored
Simplify complex sentence. Remove use of "straightforward". Backport-PR-URL: https://github.com/nodejs/node/pull/32610 PR-URL: https://github.com/nodejs/node/pull/32427 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
Eric Dobbertin authored
Backport-PR-URL: https://github.com/nodejs/node/pull/32610 PR-URL: https://github.com/nodejs/node/pull/31479 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
Jan Krems authored
Backport-PR-URL: https://github.com/nodejs/node/pull/32610 PR-URL: https://github.com/nodejs/node/pull/32068 Reviewed-By:
Bradley Farias <bradley.meck@gmail.com> Reviewed-By:
Geoffrey Booth <webmaster@geoffreybooth.com>
-
himself65 authored
Backport-PR-URL: https://github.com/nodejs/node/pull/32610 PR-URL: https://github.com/nodejs/node/pull/32147 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
Guy Bedford authored
Backport-PR-URL: https://github.com/nodejs/node/pull/32610 PR-URL: https://github.com/nodejs/node/pull/31625 Reviewed-By:
Jan Krems <jan.krems@gmail.com>
-
Guy Bedford authored
Backport-PR-URL: https://github.com/nodejs/node/pull/32610 PR-URL: https://github.com/nodejs/node/pull/31032 Reviewed-By:
Jan Krems <jan.krems@gmail.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
- Apr 02, 2020
-
-
Rich Trott authored
Update minimist used by lint-md.js to 1.2.5. Refs: https://app.snyk.io/vuln/SNYK-JS-MINIMIST-559764 Signed-off-by:
Rich Trott <rtrott@gmail.com> PR-URL: https://github.com/nodejs/node/pull/32274 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
James M Snell <jasnell@gmail.com>
-