- Sep 13, 2017
-
-
Michaël Zasso authored
Original commit message: [inspector] support for cases when embedder doesn't call contextDestroyed Node.js doesn't have good place to call contextDestroyed. We need to cleanup everything on our side to allow clients to not call contextDestroyed method. R=dgozman@chromium.org,eostroukhov@chromium.com Bug: none Change-Id: Ibe3f01fd18afbfa579e5db66ab6f174d5fad7c82 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/575519 Reviewed-by:Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#46849} Reviewed-on: https://chromium-review.googlesource.com/596549 Cr-Commit-Position: refs/heads/master@{#47060} PR-URL: https://github.com/nodejs/node/pull/14730 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com>
-
Bartosz Sosnowski authored
VS2013 does not support defaulting move constructor and assignment operator. This adds explicit definitions of those methods for two classes. This fix is required because we still support building addons with VS2013 and the incompatibility is in v8.h. Fixes: https://github.com/nodejs/node-v8/issues/4 PR-URL: https://github.com/nodejs/node/pull/13263 Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
Michael Dawson authored
regress/regress-crbug-514081 allocates a 2G block of memory and if there are multiple variants running at the same time this can lead to crashes, OOM kills or the OS failing to allocate memory. This patch limits us to running a single variant of the test Fixes: https://github.com/nodejs/node/issues/6340 PR-URL: https://github.com/nodejs/node/pull/6678 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
Michaël Zasso authored
Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 6.1. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md PR-URL: https://github.com/nodejs/node/pull/14730 Reviewed-By:
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/14730 Reviewed-By:
-
Vse Mozhet Byt authored
* Fix some abbreviated wording, a typo and a link. * Wrap long lines at 80 characters. PR-URL: https://github.com/nodejs/node/pull/15315 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
-
Gabriel Schulhof authored
The binding testing napi_wrap() creates references to primitives passed into the binding in its second parameter. This is unnecessary and not at all the point of the test. Additionally, creating persistent references to primitive values may not be supported by all VMs, since primitives are best persisted in their native form. Instead, the point of the test is to make sure that the finalize callback gets called when it should get called, that it gets called with the correct pointer, and that it does not get called when it should not get called. Creating persistent references is not necessary for verifying this. PR-URL: https://github.com/nodejs/node/pull/15289 Reviewed-By:
Jason Ginchereau <jasongin@microsoft.com> Reviewed-By:
-
Jon Moss authored
It is more secure to verify SHASUMS256.txt files via SHASUMS256.txt.sig than SHASUMS256.txt.asc. This comment does the best job at explaining the issue: https://github.com/nodejs/node/issues/6821#issuecomment-220033176 Refer: https://github.com/nodejs/node/issues/6821 Refer: https://github.com/nodejs/node/issues/9071 PR-URL: https://github.com/nodejs/node/pull/15107 Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
-
Ruben Bridgewater authored
Unbox all primitives and compare them as well instead of only comparing boxed strings. PR-URL: https://github.com/nodejs/node/pull/15050 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com>
-
geek authored
This commit adds special handling of Error instances when passed as the message argument to assert functions. With this commit, if an Error is passed as the message, then that Error is thrown instead of an AssertionError. PR-URL: https://github.com/nodejs/node/pull/15304 Reviewed-By:
-
- Sep 12, 2017
-
-
Myles Borins authored
Notable Changes * build: * Snapshots are now re-enabled in V8 https://github.com/nodejs/node/pull/14875 * console: * Implement minimal `console.group()`. https://github.com/nodejs/node/pull/14910 * deps: * upgrade libuv to 1.14.1 https://github.com/nodejs/node/pull/14866 * update nghttp2 to v1.25.0 https://github.com/nodejs/node/pull/14955 * dns: * Add `verbatim` option to dns.lookup(). When true, results from the DNS resolver are passed on as-is, without the reshuffling that Node.js otherwise does that puts IPv4 addresses before IPv6 addresses. https://github.com/nodejs/node/pull/14731 * fs: * add fs.copyFile and fs.copyFileSync which allows for more efficient copying of files. https://github.com/nodejs/node/pull/15034 * inspector: * Enable async stack traces https://github.com/nodejs/node/pull/13870 * module: * Add support for ESM. This is currently behind the `--experimental-modules` flag and requires the .mjs extension. `node --experimental-modules index.mjs` https://github.com/nodejs/node/pull/14369 * napi: * implement promise https://github.com/nodejs/node/pull/14365 * os: * Add support for CIDR notation to the output of the networkInterfaces() method. https://github.com/nodejs/node/pull/14307 * perf_hooks: * An initial implementation of the Performance Timing API for Node.js. This is the same Performance Timing API implemented by modern browsers with a number of Node.js specific properties. The User Timing mark() and measure() APIs are implemented, as is a Node.js specific flavor of the Frame Timing for measuring event loop duration. https://github.com/nodejs/node/pull/14680 * tls: * multiple PFX in createSecureContext [#14793](https://github.com/nodejs/node/pull/14793) * Added new collaborators: * BridgeAR – Ruben Bridgewater PR-URL: https://github.com/nodejs/node/pull/15308
-
Anatoli Papirovski authored
Remove unnecessary variable assignments, remove unreachable code pathways, remove path getter and setter, and other very minor cleanup. Only remove reference to stream on nextTick so that users and libraries can access it in the finish event. Fixes: https://github.com/nodejs/node/issues/15313 Refs: https://github.com/expressjs/express/pull/3390 PR-URL: https://github.com/nodejs/node/pull/15254 Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/15293 Reviewed-By:
Claudio Rodriguez <cjrodr@yahoo.com> Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/15290 Refs: https://github.com/nodejs/node/pull/14369 Reviewed-By:
Bradley Farias <bradley.meck@gmail.com> Reviewed-By:
-
James M Snell authored
Explicitly allow vague objections to change requests to be dismissed if requests for clarification go unanswered PR-URL: https://github.com/nodejs/node/pull/15233 Reviewed-By:
Jan Krems <jan.krems@gmail.com> Reviewed-By:
Ryan Graham <r.m.graham@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
Timothy Gu <timothygu99@gmail.com> Reviewed-By:
Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By:
Ron Korving <ron@ronkorving.nl> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/15212 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/15002 Reviewed-By:
-
Michaël Zasso authored
Update AUTHORS list using tools/update-authors.sh. Update .mailmap to handle duplicates. PR-URL: https://github.com/nodejs/node/pull/15181 Reviewed-By:
Khaidi Chu <i@2333.moe> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Roman Reiss <me@silverwind.io> Reviewed-By:
-
Timothy Gu authored
When ESM support was added it created a regression in the test runner that broke the ability to run individual tests. This commit re-introduces the use of `NormalizePath` which fixes the regression in the test runner Refs: https://github.com/nodejs/node/pull/15300 PR-URL: https://github.com/nodejs/node/pull/15329 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
Sebastiaan Deckers authored
PR-URL: https://github.com/nodejs/node/pull/15354 Reviewed-By:
-
- Sep 11, 2017
-
-
Jon Moss authored
Mostly shared/duplicated logic between all benchmark test files, so creating a new common module to store it. PR-URL: https://github.com/nodejs/node/pull/15004 Reviewed-By:
-
Ben Noordhuis authored
`want_separate_host_toolset_mkpeephole` was removed when V8 was upgraded to version 5.9 in commit 3dc8c3be from June. PR-URL: https://github.com/nodejs/node/pull/15266 Reviewed-By:
-
Rahul Mishra authored
PR-URL: https://github.com/nodejs/node/pull/15258 Refs: https://github.com/nodejs/node/issues/15159 Reviewed-By:
-
Ruben Bridgewater authored
PR-URL: https://github.com/nodejs/node/pull/15110 Reviewed-By:
-
David Benjamin authored
PR #11705 switched Node away from using using OpenSSL's legacy EVP_Sign* and EVP_Verify* APIs. Instead, it computes a hash normally via EVP_Digest* and then uses EVP_PKEY_sign and EVP_PKEY_verify to verify the hash directly. This change corrects two problems: 1. The documentation still recommends the signature algorithm EVP_MD names of OpenSSL's legacy APIs. OpenSSL has since moved away from thosee, which is why ECDSA was strangely inconsistent. (This is why "ecdsa-with-SHA256" was missing.) 2. Node_SignFinal copied some code from EVP_SignFinal's internals. This is problematic for OpenSSL 1.1.0 and is missing a critical check that prevents pkey->pkey.ptr from being cast to the wrong type. To resolve this, remove the non-EVP_PKEY_sign codepath. This codepath is no longer necessary. PR #11705's verify half was already assuming all EVP_PKEYs supported EVP_PKEY_sign and EVP_PKEY_verify. Also, in the documentation, point users towards using hash function names which...
-
Anatoli Papirovski authored
Using == null in code paths that are expected to mostly receive objects, arrays or other more complex data types is not ideal because typecasting these types is very slow. Change to instead check === null || === undefined. Also move one variable assignment in fromString after an if condition that doesn't need it (and returns if truthy). PR-URL: https://github.com/nodejs/node/pull/15178 Refs: https://jsperf.com/triple-equals-vs-double-equals/3 Reviewed-By:
-
Rich Trott authored
test-tls-fast-writing can fail on a heavily-loaded system due to an arbitrary 1-second timeout. Remove the arbitrary timeout. PR-URL: https://github.com/nodejs/node/pull/15138 Reviewed-By:
-
Rich Trott authored
On a slow/busy machine, `test-http-agent-maxsockets` can fail if the test takes longer than 5 seconds because that is the default value for `server.keepAliveTimeout`. Disable `keepAliveTimeout` to make the test robust. PR-URL: https://github.com/nodejs/node/pull/15192 Reviewed-By:
-
Jon Moss authored
Reasons: - `test-async-wrap-getasyncid` binds a handle, so move to sequential because port cannot be already in use. - `test-dgram-implicit-bind-failure` requires a hardcoded port number to properly send socket packet. - `test-http-agent-uninitialized-with-handle` requires a hardcoded port number to properly send http request. - `test-http-agent-uninitialized` requires a hardcoded port number to properly send http request. - `test-net-localport` requires a hardcoded port number for assertions. In addition this replaces two common.PORTs with a dynamic port. PR-URL: https://github.com/nodejs/node/pull/15151 Reviewed-By:
-
Anatoli Papirovski authored
Fix references within http2 core to HTTP_STATUS_CONTENT_RESET to point to the correct HTTP_STATUS_RESET_CONTENT. Add tests for status 204, 205 & 304 in respond, respondWithFD & respondWithFile. Add general error tests for respondWithFD & respondWithFile. PR-URL: https://github.com/nodejs/node/pull/15153 Reviewed-By:
-
Anatoli Papirovski authored
The only valid values for enablePush are 0 and 1. If validation is requested, we should verify that it wasn't set to another value rather than casting to Boolean regardless of value. PR-URL: https://github.com/nodejs/node/pull/15167 Reviewed-By:
-
Anatoli Papirovski authored
Store headersSent directly on response state after finish event is triggered, so that users can always access it. PR-URL: https://github.com/nodejs/node/pull/15232 Fixes: https://github.com/nodejs/node/issues/15226 Reviewed-By:
-
Refael Ackermann authored
* Add multiple comments. * Switch to a persistent fixture for subprocess. * Assert that `send` queue is drained. PR-URL: https://github.com/nodejs/node/pull/15186 Fixes: https://github.com/nodejs/node/issues/15176 Reviewed-By:
-
Ben Noordhuis authored
It was never an official Ecma-402 API, it is about to be superseded by `Intl.Segmenter` and it's prone to crash under some circumstances. Searches don't turn up any usage in the wild and the recommendation from the V8 team is to remove it. Now seems like a good a time as any to do that. Fixes: https://github.com/nodejs/node/issues/8865 Fixes: https://github.com/nodejs/node/issues/14909 Refs: https://github.com/tc39/proposal-intl-segmenter Refs: https://chromium-review.googlesource.com/c/v8/v8/+/620755 PR-URL: https://github.com/nodejs/node/pull/15238 Reviewed-By:
-
- Sep 10, 2017
-
-
Gabriel Schulhof authored
Fixes: https://github.com/nodejs/abi-stable-node/issues/51 PR-URL: https://github.com/nodejs/node/pull/15216 Reviewed-By:
Michael Dawson <mhdawson@ca.ibm.com> Reviewed-By:
-
Gabriel Schulhof authored
Currently the nm_modname does not match the file name of the resulting module. In fact, the nm_modname is pretty arbitrary. This seeks to introduce some consistency into the nm_modname property by having the name of the module appear in exactly one place: the "target_name" property of the gyp target that builds the module. PR-URL: https://github.com/nodejs/node/pull/15209 Reviewed-By:
-
Tim Costa authored
PR-URL: https://github.com/nodejs/node/pull/14314 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Sam Roberts authored
Properties should be documented at same level as their constructor, as they are in the other API doc sections. PR-URL: https://github.com/nodejs/node/pull/15247 Reviewed-By:
-
- Sep 09, 2017
-
-
Ezequiel Garcia authored
* add constants for dlopen flags, which are needed for dlopen's flag passing. * introduce an optional parameter for process.dlopen(), allowing to pass dlopen flags (using values from os.constants.dlopen). If no flags are passed, the default behavior is to load the library with RTLD_LAZY (perform lazy binding) and RTLD_LOCAL (symbols are available only locally). PR-URL: https://github.com/nodejs/node/pull/12794 Refs: https://github.com/nodejs/node/pull/4105 Refs: https://github.com/libuv/libuv/pull/1331 Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/15278 Reviewed-By:
-
