- Jun 12, 2019
-
-
Joyee Cheung authored
In addition correct the comment about what it does. PR-URL: https://github.com/nodejs/node/pull/28139 Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Saagar Jha authored
PR-URL: https://github.com/nodejs/node/pull/28071 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Refael Ackermann (רפאל פלחי) <refack@gmail.com>
-
Joyee Cheung authored
Split test-cpu-prof.js into multiple files for different test cases so it's easier to find the problematic one if it flakes. Also move the split tests into parallel. PR-URL: https://github.com/nodejs/node/pull/28170 Refs: https://github.com/nodejs/node/issues/27611 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
Joyee Cheung authored
Original commit message: [api] Implement StartupData::CanBeRehashed() for the snapshot blob This enables the embedder to check if the snapshot generated from SnapshotCreator::CreateBlob() can be rehashed and the seed can be recomputed during deserialization. The lack of this functionality resulted in a temporary vunerability in Node.js: https://github.com/nodejs/node/pull/27365 Change-Id: I88d52337217c40f79c26438be3c87d2db874d980 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1578661 Commit-Queue: Joyee Cheung <joyee@igalia.com> Reviewed-by:Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#61175} Refs: https://github.com/v8/v8/commit/e0a109c05821fa36ec20e1f25895c23baa8d64c3 PR-URL: https://github.com/nodejs/node/pull/27533 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
-
cjihrig authored
If require.resolve() is passed an options object, but the paths option is not present, then use the default require.resolve() paths. PR-URL: https://github.com/nodejs/node/pull/28078 Fixes: https://github.com/nodejs/node/issues/28077 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
- Jun 11, 2019
-
-
Ruben Bridgewater authored
The `-f` flag was missing a space after the module version. PR-URL: https://github.com/nodejs/node/pull/27670 Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
Ujjwal Sharma <usharma1998@gmail.com>
-
Ruben Bridgewater authored
This increases the maximum number of files to lint per worker from 40 to 60 files. This should ideally reduce the total linting time a tiny bit. PR-URL: https://github.com/nodejs/node/pull/27670 Reviewed-By:
-
Ruben Bridgewater authored
This updates out individual linting to work with eslint v6. Without this change the node_modules would also be checked for. PR-URL: https://github.com/nodejs/node/pull/27670 Reviewed-By:
-
Ruben Bridgewater authored
This is just a minor update to use the newest latest version. PR-URL: https://github.com/nodejs/node/pull/27670 Reviewed-By:
-
Ruben Bridgewater authored
This activates the following recommended eslint rules: - no-async-promise-executor - no-shadow-restricted-names PR-URL: https://github.com/nodejs/node/pull/27670 Reviewed-By:
-
Ruben Bridgewater authored
This makes sure the eslint config is up to date for eslint 6.0.0. PR-URL: https://github.com/nodejs/node/pull/27670 Reviewed-By:
-
Ruben Bridgewater authored
PR-URL: https://github.com/nodejs/node/pull/27670 Reviewed-By:
-
Ruben Bridgewater authored
This makes sure the "good" and "bad" examples are split into two. Otherwise it'll result in an parse error. PR-URL: https://github.com/nodejs/node/pull/27670 Reviewed-By:
-
Michael Dawson authored
I was asked by a community member if they needed to recompile for v12.x based on the version matrix. Add additional context to help ensure it is clear that this is not the case. PR-URL: https://github.com/nodejs/node/pull/27942 Reviewed-By:
Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By:
Christopher Hiller <boneskull@boneskull.com> Reviewed-By:
-
Ruben Bridgewater authored
Using the `util.inspect` `compact` mode set to something else than `true` resulted in breaking long lines in case the line would exceed the `breakLength` option and if it contained whitespace and or new lines. It turned out that this behavior was less useful than originally expected and it is now changed to only break on line breaks if the `breakLength` option is exceeded for the inspected string. This should be align better with the user expectation than the former behavior. PR-URL: https://github.com/nodejs/node/pull/28055 Fixes: https://github.com/nodejs/node/issues/27690 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
-
Geoffrey Booth authored
PR-URL: https://github.com/nodejs/node/pull/27957 Reviewed-By:
Jan Krems <jan.krems@gmail.com> Reviewed-By:
Bradley Farias <bradley.meck@gmail.com>
-
murgatroid99 authored
PR-URL: https://github.com/nodejs/node/pull/28074 Reviewed-By:
-
Sam Roberts authored
It was intended, according to in-test comments and common behaviour, that callbacks be either `undefined` or a function, but falsy values were being accepted as meaning "no callback". PR-URL: https://github.com/nodejs/node/pull/28109 Reviewed-By:
-
Sam Roberts authored
PR-URL: https://github.com/nodejs/node/pull/28123 Reviewed-By:
-
Rich Trott authored
test-gc-http-client is no longer believed to be unreliable. Remove it's entry indicating it's flaky from the status file. Closes: https://github.com/nodejs/node/issues/22336 PR-URL: https://github.com/nodejs/node/pull/28130 Reviewed-By:
-
Rich Trott authored
The test is believed to no longer be unreliable on AIX. Remove the flaky designation from the appropriate status file. Closes: https://github.com/nodejs/node/issues/9728 PR-URL: https://github.com/nodejs/node/pull/28129 Fixes: https://github.com/nodejs/node/issues/9728 Reviewed-By:
-
Alex Aubuchon authored
PR-URL: https://github.com/nodejs/node/pull/27962 Reviewed-By:
-
Alex Aubuchon authored
Converts the whitespace to spaces in the all: ... target for consistency. The other whitespace has to remain tabs due to how Makefiles work. PR-URL: https://github.com/nodejs/node/pull/27962 Reviewed-By:
-
Alex Aubuchon authored
PR-URL: https://github.com/nodejs/node/pull/27962 Reviewed-By:
-
Alex Aubuchon authored
PR-URL: https://github.com/nodejs/node/pull/27962 Reviewed-By:
-
Alex Aubuchon authored
PR-URL: https://github.com/nodejs/node/pull/27962 Reviewed-By:
-
Alex Aubuchon authored
PR-URL: https://github.com/nodejs/node/pull/27962 Reviewed-By:
-
Alex Aubuchon authored
PR-URL: https://github.com/nodejs/node/pull/27962 Reviewed-By:
-
Alex Aubuchon authored
PR-URL: https://github.com/nodejs/node/pull/27962 Reviewed-By:
-
Alex Aubuchon authored
PR-URL: https://github.com/nodejs/node/pull/27962 Reviewed-By:
-
Alex Aubuchon authored
Lots of changes, but mostly just search/replace of fixtures.readSync(...) to fixtures.readKey([new key]...) Benchmarks modified to use fixtures.readKey(...): benchmark/tls/throughput.js benchmark/tls/tls-connect.js benchmark/tls/secure-pair.js Also be sure to review the change to L16 of test/parallel/test-crypto-sign-verify.js PR-URL: https://github.com/nodejs/node/pull/27962 Reviewed-By:
-
Alex Aubuchon authored
PR-URL: https://github.com/nodejs/node/pull/27962 Reviewed-By:
-
Alex Aubuchon authored
PR-URL: https://github.com/nodejs/node/pull/27962 Reviewed-By:
-
Alex Aubuchon authored
PR-URL: https://github.com/nodejs/node/pull/27962 Reviewed-By:
-
Alex Aubuchon authored
PR-URL: https://github.com/nodejs/node/pull/27962 Reviewed-By:
-
Alex Aubuchon authored
Also adds make'd signatures for use in tests of signing/verification. All of the moved keys can be regenerated at will without breaking tests now. PR-URL: https://github.com/nodejs/node/pull/27962 Reviewed-By:
-
Alex Aubuchon authored
PR-URL: https://github.com/nodejs/node/pull/27962 Reviewed-By:
-
Alex Aubuchon authored
PR-URL: https://github.com/nodejs/node/pull/27962 Reviewed-By:
-
Sam Roberts authored
Workaround added in d9b9229d is no longer needed, since OpenSSL versions lower than 1.1.1 are unsupported. PR-URL: https://github.com/nodejs/node/pull/28085 Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
-
Sam Roberts authored
Versions of OpenSSL lower than 1.1.1 are no longer supported, so remove ifdefs for previous versions. PR-URL: https://github.com/nodejs/node/pull/28085 Reviewed-By:
-
