- Feb 28, 2016
-
-
Brian White authored
Fixes: https://github.com/nodejs/node/issues/5393 PR-URL: https://github.com/nodejs/node/pull/5394 Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io> Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
Evan Lucas <evanlucas@me.com>
-
Brian White authored
Fixes: https://github.com/nodejs/node/issues/5383 PR-URL: https://github.com/nodejs/node/pull/5389 Reviewed-By:
Roman Reiss <me@silverwind.io> Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
Evan Lucas <evanlucas@me.com>
-
Hugo Wood authored
This adds a paragraph in the Module Caching Caveats section about the behavior of require when Node is running on top of a file system (e.g. HFS) or operating system (e.g. Windows) that will not consider the case of file paths to find files. Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Alexis Campailla <orangemocha@nodejs.org> Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
Roman Reiss <me@silverwind.io>
-
Tristan Slominski authored
Documents that creating a buffer from base64 encoded string transparently supports "URL and Filename Safe Alphabet" base64url encoding. PR-URL: https://github.com/nodejs/node/pull/5243 Reviewed-By:
Ben Noorhduis <info@bnoordhuis.nl> Reviewed-By:
Benjamin Gruenbaum <inglor@gmail.com> Reviewed-By:
Alejandro Oviedo <alejandro.oviedo.g@gmail.com>
-
Jackson Tian authored
The description of httpVersionMajor & httpVersionMinor should have same context like httpVersion. PR-URL: https://github.com/nodejs/node/pull/5296 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io>
-
Evan Lucas authored
They were not being processed as relative links. PR-URL: https://github.com/nodejs/node/pull/5358 Reviewed-By:
Roman Reiss <me@silverwind.io>
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/5460 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io>
-
dcposch@dcpos.ch authored
This changes the doc generator to automatically link references such as `open(2)` to a man page on man7.org or freebsd.org PR-URL: https://github.com/nodejs/node/pull/5073 Reviewed-By:
Ben Noorhduis <info@bnoordhuis.nl> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io>
-
Rafael Cepeda authored
`Cluster.setupMaster(options)` Options object was missing an `args` property on the example. PR-URL: https://github.com/nodejs/node/pull/5305 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io>
-
Chris Dew authored
Corrected name of "msg" argument from "buf" to "msg". PR-URL: https://github.com/nodejs/node/pull/5449 Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io>
-
Alexander Makarenko authored
Fix missing links described in #5322. PR-URL: https://github.com/nodejs/node/pull/5364 Reviewed-By:
Roman Reiss <me@silverwind.io>
-
- Feb 27, 2016
-
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/5401 Reviewed-By:
Johan Bergström <bugs@bergstroem.nu> Reviewed-By: kahwee Reviewed-By: fhemberger Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/5427 Fixes: https://github.com/nodejs/node/issues/5424 Reviewed-By:
Roman Reiss <me@silverwind.io> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
Stefan Budeanu authored
Append --node-args to existing list, don't overwrite arg list. Fixes: https://github.com/nodejs/node/issues/5442 PR-URL: https://github.com/nodejs/node/pull/5446 Reviewed-By:
Ben Noorhduis <info@bnoordhuis.nl> Reviewed-by:
Michael Dawson <michael_dawson@ca.ibm.com>
-
Santiago Gimeno authored
Just send 10 messages recursively and check that the send calls are asynchronous by asserting that a `setImmediate` callback has been called in-between. It avoids a race condition in the test when the recursive limit is reached without having received at least 10 messages. Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> PR-URL: https://github.com/nodejs/node/pull/5079
-
Santiago Gimeno authored
This test was sometimes timing out in `OS X`. Remove the timeout and clean up the code. Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/5339
-
Andreas Madsen authored
PR-URL: https://github.com/nodejs/node/pull/5177 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Rod Vagg <rod@vagg.org>
-
Andreas Madsen authored
The benchmark runner spawns new processes for each configuration. The specific configuration is transfered by process.argv. This means that the values have to be parsed. As of right now only numbers and strings are parsed correctly. However other values such as objects where used. This fixes the benchmarks that used non-string/number values and prevents future issues by asserting the type. PR-URL: https://github.com/nodejs/node/pull/5177 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Rod Vagg <rod@vagg.org>
-
Andreas Madsen authored
url.js was broken since it didn't use the common.js runner. This fixes that issue by merging it with url-resolve.js, which also benchmarks url.resolve. PR-URL: https://github.com/nodejs/node/pull/5177 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Rod Vagg <rod@vagg.org>
-
Andreas Madsen authored
PR-URL: https://github.com/nodejs/node/pull/5177 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Rod Vagg <rod@vagg.org>
-
Phillip Johnsen authored
`vcbuild.bat` already supports both Visual Studio 2013 and 2015. PR-URL: https://github.com/nodejs/node/pull/5406 Reviewed-By:
Alexis Campailla <orangemocha@nodejs.org> Reviewed-By:
Rod Vagg <rod@vagg.org>
-
Rich Trott authored
Remove out-of-date stability index material from `tools/doc/README.md`. The stability index is documented in `doc/api/documentation.markdown`. PR-URL: https://github.com/nodejs/node/pull/5421 Reviewed-By:
Evan Lucas <evanlucas@me.com>
-
Rich Trott authored
Add verbs to make sentence fragments less fragmentary. PR-URL: https://github.com/nodejs/node/pull/5399 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io>
-
Stefan Budeanu authored
Add --node-args option that will pass arguments. PR-URL: https://github.com/nodejs/node/pull/5376 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
Marc Cuva authored
Function name in code sample had the wrong capitalization. PR-URL: https://github.com/nodejs/node/pull/5306 Reviewed-By:
Roman Reiss <me@silverwind.io>
-
Chinedu Francis Nwafili authored
Previous example didn't account for the 1 byte offset PR-URL: https://github.com/nodejs/node/pull/5282 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io>
-
cjihrig authored
util.isError() is the only remaining util.is*() method that depends on Object.prototype.toString() behavior. This commit notes the limitations of isError() related to @@toStringTag. Refs: https://github.com/nodejs/node/pull/2201 PR-URL: https://github.com/nodejs/node/pull/5414 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Ben Noordhuis authored
PR-URL: https://github.com/nodejs/node/pull/5418 Reviewed-By:
Trevor Norris <trev.norris@gmail.com>
-
Ben Noordhuis authored
PR-URL: https://github.com/nodejs/node/pull/5418 Reviewed-By:
Trevor Norris <trev.norris@gmail.com>
-
Ben Noordhuis authored
PR-URL: https://github.com/nodejs/node/pull/5418 Reviewed-By:
Trevor Norris <trev.norris@gmail.com>
-
Dirceu Pereira Tiegs authored
Remove indications that an error argument is sent to the `listen()` callback. Fixes: https://github.com/nodejs/node/issues/5345 PR-URL: https://github.com/nodejs/node/pull/5353 Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Trevor Norris <trev.norris@gmail.com>
-
Ron Korving authored
The APIs are implemented but currently not documented. PR-URL: https://github.com/nodejs/node/pull/5402 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Rod Vagg <rod@vagg.org>
-
Rod Vagg authored
Approved at CTC meeting https://github.com/nodejs/node/issues/5409 Reviewers are CTC members who voted for this. PR-URL: https://github.com/nodejs/node/pull/5275 Reviewed-By:
Brian White <mscdex@mscdex.net> Reviewed-By:
Trevor Norris <trev.norris@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Shigeki Ohtsu <ohtsu@iij.ad.jp> Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Alexis Campailla <alexis@janeasystems.com> Reviewed-By:
Chris Dickinson <chris@neversaw.us>
-
Rod Vagg authored
Approved at CTC meeting https://github.com/nodejs/node/issues/5409 Reviewers are CTC members who voted for this. PR-URL: https://github.com/nodejs/node/pull/5276 Reviewed-By:
Brian White <mscdex@mscdex.net> Reviewed-By:
Trevor Norris <trev.norris@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Shigeki Ohtsu <ohtsu@iij.ad.jp> Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Alexis Campailla <alexis@janeasystems.com> Reviewed-By:
Chris Dickinson <chris@neversaw.us>
-
Rod Vagg authored
Approved at CTC meeting https://github.com/nodejs/node/issues/5409 Reviewers are CTC members who voted for this. PR-URL: https://github.com/nodejs/node/pull/5277 Reviewed-By:
Brian White <mscdex@mscdex.net> Reviewed-By:
Trevor Norris <trev.norris@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Shigeki Ohtsu <ohtsu@iij.ad.jp> Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Alexis Campailla <alexis@janeasystems.com> Reviewed-By:
Chris Dickinson <chris@neversaw.us>
-
Rod Vagg authored
Approved at CTC meeting https://github.com/nodejs/node/issues/5409 Reviewers are CTC members who voted for this. PR-URL: https://github.com/nodejs/node/pull/5278 Reviewed-By:
Brian White <mscdex@mscdex.net> Reviewed-By:
Trevor Norris <trev.norris@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Shigeki Ohtsu <ohtsu@iij.ad.jp> Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Alexis Campailla <alexis@janeasystems.com> Reviewed-By:
Chris Dickinson <chris@neversaw.us>
-
Rich Trott authored
Fixes: https://github.com/nodejs/node/issues/4404 PR-URL: https://github.com/nodejs/node/pull/5379 Reviewed-By:
Julien Gilli <jgilli@fastmail.fm> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Rich Trott authored
The lint rule is there to avoid a circular-dependency issue that only applies to `/lib`. In preparation for linting `/benchmark`, apply that rule to `/lib` only to avoid churn in `/benchmark`. Refs: https://github.com/nodejs/node/issues/3983#issuecomment-158956113 PR-URL: https://github.com/nodejs/node/pull/5371 Reviewed-By:
Michaël Zasso <mic.besace@gmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io>
-
Rich Trott authored
Enable additional likely-uncontroversial lint rules: * `comma-dangle` set to prohibit dangling commas on objects and arrays that are defined on a single line. Multi-line definitions can use or omit a trailing comma. * `no-unused-labels` Prohibits defining a label that is not used. * `no-path-concat` Prohibits string-concatenation using i`__dirname` and `__filename`. Use `path.join()`, `path.resolve()`, or template strings instead. * `no-new-symbol` disallow use of `new` operator with `Symbol` object. Violating this rule would result in a `TypeError` at runtime.` PR-URL: https://github.com/nodejs/node/pull/5357 Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Michaël Zasso <mic.besace@gmail.com>
-
Jeremiah Senkpiel authored
PR-URL: https://github.com/nodejs/node/pull/4767 Refs: https://github.com/nodejs/docs/pull/38 Reviewed-By:
Bryan English <bryan@bryanenglish.com> Reviewed-By:
Stephan Belanger <admin@stephenbelanger.com>
-