- Apr 16, 2017
-
-
David Cai authored
PR-URL: https://github.com/nodejs/node/pull/12435 Reviewed-By:
Anna Henningsen <anna@addaleax.net>
-
Daniel Bevenius authored
I noticed that there are three static functions that only check if args is a construct call. This commit suggests replacing them and them with a lambda. PR-URL: https://github.com/nodejs/node/pull/12384 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
John Paul Bamberg authored
PR-URL: https://github.com/nodejs/node/pull/12428 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
- Apr 15, 2017
-
-
Jan Krems authored
PR-URL: https://github.com/nodejs/node/pull/12427 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com>
-
Vse Mozhet Byt authored
* Replace `var` by `const`. * Use `console.error()`. * Fix example file name mismatch. * Update output examples. * Fix output readability (add a line break, remove an unnecessary duplicate word). PR-URL: https://github.com/nodejs/node/pull/12381 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Daniel Bevenius authored
This reverts commit be98f269. The above commit prevented the functionality of --use-bundled-ca if Node has been built using --openssl-use-def-ca-store, since there will be no bundled ca included and no way to use them. I only noticed this when trying to add // Flags: --use-bundled-ca to test-tls-ccnic-whitelist.js to force it to use the bundled ca and allow the test to pass. PR-URL: https://github.com/nodejs/node/pull/12391 Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
-
Rich Trott authored
Use of `common.PORT` in `parallel` tests is not completely safe (because the same port can be previously assigned to another test running in parallel if that test uses port `0` to get an arbitrary available port). Remove `common.PORT` from test-cluster-basic. PR-URL: https://github.com/nodejs/node/pull/12377 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
-
Timothy Gu authored
PR-URL: https://github.com/nodejs/node/pull/12253 Reviewed-By:
-
Timothy Gu authored
- Use ordinary properties instead of symbols/getter redirection for internal object - Use template string literals - Remove unneeded custom inspection for internal objects - Remove unneeded OpaqueOrigin class - Remove unneeded type checks PR-URL: https://github.com/nodejs/node/pull/12252 Reviewed-By:
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/12286 Reviewed-By:
Timothy Gu <timothygu99@gmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
Jan Krems authored
PR-URL: https://github.com/nodejs/node/pull/12363 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Alexey Orlenko <eaglexrlnk@gmail.com>
-
Tobias Nießen authored
Add notes about path.parse(), path.basename() and path.dirname() ignoring trailing slashes. PR-URL: https://github.com/nodejs/node/pull/12181 Fixes: https://github.com/nodejs/node/issues/6229 Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
-
Rich Trott authored
Add minimal test for crypto benchmarks. It makes sure that they can run without returning an error code. PR-URL: https://github.com/nodejs/node/pull/12347 Reviewed-By:
-
Tobias Nießen authored
Fixes multiple possible segmentation faults in node_contextify.cc and an assertion failure in node_os.cc Fixes: https://github.com/nodejs/node/issues/12369 Fixes: https://github.com/nodejs/node/issues/12370 PR-URL: https://github.com/nodejs/node/pull/12371 Reviewed-By:
-
Anna Henningsen authored
Use `static` definitions and anonymous namespaces to reduce the number of symbols that are exported from the `node` binary. PR-URL: https://github.com/nodejs/node/pull/12366 Reviewed-By:
-
DavidCai authored
PR-URL: https://github.com/nodejs/node/pull/12306 Reviewed-By:
-
Shubheksha Jalan authored
querystring.stringify() doesn't serialize some values. Explicitly mention what values are serialized in the docs. Add what happens when another data type is passed to `querystring.stringify()` besides the ones that can be correctly parsed PR-URL: https://github.com/nodejs/node/pull/12313 Reviewed-By:
-
Rich Trott authored
Use of extra `|` breaks markdown table rendering. Fix it. PR-URL: https://github.com/nodejs/node/pull/12350 Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
-
Daniel Bevenius authored
When configuring --without-ssl test-debug-usage.js fails with the following error: assert.js:82 throw new assert.AssertionError({ ^ AssertionError: false == true at ChildProcess.<anonymous> (/Users/danielbevenius/work/nodejs/node/test/parallel/test-debug-usage.js:24:5) at ChildProcess.<anonymous> (/Users/danielbevenius/work/nodejs/node/test/common.js:461:15) at emitTwo (events.js:125:13) at ChildProcess.emit (events.js:213:7) at Process.ChildProcess._handle.onexit (internal/child_process.js:208:12) But the underlying error is the following: (node:55665) [DEP0068] DeprecationWarning: `node debug` is deprecated. Please use `node inspect` instead. internal/util.js:83 throw new Error('Node.js is not compiled with openssl crypto support'); ^ Error: Node.js is not compiled with openssl crypto support at Object.exports.assertCrypto (internal/util.js:83:11) at crypto.js:28:14 at NativeModule.compile (bootstrap_node.js:559:7) at NativeModule.require (bootstrap_node.js:500:18) at node-inspect/lib/internal/inspect_client.js:24:16 at NativeModule.compile (bootstrap_node.js:559:7) at NativeModule.require (bootstrap_node.js:500:18) at node-inspect/lib/_inspect.js:39:5 at NativeModule.compile (bootstrap_node.js:559:7) at Function.NativeModule.require (bootstrap_node.js:500:18) assert.js:82 throw new assert.AssertionError({ ^ AssertionError: false == true at ChildProcess.<anonymous> (/Users/danielbevenius/work/nodejs/node/test/parallel/test-debug-usage.js:25:5) at ChildProcess.<anonymous> (/Users/danielbevenius/work/nodejs/node/test/common.js:461:15) at emitTwo (events.js:125:13) at ChildProcess.emit (events.js:213:7) at Process.ChildProcess._handle.onexit (internal/child_process.js:208:12) This commit adds a check for crypto like some of the other tests do. PR-URL: https://github.com/nodejs/node/pull/12357 Reviewed-By: -
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/12361 Reviewed-By:
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/12361 Reviewed-By:
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/12361 Reviewed-By:
-
Michael Dawson authored
Coverity was reporting _request.work_req as not being initialized. Add memset to ensure all of _request is initialized. PR-URL: https://github.com/nodejs/node/pull/12365 Reviewed-By:
-
Sampson Gao authored
PR-URL: https://github.com/nodejs/node/pull/12368 Reviewed-By:
Jason Ginchereau <jasongin@microsoft.com>
-
Ruslan Bekenev authored
lint target now runs both linters even if one of them failed. PR-URL: https://github.com/nodejs/node/pull/12276 Reviewed-By:
-
Ruslan Bekenev authored
PR-URL: https://github.com/nodejs/node/pull/12314 Fixes: https://github.com/nodejs/node/issues/8057 Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
-
AnnaMag authored
PR-URL: https://github.com/nodejs/node/pull/12414 Reviewed-By:
-
Daijiro Wachi authored
Fixes: https://github.com/nodejs/node/issues/10655 PR-URL: https://github.com/nodejs/node/pull/12315 Reviewed-By:
-
- Apr 14, 2017
-
-
Matteo Collina authored
Makes LazyTransform writable by Streams1 by assigning .writable = true before the actual classes are loaded. Fixes: https://github.com/nodejs/node/issues/12269 PR-URL: https://github.com/nodejs/node/pull/12380 Reviewed-By:
-
Christopher Luke authored
Currently when the destination emits an 'error', 'finish' or 'close' event the pipe calls unpipe to emit 'unpipe' and trigger the clean up of all it's listeners. When the source emits an 'end' event without {end: false} it calls end() on the destination leading it to emit a 'close', this will again lead to the pipe calling unpipe. However the source emitting an 'end' event along side {end: false} is the only time the cleanup gets ran directly without unpipe being called. This fixes that so the 'unpipe' event does get emitted and cleanup in turn gets ran by that event. Fixes: https://github.com/nodejs/node/issues/11837 PR-URL: https://github.com/nodejs/node/pull/11876 Reviewed-By:Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
Refael Ackermann authored
fixes #11972 PR-URL: https://github.com/nodejs/node/pull/12258 Reviewed-By:
-
Anna Henningsen authored
The `cflags` for `--coverage` included `-O0` so far, but that was overridden by a later `-O3`. Resolve that by adding `'cflags!': [ '-O3' ]` and increase coverage accuracy. Ref: https://coverage.nodejs.org/ PR-URL: https://github.com/nodejs/node/pull/12406 Reviewed-By:
-
Sebastian Van Sande authored
Running the addon tests before the parallel, sequential, etc. tests can be a problem if there is a bug in node that prevents the addon tests from running properly. When the addon tests fail for any reason, then none of the other tests (e.g. parallel, etc.) are executed. Running the addon tests last fixes this. Refs: https://github.com/nodejs/node/issues/12031 PR-URL: https://github.com/nodejs/node/pull/12062 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
-
Evan Lucas authored
We generally stick to 80 columns even in markdown files. PR-URL: https://github.com/nodejs/node/pull/12358 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
-
Nao YONASHIRO authored
PR-URL: https://github.com/nodejs/node/pull/12354 Reviewed-By:
-
Josh Gavant authored
* Removes "experimental" warning. Fixes: https://github.com/nodejs/node/issues/11770 PR-URL: https://github.com/nodejs/node/pull/12352 Reviewed-By:
Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com>
-
Anna Henningsen authored
Missed in ca786c37. This does not actually affect the outcome because returning `nullptr` or `this` from a constructor has the same effect. PR-URL: https://github.com/nodejs/node/pull/12318 Reviewed-By:
-
Rich Trott authored
This test was disabled in 2013 because it spams random IPs with UDP messages. We've been doing fine for four years without so let's delete it. PR-URL: https://github.com/nodejs/node/pull/12330 Reviewed-By:
Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By:
-
- Apr 13, 2017
-
-
Tarun Batra authored
Set the expected outcome of `util.format('%%')` to be `%%` instead of `%`. PR-URL: https://github.com/nodejs/node/pull/12374 Fixes: https://github.com/nodejs/node/issues/12362 Reviewed-By: -
Sam Roberts authored
bootstrap_node.js was directly parsing process.execArgv to see if internals should be exposed, even though the argv was already parsed by node. This is unusual and unnecessary, change it to set the option value from the parser onto the config binding. PR-URL: https://github.com/nodejs/node/pull/12245 Reviewed-By:
-
