- Jan 17, 2017
-
-
abouthiroppy authored
https://github.com/nodejs/node/blob/master/lib/_http_incoming.js#L136 Coverage: https://coverage.nodejs.org/coverage-57f6a106fbc69a47/root/_http_incoming.js.html PR-URL: https://github.com/nodejs/node/pull/10811 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By:
Italo A. Casas <me@italoacasas.com>
-
Daijiro Wachi authored
use common.hasIntl to make sure Intl object is present or not. PR-URL: https://github.com/nodejs/node/pull/10707 Reviewed-By:
Steven R Loomis <srloomis@us.ibm.com>
-
- Jan 16, 2017
-
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/10828 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
-
Adrian Estrada authored
* validate errors in assert.throws * use arrow functions PR-URL: https://github.com/nodejs/node/pull/10752 Reviewed-By:
-
Ben Noordhuis authored
Overlooked when moving code around in commit 42da740e ("inspector: split HTTP/WS server from the inspector".) PR-URL: https://github.com/nodejs/node/pull/10407 Reviewed-By:
-
Yuya Tanaka authored
Squashed from: - child_process: stop indexOf() on whole IPC buffer - child_process: get rid of forEach() and slice() in IPC - child_process: get rid of another forEach() in IPC Fixes: https://github.com/nodejs/node/issues/3145 PR-URL: https://github.com/nodejs/node/pull/10557 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Anna Henningsen <anna@addaleax.net>
-
Yuya Tanaka authored
Squashed from: - child_process: fix IPC bench to obey send() ret val - child_process: fix IPC benchmark message has two more bytes - child_process: use setImmediate for IPC bench PR-URL: https://github.com/nodejs/node/pull/10557 Reviewed-By:
-
Rich Trott authored
Add a test to cover situation where REPL is initialized with `useGlobal` set to `true` and `.clear` is called. This adds coverage for code in repl.js that is not currently covered. Includes minor refactor of rocket functions in repl.js for concision. PR-URL: https://github.com/nodejs/node/pull/10777 Reviewed-By:
-
- Jan 15, 2017
-
-
Joyee Cheung authored
* Improve readability of util.normalizeEncoding and add some comments * Add a benchmark for util.normalizeEncoding PR-URL: https://github.com/nodejs/node/pull/10439 Reviewed-By:
Andreas Madsen <amwebdk@gmail.com>
-
Joyee Cheung authored
* add benchmark to compare the performance of getting url properties between the WHATWG URL and the legacy implementation * add benchmark to compare the performance of serializing urls between the WHATWG URL and the legacy implementation * refactor the benchmark for comparing parsing performance between the two implementations PR-URL: https://github.com/nodejs/node/pull/10678 Reviewed-By:
Brian White <mscdex@mscdex.net>
-
Rich Trott authored
There were no tests confirming situations where server.connections should return `null`. Add a test for that situation. Expand existing server.connection test slightly to check value. Refactor (mostly spacing) code for server.connections setter. PR-URL: https://github.com/nodejs/node/pull/10762 Reviewed-By:
-
This reverts commit 4444e731. PR-URL: https://github.com/nodejs/node/pull/10809 Reviewed-By:
-
Nikolai Vavilov authored
It would previously read from the current file position, which can be non-zero if the `fd` has been read from or written to. This contradicts the documentation which states that it "reads the entire contents of a file". PR-URL: https://github.com/nodejs/node/pull/9699 Fixes: https://github.com/nodejs/node/issues/9671 Reviewed-By:
Sam Roberts <vieuxtech@gmail.com>
-
- Jan 14, 2017
-
-
Joyee Cheung authored
Use the word "confidence" to indicate the confidence level of the p value so it's easier to understand. With this change more stars in the output of compare.R means higher confidence level (lower significance level). PR-URL: https://github.com/nodejs/node/pull/10737 Refs: https://github.com/nodejs/node/pull/10439 Reviewed-By:
-
cjihrig authored
This commit splits the existing cluster module into several internal modules. More specifically, the cluster master and worker implementations are separated, and the various data structures are separated. PR-URL: https://github.com/nodejs/node/pull/10746 Reviewed-By:
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/10654 Reviewed-By:
Fedor Indutny <fedor.indutny@gmail.com>
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/10654 Reviewed-By:
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/10654 Reviewed-By:
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/10654 Reviewed-By:
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/10654 Reviewed-By:
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/10654 Reviewed-By:
-
Irene Li authored
PR-URL: https://github.com/nodejs/node/pull/10755 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
Rich Trott authored
* use `+` instead of `*` where one-or-more is required * switch from String.prototype.match() to RegExp.prototype.test() PR-URL: https://github.com/nodejs/node/pull/10749 Reviewed-By:
Jackson Tian <shyvo1987@gmail.com>
-
Javis Sullivan authored
PR-URL: https://github.com/nodejs/node/pull/10741 Reviewed-By:
-
istinson authored
PR-URL: https://github.com/nodejs/node/pull/10758 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
Adrian Estrada authored
* validate the errors for all assert.throws * use arrow functions PR-URL: https://github.com/nodejs/node/pull/10734 Reviewed-By:
-
Chase Starr authored
* add asset.strictEqual to stdout and stderr. Fixes no-unused-vars. * replace double quotes with single PR-URL: https://github.com/nodejs/node/pull/10757 Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
-
- Jan 13, 2017
-
-
Jackson Tian authored
Remove the dependency on the arguments.length. PR-URL: https://github.com/nodejs/node/pull/4740 Reviewed-By:
Trevor Norris <trev.norris@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
Gibson Fahnestock authored
If a temp-dir is specified and already exists, the NODE_TEST_DIR environment variable will never be set. This fixes that. PR-URL: https://github.com/nodejs/node/pull/10723 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
-
Gibson Fahnestock authored
If you don't specify NODE_TEST_DIR, common.tmpDir will resolve to the realpath of `node/test`. If you do specify NODE_TEST_DIR (with the environment variable or by running or by running tools/test.py --test-dir=x), common.tmpDir (which is resolved from testRoot) uses the symbolic path (doesn't resolve symlinks). This uses fs.realpathSync() to fix that. PR-URL: https://github.com/nodejs/node/pull/10723 Reviewed-By:
-
Sam Roberts authored
Fix lint error introduced in ea72331a PR-URL: https://github.com/nodejs/node/pull/10771 Reviewed-By:
-
Sam Roberts authored
Reapplication of https://github.com/nodejs/node/pull/9299 since the symlink was re-added in f44969a5. PR-URL: https://github.com/nodejs/node/pull/10771 Reviewed-By:
-
Sam Roberts authored
Some systems may have multiple group names with the same group ID, in which case getgroups() returns duplicate values, where `id -G` will filter the duplicates. Unique and sort the arrays so they can be compared. PR-URL: https://github.com/nodejs/node/pull/10389 Reviewed-By:
-
Sam Roberts authored
PR-URL: https://github.com/nodejs/node/pull/10389 Reviewed-By:
-
Sam Roberts authored
PR-URL: https://github.com/nodejs/node/pull/10389 Reviewed-By:
-
Sam Roberts authored
Docs referred to an `issuer` property being optionally present, when it should have referred to the `issuerCertificate` property. PR-URL: https://github.com/nodejs/node/pull/10389 Reviewed-By:
-
Sam Roberts authored
SecureContext.addCACert() adds to the existing root store, preserving root cert entries. option.ca is applied without calling SecureContext.addRootCerts() so should add to the default, empty, root store. This test confirms that the built-in root CAs are not included when options.ca is used. Based on: https://github.com/shigeki/node/commit/acd5837fd737351dd953b0387695705067cd69cb PR-URL: https://github.com/nodejs/node/pull/10389 Reviewed-By:
-
Sam Roberts authored
TLS connection setup boilerplate is common to many TLS tests, factor it into a test fixture so tests are clearer to read and faster to write. PR-URL: https://github.com/nodejs/node/pull/10389 Reviewed-By:
-
Nathan Phillip Brink authored
Fix the explanation which stated that write() would return false if highWaterMark is exceeded to correctly state that false is returned once highWaterMark is reached. See #9247. PR-URL: https://github.com/nodejs/node/pull/10582 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com>
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/10756 Reviewed-By:
Teddy Katz <teddy.katz@gmail.com> Reviewed-By:
-
