- Nov 14, 2019
-
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/29053 Reviewed-By:
Anna Henningsen <anna@addaleax.net>
-
- Nov 13, 2019
-
-
Albert Wang authored
Fixes: https://github.com/nodejs/node/issues/30211 PR-URL: https://github.com/nodejs/node/pull/30356 Reviewed-By:
Steven R Loomis <srloomis@us.ibm.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com>
-
Luigi Pinca authored
Add documentation for the `lookup` option. PR-URL: https://github.com/nodejs/node/pull/30353 Fixes: https://github.com/nodejs/node/issues/30171 Reviewed-By:
David Carlier <devnexen@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Simon Schick authored
PR-URL: https://github.com/nodejs/node/pull/30346 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
-
Grigoriy Levanov authored
Replaces Object.assign with spread where object is simply cloned PR-URL: https://github.com/nodejs/node/pull/30306 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
-
Michael Dawson authored
* Add missing N-API version info * Fix N-API version info for napi_extended_error_info PR-URL: https://github.com/nodejs/node/pull/30254 Reviewed-By:
Jiawen Geng <technicalcute@gmail.com>
-
Vse Mozhet Byt authored
* Fix formatting. * Fix list numbering. * Unify abbreviation casing. * Use an uppercased constructor in a hypothetic code example. * Fix typos. * Fix sorting in sections and references. PR-URL: https://github.com/nodejs/node/pull/30341 Reviewed-By:
Guy Bedford <guybedford@gmail.com> Reviewed-By:
-
Guy Bedford authored
PR-URL: https://github.com/nodejs/node/pull/29866 Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
- Nov 12, 2019
-
-
Daniil Pletnev authored
PR-URL: https://github.com/nodejs/node/pull/30308 Reviewed-By:
-
Vadim Gorbachev authored
PR-URL: https://github.com/nodejs/node/pull/30305 Reviewed-By:
-
telenord authored
PR-URL: https://github.com/nodejs/node/pull/30288 Reviewed-By:
-
alexahdp authored
PR-URL: https://github.com/nodejs/node/pull/30287 Reviewed-By:
-
telenord authored
PR-URL: https://github.com/nodejs/node/pull/30285 Reviewed-By:
-
Anna Henningsen authored
V8 deprecates `GetContents()` in favour of `GetBackingStore()`. Update our code to reflect that. V8 also deprecates `Externalize()` and `IsExternal()`; we should be able to remove all usage of this once V8 8.0 is there. PR-URL: https://github.com/nodejs/node/pull/30339 Refs: https://github.com/v8/v8/commit/bfe3d6bce734e596e312465e207bcfd55a59fe34 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
-
Robert Nagy authored
MAX_HWM was added in 9208c890 where the highwatermark was changed to always increase in steps of highest power of 2 to prevent increasing hwm excessivly in tiny amounts. Why a limit was added on the highwatermark is unclear but breaks existing usage where a larger read size is used. The invariant for read(n) is that a buffer of size n is always returned. Considering a maximum ceiling on the buffer size breaks this invariant. This PR significantly increases the limit to make it less likely to break the previous invariant and also documents the limit. Fixes: https://github.com/nodejs/node/issues/29933 PR-URL: https://github.com/nodejs/node/pull/29938 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com>
-
Kamat, Trivikram authored
Refs: https://github.com/orgs/nodejs/teams/collaborators/discussions/58 This config will help contributors to run/debug tests on VSCode PR-URL: https://github.com/nodejs/node/pull/24012 Reviewed-By:
-
- Nov 11, 2019
-
-
cclauss authored
Co-authored-by: @patrickhousley Fixes to Python tests to ensure that the following all pass: 1. __python2 -m pytest ./test ./tools__ # 30 tests pass 2. __python3 -m pytest ./test ./tools__ # 30 tests pass 3. __python2 -m unittest discover -s ./test/tools__ # 1 test passes 4. __python3 -m unittest discover -s ./test/tools__ # 1 test passes 5. __PYTHON=python2 make tooltest__ # 1 test passes 6. __PYTHON=python3 make tooltest__ # 1 test passes This is a subset of #30033 PR-URL: https://github.com/nodejs/node/pull/30340 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
-
AshCripps authored
PR-URL: https://github.com/nodejs/node/pull/30316 Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By:
-
- Nov 10, 2019
-
-
Rich Trott authored
Permit the use of Travis CI results for pull requests that only change documentation or comments. This also removes node-test-pull-request-lite-pipeline from the documentation. Efforts to move all CI jobs to pipelines have stalled and it's not clear that our current Jenkins admins are enthusiastic about pipelines. PR-URL: https://github.com/nodejs/node/pull/30330 Reviewed-By:
-
Ruy Adorno authored
PR-URL: https://github.com/nodejs/node/pull/30271 Reviewed-By:
-
Rich Trott authored
Treat npm pull requests like all other pull requests. Remove special extended wait period for landing. PR-URL: https://github.com/nodejs/node/pull/30329 Reviewed-By:
-
Rich Trott authored
test-benchmark-cluster needs to account for an option added in 973f3244. PR-URL: https://github.com/nodejs/node/pull/30342 Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By:
-
peze authored
PR-URL: https://github.com/nodejs/node/pull/30260 Refs: https://github.com/nodejs/code-and-learn/issues/97 Reviewed-By:
-
- Nov 09, 2019
-
-
Nolik authored
PR-URL: https://github.com/nodejs/node/pull/30319 Reviewed-By:
Ben Coe <bencoe@gmail.com> Reviewed-By:
Masashi Hirano <shisama07@gmail.com>
-
Dmitriy Kikinskiy authored
Simple exchange var to const/let. PR-URL: https://github.com/nodejs/node/pull/30302 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
-
Ilia Safronov authored
PR-URL: https://github.com/nodejs/node/pull/30297 Reviewed-By:
-
Vladislav Botvin authored
PR-URL: https://github.com/nodejs/node/pull/30292 Reviewed-By:
-
Michaël Zasso authored
Previously, this would trigger an unhandled rejection that the user cannot handle. Fixes: https://github.com/nodejs/node/issues/30205 PR-URL: https://github.com/nodejs/node/pull/30219 Reviewed-By:
-
peze authored
Refs: nodejs/code-and-learn#97 PR-URL: https://github.com/nodejs/node/pull/30246 Refs: https://github.com/nodejs/code-and-learn/issues/97 Reviewed-By:
Khaidi Chu <i@2333.moe> Reviewed-By:
-
PerfectPan authored
Refs: https://github.com/nodejs/code-and-learn/issues/97 PR-URL: https://github.com/nodejs/node/pull/30261 Reviewed-By:
-
Nadya authored
PR-URL: https://github.com/nodejs/node/pull/30318 Reviewed-By:
-
galina.prokofeva authored
Changed a variable declaration. PR-URL: https://github.com/nodejs/node/pull/30320 Reviewed-By:
-
Vadim Gorbachev authored
PR-URL: https://github.com/nodejs/node/pull/30321 Reviewed-By:
-
Geoffrey Booth authored
PR-URL: https://github.com/nodejs/node/pull/30051 Reviewed-By:
Jan Krems <jan.krems@gmail.com>
-
Guy Bedford authored
PR-URL: https://github.com/nodejs/node/pull/29978 Reviewed-By:
-
Guy Bedford authored
PR-URL: https://github.com/nodejs/node/pull/29978 Reviewed-By:
-
Clemens Backes authored
WasmModuleObject::TransferrableModule is deprecated and will be removed in V8 v8.0. Replace all uses by CompiledWasmModule. Refs: https://github.com/v8/node/pull/101 PR-URL: https://github.com/nodejs/node/pull/30026 Reviewed-By:
-
palmires authored
PR-URL: https://github.com/nodejs/node/pull/30301 Reviewed-By:
-
Nolik authored
PR-URL: https://github.com/nodejs/node/pull/30299 Reviewed-By:
-
Michaël Zasso authored
npm requires crypto support and cannot be loaded without it. PR-URL: https://github.com/nodejs/node/pull/30265 Reviewed-By:
-
