- Dec 20, 2017
-
-
Ruben Bridgewater authored
Throw a TypeError in case a error message is provided in the second argument and a third argument is present as well. This is clearly a mistake and should not be done. PR-URL: https://github.com/nodejs/node/pull/17585 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Evan Lucas <evanlucas@me.com>
-
Ruben Bridgewater authored
A combination of try catch and common.expectsError is not necessary as the latter already does everything on its own. PR-URL: https://github.com/nodejs/node/pull/17703 Reviewed-By:
Timothy Gu <timothygu99@gmail.com> Reviewed-By:
-
Ruben Bridgewater authored
The stack frames from .throws and .doesNotThrow got included even though that was not intended. PR-URL: https://github.com/nodejs/node/pull/17703 Reviewed-By:
-
- Dec 19, 2017
-
-
Daniel Bevenius authored
This commit removes stdlib.h header as it does not seem to be used any more. PR-URL: https://github.com/nodejs/node/pull/17752 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net>
-
rt33 authored
PR-URL: https://github.com/nodejs/node/pull/17734 Reviewed-By:
Jon Moss <me@jonathanmoss.me> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/17748 Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
-
sreepurnajasti authored
PR-URL: https://github.com/nodejs/node/pull/17733 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
-
Weijia Wang authored
PR-URL: https://github.com/nodejs/node/pull/17729 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/17727 Reviewed-By:
-
Jon Moss authored
Causing the linter job to fail on CI right now. PR-URL: https://github.com/nodejs/node/pull/17741 Reviewed-By:
-
Rich Trott authored
Make the preamble to CONTRIBUTING.md more concise and focused. PR-URL: https://github.com/nodejs/node/pull/17700 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
-
Evan Lucas authored
Specify that $VERSION should include the `v` when replacing REPLACEME in documentation. PR-URL: https://github.com/nodejs/node/pull/17677 Reviewed-By:
-
alnyan authored
PR-URL: https://github.com/nodejs/node/pull/17714 Reviewed-By:
Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/17692 Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/17689 Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/17689 Reviewed-By:
-
James M Snell authored
Separate FSReqWrap definition into a new node_file.h. Add Reject and Resolve methods to encapsulate the callbacks and make the constructor, destructor protected instead of private in preparation to make FSReqWrap subclassable for the Promises implementation. Rework and simplify the After function slightly in preparation for a refactor. Introduce the node::fs namespace instead of using an anonymous namespace for fs methods. PR-URL: https://github.com/nodejs/node/pull/17689 Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/17406 Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/17406 Reviewed-By:
-
- Dec 18, 2017
-
-
Jeremiah Senkpiel authored
PR-URL: https://github.com/nodejs/node/pull/17702 Reviewed-By:
-
Jeremiah Senkpiel authored
PR-URL: https://github.com/nodejs/node/pull/17702 Reviewed-By:
-
Jeremiah Senkpiel authored
Also works on directories. PR-URL: https://github.com/nodejs/node/pull/17702 Reviewed-By:
-
Jeremiah Senkpiel authored
Reworded some parts, inter-doc links. PR-URL: https://github.com/nodejs/node/pull/17702 Reviewed-By:
-
Anatoli Papirovski authored
Currently, writeQueueSize is never used in C++ and barely used within JS. Instead of constantly updating the value on the JS object, create a getter that will retrieve the most up-to-date value from C++. For the vast majority of cases though, create a new prop on Socket.prototype[kLastWriteQueueSize] using a Symbol. Use this to track the current write size, entirely in JS land. PR-URL: https://github.com/nodejs/node/pull/17650 Reviewed-By:
-
cjihrig authored
This commit adds a test to validate postmortem debugging metadata. When this test runs, it can check for the presence of metadata constants used by tools such as llnode and mdb and report if any have accidentally been removed. PR-URL: https://github.com/nodejs/node/pull/17685 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
-
Calvin Metcalf authored
As part of the readableState/writableState mega issue #445, this removes all of the references to .length on those properties and replaces them with a readableLength and writableLength getter. See: https://github.com/nodejs/node/issues/445 PR-URL: https://github.com/nodejs/node/pull/12857 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
-
sreepurnajasti authored
Fixes: https://github.com/nodejs/node/issues/17169 PR-URL: https://github.com/nodejs/node/pull/17646 Reviewed-By:
-
Bamieh authored
PR-URL: https://github.com/nodejs/node/pull/17201 Reviewed-By:
-
Bamieh authored
PR-URL: https://github.com/nodejs/node/pull/17201 Reviewed-By:
-
Mithun Sasidharan authored
PR-URL: https://github.com/nodejs/node/pull/17635 Reviewed-By:
-
Ram Goli authored
Change the awkward "Node.js style callback" phrasing to the more informative "error-first callback." PR-URL: https://github.com/nodejs/node/pull/17638 Reviewed-By:
-
Jure Triglav authored
PR-URL: https://github.com/nodejs/node/pull/17665 Fixes: https://github.com/nodejs/node/issues/17636 Refs: https://github.com/nodejs/node/pull/16482 Refs: https://github.com/nodejs/node/pull/16860 Reviewed-By:
-
April Webster authored
Change type annotations for eventName in events API doc from {any} to {string|symbol}. PR-URL: https://github.com/nodejs/node/pull/17666 Fixes: https://github.com/nodejs/node/issues/17657 Reviewed-By:
-
- Dec 17, 2017
-
-
Thomas Watson authored
PR-URL: https://github.com/nodejs/node/pull/17711 Reviewed-By:
-
- Dec 16, 2017
-
-
Anna Henningsen authored
This should make these function calls a lot more intuitive for people who are more accustomed to Node’s EventEmitter API. PR-URL: https://github.com/nodejs/node/pull/17701 Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/17643 Reviewed-By:
-
routerman authored
PR-URL: https://github.com/nodejs/node/pull/17697 Reviewed-By:
Yosuke Furukawa <yosuke.furukawa@gmail.com> Reviewed-By:
-
you12724 authored
PR-URL: https://github.com/nodejs/node/pull/17698 Reviewed-By:
-
Shinya Kanamaru authored
PR-URL: https://github.com/nodejs/node/pull/17699 Reviewed-By:
-
Ruben Bridgewater authored
Right now it is difficult to know what argument stands for what property. By refactoring the arguments into a object it is clear what stands for what. PR-URL: https://github.com/nodejs/node/pull/17582 Reviewed-By:
-
