- Mar 29, 2017
-
-
Franziska Hinkelmann authored
The comment is outdated, function declarations have nothing to do with defineProperties. PR-URL: https://github.com/nodejs/node/pull/12048 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Nikolai Vavilov authored
PR-URL: https://github.com/nodejs/node/pull/11286 Fixes: https://github.com/nodejs/node/issues/11244 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Ron Korving <ron@ronkorving.nl>
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/12030 Ref: https://github.com/nodejs/node/issues/11972 Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Gibson Fahnestock authored
PR-URL: https://github.com/nodejs/node/pull/12054 Ref: https://github.com/nodejs/node/issues/12053 Ref: https://github.com/nodejs/node/pull/11038 Reviewed-By:
Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com>
-
Vse Mozhet Byt authored
* unify quotes in fs.md * avoid quote escaping in fs.md * simplify logics in fs.md * concatenation -> template literal in fs.md * add missing callback in fs.md * fix typo in fs.md * update output example in fs.md PR-URL: https://github.com/nodejs/node/pull/12035 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
-
Ahmad Nassri authored
`server.timeout` is a property, not a method PR-URL: https://github.com/nodejs/node/pull/12039 Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By:
-
Ahmad Nassri authored
* at 9772fb92 [`maxHeadersCount`][maxheaderscount] and [`timeout`][timeout] were erroneously changed to methods * `maxHeadersCount` was also listed to default to `1000` where it actually is [`2000`][default] [maxheaderscount]: https://github.com/nodejs/node/blob/e0a9ad1af244f8756a228a6d087b3a55ee4c0d14/lib/_http_server.js#L276 [timeout]: https://github.com/nodejs/node/blob/e0a9ad1af244f8756a228a6d087b3a55ee4c0d14/lib/_http_server.js#L273 [default]: https://github.com/nodejs/node/blob/e0a9ad1af244f8756a228a6d087b3a55ee4c0d14/lib/_http_server.js#L312 PR-URL: https://github.com/nodejs/node/pull/12039 Reviewed-By:
-
Alexey Orlenko authored
Some of the tests for `buffer.includes()` functionality introduced in https://github.com/nodejs/node/pull/3567 have been broken in a way that caused them to always pass regardless of the result of the tested method. This behavior was caused by two reasons: * These tests were written as though `buffer.includes()` was supposed to return the same value that `buffer.indexOf()` does, i.e., used indices or -1 as expected return values instead of true and false. * `assert()` was used as the assertion function to do that instead of `assert.strictEqual()`. Thus `assert()` was called with a non-zero number as the first argument effectively causing these tests to pass. This commit changes the tests to use `assert.ok()` and removes redundant indices. PR-URL: https://github.com/nodejs/node/pull/12040 Ref: https://github.com/nodejs/node/pull/3567 Reviewed-By:
-
Rich Trott authored
These are minor typographical and style improvements to the guide for writing and running benchmarks. PR-URL: https://github.com/nodejs/node/pull/12041 Reviewed-By:
Nikolai Vavilov <vvnicholas@gmail.com> Reviewed-By:
-
Sebastian Van Sande authored
stdout, stderr and stdin are all Duplex streams but documentation states otherwise Fixes https://github.com/nodejs/node/issues/9201 PR-URL: https://github.com/nodejs/node/pull/11194 Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
-
Fumiya KARASAWA authored
it should be 1 for the stdout fd number PR-URL: https://github.com/nodejs/node/pull/12055 Reviewed-By:
-
Trevor Norris authored
This partually reverts commit 4cdb0e89. A nullptr check in TSLWrap::IsAlive() and the added test were left. PR-URL: https://github.com/nodejs/node/pull/11947 Reviewed-By:
-
Trevor Norris authored
The TLSWrap constructor is passed a StreamBase* which it stores as TLSWrap::stream_, and is used to receive/send data along the pipeline (e.g. tls -> tcp). Problem is the lifetime of the instance that stream_ points to is independent of the lifetime of the TLSWrap instance. So it's possible for stream_ to be delete'd while the TLSWrap instance is still alive, allowing potential access to a then invalid pointer. Fix by having the StreamBase destructor null out TLSWrap::stream_; allowing all TLSWrap methods that rely on stream_ to do a check to see if it's available. While the test provided is fixed by this commit, it was also previously fixed by 478fabf3. Regardless, leave the test in for better testing. PR-URL: https://github.com/nodejs/node/pull/11947 Reviewed-By:
-
Dejon "DJ" Gill authored
Replace anonymous functions with arrow functions. Replace throw new Error with common.fail. PR-URL: https://github.com/nodejs/node/pull/9700 Reviewed-By:
Italo A. Casas <me@italoacasas.com> Reviewed-By:
-
Pedro lima authored
Name anonymous functions in url.js. PR-URL: https://github.com/nodejs/node/pull/9225 Ref: https://github.com/nodejs/node/issues/8913 Reviewed-By:
-
cjihrig authored
This commit adds code coverage for the scenario where exec() kills a child process, but the call to ChildProcess#kill() throws an exception. PR-URL: https://github.com/nodejs/node/pull/11038 Reviewed-By:
-
Jackson Tian authored
The keyword 'else' is unnecessary after 'throw' statements. PR-URL: https://github.com/nodejs/node/pull/11148 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
-
Claudio Rodriguez authored
Refactor net module to use the more efficient module.exports = {} pattern. Also renames internal "connect" function to "internalConnect" to avoid collision with exported "connect". PR-URL: https://github.com/nodejs/node/pull/11698 Reviewed-By: -
Luca Maraschi authored
This test is checking for the validity of the path used as parameter for mkdtempSync. PR-URL: https://github.com/nodejs/node/pull/12009 Reviewed-By:
-
John F. Mercer authored
Provide a regex to validate the error message. PR-URL: https://github.com/nodejs/node/pull/12011 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
-
Rj Bernaldo authored
Adds a second argument to the assert.throws() test to implicitly specify expected error message. PR-URL: https://github.com/nodejs/node/pull/12016 Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
-
Jeremiah Senkpiel authored
PR-URL: https://github.com/nodejs/node/pull/12023 Fixes: https://github.com/nodejs/node/issues/11445 Refs: f65a48fc Reviewed-By:
-
Rich Trott authored
A doc suggested in an error message is no longer the place to get the information about required http benchmarkers. Update the error message to point to the current location for the information. PR-URL: https://github.com/nodejs/node/pull/12026 Reviewed-By:
-
Bryan English authored
Use the original property descriptor instead of just taking the value, which would, by default, be non-writable and non-configurable. PR-URL: https://github.com/nodejs/node/pull/9306 Reviewed-By:
-
Sorin Baltateanu authored
PR-URL: https://github.com/nodejs/node/pull/7818 Reviewed-By:
-
Rich Trott authored
Replace `process.once('exit', ...)` with `common.mustCall()`. Remove unneeded variable in loop declaration. PR-URL: https://github.com/nodejs/node/pull/11981 Reviewed-By: -
Ben Noordhuis authored
Commit c5b07d4e ("lib: fix beforeExit not working with -e") runs the to-be-evaluated code at a later time than before because it switches from `process.nextTick()` to `setImmediate()`. It affects `-e 'process.on("message", ...)'` because there is now a larger time gap between startup and attaching the event listener, increasing the chances of missing early messages. I'm reasonably sure `process.nextTick()` was also susceptible to that, only less pronounced. Avoid the problem altogether by evaluating the code synchronously. Harmonizes the logic with `Module.runMain()` from lib/module.js which also calls `process._tickCallback()` afterwards. PR-URL: https://github.com/nodejs/node/pull/11958 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com>
-
Luca Maraschi authored
This test adds coverage for all the characters which are considered invalid in a http path. PR-URL: https://github.com/nodejs/node/pull/11964 Reviewed-By:
-
Nick Peleh authored
* verify error message by adding 2nd argument to throws in test-assert PR-URL: https://github.com/nodejs/node/pull/11974 Reviewed-By:
-
Rich Trott authored
Currently, benchmark code is not exercised at all in CI. This adds a minimal test for net benchmarks. If this is deemed acceptable, similar minimal tests for other benchmarks can be written. Additionally, as issues and edge cases are uncovered, checks for them can be added. PR-URL: https://github.com/nodejs/node/pull/11979 Reviewed-By:
-
Yuta Hiroto authored
PR-URL: https://github.com/nodejs/node/pull/11999 Reviewed-By:
Prince John Wesley <princejohnwesley@gmail.com>
-
Morgan Brenner authored
PR-URL: https://github.com/nodejs/node/pull/11992 Fixes: https://github.com/nodejs/node/issues/11971 Reviewed-By:
-
Richard Lau authored
PR-URL: https://github.com/nodejs/node/pull/12020 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/11934 Reviewed-By:
Timothy Gu <timothygu99@gmail.com> Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/11953 Fixes: https://github.com/nodejs/node/issues/11469 Reviewed-By:
João Reis <reis@janeasystems.com> Reviewed-By:
-
Rich Trott authored
Per email conversation with Shigeki Ohtsu, updating email address in docs. The current listed email address does not work anymore. PR-URL: https://github.com/nodejs/node/pull/11996 Reviewed-By:
Shigeki Ohtsu <ohtsu@ohtsu.org>
-
Kat Marchán authored
PR-URL: https://github.com/nodejs/node/pull/11389 Reviewed-By:
-
Shigeki Ohtsu authored
The timer handle is reused when it is unrefed in order to avoid new callback in beforeExit(#3407). If it is unrefed within a setInterval callback, the reused timer handle is closed so that setInterval no longer keep working. This fix does not close the handle in case of setInterval. PR-URL: https://github.com/nodejs/node/pull/11646 Reviewed-By:
Julien Gilli <jgilli@nodejs.org> Reviewed-By:
-
Nikolai Vavilov authored
This allows running a benchmark with two or more values for the same config rather than just one or all of them, for example: ``` node benchmark/buffers/buffer-creation.js type=buffer() type=fast-alloc type=fast-alloc-fill ``` PR-URL: https://github.com/nodejs/node/pull/11819 Reviewed-By:
Brian White <mscdex@mscdex.net>
-
Ben Noordhuis authored
Replace a few calls to FIXED_ONE_BYTE_STRING() with their persistent counterparts from `node::Environment`. None of the calls are in hot code paths but why create a new string when one already exists? PR-URL: https://github.com/nodejs/node/pull/11945 Reviewed-By:
-
