- Mar 31, 2020
-
-
Daniele Belardi authored
PR-URL: https://github.com/nodejs/node/pull/31794 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
Daniele Belardi authored
PR-URL: https://github.com/nodejs/node/pull/31794 Reviewed-By:
-
Daniele Belardi authored
PR-URL: https://github.com/nodejs/node/pull/31794 Reviewed-By:
-
Daniele Belardi authored
PR-URL: https://github.com/nodejs/node/pull/31794 Reviewed-By:
-
Daniele Belardi authored
PR-URL: https://github.com/nodejs/node/pull/31794 Reviewed-By:
-
Daniele Belardi authored
PR-URL: https://github.com/nodejs/node/pull/31794 Reviewed-By:
-
Daniele Belardi authored
PR-URL: https://github.com/nodejs/node/pull/31794 Reviewed-By:
-
Daniele Belardi authored
PR-URL: https://github.com/nodejs/node/pull/31794 Reviewed-By:
-
Daniele Belardi authored
PR-URL: https://github.com/nodejs/node/pull/31794 Reviewed-By:
-
Daniele Belardi authored
PR-URL: https://github.com/nodejs/node/pull/31794 Reviewed-By:
-
Nitin Kumar authored
PR-URL: https://github.com/nodejs/node/pull/32292 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Nitin Kumar authored
PR-URL: https://github.com/nodejs/node/pull/32292 Reviewed-By:
-
Nitin Kumar authored
PR-URL: https://github.com/nodejs/node/pull/32292 Reviewed-By:
-
Rich Trott authored
Isolate the two test cases here a bit more and refactor code. PR-URL: https://github.com/nodejs/node/pull/32526 Reviewed-By:
-
Gabriel Schulhof authored
dl_iterate_phdr(3) is also available for FreeBSD. This change adds the same trimming code for the start and end of the .text section as on Linux, making it work on FreeBSD, and removing the need for the additional FreeBSD-specific check. Manually tested on * https://www.osboxes.org/freebsd/#freebsd-12-1-vbox * https://www.osboxes.org/freebsd/#freebsd-11-vbox * test-digitalocean-freebsd11-x64-2 Signed-off-by:
Gabriel Schulhof <gabriel.schulhof@intel.com> PR-URL: https://github.com/nodejs/node/pull/32534 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
David Carlier <devnexen@gmail.com>
-
Harshitha KP authored
this was influenced by https://github.com/nodejs/node/pull/32269 PR-URL: https://github.com/nodejs/node/pull/32298 Reviewed-By:
-
Syohei YOSHIDA authored
V8 CPU profile -> V8 heap profile PR-URL: https://github.com/nodejs/node/pull/32404 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/32294 Reviewed-By:
Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
-
Ruben Bridgewater authored
Also clean up the plugins package.json files. PR-URL: https://github.com/nodejs/node/pull/32310 Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/32322 Reviewed-By:
Gus Caplan <me@gus.host>
-
Filip Skokan authored
PR-URL: https://github.com/nodejs/node/pull/32340 Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
unknown authored
Fixes: https://github.com/nodejs/node/issues/27645 PR-URL: https://github.com/nodejs/node/pull/32520 Reviewed-By:
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/32453 Reviewed-By:
Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com>
-
Richard Lau authored
For notarization on macOS all packaged binaries must be signed. Add a regression test to check that known binaries from our dependencies (at the time of this commit term-size via npm) are signed. Signed-off-by:
-
Bartosz Sosnowski authored
On Windows 2016 under high load further change events can be emitted after writing the 5 bytes is reported. Updating the mtime of the file can be reported as a separate change. This will increase the "before" count, but not the "w1HookCount" since we removed the listener. This makes the test keep the listeners until the end of the test. Fixes: https://github.com/nodejs/node/issues/21425 PR-URL: https://github.com/nodejs/node/pull/32484 Reviewed-By:
-
Ling Samuel authored
PR-URL: https://github.com/nodejs/node/pull/32456 Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
-
Anna Henningsen authored
Refs: https://github.com/nodejs/node/pull/31530 PR-URL: https://github.com/nodejs/node/pull/32490 Reviewed-By:
Ben Coe <bencoe@gmail.com> Reviewed-By:
-
Ben Noordhuis authored
Disable the following compiler warning: warning: visibility attribute not supported in this configuration; ignored [-Wattributes] This is gcc complaining about `__attribute((visibility("default"))` in static library builds. Legitimate but harmless (and uninteresting) and it drowns out more relevant warnings. PR-URL: https://github.com/nodejs/node/pull/32419 Reviewed-By: -
Daniel Bevenius authored
Currently, the following compiler warnings are generated: ../src/node_report_module.cc: In function ‘void report::ShouldReportOnFatalError( const v8::FunctionCallbackInfo<v8::Value>&)’: ../src/node_report_module.cc:132:16: warning: unused variable ‘env’ [-Wunused-variable] 132 | Environment* env = Environment::GetCurrent(info); | ^~~ ../src/node_report_module.cc: In function ‘void report::SetReportOnFatalError( const v8::FunctionCallbackInfo<v8::Value>&)’: ../src/node_report_module.cc:138:16: warning: unused variable ‘env’ [-Wunused-variable] 138 | Environment* env = Environment::GetCurrent(info); | ^~~ This commit removes the unused variables. PR-URL: https://github.com/nodejs/node/pull/32498 Reviewed-By:Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
-
James M Snell authored
Use "options.inspectOptions" instead of just "inspectOptions" Signed-off-by:
-
James M Snell authored
Use "options.recursive" instead of just "recursive" Signed-off-by:
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/32191 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
-
Rich Trott authored
Use Promise.all() instead of countdown in test-cluster-net-listen-ipv6only-false. Signed-off-by:
-
Rich Trott authored
Signed-off-by:
-
Gabriel Schulhof authored
* Introduce `OnScopeLeave` handler for cleaning up mmap()ed range(s). * Factor out failure scenario at the bottom of the function with `fail` label for use with `goto`. * Do not allocate temporary range (`nmem`) on FreeBSD, because it is not used. The intention is that the steps involved in re-mapping to large pages become more clearly visible. Signed-off-by:
-
Rich Trott authored
* Remove assert.strictEqual where assert.ok suffices * Replace countdown with Promise.all() PR-URL: https://github.com/nodejs/node/pull/32493 Reviewed-By:
-
Alba Mendez authored
PR-URL: https://github.com/nodejs/node/pull/32525 Reviewed-By:
-
Juan José Arboleda authored
PR-URL: https://github.com/nodejs/node/pull/32374 Reviewed-By:
-
Xavier Stouder authored
Using ToLocalChecked on MaybeLocal without verifying it's empty can lead to unattempted crash. PR-URL: https://github.com/nodejs/node/pull/32339 Reviewed-By:
-
Anna Henningsen authored
Otherwise, this leaks memory if the weak callback is never called. PR-URL: https://github.com/nodejs/node/pull/32421 Reviewed-By:
-
