- Oct 15, 2018
-
-
Arne Schramm authored
The arguments of the assert were passed in the wrong order (expected, actual). This would have been confusing in case of an error. Changed it to be (actual, expected) PR-URL: https://github.com/nodejs/node/pull/23524 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
Pascal Lambert authored
PR-URL: https://github.com/nodejs/node/pull/23525 Reviewed-By:
-
Jonny Kalambay authored
PR-URL: https://github.com/nodejs/node/pull/23526 Reviewed-By:
-
Joshua Belcher authored
PR-URL: https://github.com/nodejs/node/pull/23501 Reviewed-By:
-
Daniyal Mokhammad authored
PR-URL: https://github.com/nodejs/node/pull/23502 Reviewed-By:
-
David Scott authored
PR-URL: https://github.com/nodejs/node/pull/23503 Reviewed-By:
-
Viacheslav Liakhov authored
PR-URL: https://github.com/nodejs/node/pull/23504 Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
-
Jean-Francois Arseneau authored
The order of arguments in test-fs-readdir-ucs2 was the opposite of what is recommended in the documentation, which is that the first value should be the value being tested, and the second value is the expected value. This fixes the test to make it conform to the documentation. PR-URL: https://github.com/nodejs/node/pull/23505 Reviewed-By:
-
Illescas, Ricardo authored
PR-URL: https://github.com/nodejs/node/pull/23506 Reviewed-By:
-
Milton Sosa authored
PR-URL: https://github.com/nodejs/node/pull/23507 Reviewed-By:
-
Alejandro Oviedo Garcia authored
PR-URL: https://github.com/nodejs/node/pull/23508 Reviewed-By:
-
Andrew MacCuaig authored
-
Robert Monks authored
Updated all the function keywords to fat arrow implementations in test/parallel/test-event-emitter-no-error-provided-to-error-event.js PR-URL: https://github.com/nodejs/node/pull/23493 Reviewed-By:
-
scabhi authored
PR-URL: https://github.com/nodejs/node/pull/23494 Reviewed-By:
-
Greg Goforth authored
PR-URL: https://github.com/nodejs/node/pull/23496 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
-
Long Nguyen authored
This change removes a variable that is not being used in the file. PR-URL: https://github.com/nodejs/node/pull/23497 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Guy Bedford <guybedford@gmail.com> Reviewed-By:
-
Jenna Zeigen authored
PR-URL: https://github.com/nodejs/node/pull/23498 Reviewed-By:
-
@CAYdenberg authored
PR-URL: https://github.com/nodejs/node/pull/23499 Reviewed-By:
-
chrisforrette authored
PR-URL: https://github.com/nodejs/node/pull/23500 Reviewed-By:
-
Felix Schlenkrich authored
The information on how to run single tests was missing in BUILDING.md. PR-URL: https://github.com/nodejs/node/pull/23490 Fixes: https://github.com/nodejs/node/issues/23491 Reviewed-By:
-
Felix Schlenkrich authored
PR-URL: https://github.com/nodejs/node/pull/23490 Reviewed-By:
-
Kayla Altepeter authored
PR-URL: https://github.com/nodejs/node/pull/23488 Reviewed-By:
Bryan English <bryan@bryanenglish.com> Reviewed-By:
-
Carl Richmond authored
PR-URL: https://github.com/nodejs/node/pull/23489 Reviewed-By:
-
Steven Scott authored
Switch the cjs loader to use internalBinding instead of process.binding for reading command line options. PR-URL: https://github.com/nodejs/node/pull/23492 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
-
Carolina Pinzon authored
PR-URL: https://github.com/nodejs/node/pull/23549 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Artur Hayrapetyan authored
PR-URL: https://github.com/nodejs/node/pull/23551 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Denys Otrishko <shishugi@gmail.com> Reviewed-By:
-
Artur Hayrapetyan authored
PR-URL: https://github.com/nodejs/node/pull/23551 Reviewed-By:
-
Chris Nguyen authored
PR-URL: https://github.com/nodejs/node/pull/23533 Reviewed-By:
-
Сковорода Никита Андреевич authored
Fixes one WHATWG URL example to match the actual behavior. PR-URL: https://github.com/nodejs/node/pull/23359 Fixes: https://github.com/nodejs/node/issues/22653 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By:
-
Сковорода Никита Андреевич authored
Changes non-reserved domains to reserved ones in url.md. PR-URL: https://github.com/nodejs/node/pull/23359 Refs: https://www.iana.org/domains/reserved Reviewed-By:
-
Сковорода Никита Андреевич authored
Now it points to the actual pr, not to /compare/. PR-URL: https://github.com/nodejs/node/pull/23359 Reviewed-By:
-
Сковорода Никита Андреевич authored
This fixes links that were broken due to inclusion of the trailing dot. Also simplifies a pair of occurances of [](). PR-URL: https://github.com/nodejs/node/pull/23359 Reviewed-By:
-
Diana Holland authored
PR-URL: https://github.com/nodejs/node/pull/23610 Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By:
Ujjwal Sharma <usharma1998@gmail.com>
-
cjihrig authored
Update ESLint to 5.7.0. PR-URL: https://github.com/nodejs/node/pull/23629 Reviewed-By:
-
Anna Zhao authored
PR-URL: https://github.com/nodejs/node/pull/23483 Reviewed-By:
Shelley Vohr <codebytere@gmail.com>
-
David Corona authored
Moving the default assignment of async_id from the constructor in async_wrap.cc to class definition in async_wrap.h PR-URL: https://github.com/nodejs/node/pull/23495 Reviewed-By:
-
Michal Hynek authored
Removed an unused variable in test-buffer-failed-alloc-typed-arrays.js. PR-URL: https://github.com/nodejs/node/pull/23481 Reviewed-By:
-
Claire Liu authored
PR-URL: https://github.com/nodejs/node/pull/23482 Reviewed-By:
-
Matt Jiles authored
try catch syntax allows elimination of function arguments so removed unused err argument PR-URL: https://github.com/nodejs/node/pull/23484 Reviewed-By:
-
Stacey authored
PR-URL: https://github.com/nodejs/node/pull/23485 Reviewed-By:
-
