- Mar 08, 2018
-
-
Rich Trott authored
There are some uses of "in general" that are unnecessary. (We don't need to be tentative about the fact that tests should pass, for example.) PR-URL: https://github.com/nodejs/node/pull/19123 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Ruben Bridgewater authored
PR-URL: https://github.com/nodejs/node/pull/19099 Reviewed-By:
Shingo Inoue <leko.noor@gmail.com> Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
Rich Trott authored
Allow users to switch to the table of contents for older versions of Node.js. This gets rid of the "Failed to add alternative version link" warnings when building docs. PR-URL: https://github.com/nodejs/node/pull/19113 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Matheus Marchini <matheus@sthima.com> Reviewed-By:
Jon Moss <me@jonathanmoss.me> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Jakob Kummerow authored
Original commit message: Introduce --disallow-code-generation-from-strings Exposing the existing Context::AllowCodeGenerationFromStrings(false) API to the command line. Bug: v8:7134 Change-Id: I062ccff0b03c5bcf6878c41c455c0ded37a1d743 Reviewed-on: https://chromium-review.googlesource.com/809631 Reviewed-by:Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#49911} PR-URL: https://github.com/nodejs/node/pull/18212 Refs: https://github.com/v8/v8/commit/0bcb1d6f2de9b278b1de7de1b5333e7f47fdce8e Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Gus Caplan <me@gus.host>
-
Michael Dawson authored
Add team that we can use to cc organizations or people who do one of the following: * bundle node into their product * bundle node into their distributions * provide an installer * provide a version manager PR-URL: https://github.com/nodejs/node/pull/19098 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
-
punteek authored
Added a simple example showing how to rename a file. Refs: https://github.com/nodejs/node/issues11135 PR-URL: https://github.com/nodejs/node/pull/18812 Reviewed-By:
Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By:
-
Bradley Farias authored
ensures that instantiation result is only used during initial loading PR-URL: https://github.com/nodejs/node/pull/18965 Reviewed-By:
Guy Bedford <guybedford@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Jan Krems <jan.krems@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
Michael Dawson authored
Fix the gcovr version to a fixed version and uses patches specific to that version. This avoids us being broken by changes in the gcovr repo. Using file name for patches specific to the version level will allow us to move up when necessary without breaking coverage for earlier versions of Node.js PR-URL: https://github.com/nodejs/node/pull/19094 Reviewed-By:
-
Ben Noordhuis authored
Look for symbol `node_register_module_v${NODE_MODULE_VERSION}` if the add-on didn't self-register. This can be used to create add-ons that support multiple Node.js versions from a single shared object. PR-URL: https://github.com/nodejs/node/pull/18934 Reviewed-By:Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
-
Ben Noordhuis authored
Move some code around and clean up the DLib helper class as prep work for a follow-up commit. PR-URL: https://github.com/nodejs/node/pull/18934 Reviewed-By:
-
- Mar 07, 2018
-
-
Yihong Wang authored
When building the node with `--shared` option, we need to verify the symbols in shared lib instead of executable. Refs: https://github.com/nodejs/node/issues/18535 Signed-off-by:
Yihong Wang <yh.wang@ibm.com> PR-URL: https://github.com/nodejs/node/pull/18806 Refs: https://github.com/nodejs/node/issues/18535 Reviewed-By:
Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By:
-
Ruben Bridgewater authored
The offset was formerly coerced to a integer and this reimplements that. PR-URL: https://github.com/nodejs/node/pull/18215 Fixes: https://github.com/nodejs/node/issues/18208 Reviewed-By:
-
Andreas Madsen authored
Allow the user to specify the filepath for the trace_events log file using a template string. Backport-PR-URL: https://github.com/nodejs/node/pull/19144 PR-URL: https://github.com/nodejs/node/pull/18480 Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By:
-
Sho Miyamoto authored
Backport-PR-URL: https://github.com/nodejs/node/pull/19127 PR-URL: https://github.com/nodejs/node/pull/18775 Reviewed-By:
Weijia Wang <starkwang@126.com> Reviewed-By:
Roman Reiss <me@silverwind.io>
-
Sho Miyamoto authored
Backport-PR-URL: https://github.com/nodejs/node/pull/19127 PR-URL: https://github.com/nodejs/node/pull/18775 Reviewed-By:
-
- Mar 05, 2018
-
-
Anna Henningsen authored
This might otherwise result in a hard crash when trying to write to a socket after a sudden disconnect. Note that the test here uses an aborted `h2load` run to create the failing requests; That’s far from ideal, but it provides a reasonably reliably reproduction at this point. PR-URL: https://github.com/nodejs/node/pull/18987 Fixes: https://github.com/nodejs/node/issues/18973 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com>
-
Anna Henningsen authored
Make the script not error out immediately because of a missing pseudo-global. (Note that it seems like tests are still broken on `master`.) PR-URL: https://github.com/nodejs/node/pull/19059 Fixes: https://github.com/nodejs/node/issues/19044 Refs: https://github.com/nodejs/node/pull/18623 Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Minwoo Jung <minwoo@nodesource.com> Reviewed-By:
-
Anna Henningsen authored
This is pretty useful when trying to inspect the last error caught by a REPL, and is made to be analogous to `_`, which contains the last successful completion value. PR-URL: https://github.com/nodejs/node/pull/18919 Reviewed-By:
Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By:
-
Gabriel Schulhof authored
Remove the necessity for allocating on the heap, and assert that the correct pointer gets passed to the finalizer. PR-URL: https://github.com/nodejs/node/pull/19086 Reviewed-By:
-
Anna Henningsen authored
Show the stack trace for the `eventemitter.emit('error')` call in the case of an uncaught exception. Previously, there would be no clue in Node’s output about where the actual `throw` comes from. PR-URL: https://github.com/nodejs/node/pull/19003 Reviewed-By: -
Ruben Bridgewater authored
PR-URL: https://github.com/nodejs/node/pull/18746 Reviewed-By:
-
Ben Noordhuis authored
We already disable `-Wmissing-field-initializers` on other Unices but not on MacOS. PR-URL: https://github.com/nodejs/node/pull/19046 Fixes: https://github.com/nodejs/node/issues/18983 Reviewed-By:
-
Сковорода Никита Андреевич authored
For tests / benchmarks that are creating Buffer instances for any reason other than to test Buffer constructor, use the new Buffer.alloc/Buffer.from API instead of the deprecated API. PR-URL: https://github.com/nodejs/node/pull/18980 Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
-
Zeke Sikelianos authored
PR-URL: https://github.com/nodejs/node/pull/18888 Fixes: https://github.com/nodejs/node/issues/18887 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
Santiago Gimeno authored
So it does not use `common.PORT` anymore. PR-URL: https://github.com/nodejs/node/pull/18727 Reviewed-By:
-
wuweiweiwu authored
The default message will be printed if the assertion fires. Use block scope for related variables and tests. PR-URL: https://github.com/nodejs/node/pull/19054 Reviewed-By:
-
Ujjwal Sharma authored
PR-URL: https://github.com/nodejs/node/pull/19126 Reviewed-By:
-
Eric Bickle authored
Documentation for N-API Custom Asynchronous Operations incorrectly stated that async execution happens on the main event loop. Added details to napi_create_async_work about which threads are used to invoke the execute and complete callbacks. Changed 'async' to 'asynchronous' in the documentation for Custom Asynchronous Operations. Changed "executes in parallel" to "can execute in parallel" for the documentation of napi_create_async_work execute parameter. PR-URL: https://github.com/nodejs/node/pull/19073 Fixes: https://github.com/nodejs/node/issues/19071 Reviewed-By:
-
Chen Gang authored
PR-URL: https://github.com/nodejs/node/pull/19109 Reviewed-By:
-
Matteo Collina authored
The test was flaky because it relied on a specific order of asynchronous operation that were fired paralellely. This was true on most platform and conditions, but not all the time. See: https://github.com/nodejs/node/pull/18986 PR-URL: https://github.com/nodejs/node/pull/19093 Reviewed-By:
-
Rich Trott authored
Use common.platformTimeout() to give longer durations to Raspberry Pi devices to make test more reliable. PR-URL: https://github.com/nodejs/node/pull/18126 Fixes: https://github.com/nodejs/node/issues/16772 Reviewed-By:
Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By:
-
Richard Lau authored
libuv and zlib symbols are also purposefully re-exported by Node.js for use in Addons. Refs: https://github.com/nodejs/node/issues/17444 PR-URL: https://github.com/nodejs/node/pull/19013 Reviewed-By:
-
George Sapkin authored
PR-URL: https://github.com/nodejs/node/pull/18080 Reviewed-By:
-
Gabriel Schulhof authored
Passing a pointer to a static integer is sufficient for the test. PR-URL: https://github.com/nodejs/node/pull/19039 Reviewed-By:
Hitesh Kanwathirtha <hiteshk@microsoft.com>
-
Anna Henningsen authored
`async` and `bytes` are only interesting when the write is coming from JS, and unnecessary otherwise. Also, make all of the stream `Write*()` bindings use the same code for setting these, and upgrade to the non-deprecated versions. PR-URL: https://github.com/nodejs/node/pull/18963 Reviewed-By:
-
XadillaX authored
Refs: https://github.com/nodejs/node/pull/18673 PR-URL: https://github.com/nodejs/node/pull/18924 Refs: https://github.com/nodejs/node/pull/18673 Refs: https://github.com/nodejs/node/blob/v9.5.0/src/node_http2.cc#L1481-L1484 Refs: https://github.com/nodejs/node/blob/v9.5.0/lib/_http_outgoing.js#L659-L661 Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/18924 Fixes: https://github.com/nodejs/node/issues/18169 Refs: https://github.com/nodejs/node/pull/18673 Refs: https://github.com/nodejs/node/blob/v9.5.0/src/node_http2.cc#L1481-L1484 Refs: https://github.com/nodejs/node/blob/v9.5.0/lib/_http_outgoing.js#L659-L661 Reviewed-By:
Khaidi Chu <i@2333.moe> Reviewed-By:
-
Anna Henningsen authored
Previously, if `session.destroy()` was called with an error object, the information contained in it would be discarded and a generic `ERR_HTTP2_STREAM_CANCEL` would be used for all pending streams. Instead, make the information from the original error object available. PR-URL: https://github.com/nodejs/node/pull/18988 Reviewed-By:
-
Anna Henningsen authored
Make the test for pending deprecations work when the env var is set during the whole test suite run. PR-URL: https://github.com/nodejs/node/pull/18991 Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By:
-
Anna Henningsen authored
Send a human-readable HTTP/1 response in case of an unexpected ALPN protocol. This helps with debugging this condition, since previously the only result of it would be a closed socket. PR-URL: https://github.com/nodejs/node/pull/18986 Reviewed-By:
-
