- Apr 22, 2020
-
-
Gus Caplan authored
PR-URL: https://github.com/nodejs/node/pull/32979 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com>
-
Myles Borins authored
For targets that are strings that do not start with `./` or `/` the error will now have additional information about what the programming error is. Closes: https://github.com/nodejs/node/issues/32034 PR-URL: https://github.com/nodejs/node/pull/32052 Fixes: https://github.com/nodejs/node/issues/32034 Reviewed-By:
Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By:
Jan Krems <jan.krems@gmail.com> Reviewed-By:
Guy Bedford <guybedford@gmail.com> Signed-off-by:
Myles Borins <myles.borins@gmail.com>
-
Anna Henningsen authored
Fixes: https://github.com/nodejs/node/issues/32835 PR-URL: https://github.com/nodejs/node/pull/32850 Reviewed-By:
Matheus Marchini <mat@mmarchini.me> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By:
-
James M Snell authored
Make it so that the allow unauthorized warning can be easily reused by the QUIC impl once that lands. Extracted from https://github.com/nodejs/node/pull/32379 Signed-off-by:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
-
James M Snell authored
* cleanup constants in http2 binding The error constants were just doing some weird things. Cleanup and improve maintainability. * simplify settings to reduce duplicate code * improve style consistency and correctness Use snake_case for getters and setters at c++ level, avoid unnecessary use of enums, use consistent style for exported vs. internal constants, avoid unnecessary memory info reporting, use setters/getters for flags_ for improved code readability * make EmitStatistics function private * un-nest Http2Settings and Http2Ping * refactoring and cleanup of Http2Settings and Http2Ping * avoid ** syntax for readability The **session and **stream syntax for getting the underlying nghttp2 pointers is not ideal for readability * use const references for Http2Priority * remove unnecessary GetStream function * refactor Http2Scope to use BaseObjectPtr * move utility function to anonymous namespace * refactor and simplify Origins * Use an AllocatedBuffer instead of MaybeStackBuffer * Use a const reference instead of pointer * use BaseObjectPtr for Http2Streams map * move MemoryInfo impl to cc Signed-off-by:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
-
Myles Borins authored
This removes `--experimental-modules` from showing up in `node -h` and also removes the documentation from the man pages. It will still work as a no-op, and is still included in cli.md Refs: https://github.com/nodejs/modules/issues/502 PR-URL: https://github.com/nodejs/node/pull/32915 Reviewed-By:
David Carlier <devnexen@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
-
Edward Elric authored
PR-URL: https://github.com/nodejs/node/pull/32926 Reviewed-By:
Zeyu Yang <himself65@outlook.com> Reviewed-By:
-
- Apr 21, 2020
-
-
Beth Griggs authored
Deprecations: - (SEMVER-MAJOR) crypto: move pbkdf2 without digest to EOL (James M Snell) [#31166](https://github.com/nodejs/node/pull/31166) - (SEMVER-MAJOR) fs: deprecate closing FileHandle on garbage collection (James M Snell) [#28396](https://github.com/nodejs/node/pull/28396) - (SEMVER-MAJOR) http: move OutboundMessage.prototype.flush to EOL (James M Snell) [#31164](https://github.com/nodejs/node/pull/31164) - (SEMVER-MAJOR) lib: move GLOBAL and root aliases to EOL (James M Snell) [#31167](https://github.com/nodejs/node/pull/31167) - (SEMVER-MAJOR) os: move tmpDir() to EOL (James M Snell)[#31169](https://github.com/nodejs/node/pull/31169) - (SEMVER-MAJOR) src: remove deprecated wasm type check (Clemens Backes) [#32116](https://github.com/nodejs/node/pull/32116) - (SEMVER-MAJOR) stream: move \_writableState.buffer to EOL (James M Snell) [#31165](https://github.com/nodejs/node/pull/31165) - (SEMVER-MINOR) doc: deprecate process.mainModule (Antoine du HAMEL) [#32232](https://github.com/nodejs/node/pull/32232) - (SEMVER-MINOR) doc: deprecate process.umask() with no arguments (Colin Ihrig) [#32499](https://github.com/nodejs/node/pull/32499) ECMAScript Modules - Experimental Warning Removal: - module: remove experimental modules warning (Guy Bedford) [#31974](https://github.com/nodejs/node/pull/31974) In Node.js 13 we removed the need to include the --experimental-modules flag, but when running EcmaScript Modules in Node.js, this would still result in a warning ExperimentalWarning: The ESM module loader is experimental. As of Node.js 14 there is no longer this warning when using ESM in Node.js. However, the ESM implementation in Node.js remains experimental. As per our stability index: “The feature is not subject to Semantic Versioning rules. Non-backward compatible changes or removal may occur in any future release.” Users should be cautious when using the feature in production environments. Please keep in mind that the implementation of ESM in Node.js differs from the developer experience you might be familiar with. Most transpilation workflows support features such as optional file extensions or JSON modules that the Node.js ESM implementation does not support. It is highly likely that modules from transpiled environments will require a certain degree of refactoring to work in Node.js. It is worth mentioning that many of our design decisions were made with two primary goals. Spec compliance and Web Compatibility. It is our belief that the current implementation offers a future proof model to authoring ESM modules that paves the path to Universal JavaScript. Please read more in our documentation. The ESM implementation in Node.js is still experimental but we do believe that we are getting very close to being able to call ESM in Node.js “stable”. Removing the warning is a huge step in that direction. New V8 ArrayBuffer API: * **src**: migrate to new V8 ArrayBuffer API (Thang Tran) [#30782](https://github.com/nodejs/node/pull/30782) Multiple ArrayBuffers pointing to the same base address are no longer allowed by V8. This may impact native addons. Toolchain and Compiler Upgrades: - (SEMVER-MAJOR) build: update macos deployment target to 10.13 for 14.x (AshCripps)[#32454](https://github.com/nodejs/node/pull/32454) - (SEMVER-MAJOR) doc: update cross compiler machine for Linux armv7 (Richard Lau) [#32812](https://github.com/nodejs/node/pull/32812) - (SEMVER-MAJOR) doc: update Centos/RHEL releases use devtoolset-8 (Richard Lau) [#32812](https://github.com/nodejs/node/pull/32812) - (SEMVER-MAJOR) doc: remove SmartOS from official binaries (Richard Lau) [#32812](https://github.com/nodejs/node/pull/32812) - (SEMVER-MAJOR) win: block running on EOL Windows versions (João Reis) [#31954](https://github.com/nodejs/node/pull/31954) It is expected that there will be an ABI mismatch on ARM between the Node.js binary and native addons. Native addons are only broken if they interact with `std::shared_ptr`. This is expected to be fixed in a later version of Node.js 14. - [#30786](https://github.com/nodejs/node/issues/30786) Update to V8 8.1: - (SEMVER-MAJOR) deps: update V8 to 8.1.307.20 (Matheus Marchini) [#32116](https://github.com/nodejs/node/pull/32116) Other Notable Changes: - cli, report: move --report-on-fatalerror to stable (Colin Ihrig) [#32496](https://github.com/nodejs/node/pull/32496) - deps: upgrade to libuv 1.37.0 (Colin Ihrig) [#32866](https://github.com/nodejs/node/pull/32866) - fs: add fs/promises alias module (Gus Caplan) [#31553](https://github.com/nodejs/node/pull/31553) PR-URL: https://github.com/nodejs/node/pull/32181
-
Matt Kulukundis authored
An empty buffer can have a null environment. Previously, we were getting away with with this, but -fsanitize=null in clang caught it. PR-URL: https://github.com/nodejs/node/pull/32892 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
-
William Armiros authored
PR-URL: https://github.com/nodejs/node/pull/32847 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
Andrey Pechkurov authored
PR-URL: https://github.com/nodejs/node/pull/32950 Refs: https://github.com/nodejs/node/issues/32863 Reviewed-By:
-
karan singh virdi authored
This commit fixes the interchangeably usage of "folder" and "directory" terms in fs.md Fixes: https://github.com/nodejs/node/issues/32902 PR-URL: https://github.com/nodejs/node/pull/32919 Reviewed-By:
Andrey Pechkurov <apechkurov@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
雨夜带刀 authored
PR-URL: https://github.com/nodejs/node/pull/32901 Reviewed-By:
-
rickyes authored
PR-URL: https://github.com/nodejs/node/pull/32640 Reviewed-By:
-
- Apr 20, 2020
-
-
rickyes authored
PR-URL: https://github.com/nodejs/node/pull/32910 Reviewed-By:
Chengzhong Wu <legendecas@gmail.com> Reviewed-By:
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/32693 Refs: https://github.com/v8/v8/compare/8.1.307.26...8.1.307.28 Reviewed-By:
Beth Griggs <Bethany.Griggs@uk.ibm.com>
-
cjihrig authored
Notable changes: - The UV_UDP_RECVMMSG flag has been added. This flag is now required in order to utilize recvmmsg(). This was added in response to a regression introduced in 1.35.0 and 1.36.0. PR-URL: https://github.com/nodejs/node/pull/32866 Reviewed-By:
Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
-
cjihrig authored
Notable changes: - gyp support has been removed. - recvmmsg messages are returned in the correct order. - IBMi cmake support has been added. - uv_fs_lutime() has been added. - uv_fs_statfs() on Windows properly handles file paths. PR-URL: https://github.com/nodejs/node/pull/32866 Reviewed-By:
-
Rich Trott authored
Refs: https://github.com/nodejs/nodejs.org/pull/3106#issuecomment-614258785 PR-URL: https://github.com/nodejs/node/pull/32903 Reviewed-By:
-
Gabriel Schulhof authored
We introduce status `napi_would_deadlock` to be used as a return status by `napi_call_threadsafe_function` if the call is made with `napi_tsfn_blocking` on the main thread and the queue is full. Fixes: https://github.com/nodejs/node/issues/32615 Signed-off-by:
Gabriel Schulhof <gabriel.schulhof@intel.com> PR-URL: https://github.com/nodejs/node/pull/32860 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
-
- Apr 19, 2020
-
-
Juan José Arboleda authored
Based on https://github.com/nodejs/help/issues/2600#issuecomment-612857153 the condition (amount < 0) won't be possible. PR-URL: https://github.com/nodejs/node/pull/32818 Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By:
Shelley Vohr <codebytere@gmail.com> Reviewed-By:
Gus Caplan <me@gus.host>
-
Jesus Hernandez authored
PR-URL: https://github.com/nodejs/node/pull/32662 Reviewed-By:
-
David Daza authored
The if statement inside the _writeHostObject function returns an expression which makes the else block unnecessary. PR-URL: https://github.com/nodejs/node/pull/32644 Reviewed-By:
-
Vadzim Zieńka authored
Call iterator.return() if not all of its values are consumed. Fixes: https://github.com/nodejs/node/issues/32842 PR-URL: https://github.com/nodejs/node/pull/32844 Reviewed-By:
Robert Nagy <ronagy@icloud.com> Reviewed-By:
-
Robert Nagy authored
PR-URL: https://github.com/nodejs/node/pull/32886 Reviewed-By:
-
Robert Nagy authored
Simplifies Writable.end() by inlining and de-duplicating code. PR-URL: https://github.com/nodejs/node/pull/32882 Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By:
-
- Apr 18, 2020
-
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/32832 Reviewed-By:
-
Nimit authored
Convert callback functions that are anonymous to arrow functions for better readability. Also adjusted the `this` object in places where that was required. PR-URL: https://github.com/nodejs/node/pull/32875 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
-
Nimit authored
elevate v8 namespaces. Leverage `using` semantics for repeated usage of v8 artifacts. PR-URL: https://github.com/nodejs/node/pull/32872 Reviewed-By:
-
Anna Henningsen authored
This fixes the following crash on Windows for me. I don't know why this I only started to see this now, but anyway, the new timeout value is still longer than a week and a half. File "tools/test.py", line 1725, in <module> sys.exit(Main()) File "tools/test.py", line 1701, in Main if RunTestCases(cases_to_run, options.progress, \ options.j, options.flaky_tests): File "tools/test.py", line 923, in RunTestCases return progress.Run(tasks) File "tools/test.py", line 145, in Run thread.join(timeout=10000000) File "C:\Users\anna\AppData\Local\Programs\Python\Python38-32\ \ lib\threading.py", line 1015, in join self._wait_for_tstate_lock(timeout=max(timeout, 0)) File "C:\Users\anna\AppData\Local\Programs\Python\Python38-32\ \ lib\threading.py", line 1027, in _wait_for_tstate_lock elif lock.acquire(block, timeout): OverflowError: timeout value is too large PR-URL: https://github.com/nodejs/node/pull/32868 Reviewed-By:Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Bartosz Sosnowski <bartosz@janeasystems.com>
-
Juan José Arboleda authored
PR-URL: https://github.com/nodejs/node/pull/32854 Reviewed-By:
-
Michael Dawson authored
We missed adding version 6 to the compatibility table when we defined version 6. Add it along with the versions that we know will include version 6. PR-URL: https://github.com/nodejs/node/pull/32829 Reviewed-By:
-
Juan José Arboleda authored
PR-URL: https://github.com/nodejs/node/pull/32906 Reviewed-By:
-
Guy Bedford authored
PR-URL: https://github.com/nodejs/node/pull/31974 Reviewed-By:
-
William Bonawentura authored
PR-URL: https://github.com/nodejs/node/pull/32657 Reviewed-By:
-
- Apr 17, 2020
-
-
Qinhui Chen authored
Delete useless module in parent module: parent.children array when error occurs, so that it can be garbage collected. Fixes: https://github.com/nodejs/node/issues/32836 PR-URL: https://github.com/nodejs/node/pull/32837 Reviewed-By:
-
Daniel Bevenius authored
This commit removes unused using declarations in src/node_worker.cc. PR-URL: https://github.com/nodejs/node/pull/32840 Reviewed-By:
-
Michael Dawson authored
- add backticks around use of NULL - convert from null to NULL where we mean NULL Signed-off-by:
Christopher Hiller <boneskull@boneskull.com>
-
Richard Lau authored
When running `make test-v8` V8's `gclient sync` converts folders under `deps/v8/third_party` into git repositories. Unfortunately the files that were checked in under `deps/v8/third_party/zlib` have been modified from the upstream Chromium repository (some files have been deleted and there are whitespace differences in some of the files that were kept) so whenever the Node.js source tree is hard reset/checked out `gclient sync` notices there are unstaged changes as the files in the Node.js source tree do not match those of the upstream Chromium third party zlib commit. Signed-off-by:
-
Gabriel Schulhof authored
This reverts commit aeb7084f. The solution creates incorrect behaviour on Windows. Re: https://github.com/nodejs/node-addon-api/pull/697#issuecomment-612993476 Signed-off-by:
-
