- Mar 06, 2017
-
-
Rahat Ahmed authored
PR-URL: https://github.com/nodejs/node/pull/11657 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Claudio Rodriguez <cjrodr@yahoo.com>
-
Daijiro Wachi authored
In the getter of the origin in URL, the URL that has blob protocol will be parsed in a function called "originFor". Add test cases into the url-tests-additional fixture to test that. Refs: https://github.com/w3c/web-platform-tests/pull/4941 PR-URL: https://github.com/nodejs/node/pull/11426 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Timothy Gu <timothygu99@gmail.com> Reviewed-By:
-
maurice_hayward authored
test: changed test1 of test-vm-timeout.js so that entire error message would be matched in assert.throw. Before test 1 of test-vm-timeout.js would match any error, now it looks specifically for the error message "Script execution timed out." PR-URL: https://github.com/nodejs/node/pull/11590 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
-
James M Snell authored
Move to the more efficient module.exports = {} pattern. PR-URL: https://github.com/nodejs/node/pull/11597 Reviewed-By:Michaël Zasso <targos@protonmail.com>
-
Daniel Bevenius authored
Issue 4641 contains a FIXME regarding the InitCrypto function. After discussing this with bnoordhuis it seems to be an outdated comment. Refs: https://github.com/nodejs/node/issues/4641 PR-URL: https://github.com/nodejs/node/pull/11669 Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
-
Rich Trott authored
The align-function-arguments custom rule is obsolete and has been removed from the code base. Remove comment that used to disable it for one file. PR-URL: https://github.com/nodejs/node/pull/11643 Reviewed-By:
Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By:
Teddy Katz <teddy.katz@gmail.com>
-
Daijiro Wachi authored
Like the other internal modules, we should use `process.binding('config').hasIntl` instead of `try-catch` to make sure `icu` is bonded or not. PR-URL: https://github.com/nodejs/node/pull/11571 Reviewed-By:Jackson Tian <shyvo1987@gmail.com>
-
Benjamin Fleischer authored
PR-URL: https://github.com/nodejs/node/pull/11189 Reviewed-By:
Brian White <mscdex@mscdex.net> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Eugene Ostroukhov authored
Currently Inspector posts a V8 "task" when a message is incoming. To make sure messages are processed even when no JS is executed (e.g. while waiting for I/O or timer), inspector will now post a libuv request. Fixes: https://github.com/nodejs/node/issues/11589 PR-URL: https://github.com/nodejs/node/pull/11617 Reviewed-By:
-
Daijiro Wachi authored
PR-URL: https://github.com/nodejs/node/pull/11676 Reviewed-By:
Evan Lucas <evanlucas@me.com>
-
Vse Mozhet Byt authored
The functions `fs.appendFile()` and `fs.writeFile()` were being called without the required `data` argument. Refs: https://github.com/nodejs/node/issues/11595 PR-URL: https://github.com/nodejs/node/pull/11601 Reviewed-By:
Nikolai Vavilov <vvnicholas@gmail.com> Reviewed-By:
-
Shigeki Ohtsu authored
ALPN test needs NPN feature to run. It also change the messages when ALPN and NPN tests are skipped. Fixes: https://github.com/nodejs/node/issues/11650 PR-URL: https://github.com/nodejs/node/pull/11655 Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
Shigeki Ohtsu authored
In order to check if NPN feature is enabled, use `#ifndef OPENSSL_NO_NEXTPROTONEG` rather than `#ifdef OPENSSL_NPN_NEGOTIATED` because the former is used in ssl.h. Fixes: https://github.com/nodejs/node/issues/11650 PR-URL: https://github.com/nodejs/node/pull/11655 Reviewed-By:
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/11564 Reviewed-By:
-
Rich Trott authored
Unset NODE_PATH environment variable when running tests. On Ubuntu 16.04, some users experience test failures due to internal libraries being installed in /usr/lib/nodejs/internal and NODE_PATH including /usr/lib/nodejs. Tests that expect internal libraries to be off limits without the --expose-internals flag will fail in this situation. Currently, those tests are test/parallel/test-repl.js and test/parallel/test-internal-modules.js. This situation seems to (probably) be caused by some not-entirely-uncommon package that gets installed. Regardless, tests should ignore the user's NODE_PATH. (NODE_PATH is tested in test/parallel/test-module-globalpaths-nodepath.js and test/parallel/test-require-dot.js.) PR-URL: https://github.com/nodejs/node/pull/11612 Reviewed-By:
Bryan English <bryan@bryanenglish.com> Reviewed-By:
Santiago Gimeno <santiago.gimeno@gmail.com> Refs: https://twitter.com/trott/status/835729396900061184
-
Rich Trott authored
Replace toString().match().join() with toString().replace().trim(). This enables the elimination of a length check becuase replace() will return empty string if Buffer is empty whereas match() returns null. PR-URL: https://github.com/nodejs/node/pull/11600 Reviewed-By:
-
Rich Trott authored
lib/buffer.js defines Buffer.prototype.inspect() to override how buffers are presented by util.inspect(). Add basic tests for it. PR-URL: https://github.com/nodejs/node/pull/11600 Reviewed-By:
-
Richard Lau authored
Protocol of `https://example.org` is `https:` not `http:`. PR-URL: https://github.com/nodejs/node/pull/11647 Reviewed-By:
-
Santiago Gimeno authored
Use a different server instance for every test to avoid that they reuse the same port. PR-URL: https://github.com/nodejs/node/pull/11649 Fixes: https://github.com/nodejs/node/issues/11644 Reviewed-By:
-
Rich Trott authored
Instead of disabling max-len (ESLint's line-length rule) for the entire file, reformat to avoid exceeding length restrictions in most cases and disable the rule only on specific lines where exceeding the length restriction may be a better choice than conforming to it. PR-URL: https://github.com/nodejs/node/pull/11559 Reviewed-By:
-
Daniel Bevenius authored
When building --without-ssl and then running: out/Release/node --expose-internals test/parallel/test-internal-util-assertCrypto.js The following error is displayed: assert.js:420 throw actual; ^ Error: Node.js is not compiled with openssl crypto support at Object.exports.assertCrypto (internal/util.js:82:11) at assert.throws (/Users/danielbevenius/work/nodejs/node/test/parallel/test-internal-util-assertCrypto.js:8:28) at _tryBlock (assert.js:379:5) at _throws (assert.js:398:12) at Function.throws (assert.js:428:3) at Object.<anonymous> (/Users/danielbevenius/work/nodejs/node/test/parallel/test-internal-util-assertCrypto.js:8:10) at Module._compile (module.js:571:32) at Object.Module._extensions..js (module.js:580:10) at Module.load (module.js:488:32) at tryModuleLoad (module.js:447:12) It looks like the regex is not taking into account the 'Error: ' hence the failure to match it. PR-URL: https://github.com/nodejs/node/pull/11620 Reviewed-By: -
Rich Trott authored
Change the Stability Index on timers from Locked to Stable. Note that this is not intended to encourage changes to the timers API, but to allow it when its useful for Node.js (as has happened in violation of the documented stability level), and possibly to simplify the stability levels by removing Locked altogether. PR-URL: https://github.com/nodejs/node/pull/11580 Ref: https://github.com/nodejs/node/issues/11200 Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By:
-
chiaki-yokoo authored
PR-URL: https://github.com/nodejs/node/pull/11435 Reviewed-By:
-
Amelia Clarke authored
Refs: https://github.com/nodejs/node/issues/9399 PR-URL: https://github.com/nodejs/node/pull/11554 Reviewed-By:
-
James M Snell authored
The ROADMAP.md file has not been updated in a while. It serves no useful purpose that cannot be handled better in other docs (contrib guidelines, etc). Just remove it. PR-URL: https://github.com/nodejs/node/pull/11556 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
-
Bradley Curran authored
Use the plural instead of the possessive for developers PR-URL: https://github.com/nodejs/node/pull/11560 Reviewed-By:
-
Rich Trott authored
Strict mode for the test will not automatically enable strict mode in the REPL object. Enable strict mode in the test. PR-URL: https://github.com/nodejs/node/pull/11575 Reviewed-By:
-
Ben Noordhuis authored
The allowHalfOpen comment was added in commit 8a3befa0 ("net: Refactor to use streams2") from 2012 but it wasn't true even then as far as I can tell: Node.js simply always does a shutdown(2) first. It is true that streams2 withholds the 'end' event when allowHalfOpen is true but the comment is about a callback that hangs off the 'finish' event that is emitted after calling `socket.end()`. PR-URL: https://github.com/nodejs/node/pull/11573 Reviewed-By:
-
Vse Mozhet Byt authored
* add semicolons in examples * fix indentation in code example * add spaces in code examples * console.log() -> console.error() * fix level of headings * update comment code example * delete obsolete info and example Fixes: https://github.com/nodejs/node/issues/11558 PR-URL: https://github.com/nodejs/node/pull/11566 Reviewed-By:
-
The `common.skip` function adds proper message in TAP format to skipped tests. It is better not to have the message rewritten in the tests. PR-URL: https://github.com/nodejs/node/pull/11585 Reviewed-By:
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/11625 Reviewed-By:
-
Timothy Gu authored
PR-URL: https://github.com/nodejs/node/pull/11549 Reviewed-By:
-
Timothy Gu authored
- Split the tests out to a separate file - Add invalid cases - Add tests for url.domainTo*() - Re-enable previously broken WPT URL parsing tests PR-URL: https://github.com/nodejs/node/pull/11549 Reviewed-By:
-
Timothy Gu authored
Old behavior can be restored using a special `lenient` mode, as used in the legacy URL parser. PR-URL: https://github.com/nodejs/node/pull/11549 Reviewed-By:
-
James Sumners authored
PR-URL: https://github.com/nodejs/node/pull/11518 Reviewed-By:
-
Nikolai Vavilov authored
PR-URL: https://github.com/nodejs/node/pull/11615 Reviewed-By:
-
Ben Schmidt authored
Also squashed from: * test: move tty-wrap isrefed test to pseudo-tty/ * test: test tty-wrap handle isrefed properly * test: improve failure messages in isrefed tests PR-URL: https://github.com/nodejs/node/pull/7360 Reviewed-By:
-
- Mar 02, 2017
-
-
Italo A. Casas authored
PR-URL: https://github.com/nodejs/node/pull/11638
-
Italo A. Casas authored
Notable changes: Node.js 7.7.0 contains a bug that will prevent all native modules from building, this patch should fix the issue. Apologies to everyone who was affected by 7.7.0. PR-URL: https://github.com/nodejs/node/pull/11638
-
Michaël Zasso authored
In V8 5.6, String#toLocaleUpperCase can work even when no ICU data is loaded. Use another method to check the --icu-data-dir option pointing to an empty directory. PR-URL: https://github.com/nodejs/node/pull/10992 Reviewed-By:
-
