Commits · cff2aea5df3d65caee17148891a7c751be7e5110 · github.com / v8-riscv / node

Aug 17, 2021

test: add known issues test for debugger heap snapshot race · cff2aea5

Rich Trott authored Jul 27, 2021

Refs: https://github.com/nodejs/node/issues/39555

PR-URL: https://github.com/nodejs/node/pull/39557


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

cff2aea5

doc: update min mac ver + move mac arm64 to tier 1 · 75144054

Ash Cripps authored Jul 30, 2021

Update the minimum macos version that can compile to match the
xcode requirements.

Also move mac arm64 to tier 1.

refs: https://github.com/nodejs/node/issues/39584#issuecomment-889701855

PR-URL: https://github.com/nodejs/node/pull/39586


Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

75144054

doc: add missing `introduced_in` metadata · d7c8c6dc

Richard Lau authored Jul 29, 2021

Fixes doc build warnings:
```
Failed to add alternative version links to webstreams
Failed to add alternative version links to async_context
```

PR-URL: https://github.com/nodejs/node/pull/39575


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>

d7c8c6dc

meta: align README/.mailmap/AUTHORS email entries · 6b664e22

Rich Trott authored Jul 24, 2021

The email address for Weijia Wang in the AUTHORS and .mailmap files is
different from the email address in the README.md file. Based on their
GitHub profile and commit metadata, the one in the README.md file is the
preferred email. Updating .mailmap and AUTHORS to reflect it.

PR-URL: https://github.com/nodejs/node/pull/39505


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>

6b664e22

build: exclude markdown files from some GitHub Actions · 9d38400d

Rich Trott authored Jul 28, 2021

Ignore all markdown files when determining if test-asan, coverage-*, and
test-macos need to run.

Refs: https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#patterns-to-match-file-paths

PR-URL: https://github.com/nodejs/node/pull/39565


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

9d38400d

meta: add mailmap entry for garygsc · 96d8ecbd

Rich Trott authored Jul 30, 2021

Add mailmap entry for garygsc and re-run AUTHORS to remove duplicate
entry.

PR-URL: https://github.com/nodejs/node/pull/39588


Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

96d8ecbd

meta: add mailmap entry for ttzztztz · 16d85f3f

Rich Trott authored Jul 30, 2021

Add mailmap entry for ttzztztz and re-run AUTHORS to remove duplicate
entry.

PR-URL: https://github.com/nodejs/node/pull/39588


Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

16d85f3f

meta: update AUTHORS · 60ab111f

Rich Trott authored Jul 30, 2021

PR-URL: https://github.com/nodejs/node/pull/39587


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

60ab111f

doc: add code examples to `Writable.destroy()` and `Writable.destroyed` · 80725170
Juan José Arboleda authored Jul 22, 2021
```
PR-URL: https://github.com/nodejs/node/pull/39491


Reviewed-By: James M Snell <jasnell@gmail.com>
```
80725170

perf_hooks: fix performance timeline wpt failures · b37575b6

legendecas authored Jul 26, 2021

PR-URL: https://github.com/nodejs/node/pull/39532


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>

b37575b6

doc: add `String.prototype.at` and `%TypedArray%.prototype.at` · 55f47cc2

Jordan Harband authored Jul 29, 2021

PR-URL: https://github.com/nodejs/node/pull/39583


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Ash Cripps <acripps@redhat.com>

55f47cc2

meta: update .mailmap to remove duplication in AUTHORS · b43f87d7

Rich Trott authored Jul 27, 2021

PR-URL: https://github.com/nodejs/node/pull/39561


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>

b43f87d7

meta: add .mailmap entries to remove AUTHORS duplicates · 6f4a2aa5

Rich Trott authored Jul 27, 2021

PR-URL: https://github.com/nodejs/node/pull/39560


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>

6f4a2aa5

doc: move `NODE_MODULE_VERSION` in release guide · 0c0412e2

Richard Lau authored Jul 27, 2021

Move the section on `NODE_MODULE_VERSION` into the section for
major releases as it should only be updated for a major release.
Add a note to remove the `-pre` suffix from the registry for the
release commit.

PR-URL: https://github.com/nodejs/node/pull/39544


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

0c0412e2

doc: remove outdated ARM information from release guide · 5df74f9b

Richard Lau authored Jul 27, 2021

We no longer produced ARMv6 builds, and the ARMv7 builds are now
cross compiled and are as quick as builds on the other platforms.

PR-URL: https://github.com/nodejs/node/pull/39544


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

5df74f9b

doc: fence command examples in release guide · 8eccb11e

Richard Lau authored Jul 27, 2021

Put the command examples for finding and replacing the `REPLACEME`
tags into code fences so that they are more easily copiable when
viewing the guide in the GitHub web UI.

PR-URL: https://github.com/nodejs/node/pull/39544


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

8eccb11e

doc: update backport labels in release guide · 0bd97e1f

Richard Lau authored Jul 27, 2021

Add `backport-open-v1.x,backported-to-v1.x` labels to `branch-diff`
commands as these indicate pull requests that are being manually
backported and should not be cherry-picked.

PR-URL: https://github.com/nodejs/node/pull/39544


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

0bd97e1f

meta: add .mailmap entry to remove duplication in AUTHORS · 86d144c5

Rich Trott authored Jul 27, 2021

PR-URL: https://github.com/nodejs/node/pull/39559


Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>

86d144c5

build: use lts shorthand in GitHub Actions · eeb804a7

Rich Trott authored Jul 26, 2021

Rather than hard-coding GitHub Actions to use Node.js 14.x, use the
`lts/*` shorthand for "most recent LTS version".

PR-URL: https://github.com/nodejs/node/pull/39538


Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

eeb804a7

src: add cosmetic space character to `async_wrap.h` file · 60a2b31c

Juan José Arboleda authored Jul 19, 2021

PR-URL: https://github.com/nodejs/node/pull/39459


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

60a2b31c

async_hooks: merge resource_symbol with owner_symbol · a80c9893

Darshan Sen authored Apr 29, 2021



Signed-off-by: Darshan Sen <darshan.sen@postman.com>

PR-URL: https://github.com/nodejs/node/pull/38468


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

a80c9893

http: decodes url.username and url.password for authorization header · 54dd3df9

Lew Gordon authored Jul 08, 2021

This change properly decodes the url.username and url.password for
the authorization header constructed from the URL object for
http(s) requests.

Fixes: https://github.com/nodejs/node/issues/31439

PR-URL: https://github.com/nodejs/node/pull/39310


Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

54dd3df9

doc: add code example to `fs.truncate` method · 2129ad6a

Juan José Arboleda authored Jul 19, 2021

PR-URL: https://github.com/nodejs/node/pull/39454


Reviewed-By: James M Snell <jasnell@gmail.com>

2129ad6a

doc: add code example to `http.createServer` method · 3ff5e153
Juan José Arboleda authored Jul 19, 2021
```
PR-URL: https://github.com/nodejs/node/pull/39455


Reviewed-By: James M Snell <jasnell@gmail.com>
```
3ff5e153

meta: update collaborator email in AUTHORS/.mailmap · 110c088f

Rich Trott authored Jul 25, 2021

Update email for Ujjwal Sharma.

PR-URL: https://github.com/nodejs/node/pull/39521


Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

110c088f

meta: update collaborator email in README · 72af147b

Rich Trott authored Jul 25, 2021

Update email for Shelley Vohr to correspond to what is specified in
.mailmap and what is used in more recently authored commits.

PR-URL: https://github.com/nodejs/node/pull/39521


Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

72af147b

meta: update collaborator email in AUTHORS/.mailmap · 23bc4cfb

Rich Trott authored Jul 25, 2021

Update email for Zeyu Yang.

PR-URL: https://github.com/nodejs/node/pull/39521


Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

23bc4cfb

tools: update ESLint to 7.31.0 · af1c782c

cjihrig authored Jul 17, 2021

Update ESLint to 7.31.0

PR-URL: https://github.com/nodejs/node/pull/39424


Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>

af1c782c

meta: move gdams to emeritus · e4289728

Rich Trott authored Jul 26, 2021

George does not appear to be active in Node.js for quite some time
(correction welcome!) and my attempts to get in touch have failed.

PR-URL: https://github.com/nodejs/node/pull/39539


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: George Adams <george.adams@microsoft.com>
Reviewed-By: Stewart X Addison <sxa@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

e4289728

doc: add PerformanceObserver `buffered` document · 7d0c869c

legendecas authored Jul 25, 2021

The option buffered is not about queueing the PerformanceEntrys with
an event loop task or not. The option buffered in the spec is about
filling the observer with the global PerformanceEntry buffer. The
current (and the spec) behavior is different with Node.js
version <= v16.0.0.

PR-URL: https://github.com/nodejs/node/pull/39514
Refs: https://w3c.github.io/performance-timeline/#observe-method
Refs: https://nodejs.org/dist/latest-v14.x/docs/api/perf_hooks.html#perf_hooks_performanceobserver_observe_options
Refs: https://github.com/nodejs/node/pull/39297


Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

7d0c869c

perf_hooks: web performance timeline compliance · 64c02eb3

legendecas authored Jun 24, 2021

All API introduced in this PR are compliant with web
[performance-timeline](https://w3c.github.io/performance-timeline)
spec. "performance-timeline" is listed as supported web spec in the doc
https://nodejs.org/docs/latest/api/perf_hooks.html#perf_hooks_performance_measurement_apis.

Changes summary:
1. Add new supported wpt test subsets: user-timing and
  performance-timeline.
2. Add support for `Performance.getEntries`,
  `Performance.getEntriesByName` and `Performance.getEntriesByType`
  to synchronously fetch buffered performance entries. This means
  the user should invoke `Performance.clearMarks` and
  `Performance.clearMeasures` to clear buffered entries to prevent from
  those entries been kept alive forever.
3. Add support (again after https://github.com/nodejs/node/pull/37136)
  for `buffered` flags for `PerformanceObserver`.
3. Fixes `PerformanceMark` and `PerformanceMeasure` wpt compliance
  issues.
4. Only user-created performance entries will be buffered globally. This
  behavior should be compliant with
  https://w3c.github.io/timing-entrytypes-registry/#registry.

With the new ability to fetch user-created performance entries
synchronously, the issues raised in
https://github.com/nodejs/diagnostics/issues/464#issuecomment-861920116
could also be fixed.

PR-URL: https://github.com/nodejs/node/pull/39297


Reviewed-By: James M Snell <jasnell@gmail.com>

64c02eb3

Aug 11, 2021

Working on v16.6.3 · 8f11b163
Beth Griggs authored Aug 11, 2021
```
PR-URL: https://github.com/nodejs-private/node-private/pull/280
```
8f11b163

2021-08-11, Version 16.6.2 (Current) · bfe80913

Beth Griggs authored Aug 11, 2021

This is a security release.

Notable Changes:

- CVE-2021-3672/CVE-2021-22931:
    Improper handling of untypical characters in domain names (High)
- CVE-2021-22930:
    Use after free on close http2 on stream canceling (High)
- CVE-2021-22939:
    Incomplete validation of rejectUnauthorized parameter (Low)

PR-URL: https://github.com/nodejs-private/node-private/pull/280

bfe80913

deps: update c-ares to 1.17.2 · 054537cd

Beth Griggs authored Aug 10, 2021

Refs: https://github.com/c-ares/c-ares/releases/tag/cares-1_17_2

CVE-ID: CVE-2021-3672, CVE-2021-22931
Refs: https://nvd.nist.gov/vuln/detail/CVE-2021-3672
Refs: https://nvd.nist.gov/vuln/detail/CVE-2021-22931
PR-URL: https://github.com/nodejs/node/pull/39724


Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

054537cd

Aug 09, 2021

deps: reflect c-ares source tree · ac544905

Beth Griggs authored Aug 03, 2021

c-ares refactored their source tree in 1.17.0 which we did not apply in
our update to 1.17.1. This commit syncs our source with their new
structure for easier maintenance going forward. cares.gyp is updated
accordingly.

Refs: https://github.com/c-ares/c-ares/pull/349
Refs: https://github.com/nodejs/node/pull/36207

PR-URL: https://github.com/nodejs/node/pull/39653


Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

ac544905

deps: apply missed updates from c-ares 1.17.1 · a914b23c

Beth Griggs authored Aug 03, 2021

PR-URL: https://github.com/nodejs/node/pull/39653
Refs: https://github.com/c-ares/c-ares/pull/349
Refs: https://github.com/nodejs/node/pull/36207


Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

a914b23c

tls: validate "rejectUnauthorized: undefined" · 6c7fff6f

Matteo Collina authored Aug 04, 2021

Incomplete validation of rejectUnauthorized parameter (Low)

If the Node.js https API was used incorrectly and "undefined" was passed
in for the "rejectUnauthorized" parameter, no error was returned and
connections to servers with an expired certificate would have been
accepted.

CVE-ID: CVE-2021-22939
Refs: https://nvd.nist.gov/vuln/detail/CVE-2021-22939
Refs: https://hackerone.com/reports/1278254
PR-URL: https://github.com/nodejs-private/node-private/pull/276


Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Akshay K <iit.akshay@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Richard Lau <rlau@redhat.com>

6c7fff6f

http2: add tests for cancel event while client is paused reading · 31d57736

Akshay K authored Aug 05, 2021

PR-URL: https://github.com/nodejs/node/pull/39622
Refs: https://github.com/nodejs/node/pull/39423


Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>

31d57736

http2: update handling of rst_stream with error code NGHTTP2_CANCEL · a3c33d4c

Akshay K authored Jul 30, 2021

The PR updates the handling of rst_stream frames and adds all streams
to the pending list on receiving rst frames with the error code
NGHTTP2_CANCEL.

The changes will remove dependency on the stream state that may allow
bypassing the checks in certain cases. I think a better solution is to
delay streams in all cases if rst_stream is received for the cancel
events.

The rst_stream frames can be received for protocol/connection error as
well it should be handled immediately. Adding streams to the pending
list in such cases may cause errors.

CVE-ID: CVE-2021-22930
Refs: https://nvd.nist.gov/vuln/detail/CVE-2021-22930
PR-URL: https://github.com/nodejs/node/pull/39622
Refs: https://github.com/nodejs/node/pull/39423


Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>

a3c33d4c

Aug 03, 2021
- Working on v16.6.2 · 2a995496
  Michaël Zasso authored Aug 03, 2021
```
PR-URL: https://github.com/nodejs/node/pull/39631
```
  2a995496