- May 17, 2019
-
-
Tim De Pauw authored
Originally discovered and resolved by @szmarczak. PR-URL: https://github.com/nodejs/node/pull/25536 Fixes: https://github.com/nodejs/node/issues/25499 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Anna Henningsen authored
- Generate and use a list of suppressions that reduce noisiness for known (non-)issues. - Use `--zero-fill-buffers` for tests, as they sometimes use `Buffer.allocUnsafe()` and valgrind reports that as usage of uninitialized memory. PR-URL: https://github.com/nodejs/node/pull/25498 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
-
yathamravali authored
PR-URL: https://github.com/nodejs/node/pull/25441 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
Daniel Bevenius authored
This commit updates the named curves P-192 (prime192v1), and secp192k1 to 256 bit versions. The motivation for this is that in Red Hat Enterprise Linux (RHEL) all ECC curves < 224 bits are removed from OpenSSL provided by the system. I'm not sure if other distributions do this but these 256 bit curves are availalbe in OpenSSL 1.1.0j (current version on master) and OpenSSL 1.1.1 so as far as I can tell it should be safe change to make. PR-URL: https://github.com/nodejs/node/pull/25564 Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
-
cjihrig authored
Update ESLint to 5.12.1 PR-URL: https://github.com/nodejs/node/pull/25573 Reviewed-By:
Wyatt Preul <wpreul@gmail.com> Reviewed-By:
Masashi Hirano <shisama07@gmail.com>
-
Daniel George Holz authored
I was implementing a Writable stream and misunderstood `decodeStrings` to mean 'will decode `Buffer`s into `string`s before calling `_write`'. This change adds a little more detail to the description of `decodeStrings` to clarify its effect on a Writable stream & what gets passed to `_write`. Changing the name of the option to `encodeStrings` would make it much easier to understand, but the name was chosen in 2012 and the option used in many projects (22k mentions of 'decodeStringsr in JS projects in GitHub). Deprecating the old name & rolling out a replacement is beyond my capabilities as a first-time contributor. PR-URL: https://github.com/nodejs/node/pull/25468 Fixes: https://github.com/nodejs/node/issues/25464 Reviewed-By:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/25566 Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/25585 Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com>
-
Luigi Pinca authored
If specified, and only when a socket is created internally, the option will make `socket.setTimeout()` to be called on the created socket with the given timeout. This is consistent with the `timeout` option of `net.connect()` and prevents the `timeout` option of the `https.Agent` from being ignored when a socket is created. PR-URL: https://github.com/nodejs/node/pull/25517 Reviewed-By:
Roman Reiss <me@silverwind.io> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
Gireesh Punathil authored
In parallel/test-fs-read-stream-concurrent-reads.js the number of data chunks used is being tested when few concurrent reads are performed. The number of chunks can fluctuate based on the number of concurrent reads as well as the data that was read in one shot. Accommodate these variations in the test. Fixes: https://github.com/nodejs/node/issues/22339 PR-URL: https://github.com/nodejs/node/pull/25415 Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/25547 Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By:
-
Michael Dawson authored
Coverage report for src/node_i18n.cc shows that the Has() method is not covered. This test adds coverage for that method. PR-URL: https://github.com/nodejs/node/pull/25428 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
-
Daniel Bevenius authored
Currently, test-cli-node-print-help uses common.hasFipsCrypto to determine if the test should check for the existence of FIPS related options (--enable-fips, and --force-fips). The FIPS options are available when node has been compiled against an OpenSSL library with FIPS support in which case the test would verify that these options are available. But by using crypto.fips (which uses crypto.getFips()) this would only be checked when fips has been enabled, but these options are available regardless if FIPS is enabled or disabled. This commit updates the test to use fipsMode from config to determine if the FIPS options existence should be checked. PR-URL: https://github.com/nodejs/node/pull/25510 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
-
Anna Henningsen authored
Only use the amount of data that was actually read from the test file. Otherwise, there is a small risk of getting false positives, and generally reading uninitialized memory makes using automated memory error detection tools harder. PR-URL: https://github.com/nodejs/node/pull/25475 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
H1Gdev authored
PR-URL: https://github.com/nodejs/node/pull/25544 Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
-
Rich Trott authored
Reduce the time it takes to run test/pummel/test-hash-seed by switching from spawnSync() to spawn(). On my computer, this reduces the runtime from about 80 seconds to about 40 seconds. This test is not (yet) run regularly on CI, but when it was run recently, it timed out. PR-URL: https://github.com/nodejs/node/pull/25522 Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
Minwoo Jung <minwoo@nodesource.com>
-
Rich Trott authored
Replace min() function with Math.min(...). PR-URL: https://github.com/nodejs/node/pull/25522 Reviewed-By:
-
Rich Trott authored
test/pummel/test-keep-alive.js requires `wrk` to be installed. Check if it is, and skip the test if it isn't. This is yet another step in preparation for running pummel tests in CI daily. PR-URL: https://github.com/nodejs/node/pull/25516 Reviewed-By:
-
Michael Dawson authored
Fixes: https://github.com/nodejs/TSC/issues/650 PR-URL: https://github.com/nodejs/node/pull/25535 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/25425 Reviewed-By:
-
Sam Roberts authored
- DEFAULT_ECDH_CURVE default changed to 'auto' for 10.0.0 - ecdhCurve parameter allowed multiple values and 'auto' from 9.0.0 PR-URL: https://github.com/nodejs/node/pull/25502 Reviewed-By:
-
Rich Trott authored
* Use port 0 instead of `common.PORT`. * Use `//` for comments, capitalize comments, and add punctuation. PR-URL: https://github.com/nodejs/node/pull/25485 Reviewed-By:
-
Rich Trott authored
* Use port 0 instead of `common.PORT`. * Reduce `concurrent` from 100 to 50 and `connections_per_client` from 5 to 3. This is to avoid side effects from other tests. Prior to this change, running this along with test-keep-alive would result in failures on my local setup, apparently due to network throttling. * Remove unnecessary `console.log()` and improve remaining `console.log()` to provide clearer information. PR-URL: https://github.com/nodejs/node/pull/25485 Reviewed-By:
-
Rich Trott authored
* Reduce ROUNDS and ATTEMPTS_PER_ROUND by half to avoid spurious test failures as a result of side effects from other tests. (For my local setup, test-keep-alive seems to cause this test to fail with ETIMEDOUT and/or EADDRNOTAVAIL. It would seem to be a result of throttling. Reducing the pummel-iness of that test and this one seems to solve the problem.) * Apply capitalization and punctuation to comment. PR-URL: https://github.com/nodejs/node/pull/25485 Reviewed-By:
-
Rich Trott authored
* Reduce concurrent and duration options by half so as to avoid interference with other tests. (Excessive TCP activity in this test resulted in throttling that caused subsequent tests to fail on my local setup.) * Use an OS-provided port rather than `common.PORT`. This possibly reduces side-effects on other tests (that may also be using `common.PORT`). * Add punctuation in comments. PR-URL: https://github.com/nodejs/node/pull/25485 Reviewed-By:
-
Eugene Ostroukhov authored
Many Inspector protocol clients rely on the top frame reported for the console messages. This test makes sure correct location is reported. PR-URL: https://github.com/nodejs/node/pull/25455 Reviewed-By:
-
Sam Roberts authored
The API has existed forever and is used in our unit tests. It is supported for TLS1.3 as well as 1.2 and useful for troubleshooting, so it should be documented. PR-URL: https://github.com/nodejs/node/pull/25423 Reviewed-By:
-
ZYSzys authored
PR-URL: https://github.com/nodejs/node/pull/25439 Reviewed-By:
-
Ankur Oberoi authored
PR-URL: https://github.com/nodejs/node/pull/25103 Reviewed-By:
-
Sam Roberts authored
Remove: - use of tls global so tests can run in parallel - test counting in favour of common.mustCall() - limit of only one cipher suite per ephemeral key type tested The last change will allow adding TLS 1.3 cipher suites and testing 'ECDH' key info with them. PR-URL: https://github.com/nodejs/node/pull/25409 Reviewed-By:
-
Sam Roberts authored
Check that the return value and callback error for tls.renegotiate() does not indicate a failure. Also, remove unnecessary line wrapping and indentation. PR-URL: https://github.com/nodejs/node/pull/25437 Reviewed-By:
-
Anto Aravinth authored
PR-URL: https://github.com/nodejs/node/pull/24054 Reviewed-By:
-
Vse Mozhet Byt authored
This PR places `Buffer.from(object...)` section before `Buffer.from(string...)` section and upper-cased bottom references before backtick-started ones. PR-URL: https://github.com/nodejs/node/pull/25477 Reviewed-By:
Beth Griggs <Bethany.Griggs@uk.ibm.com>
-
Philipp Renoth authored
- parameter `resource_object` is mandatory PR-URL: https://github.com/nodejs/node/pull/25366 Reviewed-By:
-
Rich Trott authored
test-net-connect-econnrefused was recently fixed, but only in certain circumstances. This change allows it to succeed whether it is invoked with `node` or `tools/test.py`. Makes sure no Socket handles are left, which is what the test is trying to determine, rather than failing if there are no handles of any kind left. PR-URL: https://github.com/nodejs/node/pull/25438 Reviewed-By:
-
Matteo Collina authored
See: https://github.com/nodejs/node/issues/25373 See: https://github.com/nodejs/node/pull/18438 PR-URL: https://github.com/nodejs/node/pull/25413 Reviewed-By:
-
Rich Trott authored
test-inspector-port-cluster passes in workers. Remove skipIfWorker() from the test. PR-URL: https://github.com/nodejs/node/pull/25427 Reviewed-By:
Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By:
-
cjihrig authored
Use of process.binding() has largely been replaced by internalBinding(). This commit updates the custom crypto check ESLint rule to check for both process.binding() and internalBinding(). Refs: https://github.com/nodejs/node/pull/24952 PR-URL: https://github.com/nodejs/node/pull/25395 Reviewed-By:
-
Mitar authored
PR-URL: https://github.com/nodejs/node/pull/25332 Reviewed-By:
-
jvelezpo authored
The os.networkInterfaces() example was outdated as the IPv6 interfaces did not include the scopeid property, now they do. PR-URL: https://github.com/nodejs/node/pull/25417 Fixes: https://github.com/nodejs/node/issues/25408 Reviewed-By:
Weijia Wang <starkwang@126.com>
-
