- Jul 15, 2020
-
-
Michael Dawson authored
Refs: https://github.com/nodejs/node/issues/33796 Signed-off-by:
Michael Dawson <michael_dawson@ca.ibm.com> PR-URL: https://github.com/nodejs/node/pull/33814 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Dennis Ameling authored
Adds configuration to allow building an MSI installer for Windows ARM64. MSI can be created by running `vcbuild.bat release msi arm64` Refs: https://github.com/nodejs/node/issues/25998 Refs: https://github.com/nodejs/node/issues/32582 PR-URL: https://github.com/nodejs/node/pull/33689 Reviewed-By:
João Reis <reis@janeasystems.com> Reviewed-By:
Bartosz Sosnowski <bartosz@janeasystems.com>
-
legendecas authored
PR-URL: https://github.com/nodejs/node/pull/33769 Fixes: https://github.com/nodejs/node/issues/30516 Reviewed-By:
Denys Otrishko <shishugi@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
-
cjihrig authored
It has been reported that the https://github.com/cjihrig/node-v8-inspector V8 inspector extension can no longer connect DevTools (despite no code changes to the extension since Feb. 2017). Upon investigation, Chrome dropped support for the chrome-devtools: scheme recently. I've confirmed that dropping 'chrome-' from the URL here allows the debugger to function properly with modern Chrome. Refs: https://chromium.googlesource.com/chromium/src/+/6700d12448f76712c62a6d2372a95b97a26d4779 PR-URL: https://github.com/nodejs/node/pull/33758 Reviewed-By:
Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By:
Matheus Marchini <mat@mmarchini.me> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
David Carlier <devnexen@gmail.com>
-
cjihrig authored
This commit updates the V8 inspector example to reflect what is currently printed to the console. PR-URL: https://github.com/nodejs/node/pull/33758 Reviewed-By:
-
sapics authored
PR-URL: https://github.com/nodejs/node/pull/33722 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Zeyu Yang <himself65@outlook.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com>
-
Daniel Bevenius authored
Currently, when using the bash completions for node the normal completions for filenames directories do not work. For example, after finding a node completion and then wanting to use tab completion for a filename in the test directory, it is only possible to get the name of the test directory completed, followed by a space. What is expected is to be able to continue with tab completion for directories. This commit adds options to the complete command to enable default bash completions. PR-URL: https://github.com/nodejs/node/pull/33744 Reviewed-By:
-
Daniel Bevenius authored
This commit adds a configuration option named openssl-default-cipher-list which takes a colon separated string specifying ciphers that should be used as the default ciphers instead of the ones defined in node_constants. The motivation for this is a use case where Fedora/RHEL would like to be able to specify a default cipher in the format PROFILE=SYSTEM. This would enable Fedora/RHEL to have a system wide security level for all applications. PR-URL: https://github.com/nodejs/node/pull/33708 Refs: https://docs.fedoraproject.org/en-US/packaging-guidelines/CryptoPolicies/ Reviewed-By:
-
Daniel Bevenius authored
This commit removes the reported unused using declarations from cache_builder.cc PR-URL: https://github.com/nodejs/node/pull/33697 Reviewed-By:
-
Daniel Bevenius authored
This commit adds the prerequisites which contains all the files to lint. Currently the only the files in 'src' will be checked. PR-URL: https://github.com/nodejs/node/pull/33697 Reviewed-By:
-
Daniel Bevenius authored
This commit replaces FromJust() calls with Check() in places where the value that FromJust() returns is not used. PR-URL: https://github.com/nodejs/node/pull/33706 Reviewed-By:
-
João Reis authored
Original PR: PR-URL: https://github.com/nodejs/node/pull/28858 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de>
-
Pranshu Srivastava authored
Disable lint checks (enable prohibited-strings remark-lint) for doc-style-guide.md:66. This was producing lint errors in builds on master. PR-URL: https://github.com/nodejs/node/pull/33787 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com>
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/33755 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/33756 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/33756 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/33756 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/33756 Reviewed-By:
-
Rich Trott authored
The phrasing "pre Node.js v0.10" is not grammatical, as "pre" is not a word. This also changes "Node.js v0.10" to "Node.js 0.10". We dropped use of the "v" prefix in prose some time ago to avoid confusion as to whether "v8" referred to the V8 JavaScript engine or Node.js 8.x. PR-URL: https://github.com/nodejs/node/pull/33754 Reviewed-By:
-
antsmartian authored
PR-URL: https://github.com/nodejs/node/pull/33635 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Robert Nagy <ronagy@icloud.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
-
Anna Henningsen authored
In the benchmark, because it performs asynchronous operations before writing its HTTP replies, the underlying socket can be closed by the peer before the response is written. Since 28e6626c, that means that attempting to `.end()` the HTTP response results in an uncaught exception, breaking the benchmark. Fix that by checking whether the response object has been destroyed or not before attempting to call `.end()`. https://github.com/nodejs/node/issues/33591 PR-URL: https://github.com/nodejs/node/pull/33642 Reviewed-By:
-
Derek Lewis authored
Prior to this commit, C++ fenced code blocks in Markdown files had inconsistent info strings. This has been corrected to standarize on the one with the highest frequency in the doc/api/ dir. Stats: > 'cpp' => 19, > 'C++' => 6, > 'c++' => 3, PR-URL: https://github.com/nodejs/node/pull/33483 Reviewed-By:
-
Rich Trott authored
In the docs, we specify the default value of function parameters in the list below the header. There is one exception where we use default parameter notation. Change that instance to be like the rest of the docs instead. I rather like the default parameter notation, and I get why we didn't use it to begin with. (The notation didn't exist in JavaScript at the time.) I wouldn't mind switching to it, but that would result in big churn. That can be a separate topic of discussion. For now, though, let's get the docs consistent. PR-URL: https://github.com/nodejs/node/pull/33752 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/33727 Reviewed-By:
-
Sagar Jadhav authored
Convert callback functions that are anonymous to arrow functions for better readability. PR-URL: https://github.com/nodejs/node/pull/33711 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
-
Daniel Bevenius authored
This commit replaces the IsEmpty call to use ToLocal instead which allows for the following ToLocalChecked function call to be avoided. PR-URL: https://github.com/nodejs/node/pull/33695 Reviewed-By:
-
Daniel Bevenius authored
PR-URL: https://github.com/nodejs/node/pull/33683 Reviewed-By:
-
Nick Schonning authored
Related to https://github.com/nodejs/remark-preset-lint-node/pull/94 PR-URL: https://github.com/nodejs/node/pull/33692 Reviewed-By:
-
Rich Trott authored
Disable linting for prohibited strings in the collaborator list so that sam-github does not have to be sam-GitHub. Refs: https://github.com/nodejs/remark-preset-lint-node/pull/96 Signed-off-by:
Beth Griggs <Bethany.Griggs@uk.ibm.com>
-
- Jul 09, 2020
-
-
Sebastien Ahkrin authored
PR-URL: https://github.com/nodejs/node/pull/31205 Reviewed-By:
-
cjihrig authored
"occasionally" was spelled incorrectly. PR-URL: https://github.com/nodejs/node/pull/33677 Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
-
cjihrig authored
The other issue templates are wrapped at 80 characters. This commit updates the flaky test template to be consistent. PR-URL: https://github.com/nodejs/node/pull/33677 Reviewed-By:
-
Ben Noordhuis authored
PR-URL: https://github.com/nodejs/node/pull/33472 Reviewed-By:
-
Xu Meng authored
Since the PR https://github.com/libuv/libuv/pull/2753 has been landed, we need to revert the code change in PR https://github.com/nodejs/node/pull/32338. PR-URL: https://github.com/nodejs/node/pull/33629 Reviewed-By:
-
Ben Noordhuis authored
PR-URL: https://github.com/nodejs/node/pull/33602 Reviewed-By:
-
Anna Henningsen authored
This is not a big concern, because right now, all (non-test) inputs to the parser are `'\0'`-terminated, but we should be future-proof here and not perform these OOB reads. PR-URL: https://github.com/nodejs/node/pull/33640 Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
-
Lucas Holmquist authored
PR-URL: https://github.com/nodejs/node/pull/33590 Reviewed-By:
-
sapics authored
Replace redirected urls with the final ones. Replace http urls with https ones. PR-URL: https://github.com/nodejs/node/pull/33614 Reviewed-By:
-
Daniel Bevenius authored
This commit suggest using MaybeLocal.ToLocal and passing in the Local<String> node_opts. It also introduces a variable, arg_v8, of type Local<String> to enable the use of ToLocal. The motivation for doing this is that the following MaybeLocal::ToLocalChecked and MaybeLocal::FromMaybe calls can then be avoided. PR-URL: https://github.com/nodejs/node/pull/33599 Reviewed-By:
-
Gus Caplan authored
PR-URL: https://github.com/nodejs/node/pull/33597 Reviewed-By:
-
