- Sep 23, 2014
-
-
Calvin Metcalf authored
Expands the paragraph in the transform stream implementation docs about the callback that is passed to the _transform method to include details about how two arguments may be passed, error and data. A code example is also included. Reviewed-By:Fedor Indutny <fedor@indutny.com>
-
- Sep 18, 2014
-
-
cjihrig authored
Currently, a TypeError is incorrectly thrown if the second argument is an object. This commit allows the args argument to be properly omitted. Fixes: https://github.com/joyent/node/issues/6068 Reviewed-by:
Trevor Norris <trev.norris@gmail.com>
-
- Sep 17, 2014
-
-
Timothy J Fontaine authored
-
Timothy J Fontaine authored
-
Timothy J Fontaine authored
* npm: Update to 1.4.28 * v8: fix a crash introduced by previous release (Fedor Indutny) * configure: add --openssl-no-asm flag (Fedor Indutny) * crypto: use domains for any callback-taking method (Chris Dickinson) * http: do not send `0rnrn` in TE HEAD responses (Fedor Indutny) * querystring: fix unescape override (Tristan Berger) * url: Add support for RFC 3490 separators (Mathias Bynens)
-
Timothy J Fontaine authored
-
Fedor Indutny authored
When replying to a HEAD request, do not attempt to send the trailers and EOF sequence (`0\r\n\r\n`). The HEAD request MUST not have body. Quote from RFC: The presence of a message body in a response depends on both the request method to which it is responding and the response status code (Section 3.1.2). Responses to the HEAD request method (Section 4.3.2 of [RFC7231]) never include a message body because the associated response header fields (e.g., Transfer-Encoding, Content-Length, etc.), if present, indicate only what their values would have been if the request method had been GET (Section 4.3.1 of [RFC7231]). fix #8361 Reviewed-By:Timothy J Fontaine <tjfontaine@gmail.com>
-
Chris Dickinson authored
This adds domains coverage for pdbkdf2, pseudoRandomBytes, and randomBytes. All others should be covered by event emitters. Fixes #5801. Reviewed-By:Timothy J Fontaine <tjfontaine@gmail.com>
-
- Sep 16, 2014
-
-
Maciej Małecki authored
Fixes #6424. Reviewed-By:Fedor Indutny <fedor@indutny.com>
-
- Sep 15, 2014
-
-
Mathias Schreck authored
The behavior of the `node_modules` lookup algorithm was changed in #1177, but the documentation was not updated completely to describe the new behavior. The pseudocode of the lookup algorithm did not metion that `index.json` is tried to be loaded if you require a folder. Reviewed-By:Fedor Indutny <fedor@indutny.com>
-
- Sep 03, 2014
-
-
Fedor Indutny authored
see #8062 Reviewed-By:Trevor Norris <trev.norris@gmail.com>
-
Julien Gilli authored
PR #8034 came with a test to make sure that timers expiry is based on monotonic time and not on wall-clock time. However, a bug in the implementation broke timers with non-integer delays. A fix for this issue was provided with PR #8073, but it didn't come with a test. Because #8073 fixed a subtle issue that could reappear in the future, and because the impact of such an issue would be significant, I suggest adding this test. The test would timeout after 1 minute if the issue was reproduced. Otherwise it will run very quickly. Reviewed-By:Fedor Indutny <fedor@indutny.com>
-
- Aug 27, 2014
-
-
Mathias Bynens authored
There is no need to split the host by hand in `url.js` – Punycode.js takes care of it anyway. This not only simplifies the code, but also adds support for RFC 3490 separators (i.e. not just U+002E, but U+3002, U+FF0E, and U+FF61 as well). Closes #6055. Reviewed-By:Fedor Indutny <fedor@indutny.com>
-
Tristan Berger authored
Documentation states that `querystring.unescape` may be overridden to replace unescaper during parsing. However, the function was only being used as a fallback for when the native decoder throws (on a malformed URL). This patch moves the call to the native function and the try/catch around it into querystring.unescape then has the parser always invoke it, so that an override will always be used. Fixes #4055 Reviewed-By:Fedor Indutny <fedor@indutny.com>
-
Fedor Indutny authored
Should help addons use OpenSSL functions. Reviewed-By:Fedor Indutny <fedor@indutny.com>
-
Fedor Indutny authored
fix #8062
-
- Aug 22, 2014
-
-
Fedor Indutny authored
fd80a31e has introduced a segfault during redundant boundary check elimination (#8208). The problem consists of two parts: 1. Abscense of instruction iterator in `EliminateRedundantBoundsChecks`. It was present in recent v8, but wasn't considered important at the time of backport. However, since the function is changing instructions order in block, it is important to not rely at `i->next()` at the end of the loop. 2. Too strict ASSERT in `MoveIndexIfNecessary`. It is essentially a backport of a45c96ab from v8's upstream. See https://github.com/v8/v8/commit/a45c96ab for details. fix #8208
-
- Aug 20, 2014
-
-
Timothy J Fontaine authored
-
Timothy J Fontaine authored
-
- Aug 19, 2014
-
-
Timothy J Fontaine authored
* v8: backport CVE-2013-6668 * openssl: Update to v1.0.1i * npm: Update to v1.4.23 * cluster: disconnect should not be synchronous (Sam Roberts) * fs: fix fs.readFileSync fd leak when get RangeError (Jackson Tian) * stream: fix Readable.wrap objectMode falsy values (James Halliday) * timers: fix timers with non-integer delay hanging. (Julien Gilli)
-
Timothy J Fontaine authored
-
- Aug 18, 2014
-
-
Fedor Indutny authored
-
Fedor Indutny authored
This reverts commit 181b8a5d.
-
- Aug 17, 2014
-
-
Fedor Indutny authored
-
- Aug 14, 2014
-
-
Fedor Indutny authored
Original commit message: Fix Hydrogen bounds check elimination When combining bounds checks, they must all be moved before the first load/store that they are guarding. BUG=chromium:344186 LOG=y R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/172093002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@19475 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 fix #8070 -
Fedor Indutny authored
Original source: http://openssl.6102.n7.nabble.com/PATCH-s-client-Fix-keypress-requirement-with-redirected-input-on-Windows-td46787.html Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
Fedor Indutny authored
-
- Aug 08, 2014
-
-
Julien Gilli authored
Send messages until both the parent and the child process have received at least one message. If at least one of them doesn't receive any message, the test runner will make the test timeout. Fixes #8046.
-
Maciej Małecki authored
Fixes #6361.
-
Jackson Tian authored
-
- Aug 07, 2014
-
-
Kevin Simper authored
-
- Aug 05, 2014
-
-
Timothy J Fontaine authored
Supresses a very loud warning from GCC 4.8 about unused typedefs Original url https://codereview.chromium.org/69413002
-
Julien Gilli authored
When backporting f8193ab3 into v0.10, a regression was introduced. Timers with non-integer timeout could trigger a infinite recursion with 100% cpu usage. This commit backports 93b06246 which fixes the regression. After backporting f8193ab3, instead of using Date.now(), timers would use Timer.now() to determine if they had expired. However, Timer.now() is based on loop->time, which is not updated when a timer's remaining time is > 0 and < 1. Timers would thus never timeout if their remaining time was at some point > 0 and < 1. With this commit, Timer.now() updates loop->time itself, and timers always timeout eventually. Fixes #8065 and #8068.
-
- Aug 02, 2014
-
-
Sam Roberts authored
Callbacks in node are usually asynchronous, and should never be sometimes synchronous, and sometimes asynchronous. Reviewed-by:Trevor Norris <trev.norris@gmail.com>
-
James Halliday authored
A streams1 stream will have its falsy values such as 0, false, or "" eaten by the upgrade to streams2, even when objectMode is enabled. Include test for said cases. Reviewed-by:
isaacs <i@izs.me> Reviewed-by:
Trevor Norris <trev.norris@gmail.com>
-
- Aug 01, 2014
-
-
Jakob Gillich authored
Reviewed-By:Fedor Indutny <fedor@indutny.com>
-
Timothy J Fontaine authored
-
Timothy J Fontaine authored
-
Timothy J Fontaine authored
* uv: Upgrade to v0.10.28 * npm: Upgrade to v1.4.21 * v8: Interrupts must not mask stack overflow. * Revert "stream: start old-mode read in a next tick" (Fedor Indutny) * buffer: fix sign overflow in `readUIn32BE` (Fedor Indutny) * buffer: improve {read,write}{U}Int* methods (Nick Apperson) * child_process: handle writeUtf8String error (Fedor Indutny) * deps: backport 4ed5fde4f from v8 upstream (Fedor Indutny) * deps: cherry-pick eca441b2 from OpenSSL (Fedor Indutny) * lib: remove and restructure calls to isNaN() (cjihrig) * module: eliminate double `getenv()` (Maciej Małecki) * stream2: flush extant data on read of ended stream (Chris Dickinson) * streams: remove unused require('assert') (Rod Vagg) * timers: backport f8193ab3 (Julien Gilli) * util.h: interface compatibility (Oguz Bastemur) * zlib: do not crash on write after close (Fedor Indutny) -
Timothy J Fontaine authored
-