- Jul 22, 2020
-
-
Ruy Adorno authored
The "Labels" section of doc/guides/onboarding-extras.md was missing a reference to the `author-ready` label. This commit adds a description similar to the definition found in doc/guides/collaborator-guide.md with the goal of making it easier for new contributors to find labels info all in one place. PR-URL: https://github.com/nodejs/node/pull/34381 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
Anna Henningsen authored
This prevents accidental resource leaks when terminating or exiting Worker that own FDs opened through `fs.open()`. Refs: https://github.com/nodejs/node/pull/34303 PR-URL: https://github.com/nodejs/node/pull/34394 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Joyee Cheung authored
Otherwise the build would fail with `./configure --experimental-quic --ninja` as the list of per-Environment values would not match and the code cache builder would not generate code cache for the quic JS sources. This is more or less a band-aid - a proper fix would be to aggregate these flags into something that can be included by all these different binary targets. See https://github.com/nodejs/node/issues/31074. PR-URL: https://github.com/nodejs/node/pull/34454 Fixes: https://github.com/nodejs/node/issues/34435 Reviewed-By:
Jiawen Geng <technicalcute@gmail.com>
-
Harshitha K P authored
Fixes: https://github.com/nodejs/node/issues/34242 PR-URL: https://github.com/nodejs/node/pull/34417 Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com>
-
Andrey Pechkurov authored
PR-URL: https://github.com/nodejs/node/pull/34048 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/34420 Reviewed-By:
-
Anna Henningsen authored
In the termination case, we should not crash. There’s also no harm being done by ignoring the termination exception here, since the thread is about to be torn down anyway. Also, add a guard against running this during shutdown. That is the likely cause of https://github.com/nodejs/node/issues/34361. Fixes: https://github.com/nodejs/node/issues/34361 PR-URL: https://github.com/nodejs/node/pull/34362 Fixes: https://github.com/nodejs/node/issues/27261 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
-
Anna Henningsen authored
Creating a new function each time the property descriptor is set comes with performance overhead, since these functions have different identities, even if they contain the same code. Refs: https://twitter.com/tverwaes/status/1285496612618473472 PR-URL: https://github.com/nodejs/node/pull/34459 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
-
Myles Borins authored
Notable changes: deps: * upgrade npm to 6.14.6 (claudiahdz) https://github.com/nodejs/node/pull/34246 * upgrade to libuv 1.38.1 (Colin Ihrig) https://github.com/nodejs/node/pull/34187 * (SEMVER-MINOR) update V8 to 8.4.371.19 (Michaël Zasso) [#33579](https://github.com/nodejs/node/pull/33579) module: * (SEMVER-MINOR) deprecate module.parent (Antoine du HAMEL) https://github.com/nodejs/node/pull/32217 * (SEMVER-MINOR) package "imports" field (Guy Bedford) https://github.com/nodejs/node/pull/34117 src: * (SEMVER-MINOR) add option to track unmanaged file descriptors (Anna Henningsen) https://github.com/nodejs/node/pull/34303 * (SEMVER-MINOR) allow embedders to disable esm loader (Shelley Vohr) https://github.com/nodejs/node/pull/34060 tls: * (SEMVER-MINOR) make 'createSecureContext' honor more options (Mateusz Krawczuk) https://github.com/nodejs/node/pull/33974 vm: * (SEMVER-MINOR) add run-after-evaluate microtask mode (Anna Henningsen) https://github.com/nodejs/node/pull/34023 worker: * (SEMVER-MINOR) add option to track unmanaged file descriptors (Anna Henningsen) https://github.com/nodejs/node/pull/34303 New Collaborators: * add danielleadams to collaborators (Danielle Adams) https://github.com/nodejs/node/pull/34360 * add sxa as collaborator (Stewart X Addison) https://github.com/nodejs/node/pull/34338 * add ruyadorno to collaborators (Ruy Adorno) https://github.com/nodejs/node/pull/34297 PR-URL: https://github.com/nodejs/node/pull/34371
-
Anna Henningsen authored
Refs: https://github.com/nodejs/node/pull/34454 PR-URL: https://github.com/nodejs/node/pull/34460 Reviewed-By:
David Carlier <devnexen@gmail.com>
-
Shelley Vohr authored
PR-URL: https://github.com/nodejs/node/pull/34464 Reviewed-By:
-
Robert Nagy authored
Ensures that _construct has finished before invoking _destroy. The 'constructed' property was not properly set to false for both writable and readable state. Fixes: https://github.com/nodejs/node/issues/34448 PR-URL: https://github.com/nodejs/node/pull/34456 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
- Jul 21, 2020
-
-
Richard Lau authored
Notable changes: - deps: - upgrade npm to 6.14.6 (claudiahdz) https://github.com/nodejs/node/pull/34246 - upgrade openssl sources to 1.1.1g (Hassaan Pasha) https://github.com/nodejs/node/pull/32982 - n-api: - add `napi_detach_arraybuffer` (legendecas) https://github.com/nodejs/node/pull/29768 PR-URL: https://github.com/nodejs/node/pull/34170 -
Shelley Vohr authored
PR-URL: https://github.com/nodejs/node/pull/34387 Reviewed-By:
-
Pranshu Srivastava authored
Fixes: https://github.com/nodejs/node/issues/34121 PR-URL: https://github.com/nodejs/node/pull/34457 Reviewed-By:
-
Pekka Nikander authored
Add IPv6 link local scope ID suffix to the rinfo address in those received upd6 datagrams whose source address is a link local address. Add a new test case, test-dgram-udp6-link-local-address, to verify that IPv6 UDP datagrams received from a link-local source address do contain the scope ID suffix in the rinfo address field. When a packet is received from a link-local source address, if the address does not contain the scope ID suffix, it is impossible to reply back to the sender, as the kernel is not able to determine the right network interface to send the packet through and returns with an error. Ref: https://github.com/nodejs/node/issues/1649 PR-URL: https://github.com/nodejs/node/pull/14500 Refs: https://github.com/nodejs/node/issues/1649 Reviewed-By:
Stewart X Addison <sxa@uk.ibm.com>
-
cjihrig authored
Update ESLint to 7.5.0 PR-URL: https://github.com/nodejs/node/pull/34423 Reviewed-By:
Michaël Zasso <targos@protonmail.com>
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/34424 Reviewed-By:
-
Anna Henningsen authored
This ensures that microtasks scheduled by native immediates are run after the tasks are done. In particular, this affects the inspector integration since 6f9f5464. Fixes: https://github.com/nodejs/node/issues/33002 Refs: https://github.com/nodejs/node/pull/32523 PR-URL: https://github.com/nodejs/node/pull/34366 Reviewed-By:
-
Antoine du Hamel authored
Remove the "Current" label for Node.js 13 in the CHANGELOG. PR-URL: https://github.com/nodejs/node/pull/34436 Reviewed-By:
Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By:
-
Jucke authored
PR-URL: https://github.com/nodejs/node/pull/34419 Reviewed-By:
-
Jucke authored
PR-URL: https://github.com/nodejs/node/pull/34419 Reviewed-By:
-
sapics authored
PR-URL: https://github.com/nodejs/node/pull/33718 Reviewed-By:
-
AshCripps authored
Add a flag that allows for the setting of a directory where all diagnostic output will be written to. e.g. --redirect-warnings Refs: https://github.com/nodejs/node/pull/33010#issuecomment-618544792 PR-URL: https://github.com/nodejs/node/pull/33584 Reviewed-By:
-
Ruben Bridgewater authored
This makes sure the common path does not normalize the input string. It's only required for characters that are outside of the ASCII range. Signed-off-by:
Ruben Bridgewater <ruben@bridgewater.de> PR-URL: https://github.com/nodejs/node/pull/33674 Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com>
-
Anna Henningsen authored
The result of an async IIFE should always be handled in our tests, typically by adding `.then(common.mustCall())` to verify that the async function actually finishes executing at some point. PR-URL: https://github.com/nodejs/node/pull/34363 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
-
Anna Henningsen authored
This makes sure that all async functions finish as expected. PR-URL: https://github.com/nodejs/node/pull/34363 Reviewed-By:
-
Myles Borins authored
This reverts commit 51af89fe. This has needed to be backed out of both the 14.5.0 and 14.6.0 releases due to creating regressions across multiple projects including: * coffeescript * JSONStream * gulp * and more We should reopen a PR to figure out how to land this in a way that is non-breaking. Refs: https://github.com/nodejs/node/pull/33476 PR-URL: https://github.com/nodejs/node/pull/34403 Reviewed-By:
Guy Bedford <guybedford@gmail.com> Reviewed-By:
Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By:
-
- Jul 20, 2020
-
-
Richard Lau authored
Add Richard Lau and his Release key. Signed-off-by:
-
Rich Trott authored
Replace stream.respondWithFile(__filename) with stream.respondWithFile(process.execPath). The test file is probably small enough on some operating systems to be sent immediately, without waiting for the receiving side to do anything. The fix was figured out by addaleax. Co-authored-by:
-
- Jul 19, 2020
-
-
Rich Trott authored
In one place, the fs docs use `previousStat` for an argument that is identified as `previous` everywhere else. Use `previous` for consistency. PR-URL: https://github.com/nodejs/node/pull/34405 Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/34329 Reviewed-By:
-
Tobias Nießen authored
Refs: https://github.com/nodejs/node-v0.x-archive/pull/6900 Refs: https://github.com/nodejs/node-v0.x-archive/issues/6889 PR-URL: https://github.com/nodejs/node/pull/34323 Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/34325 Reviewed-By:
-
Tobias Nießen authored
Refs: https://github.com/nodejs/node/issues/33715 PR-URL: https://github.com/nodejs/node/pull/34294 Reviewed-By:
-
Gireesh Punathil authored
The role helps triaging issue backlogs effectively Fixes: https://github.com/nodejs/node/issues/34054 Refs: https://github.com/nodejs/TSC/pull/891 PR-URL: https://github.com/nodejs/node/pull/34295 Reviewed-By:
-
Rich Trott authored
Sure, I'm advocating for permitting second-person pronouns in a current PR, but the use in errors.md is superfluous and weakens the sentence. Remove it. PR-URL: https://github.com/nodejs/node/pull/34390 Reviewed-By:
-
- Jul 18, 2020
-
-
Joyee Cheung authored
This runs `lib/internal/bootstrap/node.js` before creating the builtin snapshot and deserialize the loaders from the snapshot in deserialization mode. PR-URL: https://github.com/nodejs/node/pull/32984 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com>
-
Joyee Cheung authored
Since V8 snapshot does not currently support instance member initialization, initialize them in ordianry class constructors for now so that these classes can be included in the snapshot. This may be reverted once https://bugs.chromium.org/p/v8/issues/detail?id=10704 is fixed and backported. PR-URL: https://github.com/nodejs/node/pull/32984 Reviewed-By:
-
Joyee Cheung authored
Fast APIs need to work with ArrayBuffers which we need to rebuild connections to after deserializing them from the snapshot. For now, postpone their creation until pre-execution to simplify the process. PR-URL: https://github.com/nodejs/node/pull/32984 Reviewed-By:
-
