- Jan 15, 2016
-
-
Jackson Tian authored
Add a bytesRead property for readable is useful in some use cases. When user want know how many bytes read of readable, need to caculate it in userland. If encoding is specificed, get the value is very slowly. PR-URL: https://github.com/nodejs/node/pull/4372 Reviewed-By:
Trevor Norris <trev.norris@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Fedor Indutny authored
Clean up OpenSSL error stack in `ECDH::Initialize`, some curves have faulty implementations that are leaving dangling errors after initializing the curve. Fix: #4686 PR-URL: https://github.com/nodejs/node/pull/4689 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Shigeki Ohtsu <ohtsu@iij.ad.jp>
-
Claudio Rodriguez authored
Documents the "path" property on fs.WriteStream and fs.ReadStream. See #4327 PR-URL: https://github.com/nodejs/node/pull/4368 Reviewed-By:
-
Vitor Cortez authored
The last sentence of the explanation for the first stream section seemed a bit confusing. I tried to change the sentence to clarify it. Additionally, the sections were turned into a numbered list to be more clear about which section is being described, and improve readability. PR-URL: https://github.com/nodejs/node/pull/4234 Reviewed-By:
-
- Jan 14, 2016
-
-
julien.waechter authored
This changes vcbuild.bat to accept a new parameter (vc2015 or vc2013) to select the version of Visual Studio to use. PR-URL: https://github.com/nodejs/node/pull/4645 Reviewed-By:
João Reis <reis@janeasystems.com>
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/4194 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/4194 Reviewed-By:
-
Rod Vagg authored
instead of doc-* PR-URL: https://github.com/nodejs/node/pull/4412 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Johan Bergström <bugs@bergstroem.nu>
-
Santiago Gimeno authored
There is no guarantee that the `suicide` property of a worker in the master process is going to be set when the `disconnect` and `exit` events are emitted. To fix it, wait for the ACK of the suicide message from the master before disconnecting the worker. Also, there's no need to send the suicide message from the worker if the disconnection has been initiated in the master. Add `test-cluster-disconnect-suicide-race` that forks a lot of workers to consistently reproduce the issue this patch tries to solve. Modify `test-regress-GH-3238` so it checks both the `kill` and `disconnect` cases. Also take into account that the `disconnect` event may be received after the `exit` event. PR-URL: https://github.com/nodejs/node/pull/4349 Reviewed-By:
-
Jérémy Lal authored
PR-URL: https://github.com/nodejs/node/pull/4680 Reviewed-By:
-
Michaël Zasso authored
Replace var keyword with const or let. PR-URL: https://github.com/nodejs/io.js/pull/2286 Reviewed-By:
Roman Reiss <me@silverwind.io>
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/io.js/pull/2286 Reviewed-By:
-
Michaël Zasso authored
With an indentation style of two spaces, it is not possible to indent multiline variable declarations by four spaces. Instead, the var keyword is used on every new line. Use const instead of var where applicable for changed lines. PR-URL: https://github.com/nodejs/io.js/pull/2286 Reviewed-By:
-
Michaël Zasso authored
The no-reserved-keys rule doesn't exist anymore and we don't need ES3 compatibility. escape and unescape are now known by eslint. --reset flag was removed and it is now the default behavior. PR-URL: https://github.com/nodejs/io.js/pull/2286 Reviewed-By:
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/io.js/pull/2286 Reviewed-By:
-
Michaël Zasso authored
On case-insensitive platorms, the Debug/ rule catches the debug module under npm and eslint. PR-URL: https://github.com/nodejs/node/pull/2286 Reviewed-By:
-
Julien Gilli authored
Clear domains stack __even if no domain error handler is set__ so that code running in the process' uncaughtException handler, or any code that may be executed when an error is thrown and not caught and that is not the domain's error handler, doesn't run in the context of the domain within which the error was thrown. PR: #4659 PR-URL: https://github.com/nodejs/node/pull/4659 Reviewed-By:
-
Rich Trott authored
In test-cluster-worker-wait-server-close, remove unneeded 1-second delay and refactor to eliminate flakiness on FreeBSD. PR-URL: https://github.com/nodejs/node/pull/4616 Reviewed-By:
-
Roman Klauke authored
The child_process docs contained some links, but some links were somehow "broken". `make doc` couldn't translate them and left `[]` in the compiled HTML. PR-URL: https://github.com/nodejs/node/pull/4654 Reviewed-By:
-
Brian White authored
Reassigning a named parameter while also using the arguments object causes the entire function to never be optimized. PR-URL: https://github.com/nodejs/node/pull/4613 Reviewed-By:
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/4667 Reviewed-By:
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/4666 Reviewed-By:
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/4665 Reviewed-By:
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/4664 Reviewed-By:
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/4663 Reviewed-By:
-
cjihrig authored
Prior to this commit, the test was flaky because it was executing the majority of its logic in a function called from the client and multiple events on the server. This commit simplifies the test by separating the server's connection and listening events, and isolating the client logic. Refs: https://github.com/nodejs/node/pull/4476 Refs: https://github.com/nodejs/node/pull/4644 PR-URL: https://github.com/nodejs/node/pull/4650 Reviewed-By:
-
Rich Trott authored
A 50ms timeout results in a race condition. Instead, enforce expected order through callbacks. This has the side effect of speeding up the test in most situations. Ref: https://github.com/nodejs/node/pull/4476 PR-URL: https://github.com/nodejs/node/pull/4637 Reviewed-By:
-
Ryan Sobol authored
PR-URL: https://github.com/nodejs/node/pull/4504 Reviewed-By:
Sam Roberts <vieuxtech@gmail.com>
-
Myles Borins authored
Original key did not have personal information associated with it. The new key rectifies this problem PR-URL: https://github.com/nodejs/node/pull/4657 Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
-
Myles Borins authored
PR-URL: https://github.com/nodejs/node/pull/4656 Reviewed-By:
-
Daniel Sellers authored
Now returns a 417 error status or allows for an event listener on the `checkExpectation` event. Before we were ignoring requests that had misspelled `100-continue` values for expect headers. This is a quick port of the work done here: https://github.com/nodejs/node-v0.x-archive/pull/7132 by alFReD-NSH with surrounding discussion here: https://github.com/nodejs/node-v0.x-archive/issues/4651 Also updates all the instances of the deprecated EventEmitter.listenerCount to the current self.listenerCount. Most of these were in the new code ported over but there was another legacy instance. Refs: #2403 PR-URL: https://github.com/nodejs/node/pull/4501 Reviewed-By:
-
- Jan 13, 2016
-
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/4192 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/4192 Reviewed-By:
-
Rich Trott authored
To enable greater parallelization of tests on CI, move resource intensive tests out of parallel and into sequential. Ref: https://github.com/nodejs/node/pull/4476 PR-URL: https://github.com/nodejs/node/pull/4615 Reviewed-By:
-
Myles Borins authored
Notable Changes: * Minor performance improvements: - module: move unnecessary work for early return (Andres Suarez) https://github.com/nodejs/node/pull/3579 * Various bug fixes * Various doc fixes * Various test improvements PR-URL: https://github.com/nodejs/node/pull/4626 Reviewed-By:
-
zoubin authored
PR-URL: https://github.com/nodejs/node/pull/4639 Reviewed-By:
Chris Dickinson <chris@neversaw.us>
-
Myles Borins authored
Useful to have for reference, especially for onboarding PR-URL: https://github.com/nodejs/node/pull/4636 Reviewed-By:
James M <Snell<jasnell@gmail.com>
-
Ben Noordhuis authored
Use internalModuleReadFile() to read the file from disk to avoid the fs.fstatSync() call that fs.readFileSync() makes. It does so to know the file size in advance so it doesn't have to allocate O(n) buffers when reading the file from disk. internalModuleReadFile() is plenty efficient though, even more so because we want a string and not a buffer. This way we also don't allocate a buffer that immediately gets thrown away again. This commit reduces the number of fstat() system calls in a benchmark application[0] from 549 to 29, all made by the application itself. [0] https://github.com/strongloop/loopback-sample-app PR-URL: https://github.com/nodejs/node/pull/4575 Reviewed-By:
-
Ben Noordhuis authored
Avoid an unneeded ArgumentsAdaptorTrampoline stack frame by passing the the right number of arguments to Module._load() in Module.require(). Shortens the following stack trace with one frame: LazyCompile:~Module.load module.js:345 LazyCompile:Module._load module.js:282 Builtin:ArgumentsAdaptorTrampoline LazyCompile:*Module.require module.js:361 LazyCompile:*require internal/module.js:11 PR-URL: https://github.com/nodejs/node/pull/4575 Reviewed-By: -
Ben Noordhuis authored
Reduce the number of stat() system calls that require() makes by caching the results more aggressively. To avoid unbounded growth without implementing a LRU cache, scope the cache to the lifetime of the first call to require(). Recursive calls (i.e. require() calls in the included code) transparently profit from the cache. The benchmarked application is the loopback-sample-app[0] and it sees the number of stat calls at start-up go down by 40%, from 4736 to 2810. [0] https://github.com/strongloop/loopback-sample-app PR-URL: https://github.com/nodejs/node/pull/4575 Reviewed-By:
-
