- Oct 27, 2020
-
-
Daijiro Wachi authored
Refs: https://github.com/web-platform-tests/wpt/pull/25988 Refs: https://github.com/web-platform-tests/wpt/pull/26158 PR-URL: https://github.com/nodejs/node/pull/35794 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
- Oct 29, 2020
-
-
Benjamin Gruenbaum authored
The AbortController abort event is trusted, currently we fire all events with isTrusted: false. Allow dispatching events internally with `isTrusted: true` and add a test for it. Co-Authored-By:
ExE Boss <3889017+ExE-Boss@users.noreply.github.com> Fixes: https://github.com/nodejs/node/issues/35748 PR-URL: https://github.com/nodejs/node/pull/35811 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
- Oct 28, 2020
-
-
Luigi Pinca authored
Fixes: https://github.com/nodejs/node/issues/35762 PR-URL: https://github.com/nodejs/node/pull/35805 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net>
-
Rich Trott authored
* button -> key * apply missing kbd element * revise "Recoverable errors" text for brevity and clarity PR-URL: https://github.com/nodejs/node/pull/35808 Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Andrey Pechkurov authored
Refs: #25436 PR-URL: https://github.com/nodejs/node/pull/35753 Refs: https://github.com/nodejs/node/pull/25436 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Minwoo Jung <nodecorelab@gmail.com>
-
Anna Henningsen authored
Refs: https://github.com/nodejs/node/pull/34057 Refs: https://github.com/nodejs/node/issues/35835 PR-URL: https://github.com/nodejs/node/pull/35839 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Matthew Francis Brunetti authored
The new event signals that the subprocess has spawned successfully and no 'error' event will be emitted from failing to spawn. Fixes: https://github.com/nodejs/node/issues/35288 PR-URL: https://github.com/nodejs/node/pull/35369 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
Daniel Bevenius authored
This commit suggests removing the ERR prefix in the WebCryptoKeyExportStatus enum. The motivation for this is that I think it improves the readability of the code. For example, the following line had me look twice to see what was going on: case WebCryptoKeyExportStatus::ERR_OK: // Success! PR-URL: https://github.com/nodejs/node/pull/35639 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
Pooja D.P authored
PR-URL: https://github.com/nodejs/node/pull/35624 Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
- Oct 27, 2020
-
-
Richard Lau authored
Notable changes: This release marks the transition of Node.js 14.x into Long Term Support (LTS) with the codename 'Fermium'. The 14.x release line now moves into "Active LTS" and will remain so until October 2021. After that time, it will move into "Maintenance" until end of life in April 2023. PR-URL: https://github.com/nodejs/node/pull/35746
-
Richard Lau authored
Notable changes: - deps: - upgrade npm to 6.14.8 (Ruy Adorno) https://github.com/nodejs/node/pull/34834 - n-api: - create N-API version 7 (Gabriel Schulhof) https://github.com/nodejs/node/pull/35199 - expose napi_build_version variable (NickNaso) https://github.com/nodejs/node/pull/27835 - tools: - add debug entitlements for macOS 10.15+ (Gabriele Greco) https://github.com/nodejs/node/pull/34378 PR-URL: https://github.com/nodejs/node/pull/35544 -
Daijiro Wachi authored
Refs: https://github.com/web-platform-tests/wpt/pull/26126 PR-URL: https://github.com/nodejs/node/pull/35792 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Rich Trott authored
Update documentation and test comment for v8.cachedDataVersionTag(). PR-URL: https://github.com/nodejs/node/pull/35795 Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/35787 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Michael Dawson authored
Fixes: https://github.com/nodejs/node/issues/35620 This reverts commit a6b655614f03e073b9c60f3d71ed884c5af32ffc which changed finalization behavior related to N-API. We will investigate the original issue with the test separately. PR-URL: https://github.com/nodejs/node/pull/35777 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By:
Chengzhong Wu <legendecas@gmail.com> Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de>
-
Trevor Norris authored
Allow calling eventLoopUtilization() directly on a worker thread: const worker = new Worker('./foo.js'); const elu = worker.performance.eventLoopUtilization(); setTimeout(() => { worker.performance.eventLoopUtilization(elu); }, 10); Add a new performance object on the Worker instance that will hopefully one day hold all the other performance metrics, such as nodeTiming. Include benchmarks and tests. PR-URL: https://github.com/nodejs/node/pull/35664 Reviewed-By:Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Robert Nagy authored
When rawHeaders is enough don't create the headers object. PR-URL: https://github.com/nodejs/node/pull/35281 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Alejandro Oviedo authored
PR-URL: https://github.com/nodejs/node/pull/35790 Reviewed-By:
Robert Nagy <ronagy@icloud.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Pooja D.P authored
PR-URL: https://github.com/nodejs/node/pull/35718 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
Michaël Zasso authored
This adds support for nullish coalescing, optional chaining and numeric separators. The acorn-numeric-separator plugin can be removed. PR-URL: https://github.com/nodejs/node/pull/35791 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Shelley Vohr <codebytere@gmail.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com>
-
raisinten authored
PR-URL: https://github.com/nodejs/node/pull/35807 Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
- Oct 26, 2020
-
-
Daniel Bevenius authored
This reverts Commit 3ff2aece ("src: ignore GCC -Wcast-function-type for v8.h") and Commit 2462a2c5 ("src: fix ignore GCC -Wcast-function-type for older compilers") as this has now been included in the V8 version being used. PR-URL: https://github.com/nodejs/node/pull/35768 Refs: https://github.com/v8/v8/commit/f08cbfdc4051266e4200b6e26775d35307b1259b Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Minwoo Jung <nodecorelab@gmail.com> Reviewed-By:
David Carlier <devnexen@gmail.com>
-
Daniel Bevenius authored
PR-URL: https://github.com/nodejs/node/pull/35716 Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
David Carlier <devnexen@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Daniel Bevenius authored
This reverts commit f21cf456 as this has now been included in the V8 version being used. PR-URL: https://github.com/nodejs/node/pull/35758 Refs: https://github.com/v8/v8/commit/f08cbfdc4051266e4200b6e26775d35307b1259b Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Denys Otrishko <shishugi@gmail.com> Reviewed-By:
David Carlier <devnexen@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Pooja D.P authored
PR-URL: https://github.com/nodejs/node/pull/35554 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Harshitha K P <harshitha014@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
Pooja D.P authored
PR-URL: https://github.com/nodejs/node/pull/35517 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
bcoe authored
Turns off coverage comments for the time being, until we can sort out issues. PR-URL: https://github.com/nodejs/node/pull/35800 Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
Stephen Belanger <admin@stephenbelanger.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Rich Trott authored
The kbd element has already been added in the keybindings table, but we missed it in one line in the prose. PR-URL: https://github.com/nodejs/node/pull/35737 Reviewed-By:
Roman Reiss <me@silverwind.io> Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
-
Shubham Parihar authored
PR-URL: https://github.com/nodejs/node/pull/35786 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
Ricky Zhou <0x19951125@gmail.com>
-
- Oct 25, 2020
-
-
bcoe authored
Cleanup logic in Makefile for coverage. Update BUILDING.md accordingly. PR-URL: https://github.com/nodejs/node/pull/35767 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com>
-
ax1 authored
Indentation for #fs_fs_promises_api is level 2 but it should be level 3. PR-URL: https://github.com/nodejs/node/pull/35771 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
Rich Trott authored
Remove note indicating that the APIs can change at any time. This module migrated from Experimental to Stable 6 years ago (in io.js 1.4.2). PR-URL: https://github.com/nodejs/node/pull/35774 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com>
-
Vse Mozhe Buty authored
PR-URL: https://github.com/nodejs/node/pull/35764 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com>
-
Yash Ladha authored
Using the variable name in the comment and justifying the type seems redundant to me and instead it should defined the entity which it is acting, like in our case it is acting as a flag to control the flow in streams. PR-URL: https://github.com/nodejs/node/pull/35728 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Robert Nagy <ronagy@icloud.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com>
-
Turner Jabbour authored
PR-URL: https://github.com/nodejs/node/pull/35437 Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Pooja D.P authored
example code added to the process.setgroups() API doc property in process.md PR-URL: https://github.com/nodejs/node/pull/35738 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
Momtchil Momtchev authored
We reinject when the sockets has already waiting data, remarked by @mildsunrise Co-authored-by:
Alba Mendez <me@alba.sh> PR-URL: https://github.com/nodejs/node/pull/35678 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Alba Mendez <me@alba.sh> Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By:
Ricky Zhou <0x19951125@gmail.com>
-
Momtchil Momtchev authored
Reinject the data already received from the TLS socket when the HTTP2 client is attached with a delay Fixes: https://github.com/nodejs/node/issues/35475 PR-URL: https://github.com/nodejs/node/pull/35678 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Alba Mendez <me@alba.sh> Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By:
Ricky Zhou <0x19951125@gmail.com>
-
Vincent Boivin authored
Allow the user to update the server settings after using http2.createSecureServer() or after using http2.createServer(). Fixes: https://github.com/nodejs/node/issues/35353 PR-URL: https://github.com/nodejs/node/pull/35383 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Denys Otrishko <shishugi@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By:
Ricky Zhou <0x19951125@gmail.com>
-
ExE Boss authored
Fixes: https://github.com/nodejs/node/issues/35740 Refs: https://github.com/nodejs/node/pull/31553 Refs: https://github.com/nodejs/node/pull/32953 Refs: https://github.com/nodejs/node/pull/33991 Refs: https://github.com/nodejs/node/pull/34001 Refs: https://github.com/nodejs/node/pull/34055 Refs: https://github.com/nodejs/node/pull/34962 Co-authored-by:
Antoine du Hamel <duhamelantoine1995@gmail.com> Co-authored-by:
Trivikram Kamat <trivikr.dev@gmail.com> Co-authored-by:
Rich Trott <rtrott@gmail.com> PR-URL: https://github.com/nodejs/node/pull/34002 Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Masashi Hirano <shisama07@gmail.com> Reviewed-By:
Pranshu Srivastava <rexagod@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com>
-