- Mar 02, 2013
-
-
isaacs authored
-
- Mar 01, 2013
-
-
Ben Noordhuis authored
Register the 'close' event listener with .once(), not .on(). It doesn't matter in the grand scheme of things because the listener doesn't keep references to any heavy-weight objects but using .once() for a oneshot listener is something of a best practice.
-
Eugene Girshov authored
-
Timothy J Fontaine authored
Test output is always \n and not platform dependent
-
- Feb 28, 2013
-
-
Ben Noordhuis authored
Turn off safe exception handlers, they're incompatible with how openssl is compiled / linked under MSVS 2012. Addresses the following build error: openssl.lib(x86cpuid.obj) : error LNK2026: module unsafe for SAFESEH image. [g:\jenkins\workspace\nodejs-oneoff\node.vcxproj] openssl.lib(x86.obj) : error LNK2026: module unsafe for SAFESEH image. [g:\jenkins\workspace\nodejs-oneoff\node.vcxproj] # etc. etc. g:\jenkins\workspace\nodejs-oneoff\Release\node.exe : fatal error LNK1281: Unable to generate SAFESEH image. [g:\jenkins\workspace\nodejs-oneoff\node.vcxproj] Fixes #4242.
-
Ben Noordhuis authored
Document how to run the example on the home page in more detail. Apparently our Windows brethren are prone to double-clicking on the binary instead of running it from the command line. Fixes #4854.
-
- Feb 26, 2013
-
-
isaacs authored
-
isaacs authored
-
isaacs authored
-
isaacs authored
-
isaacs authored
-
isaacs authored
* http: Do not free the wrong parser on socket close (isaacs) * http: Handle hangup writes more gently (isaacs) * zlib: fix assert on bad input (Ben Noordhuis) * test: add TAP output to the test runner (Timothy J Fontaine) * unix: Handle EINPROGRESS from domain sockets (Ben Noordhuis)
-
isaacs authored
-
isaacs authored
This appears to fix #4673. That bug is very hard to reproduce, so it's hard to tell for certain, but this approach is more correct anyway. Hat-tip: @dougwilson
-
- Feb 23, 2013
-
-
isaacs authored
-
- Feb 22, 2013
-
-
Ben Noordhuis authored
Fixes #4808.
-
Ben Noordhuis authored
The following test case occasionally triggered an assert because write_in_progress_ didn't get cleared on error: $ cat test.js require('zlib').gunzip('BAM', console.log); setTimeout(gc, 10); $ while true; do node --expose-gc test.js || break; done { [Error: incorrect header check] errno: -3, code: 'Z_DATA_ERROR' } Assertion failed: (!write_in_progress_ && "write in progress"), function Clear, file ../src/node_zlib.cc, line 71. Abort trap: 6 Steps to avoid that: * Initialize all primitive member fields in the constructor. * Clear the write_in_progress_ member field in ZCtx::Error(). * Ref the ZCtx object as soon as write_in_progress_ is set to true. Before this commit, it could get GC'ed in the time between setting the field and the call to ctx->Ref(). Fixes #4783.
-
- Feb 21, 2013
-
-
Timothy J Fontaine authored
This is a back-port of commit 14ed1732 from the master branch.
-
- Feb 20, 2013
-
-
isaacs authored
-
- Feb 16, 2013
- Feb 15, 2013
-
-
isaacs authored
Fix #4373
-
isaacs authored
Prior to v0.10, Node ignored ECONNRESET errors in many situations. There *are* valid cases in which ECONNRESET should be ignored as a normal part of the TCP dance, but in many others, it's a very relevant signal that must be heeded with care. Exacerbating this problem, if the OutgoingMessage does not have a req.connection._handle, it assumes that it is in the process of connecting, and thus buffers writes up in an array. The problem happens when you reuse a socket between two requests, and it is destroyed abruptly in between them. The writes will be buffered, because the socket has no handle, but it's not ever going to GET a handle, because it's not connecting, it's destroyed. The proper fix is to treat ECONNRESET correctly. However, this is a behavior/semantics change, and cannot land in a stable branch. Fix #4775
-
Ben Noordhuis authored
It only works for stdin, not stdout/stderr, for obvious reasons.
-
- Feb 14, 2013
-
-
Ben Noordhuis authored
-
- Feb 13, 2013
-
-
Dan Kohn authored
Running repl.start without the prompt set produces this error: repl.js:95 throw new Error('An options Object, or a prompt String are required'); ^ Error: An options Object, or a prompt String are required at new REPLServer (repl.js:95:11) at Object.exports.start (repl.js:321:14) at Object.<anonymous> (/Users/dan/Dropbox/Documents/dev/nextgen/repl_test.js:5:6) at Module._compile (module.js:449:26) at Object.Module._extensions..js (module.js:467:10) at Module.load (module.js:356:32) at Function.Module._load (module.js:312:12) at Module.runMain (module.js:492:10) at process.startup.processNextTick.process._tickCallback (node.js:244:9) -
isaacs authored
-
isaacs authored
Thanks, @domenic
-
- Feb 08, 2013
-
-
Ben Noordhuis authored
It's not a good citizen, it spams random IP addresses with UDP packets. Fixes #4730.
-
isaacs authored
-
isaacs authored
-
- Feb 07, 2013
-
-
Bert Belder authored
This patch is a back-port of 3c293ba2. Closes #4696
-
isaacs authored
-
isaacs authored
-
isaacs authored
-
isaacs authored
* npm: Upgrade to v1.2.10 * zlib: pass object size hint to V8 (Ben Noordhuis) * zlib: reduce memory consumption, release early (Ben Noordhuis) * buffer: slow buffer copy compatibility fix (Trevor Norris) * zlib: don't assert on malformed dictionary (Ben Noordhuis) * zlib: don't assert on missing dictionary (Ben Noordhuis) * windows: better ipv6 support (Bert Belder) * windows: add error mappings related to unsupported protocols (Bert Belder) * windows: map ERROR_DIRECTORY to UV_ENOENT (Bert Belder)
-
isaacs authored
-