1. Mar 02, 2013
  2. Mar 01, 2013
  3. Feb 28, 2013
    • Ben Noordhuis's avatar
      build, windows: disable SEH · d8790428
      Ben Noordhuis authored
      Turn off safe exception handlers, they're incompatible with how
      openssl is compiled / linked under MSVS 2012.
      
      Addresses the following build error:
      
        openssl.lib(x86cpuid.obj) : error LNK2026: module unsafe for SAFESEH
        image. [g:\jenkins\workspace\nodejs-oneoff\node.vcxproj]
        openssl.lib(x86.obj) : error LNK2026: module unsafe for SAFESEH
        image. [g:\jenkins\workspace\nodejs-oneoff\node.vcxproj]
        # etc. etc.
        g:\jenkins\workspace\nodejs-oneoff\Release\node.exe : fatal error
        LNK1281: Unable to generate SAFESEH image.
        [g:\jenkins\workspace\nodejs-oneoff\node.vcxproj]
      
      Fixes #4242.
      d8790428
    • Ben Noordhuis's avatar
      doc: update instructions on home page · 522668b5
      Ben Noordhuis authored
      Document how to run the example on the home page in more detail.
      
      Apparently our Windows brethren are prone to double-clicking on the
      binary instead of running it from the command line.
      
      Fixes #4854.
      522668b5
  4. Feb 26, 2013
  5. Feb 23, 2013
  6. Feb 22, 2013
    • Ben Noordhuis's avatar
      doc: add note about child process line buffering · 22d3eff8
      Ben Noordhuis authored
      Fixes #4808.
      22d3eff8
    • Ben Noordhuis's avatar
      zlib: fix assert on bad input · ef945219
      Ben Noordhuis authored
      The following test case occasionally triggered an assert because
      write_in_progress_ didn't get cleared on error:
      
        $ cat test.js
        require('zlib').gunzip('BAM', console.log);
        setTimeout(gc, 10);
      
        $ while true; do node --expose-gc test.js || break; done
        { [Error: incorrect header check] errno: -3, code: 'Z_DATA_ERROR' }
        Assertion failed: (!write_in_progress_ && "write in progress"),
        function Clear, file ../src/node_zlib.cc, line 71.
        Abort trap: 6
      
      Steps to avoid that:
      
      * Initialize all primitive member fields in the constructor.
      * Clear the write_in_progress_ member field in ZCtx::Error().
      * Ref the ZCtx object as soon as write_in_progress_ is set to true.
        Before this commit, it could get GC'ed in the time between setting
        the field and the call to ctx->Ref().
      
      Fixes #4783.
      ef945219
  7. Feb 21, 2013
  8. Feb 20, 2013
  9. Feb 16, 2013
  10. Feb 15, 2013
    • isaacs's avatar
      http: Do not let Agent hand out destroyed sockets · 987338fe
      isaacs authored
      Fix #4373
      987338fe
    • isaacs's avatar
      http: Raise hangup error on destroyed socket write · c9dcf571
      isaacs authored
      Prior to v0.10, Node ignored ECONNRESET errors in many situations.
      There *are* valid cases in which ECONNRESET should be ignored as a
      normal part of the TCP dance, but in many others, it's a very relevant
      signal that must be heeded with care.
      
      Exacerbating this problem, if the OutgoingMessage does not have a
      req.connection._handle, it assumes that it is in the process of
      connecting, and thus buffers writes up in an array.
      
      The problem happens when you reuse a socket between two requests, and it
      is destroyed abruptly in between them.  The writes will be buffered,
      because the socket has no handle, but it's not ever going to GET a
      handle, because it's not connecting, it's destroyed.
      
      The proper fix is to treat ECONNRESET correctly.  However, this is a
      behavior/semantics change, and cannot land in a stable branch.
      
      Fix #4775
      c9dcf571
    • Ben Noordhuis's avatar
      doc: clarify child_process.exec() stdio option · 3e2be6f3
      Ben Noordhuis authored
      It only works for stdin, not stdout/stderr, for obvious reasons.
      3e2be6f3
  11. Feb 14, 2013
  12. Feb 13, 2013
    • Dan Kohn's avatar
      doc: add prompt to fix repl_test.js example · 2e1ebbf2
      Dan Kohn authored
      Running repl.start without the prompt set produces this error:
      
      repl.js:95
          throw new Error('An options Object, or a prompt String are required');
                ^
      Error: An options Object, or a prompt String are required
          at new REPLServer (repl.js:95:11)
          at Object.exports.start (repl.js:321:14)
          at Object.<anonymous> (/Users/dan/Dropbox/Documents/dev/nextgen/repl_test.js:5:6)
          at Module._compile (module.js:449:26)
          at Object.Module._extensions..js (module.js:467:10)
          at Module.load (module.js:356:32)
          at Function.Module._load (module.js:312:12)
          at Module.runMain (module.js:492:10)
          at process.startup.processNextTick.process._tickCallback (node.js:244:9)
      2e1ebbf2
    • isaacs's avatar
      blog: Forgot slug on peer-dependencies article · 82ad5fbe
      isaacs authored
      82ad5fbe
    • isaacs's avatar
      blog: Peer Dependencies article · 6dcadb9f
      isaacs authored
      Thanks, @domenic
      6dcadb9f
  13. Feb 08, 2013
  14. Feb 07, 2013