- Nov 27, 2018
-
-
Rich Trott authored
Make it more explicit that symlinks are resolved in `__filename`. Refs: https://github.com/nodejs/node/issues/22602#issuecomment-440906602 PR-URL: https://github.com/nodejs/node/pull/24587 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Refael Ackermann authored
PR-URL: https://github.com/nodejs/node/pull/24505 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Fedor Indutny <fedor.indutny@gmail.com>
-
- Nov 26, 2018
-
-
Naojirou Hisada authored
PR-URL: https://github.com/nodejs/node/pull/24596 Reviewed-By:
Ron Korving <ron@ronkorving.nl> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
kazuya kawaguchi authored
replace with C++ API. Refs: https://github.com/nodejs/node/pull/24125 PR-URL: https://github.com/nodejs/node/pull/24614 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Gus Caplan <me@gus.host>
-
tottokotkd authored
PR-URL: https://github.com/nodejs/node/pull/24612 Reviewed-By:
Shingo Inoue <leko.noor@gmail.com> Reviewed-By:
-
kohta ito authored
PR-URL: https://github.com/nodejs/node/pull/24601 Reviewed-By:
-
yosuke ota authored
Changed function expression to arrow function. PR-URL: https://github.com/nodejs/node/pull/24597 Reviewed-By:
-
takato authored
PR-URL: https://github.com/nodejs/node/pull/24589 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
koki-oshima authored
PR-URL: https://github.com/nodejs/node/pull/24606 Reviewed-By:
-
Rich Trott authored
Simplify and clarify the text of the COLLABORATORS_GUIDE where handling one's own pull requests is concerned. PR-URL: https://github.com/nodejs/node/pull/24583 Reviewed-By:
Yuta Hiroto <hello@hiroppy.me> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
cclauss authored
PR-URL: https://github.com/nodejs/node/pull/24486 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Vse Mozhet Byt authored
This replacement can save us a function call, two array spreadings, and an array concatenation. PR-URL: https://github.com/nodejs/node/pull/24582 Refs: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Reflect/ownKeys#Description Reviewed-By:
-
Vse Mozhet Byt authored
* Unwrap short lines. * Unify comments. * Decrease function calls. PR-URL: https://github.com/nodejs/node/pull/24581 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
-
- Nov 25, 2018
-
-
jamesgeorge007 authored
PR-URL: https://github.com/nodejs/node/pull/24513 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
-
Gagandeep Singh authored
PR-URL: https://github.com/nodejs/node/pull/24528 Reviewed-By:
-
Rich Trott authored
Replace `find -not` usage with `find !` as `-not` is not universally supported. Fixes: https://github.com/nodejs/node/issues/24634 PR-URL: https://github.com/nodejs/node/pull/24635 Reviewed-By:
-
Ouyang Yadong authored
This commit makes those errors caused by calling `net.Socket.write()` after sockets ending be emitted in the next tick. PR-URL: https://github.com/nodejs/node/pull/24457 Fixes: https://github.com/nodejs/node/issues/24111 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com>
-
Rich Trott authored
Splitting out the http2 portion of the test has a few benfits: * We don't skip the rest of the tests if `node` is compiled without crypto. * We can find out if the http2 portion of the test is responsible for the timeouts reported in issue 24456. Refs: https://github.com/nodejs/node/issues/24456 PR-URL: https://github.com/nodejs/node/pull/24631 Reviewed-By:
-
Laszlo.Moczo authored
In path.basename was a case when the path and the extension is the same and this wasn't covered with tests. I covered this case both in Windows and Unix environments. PR-URL: https://github.com/nodejs/node/pull/24570 Reviewed-By:
-
mki-skt authored
PR-URL: https://github.com/nodejs/node/pull/24619 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
-
Jayasankar authored
Elevate namespace for repeated entities. PR-URL: https://github.com/nodejs/node/pull/24573 Reviewed-By:
-
teppeis authored
PR-URL: https://github.com/nodejs/node/pull/24591 Reviewed-By:
Masashi Hirano <shisama07@gmail.com>
-
Gerhard Stoebich authored
Make `pseudoRandomBytes` and it's aliases `prng` and `rng` configurable to allow monkey patching. PR-URL: https://github.com/nodejs/node/pull/24108 Refs: https://github.com/nodejs/node/pull/22519 Refs: https://github.com/nodejs/node/pull/23017 Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By:
Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By:
-
leeight authored
`finishSessionDestroy` session cleanup when already done. PR-URL: https://github.com/nodejs/node/pull/24547 Fixes: https://github.com/nodejs/node/issues/24546 Reviewed-By:
Ouyang Yadong <oyydoibh@gmail.com> Reviewed-By:
-
dominikeinkemmer authored
Switched the order of arguments for strictEqual checks inside of test/paralell/test-http2-binding.js PR-URL: https://github.com/nodejs/node/pull/24616 Refs: https://github.com/nodejsjp/node-1/issues/1 Reviewed-By:
-
sota1235 authored
PR-URL: https://github.com/nodejs/node/pull/24595 Reviewed-By:
-
- Nov 24, 2018
-
-
Yusuke Kawasaki authored
PR-URL: https://github.com/nodejs/node/pull/24611 Reviewed-By:
Denys Otrishko <shishugi@gmail.com>
-
Yang Guo authored
Original commit message: Fix collection iterator preview with deleted entries We used to assume that we know the remaining entries returned by the iterator based on the current index. However, that is not accurate, since entries skipped by the current index could be deleted. In the new approach, we allocate conservatively and shrink the result. R=neis@chromium.org Bug: v8:8433 Change-Id: I38a3004dc3af292daabb454bb76f38d65ef437e8 Reviewed-on: https://chromium-review.googlesource.com/c/1325966 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#57360} Refs: https://github.com/v8/v8/commit/88f8fe19a863c6392bd296faf86c06eff2a41bc1 PR-URL: https://github.com/nodejs/node/pull/24514 Refs: https://github.com/nodejs/node/issues/24053 Reviewed-By:
-
ka2jun8 authored
PR-URL: https://github.com/nodejs/node/pull/24617 Reviewed-By:
-
sadness_ojisan authored
PR-URL: https://github.com/nodejs/node/pull/24590 Reviewed-By:
-
yuriettys authored
PR-URL: https://github.com/nodejs/node/pull/24627 Reviewed-By:
-
Yusuke Kawasaki authored
PR-URL: https://github.com/nodejs/node/pull/24628 Reviewed-By:
-
prodroy1 authored
PR-URL: https://github.com/nodejs/node/pull/24434 Reviewed-By:
-
Michael Dawson authored
This was missed when the function was added. As it is experimental in the code it should also be experimental in the docs. Fixes: https://github.com/nodejs/node/issues/24509 PR-URL: https://github.com/nodejs/node/pull/24572 Reviewed-By:
-
Juan José Arboleda authored
PR-URL: https://github.com/nodejs/node/pull/24455 Reviewed-By:
-
gengjiawen authored
PR-URL: https://github.com/nodejs/node/pull/24459 Reviewed-By:
-
sreepurnajasti authored
PR-URL: https://github.com/nodejs/node/pull/24541 Reviewed-By:
-
- Nov 23, 2018
-
-
Michael Dawson authored
Crashes were reported during finalization due to the memory for a reference being deleted and the finalizer running after the deletion. This change ensures the deletion of the memory for the reference only occurs after the finalizer has run. Fixes: https://github.com/nodejs/node-addon-api/issues/393 PR-URL: https://github.com/nodejs/node/pull/24494 Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By:
-
potham authored
PR-URL: https://github.com/nodejs/node/pull/24531 Reviewed-By:
-
Gagandeep Singh authored
PR-URL: https://github.com/nodejs/node/pull/24527 Reviewed-By:
-
