- Feb 20, 2015
-
-
Fedor Indutny authored
`TLSSocket` wraps the original `net.Socket`, but writes/reads to/from `TLSSocket` do not touch the timers of original `net.Socket`. Introduce `socket._parent` property, and iterate through all parents to unref timers and prevent timeout event on original `net.Socket`. Fix: https://github.com/joyent/node/issues/9242 PR-URL: https://github.com/iojs/io.js/pull/891 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
- Feb 18, 2015
-
-
Bruno Jouhier authored
Currently, fs.truncate() silently fails when a file descriptor is passed as the first argument. This commit changes this behavior to properly call fs.ftruncate(). PR-URL: https://github.com/joyent/node/pull/9161 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Timothy J Fontaine <tjfontaine@gmail.com>
-
- Feb 17, 2015
-
-
Julien Gilli authored
-
Julien Gilli authored
The commit in v0.10 (431eb172) that backported the original change (https://codereview.chromium.org/806143002) did add an extra newline because the logging facilities in v0.10's V8 do not add one. When merging this commit in v0.12, V8's logging facilities now automatically add the newline character, and the debug builds assert if one is already present.
-
Julien Gilli authored
431eb172 had integrated the addition of V8's version in V8's profiler log files, without backporting the test that was included in the original change (https://codereview.chromium.org/806143002). This commit backports this test. The newly added test was tested with https://github.com/joyent/node/pull/9208.
-
Julien Gilli authored
Conflicts: deps/v8/src/log-utils.cc
-
Trevor Norris authored
If the Buffer allocation isn't a slice then there's no need to adjust the pool offset after realloc'ing the space available. Fixes: 6462519d "buffer, doc: misc. fix and cleanup"
-
- Feb 13, 2015
-
-
cjihrig authored
Console.prototype.timeEnd() returns NaN if the timer label corresponds to a property on Object.prototype. This commit uses Object.create(null) to construct the _times object. Fixes: https://github.com/joyent/node/issues/9069 PR-URL: https://github.com/joyent/node/pull/9116 Reviewed-By:
Trevor Norris <trev.norris@gmail.com>
-
Herbert Vojčík authored
The NativeModule system passes NativeModule.require transparently and so is unnecessary to call explicitly. The only one which should have the prefix is the in line 295, where actually implements a big fs-based module system and actually requires a native module. That is left unchanged. PR-URL: https://github.com/joyent/node/pull/9201 Ref: https://github.com/joyent/node/issues/2009 Reviewed-by:
Trevor Norris <trev.norris@gmail.com>
-
Dan Dascalescu authored
Add a ';' to the end of a function call in documentation. PR-URL: https://github.com/joyent/node/pull/9198 Reviewed-by:
Trevor Norris <trev.norris@gmail.com>
-
- Feb 12, 2015
-
-
Jackson Tian authored
Change the fs.F_OK/R_OK/W_OK/X_OK out of fs.js will lead unexpect exception. Make these properties readonly. PR-URL: https://github.com/joyent/node/pull/9060 [trev.norris@gmail.com test properties are read only] Signed-off-by:
Trevor Norris <trev.norris@gmail.com>
-
Jan Schär authored
Timeout#unref() call returns undefined, not this. The test already worked before, because the interval was still unref'd, and the test also succeeds without clearing the interval. PR-URL: https://github.com/joyent/node/pull/9171 Reviewed-by:
Colin Ihrig <cjihrig@gmail.com> Reviewed-by:
Timothy J Fontaine <tjfontaine@gmail.com>
-
Debjeet Biswas authored
PR-URL: https://github.com/joyent/node/pull/9164 Reviewed-by:
Colin Ihrig <cjihrig@gmail.com>
-
- Feb 11, 2015
-
-
Ben Noordhuis authored
A number -> uint32 type coercion bug made buffer sizes larger than kMaxLength (0x3fffffff) wrap around. Instead of rejecting the requested size with an exception, the constructor created a buffer with the wrong size. PR-URL: https://github.com/iojs/io.js/pull/657 Reviewed-By:
Trevor Norris <trev.norris@gmail.com>
-
- Feb 10, 2015
-
-
Trevor Norris authored
AsyncWrap should always properly propagate asynchronous calls to any child that is created. Regardless whether kCallInitHook is currently active. The previous logic would always return early if kCallInitHook wasn't set. PR-URL: https://github.com/joyent/node/pull/9146 Reviewed-by:
Julien Gilli <julien.gilli@joyent.com>
-
Amir Saboury authored
'.' and '..' are directory specs and resolving urls with or without the hostname with '.' and '..' should add a trailing slash to the end of the url. Fixes: https://github.com/joyent/node/issues/8992 PR-URL: https://github.com/joyent/node/pull/9010 Reviewed-by:
Trevor Norris <trev.norris@gmail.com>
-
- Feb 07, 2015
-
-
Julien Gilli authored
-
Julien Gilli authored
-
Julien Gilli authored
* npm: Upgrade to 2.5.1 * mdb_v8: update for v0.12 (Dave Pacheco)
-
Forrest L Norvell authored
Fixes #9126. Reviewed-By:
Timothy J Fontaine <tjfontaine@gmail.com> Reviewed-By:
Julien Gilli <julien.gilli@joyent.com>
-
- Feb 06, 2015
-
-
Julien Gilli authored
-
Julien Gilli authored
Replace tools/updateAuthors.awk with tools/update-authors.js. The new tool generates an AUTHORS file that is stable-ordered alphanumerically. Fixes #9077. PR: #9088 PR-URL: https://github.com/joyent/node/pull/9088 Reviewed-By:
Timothy J Fontaine <tjfontaine@gmail.com>
-
Julien Gilli authored
V8_CONSTANT_REMOVED_SINCE(major, minor) can be used to mark a constant has being removed from V8 since V8 version major.minor. Reviewed-By:
Dave Pacheco <dap@joyent.com> Reviewed-By:
Timothy J Fontaine <tjfontaine@gmail.com>
-
Julien Gilli authored
Reviewed-By:
Dave Pacheco <dap@joyent.com> Reviewed-By:
Timothy J Fontaine <tjfontaine@gmail.com>
-
Dave Pacheco authored
Bugs fixed: * v0.12 and later: in-object properties not printing correctly. * 64-bit: not printing external strings correctly (offset was hardcoded for 32-bit). This would happen with "::jsstack -vn0" because the script "node.js" wasn't printed correctly, at least with 0.10 core files. * 64-bit: printing JS source (via "::jsstack -v") emits errors and shows the wrong code. * Several build warnings. * Two-byte strings are unnecessarily truncated. * Could print friendlier note when given obviously bogus function token positions. New features: * ::jsstack prints much cleaner output by default. * ::jsprint keys are now quoted. * ::jsstack -v includes "this" value for each function on the stack. * ::jsstack -v includes more details about each argument (constructor names for each object). * new commands: ::jsconstructor, ::jsfunctions, ::jssource, ::nodebuffer and ::v8internal. * ::findjsobjects and ::jsprint hidden flags for developers to measure and improve test coverage. * internal jsobj_properties() function is much better documented. Reviewed-By:Timothy J Fontaine <tjfontaine@gmail.com>
-
- Feb 05, 2015
-
-
Ben Noordhuis authored
Patch from issue 800293002 authored by ben@strongloop.com Review URL: https://codereview.chromium.org/806143002 PR-URL: https://github.com/joyent/node/pull/9043 Reviewed-by:
Trevor Norris <trev.norris@gmail.com> Reviewed-By:
Timothy J Fontaine <tjfontaine@gmail.com>
-
- Jan 31, 2015
-
-
Julien Gilli authored
-
Julien Gilli authored
-
- Jan 30, 2015
-
-
Julien Gilli authored
* openssl: Upgrade to 1.0.1l * npm: Upgrade to 2.3.0 * url: revert support of `path` for url.format" (Julien Gilli) * assert: use util.inspect() to create error messages (cjihrig) * net: throw on invalid socket timeouts (cjihrig) * url: fix parsing of ssh urls (Evan Lucas)
-
Julien Gilli authored
Building node with GCC > 4.4 on CentOS makes the node binary depend on a more recent version of the C/C++ runtime that is not installed by default on these older CentOS platforms, and probably on other platforms as well. Building node with the default gcc and g++ compilers that come with these older versions of CentOS allows to ship a node binary that runs out of the box on these setups with older C/C++ runtimes. This change works around a bug that was fixed in GCC 4.5. Versions of GCC < 4.5 would not support using the injected-class-name of a template base class as a type name. This change also disables aliasing optimizations for toolchains using GCC <= 4.4 as they're not able to deal with the aliasing in the queue implementation used by libuv and node (see src/queue.h). Fixes #9079. PR: #9098 PR-URL: https://github.com/joyent/node/pull/9098 Reviewed-By:
Timothy J Fontaine <tjfontaine@gmail.com> Reviewed-By:
Trevor Norris <trev.norris@gmail.com>
-
cjihrig authored
Currently, JSON.stringify() is used to create error messages on failed assertions. This causes an error when stringifying objects with circular references. This commit switches out JSON.stringify() for util.inspect(), which can handle circular references. PR: #8734 PR-URL: https://github.com/joyent/node/pull/8734 Reviewed-By:
Julien Gilli <julien.gilli@joyent.com>
-
Julien Gilli authored
This reverts commit d312b6d1. d312b6d1 introduced some confusion in the existing API of url.format and url.parse. The way the 'path' property overrides other properties in url.format's input is too confusing for existing users compared to the issues it fixes. Fixes such as https://github.com/joyent/node/pull/9081 have been proposed, but they do not make the API less confusing. Instead, this change just reverts the original breaking change so that it gives us more time after v0.12.0 is released to come up with a better API for url.format, url.parse and other related APIs in the v0.13 development branch. Fixes #9070. Conflicts: doc/api/url.markdown PR: #9109 PR-URL: https://github.com/joyent/node/pull/9109 Reviewed-By:
Timothy J Fontaine <tjfontaine@gmail.com>
-
- Jan 28, 2015
-
-
Forrest L Norvell authored
PR: #9086 PR-URL: https://github.com/joyent/node/pull/9086 Reviewed-By:
Julien Gilli <julien.gilli@joyent.com> Reviewed-By:
Timothy J Fontaine <tjfontaine@gmail.com>
-
- Jan 27, 2015
-
-
Julien Gilli authored
On Windows, when building the "build-release" rule, enable both small-icu and download-all. This change also slightly refactors the build-release rule, mainly so that it's easier to read. The resulting MSI package was tested on Windows 7. Fixes #9099. PR: #9100 PR-URL: https://github.com/joyent/node/pull/9100 Reviewed-By:
Steven R. Loomis <srloomis@us.ibm.com> Reviewed-By:
Timothy J Fontaine <tjfontaine@gmail.com>
-
Timothy J Fontaine authored
Conflicts: ChangeLog doc/api/assert.markdown src/node_version.h test/simple/test-crypto-stream.js vcbuild.bat
-
Timothy J Fontaine authored
-
Timothy J Fontaine authored
-
Timothy J Fontaine authored
* openssl: update to 1.0.1l * v8: Fix debugger and strict mode regression (Julien Gilli) * v8: don't busy loop in cpu profiler thread (Ben Noordhuis)
-
- Jan 24, 2015
-
-
Timothy J Fontaine authored
PR-URL: https://github.com/joyent/node/pull/9085 PR: #9085 Reviewed-by:
Julien Gilli <julien.gilli@joyent.com>
-
Evan Lucas authored
Fix regression introduced in 61204720 that broke parsing of some ssh: urls. An example url is ssh://git@github.com:npm/npm.git Fixes #9072. Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Julien Gilli <julien.gilli@joyent.com> Reviewed-By:
Trevor Norris <trev.norris@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-