Commits · b98027ee5f4e906c84e8d92e8d76baeefa60b8cf · github.com / v8-riscv / node

Nov 23, 2017

zlib: remove unnecessary else branch · b98027ee

john authored Nov 15, 2017

PR-URL: https://github.com/nodejs/node/pull/17057


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

b98027ee

test: remove unlink function which is needless · b28a28a5

buji authored Nov 20, 2017

PR-URL: https://github.com/nodejs/node/pull/17119


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

b28a28a5

test: dont need to remove nonexistent directory · fdbee334

buji authored Nov 19, 2017

the TempDirection is empty , so tempdir/test1 and tempdir/test2
are nonexistent. we dont need to delete nonexistent directories.

PR-URL: https://github.com/nodejs/node/pull/17119


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

fdbee334

fs: use arrow functions instead of `.bind` and `self` · a68b8b70

Weijia Wang authored Nov 20, 2017

PR-URL: https://github.com/nodejs/node/pull/17137


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

a68b8b70

net: remove deprecated getters for internals · 3701b023

Anna Henningsen authored Nov 19, 2017

Remove the getters introduced in 75a19fb3.

PR-URL: https://github.com/nodejs/node/pull/17141
Refs: https://github.com/nodejs/node/pull/14449


Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

3701b023

doc: use better terminology for build machines · 8f504077

Anna Henningsen authored Nov 19, 2017

PR-URL: https://github.com/nodejs/node/pull/17142


Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

8f504077

stream: improve the error message of `ERR_INVALID_ARG_TYPE` · 0a948b90

Weijia Wang authored Nov 20, 2017

The `expected` argument of `ERR_INVALID_ARG_TYPE` can be an
array, which is better than a single string.

PR-URL: https://github.com/nodejs/node/pull/17145


Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

0a948b90

doc: use "JavaScript" instead of "Javascript" · 8f2c366b

Rich Trott authored Nov 18, 2017

PR-URL: https://github.com/nodejs/node/pull/17163


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

8f2c366b

doc: prepare for v8/V8 linting in doc text · 911f1632

Rich Trott authored Nov 18, 2017

PR-URL: https://github.com/nodejs/node/pull/17163


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

911f1632

doc: add capitalization styling to STYLE_GUIDE · e577d7db

Rich Trott authored Nov 18, 2017

This is mostly an excuse to remind people that it's "V8" and not "v8"
when referring to the JavaScript engine.

PR-URL: https://github.com/nodejs/node/pull/17163


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

e577d7db

test: use common.crashOnUnhandledRejection() · a3a987b4

Ivan Wei authored Nov 22, 2017

add common.crashOnUnhandledRejectio to
test-http2-window-size.js

PR-URL: https://github.com/nodejs/node/pull/17227


Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

a3a987b4

test: add common.crashOnUnhandledRejection() · 96093981

Kyle Yu authored Nov 22, 2017

add common.crashOnUnhandledRejection() in test-wasm-simple.js

PR-URL: https://github.com/nodejs/node/pull/17236


Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

96093981

Nov 22, 2017

test: use crashOnUnhandledRejection · 5d6693fc

YuLun Shih authored Nov 22, 2017

Add common.crashOnUnhandledRejection to
test/parallel/test-async-hooks-disable-during-promise.js

PR-URL: https://github.com/nodejs/node/pull/17220


Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

5d6693fc

test: fix linting error · cf5ad75b

James M Snell authored Nov 22, 2017

Fast-tracked on landing to unbreak CI

PR-URL: https://github.com/nodejs/node/pull/17251


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

cf5ad75b

test: use common.crashOnUnhandledRejection · 685abcde

jimliu7434 authored Nov 22, 2017

Add common.crashOnUnhandledRejection to
test-async-wrap-promise-after-enabled.js

PR-URL: https://github.com/nodejs/node/pull/17231


Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

685abcde

test: use crashOnUnhandledRejection · 1cc8ec3a

Roth Peng authored Nov 22, 2017

Add common.crashOnUnhandledRejection to
test/parallell/test-microtask-queue-run-domain.js

PR-URL: https://github.com/nodejs/node/pull/17226


Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

1cc8ec3a

test: use common.crashOnUnhandledRejection · 339e247e

esbb48 authored Nov 22, 2017

PR-URL: https://github.com/nodejs/node/pull/17218


Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

339e247e

test: use arrow function instead of bind · 571ecd1a

Lance Ball authored Nov 21, 2017

Using an arrow function here eliminates the need to call `bind()`.

PR-URL: https://github.com/nodejs/node/pull/17202


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

571ecd1a

test: use crashOnUnhandledRejection · d7b0c237

Chiahao Lin authored Nov 22, 2017

Add common.crashOnUnhandledRejection to test-microtask-queue-integration.js

PR-URL: https://github.com/nodejs/node/pull/17219


Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

d7b0c237

test: use common.crashOnUnhandledRejection · bd5acfe4

Whien authored Nov 22, 2017

Add common.crashOnUnhandledRejection to
test-microtask-queue-run-immediate.js

PR-URL: https://github.com/nodejs/node/pull/17214


Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

bd5acfe4

src: add napi_handle_scope_mismatch to msg list · a4a9a3de

neta authored Nov 20, 2017

PR-URL: https://github.com/nodejs/node/pull/17161


Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

a4a9a3de

test: clean up inappropriate language · 7fd8a211

Gus Caplan authored Nov 20, 2017

PR-URL: https://github.com/nodejs/node/pull/17170


Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

7fd8a211

async_hooks: remove deprecated API · 1cc6b993

Andreas Madsen authored Nov 22, 2017

PR-URL: https://github.com/nodejs/node/pull/17147
Refs: https://github.com/nodejs/node/pull/16972


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

1cc6b993

doc: update mgol in AUTHORS.txt, add to .mailmap · f3b12aa4

Michał Gołębiowski-Owczarek authored Nov 22, 2017

PR-URL: https://github.com/nodejs/node/pull/17239


Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

f3b12aa4

doc: update release table in V8 guide · f722d312

Ali Ijaz Sheikh authored Nov 19, 2017

PR-URL: https://github.com/nodejs/node/pull/17136


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

f722d312

test: bypass dns for IPv6 net tests · 283b9494

Refael Ackermann authored Nov 12, 2017

PR-URL: https://github.com/nodejs/node/pull/16976
Refs: https://github.com/nodejs/node/pull/16248


Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

283b9494

src, tools: add debug symbols for node internals · 446c1ecf

Matheus Marchini authored Sep 24, 2017

Before these changes, only V8 added debug symbols to Node's binary,
limiting the possibilities for debugger's developers to add some
features that rely on investigating Node's internal structures.

These changes are a first steps towards empowering debug tools to
navigate Node's internals strucutres. One example of what can be
achieved with this is shown at nodejs/llnode#122 (a command which prints
information about handles and requests on the queue for a core dump
file). Node debug symbols are prefixed with node_dbg_.

Ref: https://github.com/nodejs/llnode/pull/122

PR-URL: https://github.com/nodejs/node/pull/14901
Refs: https://github.com/nodejs/post-mortem/issues/46


Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

446c1ecf

doc: add guybedford to collaborators · 2346c638

Guy Bedford authored Nov 21, 2017

PR-URL: https://github.com/nodejs/node/pull/17197


Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

2346c638

test: wrap callback in common.mustCall · a95d88c8

suman-mitra authored Nov 21, 2017

PR-URL: https://github.com/nodejs/node/pull/17173


Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

a95d88c8

src: fix compiler warning · bb31a168

cjihrig authored Nov 21, 2017

This commit fixes a -Winconsistent-missing-override warning.

PR-URL: https://github.com/nodejs/node/pull/17195


Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

bb31a168

test: remove unused parameter in test-next-tick-error-spin.js · 6a87cac5

Francois KY authored Nov 21, 2017

PR-URL: https://github.com/nodejs/node/pull/17185


Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>

6a87cac5

module: replace default paths in require.resolve() · 8578e81b

cjihrig authored Nov 18, 2017

Prior to this commit, the default search paths would be included
in the require.resolve() process, even if user specified paths
were provided. This commit causes the default paths to be
omitted by using a fake parent module.

Refs: https://github.com/nodejs/node/issues/5963
PR-URL: https://github.com/nodejs/node/pull/17113


Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

8578e81b

src: remove unprofessional slang in assertions · 4b34e6fe

Alexey Orlenko authored Nov 21, 2017

Convert `CHECK(0 && "wtf?")` (sic) assertions to more suitable
`UNREACHABLE()` macro invocations in `node_zlib.cc`.

PR-URL: https://github.com/nodejs/node/pull/17166


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

4b34e6fe

Nov 21, 2017

benchmark: set maxHeaderListPairs in h2 headers.js · f5352b3f

Anatoli Papirovski authored Nov 21, 2017

PR-URL: https://github.com/nodejs/node/pull/17194


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

f5352b3f

test: remove unused parameter · 3e29e012

Fran Herrero authored Nov 21, 2017

PR-URL: https://github.com/nodejs/node/pull/17193


Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>

3e29e012

test: remove unused variable · 9f2f56dd

Pierre-Loic Doulcet authored Nov 21, 2017

Remove unused variable err in
  test/sequential/test-http-writable-true-after-close.js

PR-URL: https://github.com/nodejs/node/pull/17186


Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>

9f2f56dd

src: implement v8::TaskRunner API in NodePlatform · f0056567

Anna Henningsen authored Nov 19, 2017

V8 is switching APIs for scheduling tasks. Implement the new APIs.

Fixes: https://github.com/nodejs/node-v8/issues/24
Refs: https://github.com/v8/v8/commit/c690f54d9580243c53f7d892fcff1ce6bae4bfc0

PR-URL: https://github.com/nodejs/node/pull/17134
Fixes: https://github.com/nodejs/node-v8/issues/24


Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>

f0056567

deps: cherry-pick 98c40a4bae915 from V8 upstream · 2540e3da

Anna Henningsen authored Nov 19, 2017

Original commit message:

    [platform] Return task runners as shared_ptr

    At the moment, task runners are returned as unique_ptr. This is
    inconvenient, however. In all implementations I did, the platform holds
    a shared pointer of the task runner and wraps it in a wrapper class just
    to return it as a unique_ptr. With this CL the platform API is changed
    to return a shared_ptr directly.

    R=rmcilroy@chromium.org

    Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
    Change-Id: Ide278db855199ea239ad0ae14d97fd17349dac8c
    Reviewed-on: https://chromium-review.googlesource.com/768867


    Commit-Queue: Andreas Haas <ahaas@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#49366}

Refs: https://github.com/v8/v8/commit/98c40a4bae915a9762c73de3307300c61e4fd91a

PR-URL: https://github.com/nodejs/node/pull/17134
Fixes: https://github.com/nodejs/node-v8/iss...

2540e3da

deps: cherry-pick c690f54d95802 from V8 upstream · 5d35a1a3

Anna Henningsen authored Nov 19, 2017

Original commit message:

    [platform] Add TaskRunner to the platform API

    With the existing platform API it is not possible to post foreground
    tasks from background tasks. This is, however, required to implement
    asynchronous compilation for WebAssembly. With this CL we add the
    concept of a TaskRunner to the platform API. The TaskRunner contains
    all data needed to post a foreground task and can be used both from a
    foreground task and a background task. Eventually the TaskRunner should
    replace the existing API.

    In addition, this CL contains a default implementation of the
    TaskRunner. This implementation has tempory workaround for platforms
    which do not provide a TaskRunner implementation yet. This default
    implementation should be deleted again when all platforms provide a
    TaskRunner implementation.

    R=rmcilroy@chromium.org

    Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
    Change-Id: I6ea4a1c9da1eb9a19e8ce8f2163000dbc2598802
    Reviewed-on: https://chromium-review.googlesource.com/741588


    Commit-Queue: Andreas Haas <ahaas@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#49041}

Refs: https://github.com/v8/v8/commit/c690f54d9580243c53f7d892fcff1ce6bae4bfc0

PR-URL: https://github.com/nodejs/node/pull/17134
Fixes: https://github.com/nodejs/node-v8/issues/24


Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>

5d35a1a3

test: remove unused variable · 5bc77924

Guillaume Flandre authored Nov 21, 2017

PR-URL: https://github.com/nodejs/node/pull/17187


Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

5bc77924