Commits · b7cdeb8a3a39000944106ddcd8ebcd5d1a8a5486 · github.com / v8-riscv / node

Nov 28, 2019

fs: add retryDelay option to rimraf · b7cdeb8a

cjihrig authored Nov 25, 2019

This commit adds a retryDelay option to rimraf which configures
the amount of time between retry operations.

Refs: https://github.com/nodejs/node/issues/30580
PR-URL: https://github.com/nodejs/node/pull/30644


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

b7cdeb8a

fs: remove rimraf's emfileWait option · 4c77a76a

cjihrig authored Nov 25, 2019

This commit removes the emfileWait option. EMFILE errors are
now handled the same as any other retriable error.

Refs: https://github.com/nodejs/node/issues/30580
PR-URL: https://github.com/nodejs/node/pull/30644


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

4c77a76a

fs: make rimraf default to 0 retries · 7e85f068

cjihrig authored Nov 25, 2019

This commit makes retries an opt-in feature by defaulting
to no automatic retries. This will be particularly important
once synchronous operations can sleep between attempts.

Refs: https://github.com/nodejs/node/issues/30580
PR-URL: https://github.com/nodejs/node/pull/30644


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

7e85f068

fs: rename rimraf's maxBusyTries to maxRetries · 40590557

cjihrig authored Nov 25, 2019

This is part of reworking the rimraf retry logic.

Refs: https://github.com/nodejs/node/issues/30580
PR-URL: https://github.com/nodejs/node/pull/30644


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

40590557

doc: remove "this API is unstable" note for v8 serdes API · 84aa1927

bruce-one authored Nov 25, 2019

As #30234 marked this as stable I think this line
should be removed as well?

Refs: https://github.com/nodejs/node/pull/30234
PR-URL: https://github.com/nodejs/node/pull/30631


Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>

84aa1927

doc: fixup incorrect flag name reference · 50ab2e3a

Guy Bedford authored Nov 26, 2019

PR-URL: https://github.com/nodejs/node/pull/30651


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

50ab2e3a

lib: enforce use of Array from primordials · 141a6e34

Michaël Zasso authored Nov 23, 2019

PR-URL: https://github.com/nodejs/node/pull/30635


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

141a6e34

doc: minor updates to releases.md · 5904dfcc

Beth Griggs authored Nov 25, 2019

PR-URL: https://github.com/nodejs/node/pull/30636


Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>

5904dfcc

Nov 27, 2019

doc,deps: document how to maintain ICU in Node.js · f36331c1

Steven R. Loomis authored Nov 22, 2019

- update v8 guide to mention ICU
- move content from the tools/icu/README.md but leave a pointer

Fixes: https://github.com/nodejs/node/issues/26108


Co-Authored-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/30607



Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

f36331c1

doc: add 13 and 12 to previous versions · 7f94fe00

Andrew Hughes authored Nov 22, 2019

Remove Node.js 6 and add Node.js 12 and Node.js 13 to the previous
versions of this document section

PR-URL: https://github.com/nodejs/node/pull/30590


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

7f94fe00

doc: update AUTHORS list · 73a244fc

Gus Caplan authored Nov 26, 2019

PR-URL: https://github.com/nodejs/node/pull/30672


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

73a244fc

test: skip test-domain-error-types in debug mode temporariliy · 6d022c13

Rich Trott authored Nov 24, 2019

Until https://github.com/nodejs/node/issues/30498 is resolved, skip
test-domain-error-types on debug builds.

PR-URL: https://github.com/nodejs/node/pull/30629


Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

6d022c13

test: move test-worker-prof to sequential · ebb177ee

Rich Trott authored Nov 24, 2019

Refs: https://github.com/nodejs/node/issues/26401#issuecomment-557899953

PR-URL: https://github.com/nodejs/node/pull/30628


Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

ebb177ee

esm: data URLs should ignore unknown parameters · 568968e3

Bradley Farias authored Nov 22, 2019

PR-URL: https://github.com/nodejs/node/pull/30593


Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>

568968e3

Nov 26, 2019

test: dir class initialisation w/o handler · 8c41b196

Dmitriy Kikinskiy authored Nov 06, 2019

Covering the case when init Dir class without passing
handle paramd to constructor.

PR-URL: https://github.com/nodejs/node/pull/30313


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

8c41b196

doc: add explanation why keep var with for loop · 4506991a

Lucas Recknagel authored Nov 12, 2019

This comment will help contributors to understand why keeping var
PR-URL: https://github.com/nodejs/node/pull/30380


Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

4506991a

lib: use let instead of var · a2dfa3c4

Shubham Chaturvedi authored Nov 12, 2019

this commit uses let instead of var for util.js & warning.js
PR-URL: https://github.com/nodejs/node/pull/30375


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

a2dfa3c4

lib: replace var with let/const · 03bb272c

jens-cappelle authored Nov 12, 2019

PR-URL: https://github.com/nodejs/node/pull/30391


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

03bb272c

util: use let instead of var for util/inspect.js · 3f597041

Luciano authored Nov 12, 2019

PR-URL: https://github.com/nodejs/node/pull/30399


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

3f597041

process: replace var with let/const · ecfebee9

Jesper Ek authored Nov 12, 2019

PR-URL: https://github.com/nodejs/node/pull/30382


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

ecfebee9

cluster: replace vars in child.js · 18ce3a3b

EmaSuriano authored Nov 12, 2019

PR-URL: https://github.com/nodejs/node/pull/30383


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

18ce3a3b

lib: replace var w/ let · bcb419c0

Chris Oyler authored Nov 12, 2019

replace var w/ let in lib/internal/error-serdes.js

PR-URL: https://github.com/nodejs/node/pull/30386


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

bcb419c0

process: replace vars in per_thread.js · 9240e544

EmaSuriano authored Nov 12, 2019

PR-URL: https://github.com/nodejs/node/pull/30385


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

9240e544

child_process: replace var with let/const · deb41274

dnlup authored Nov 12, 2019

PR-URL: https://github.com/nodejs/node/pull/30389


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

deb41274

lib: replace var with let/const · 00e22766

Tijl Claessens authored Nov 12, 2019

PR-URL: https://github.com/nodejs/node/pull/30390


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

00e22766

http2: change var to let compact.js · dba276dd

Maria Emmanouil authored Nov 12, 2019

PR-URL: https://github.com/nodejs/node/pull/30392


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

dba276dd

test: change object assign by spread operator · 48a16f25

poutch authored Nov 12, 2019

change object assign by spread operator in test-require-symlink.js
PR-URL: https://github.com/nodejs/node/pull/30438


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

48a16f25

lib: adding perf notes js_stream_socket.js · 79e86ac5

ryan jarvinen authored Nov 12, 2019

Leaving var in place of let for performance optimization
in short loops in hot paths. Added comments explaining why.

PR-URL: https://github.com/nodejs/node/pull/30415


Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

79e86ac5

test: use useful message argument in test function · a6fd2828

Rich Trott authored Nov 23, 2019

The message argument of two test functions in
test-inspector-async-call-stack is useful but unused. Use it!

PR-URL: https://github.com/nodejs/node/pull/30618


Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

a6fd2828

test: test for minimum ICU version consistency · f2060fa9

Richard Lau authored Nov 22, 2019

The minimum ICU version for Node.js must be at least the minimum ICU
version for V8.

PR-URL: https://github.com/nodejs/node/pull/30608
Refs: https://github.com/nodejs/node/pull/30607


Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

f2060fa9

doc: document "Resume Build" limitation · f3a50972

Richard Lau authored Nov 22, 2019

Compiled binaries for fanned CI builds on Windows and ARM are only kept
for seven days.

PR-URL: https://github.com/nodejs/node/pull/30604


Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

f3a50972

doc: add note of caution about non-conforming streams · d67c3772

Robert Nagy authored Oct 09, 2019

PR-URL: https://github.com/nodejs/node/pull/29895


Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

d67c3772

tools: enable more eslint rules · a50cc2ed

cjihrig authored Nov 22, 2019

This commit enables these new in ESLint 6.7.0 rules:

- no-constructor-return
- no-dupe-else-if
- no-setter-return

PR-URL: https://github.com/nodejs/node/pull/30598


Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

a50cc2ed

tools: update ESLint to 6.7.1 · 90fb308d

cjihrig authored Nov 22, 2019

Update ESLint to 6.7.1

PR-URL: https://github.com/nodejs/node/pull/30598


Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

90fb308d

Nov 25, 2019

lib: replace var with let · 02d4c742

Dennis Saenger authored Nov 12, 2019

PR-URL: https://github.com/nodejs/node/pull/30396


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

02d4c742

test: code&learn var to let update · a7ddf8c5

Nazar Malyy authored Nov 12, 2019

PR-URL: https://github.com/nodejs/node/pull/30436


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

a7ddf8c5

lib: flatten access to primordials · 0646eda4

Michaël Zasso authored Nov 22, 2019

Store all primordials as properties of the primordials object.
Static functions are prefixed by the constructor's name and prototype
methods are prefixed by the constructor's name followed by "Prototype".
For example: primordials.Object.keys becomes primordials.ObjectKeys.

PR-URL: https://github.com/nodejs/node/pull/30610
Refs: https://github.com/nodejs/node/issues/29766


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

0646eda4

src: replaced var with let · 35c6e0cc

Aldo Ambrosioni authored Nov 12, 2019

replaced var with let in lib/internal/cluter/master.js
PR-URL: https://github.com/nodejs/node/pull/30397


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

35c6e0cc

lib: main_thread_only change var to let · 1cdd1b7b

matijagaspar authored Nov 12, 2019

PR-URL: https://github.com/nodejs/node/pull/30398


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

1cdd1b7b

lib: change var to let in stream_base_commons · 12a21aee

Kyriakos Markakis authored Nov 12, 2019

PR-URL: https://github.com/nodejs/node/pull/30426


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

12a21aee